coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: mb/google/octopus: Add yorp variant
by build bot (Jenkins) (Code Review) 13 Mar '18

13 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25086 ) Change subject: mb/google/octopus: Add yorp variant ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22917/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68505/ : SUCCESS -- To view, visit https://review.coreboot.org/25086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55af8f02d33138a3b6bab7860a665e3deb5595c2 Gerrit-Change-Number: 25086 Gerrit-PatchSet: 4 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 16:57:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Add yorp variant
by build bot (Jenkins) (Code Review) 13 Mar '18

13 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25086 ) Change subject: mb/google/octopus: Add yorp variant ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22916/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68504/ : SUCCESS -- To view, visit https://review.coreboot.org/25086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55af8f02d33138a3b6bab7860a665e3deb5595c2 Gerrit-Change-Number: 25086 Gerrit-PatchSet: 3 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 16:41:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Create yorp variant
by build bot (Jenkins) (Code Review) 13 Mar '18

13 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25131 ) Change subject: mb/google/octopus: Create yorp variant ...................................................................... Patch Set 2: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/68502/ : UNSTABLE -- To view, visit https://review.coreboot.org/25131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6962f15956a4d5280062ee684bb5154163e5473 Gerrit-Change-Number: 25131 Gerrit-PatchSet: 2 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 16:39:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/octopus: Add yorp variant
by build bot (Jenkins) (Code Review) 13 Mar '18

13 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25086 ) Change subject: mb/google/octopus: Add yorp variant ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/22915/ : ABORTED https://qa.coreboot.org/job/coreboot-gerrit/68503/ : ABORTED -- To view, visit https://review.coreboot.org/25086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55af8f02d33138a3b6bab7860a665e3deb5595c2 Gerrit-Change-Number: 25086 Gerrit-PatchSet: 2 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 16:35:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Create yorp variant
by Justin TerAvest (Code Review) 13 Mar '18

13 Mar '18

Justin TerAvest has abandoned this change. ( https://review.coreboot.org/25131 ) Change subject: mb/google/octopus: Create yorp variant ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/25131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Id6962f15956a4d5280062ee684bb5154163e5473 Gerrit-Change-Number: 25131 Gerrit-PatchSet: 2 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/octopus: Create yorp variant
by build bot (Jenkins) (Code Review) 13 Mar '18

13 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25131 ) Change subject: mb/google/octopus: Create yorp variant ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/22914/ : ABORTED https://qa.coreboot.org/job/coreboot-gerrit/68501/ : ABORTED -- To view, visit https://review.coreboot.org/25131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6962f15956a4d5280062ee684bb5154163e5473 Gerrit-Change-Number: 25131 Gerrit-PatchSet: 1 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 16:27:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Create yorp variant
by Justin TerAvest (Code Review) 13 Mar '18

13 Mar '18

Justin TerAvest has uploaded a new patch set (#2). ( https://review.coreboot.org/25131 ) Change subject: mb/google/octopus: Create yorp variant ...................................................................... mb/google/octopus: Create yorp variant This commit provides a Yorp board config option and the necessary variant files to allow building. BUG=b:74443669,b:74067452 TEST=Build Signed-off-by: Justin TerAvest <teravest(a)chromium.org> Change-Id: Id6962f15956a4d5280062ee684bb5154163e5473 --- M src/mainboard/google/octopus/Kconfig M src/mainboard/google/octopus/Kconfig.name A src/mainboard/google/octopus/variants/yorp/include/variant/acpi/dptf.asl A src/mainboard/google/octopus/variants/yorp/include/variant/ec.h A src/mainboard/google/octopus/variants/yorp/include/variant/gpio.h 5 files changed, 69 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/25131/2 -- To view, visit https://review.coreboot.org/25131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id6962f15956a4d5280062ee684bb5154163e5473 Gerrit-Change-Number: 25131 Gerrit-PatchSet: 2 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org>

1 0

Change in coreboot[master]: mb/google/octopus: Create yorp variant.
by Justin TerAvest (Code Review) 13 Mar '18

13 Mar '18

Justin TerAvest has uploaded this change for review. ( https://review.coreboot.org/25131 Change subject: mb/google/octopus: Create yorp variant. ...................................................................... mb/google/octopus: Create yorp variant. This commit provides a Yorp board config option and the necessary variant files to allow building. BUG=b:74443669,b:74067452 TEST=Build Signed-off-by: Justin TerAvest <teravest(a)chromium.org> Change-Id: Id6962f15956a4d5280062ee684bb5154163e5473 --- M src/mainboard/google/octopus/Kconfig M src/mainboard/google/octopus/Kconfig.name A src/mainboard/google/octopus/variants/yorp/include/variant/acpi/dptf.asl A src/mainboard/google/octopus/variants/yorp/include/variant/ec.h A src/mainboard/google/octopus/variants/yorp/include/variant/gpio.h 5 files changed, 69 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/25131/1 diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index 0f30316..0375b78 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -33,6 +33,7 @@ config VARIANT_DIR string + default "yorp" if BOARD_GOOGLE_YORP default "octopus" if BOARD_GOOGLE_OCTOPUS config DEVICETREE @@ -41,6 +42,7 @@ config MAINBOARD_PART_NUMBER string + default "yorp" if BOARD_GOOGLE_YORP default "octopus" if BOARD_GOOGLE_OCTOPUS config MAINBOARD_FAMILY @@ -50,6 +52,7 @@ config GBB_HWID string depends on CHROMEOS + default "YORP TEST 7755" if BOARD_GOOGLE_YORP default "OCTOPUS TEST 6859" if BOARD_GOOGLE_OCTOPUS config MAX_CPUS diff --git a/src/mainboard/google/octopus/Kconfig.name b/src/mainboard/google/octopus/Kconfig.name index 5d375f7..f4bd02c 100644 --- a/src/mainboard/google/octopus/Kconfig.name +++ b/src/mainboard/google/octopus/Kconfig.name @@ -2,3 +2,11 @@ bool "Octopus" select BOARD_GOOGLE_BASEBOARD_OCTOPUS select BASEBOARD_OCTOPUS_LAPTOP +config BOARD_GOOGLE_YORP + bool "Yorp" + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select BASEBOARD_OCTOPUS_LAPTOP +config BOARD_GOOGLE_BIP + bool "Bip" + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select BASEBOARD_OCTOPUS_LAPTOP diff --git a/src/mainboard/google/octopus/variants/yorp/include/variant/acpi/dptf.asl b/src/mainboard/google/octopus/variants/yorp/include/variant/acpi/dptf.asl new file mode 100644 index 0000000..f3ff04b --- /dev/null +++ b/src/mainboard/google/octopus/variants/yorp/include/variant/acpi/dptf.asl @@ -0,0 +1,16 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2016 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/acpi/dptf.asl> diff --git a/src/mainboard/google/octopus/variants/yorp/include/variant/ec.h b/src/mainboard/google/octopus/variants/yorp/include/variant/ec.h new file mode 100644 index 0000000..586f106 --- /dev/null +++ b/src/mainboard/google/octopus/variants/yorp/include/variant/ec.h @@ -0,0 +1,21 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2016 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef MAINBOARD_EC_H +#define MAINBOARD_EC_H + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/octopus/variants/yorp/include/variant/gpio.h b/src/mainboard/google/octopus/variants/yorp/include/variant/gpio.h new file mode 100644 index 0000000..6d1ce5a --- /dev/null +++ b/src/mainboard/google/octopus/variants/yorp/include/variant/gpio.h @@ -0,0 +1,21 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2016 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the + * GNU General Public License for more details. + */ + +#ifndef MAINBOARD_GPIO_H +#define MAINBOARD_GPIO_H + +#include <baseboard/gpio.h> + +#endif /* MAINBOARD_GPIO_H */ -- To view, visit https://review.coreboot.org/25131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id6962f15956a4d5280062ee684bb5154163e5473 Gerrit-Change-Number: 25131 Gerrit-PatchSet: 1 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org>

1 0

Change in coreboot[master]: mb/google/poppy/variant/nautilus: Enable CABC feature as default
by build bot (Jenkins) (Code Review) 13 Mar '18

13 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25120 ) Change subject: mb/google/poppy/variant/nautilus: Enable CABC feature as default ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68500/ : SUCCESS -- To view, visit https://review.coreboot.org/25120 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifed0d37bf8147aa1b580f594f36f186051c2eb52 Gerrit-Change-Number: 25120 Gerrit-PatchSet: 2 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 08:05:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variant/nautilus: Enable CABC feature as default
by build bot (Jenkins) (Code Review) 13 Mar '18

13 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25120 ) Change subject: mb/google/poppy/variant/nautilus: Enable CABC feature as default ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/22913/ : ABORTED https://qa.coreboot.org/job/coreboot-gerrit/68499/ : ABORTED -- To view, visit https://review.coreboot.org/25120 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifed0d37bf8147aa1b580f594f36f186051c2eb52 Gerrit-Change-Number: 25120 Gerrit-PatchSet: 1 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 07:59:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018