coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: mb/google/poppy: Clear memory_params before initializing them
by build bot (Jenkins) (Code Review) 11 Mar '18

11 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25101 ) Change subject: mb/google/poppy: Clear memory_params before initializing them ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22880/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68461/ : SUCCESS -- To view, visit https://review.coreboot.org/25101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06c6511625de930903ae13788bdcd27667a17886 Gerrit-Change-Number: 25101 Gerrit-PatchSet: 2 Gerrit-Owner: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Mar 2018 01:52:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy: Initialize use_sec_spd to 0 on all platforms
by build bot (Jenkins) (Code Review) 11 Mar '18

11 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25101 ) Change subject: mb/google/poppy: Initialize use_sec_spd to 0 on all platforms ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22879/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68460/ : SUCCESS -- To view, visit https://review.coreboot.org/25101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06c6511625de930903ae13788bdcd27667a17886 Gerrit-Change-Number: 25101 Gerrit-PatchSet: 1 Gerrit-Owner: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Mar 2018 01:33:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy: Initialize use_sec_spd to 0 on all platforms
by Nicolas Boichat (Code Review) 11 Mar '18

11 Mar '18

Nicolas Boichat has uploaded this change for review. ( https://review.coreboot.org/25101 Change subject: mb/google/poppy: Initialize use_sec_spd to 0 on all platforms ...................................................................... mb/google/poppy: Initialize use_sec_spd to 0 on all platforms BRANCH=poppy BUG=b:74439917 TEST=Nautilus and poppy can boot, and do not get stuck at "CBFS: 'sec-spd.bin' not found." Change-Id: I06c6511625de930903ae13788bdcd27667a17886 Signed-off-by: Nicolas Boichat <drinkcat(a)chromium.org> --- M src/mainboard/google/poppy/variants/baseboard/memory.c M src/mainboard/google/poppy/variants/nautilus/memory.c 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/25101/1 diff --git a/src/mainboard/google/poppy/variants/baseboard/memory.c b/src/mainboard/google/poppy/variants/baseboard/memory.c index 8134f1a..bb1ca72 100644 --- a/src/mainboard/google/poppy/variants/baseboard/memory.c +++ b/src/mainboard/google/poppy/variants/baseboard/memory.c @@ -48,6 +48,7 @@ p->rcomp_resistor_size = sizeof(rcomp_resistor); p->rcomp_target = rcomp_target; p->rcomp_target_size = sizeof(rcomp_target); + p->use_sec_spd = 0; } int __attribute__((weak)) variant_memory_sku(void) diff --git a/src/mainboard/google/poppy/variants/nautilus/memory.c b/src/mainboard/google/poppy/variants/nautilus/memory.c index dc845bc..850e98d 100644 --- a/src/mainboard/google/poppy/variants/nautilus/memory.c +++ b/src/mainboard/google/poppy/variants/nautilus/memory.c @@ -46,4 +46,5 @@ p->rcomp_resistor_size = sizeof(rcomp_resistor); p->rcomp_target = rcomp_target; p->rcomp_target_size = sizeof(rcomp_target); + p->use_sec_spd = 0; } -- To view, visit https://review.coreboot.org/25101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I06c6511625de930903ae13788bdcd27667a17886 Gerrit-Change-Number: 25101 Gerrit-PatchSet: 1 Gerrit-Owner: Nicolas Boichat <drinkcat(a)chromium.org>

1 0

Change in coreboot[master]: src/device/dram/ddr2: Fix supported burst lengths
by Arthur Heymans (Code Review) 11 Mar '18

11 Mar '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/25098 ) Change subject: src/device/dram/ddr2: Fix supported burst lengths ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/25098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I502710bdac7eec715b29febefd64be88e5a1b80a Gerrit-Change-Number: 25098 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 11 Mar 2018 18:42:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/device/dram/ddr2: Fix supported burst lengths
by build bot (Jenkins) (Code Review) 11 Mar '18

11 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25098 ) Change subject: src/device/dram/ddr2: Fix supported burst lengths ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22878/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68459/ : SUCCESS -- To view, visit https://review.coreboot.org/25098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I502710bdac7eec715b29febefd64be88e5a1b80a Gerrit-Change-Number: 25098 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 11 Mar 2018 17:59:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/device/dram/ddr2: Fix supported burst lengths
by Elyes HAOUAS (Code Review) 11 Mar '18

11 Mar '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/25098 Change subject: src/device/dram/ddr2: Fix supported burst lengths ...................................................................... src/device/dram/ddr2: Fix supported burst lengths Supported burst lengths is described at byte 16 Change-Id: I502710bdac7eec715b29febefd64be88e5a1b80a Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/dram/ddr2.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/25098/1 diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c index eefb569..921679c 100644 --- a/src/device/dram/ddr2.c +++ b/src/device/dram/ddr2.c @@ -572,11 +572,11 @@ /* SDRAM Supported Burst length */ printram(" Burst length :"); - if (spd[16] & 0x06) { + if (spd[16] & 0x08) { dimm->flags.bl8 = 1; printram(" BL8"); } - if (spd[22] & 0x04) { + if (spd[16] & 0x04) { dimm->flags.bl4 = 1; printram(" BL4"); } -- To view, visit https://review.coreboot.org/25098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I502710bdac7eec715b29febefd64be88e5a1b80a Gerrit-Change-Number: 25098 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 8770w
by build bot (Jenkins) (Code Review) 10 Mar '18

10 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23651 ) Change subject: mainboard/hp: Add HP Elitebook 8770w ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22877/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68458/ : SUCCESS -- To view, visit https://review.coreboot.org/23651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4ff64e9cf0c7a51ac48ca2fe6fe8beab02e9f9a Gerrit-Change-Number: 23651 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Reeves <xiinc37(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Robert Reeves <xiinc37(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Comment-Date: Sun, 11 Mar 2018 00:50:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 8770w
by build bot (Jenkins) (Code Review) 10 Mar '18

10 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23651 ) Change subject: mainboard/hp: Add HP Elitebook 8770w ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68457/ : SUCCESS -- To view, visit https://review.coreboot.org/23651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4ff64e9cf0c7a51ac48ca2fe6fe8beab02e9f9a Gerrit-Change-Number: 23651 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Reeves <xiinc37(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Robert Reeves <xiinc37(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Comment-Date: Sun, 11 Mar 2018 00:30:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 8770w
by build bot (Jenkins) (Code Review) 10 Mar '18

10 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23651 ) Change subject: mainboard/hp: Add HP Elitebook 8770w ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68456/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22876/ : SUCCESS -- To view, visit https://review.coreboot.org/23651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4ff64e9cf0c7a51ac48ca2fe6fe8beab02e9f9a Gerrit-Change-Number: 23651 Gerrit-PatchSet: 2 Gerrit-Owner: Robert Reeves <xiinc37(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Robert Reeves <xiinc37(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Comment-Date: Sun, 11 Mar 2018 00:25:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 8770w (take 2)
by build bot (Jenkins) (Code Review) 10 Mar '18

10 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25008 ) Change subject: mainboard/hp: Add HP Elitebook 8770w (take 2) ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22875/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68455/ : SUCCESS -- To view, visit https://review.coreboot.org/25008 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c4de6533e155f98cf0505cbc169e39f68855dca Gerrit-Change-Number: 25008 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Reeves <xiinc37(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Robert Reeves <xiinc37(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 11 Mar 2018 00:13:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018