coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: mb/google/zoombini: Enable NVMe
by Nick Vaccaro (Code Review) 16 Mar '18

16 Mar '18

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/25256 Change subject: mb/google/zoombini: Enable NVMe ...................................................................... mb/google/zoombini: Enable NVMe BUG=b:72120814 BRANCH=master TEST=none Change-Id: I64ab38dda78345c1f3d7d3f2bf3cb04c19290ceb Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/zoombini/variants/baseboard/devicetree.cb 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/25256/1 diff --git a/src/mainboard/google/zoombini/variants/baseboard/devicetree.cb b/src/mainboard/google/zoombini/variants/baseboard/devicetree.cb index 44ea0bb..512354e 100644 --- a/src/mainboard/google/zoombini/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/zoombini/variants/baseboard/devicetree.cb @@ -51,6 +51,11 @@ register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC0)" register "usb3_ports[5]" = "USB3_PORT_DEFAULT(OC0)" + # Enable Root port 8 (PCIe port 9) for NVMe + register "PcieRpEnable[8]" = "1" + register "PcieClkSrcUsage[3]" = "8" + register "PcieClkSrcClkReq[3]" = "3" + device domain 0 on device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device @@ -81,7 +86,7 @@ device pci 1c.5 off end # PCI Express Port 6 device pci 1c.6 off end # PCI Express Port 7 device pci 1c.7 off end # PCI Express Port 8 - device pci 1d.0 off end # PCI Express Port 9 + device pci 1d.0 on end # PCI Express Port 9 device pci 1d.1 off end # PCI Express Port 10 device pci 1d.2 off end # PCI Express Port 11 device pci 1d.3 off end # PCI Express Port 12 -- To view, visit https://review.coreboot.org/25256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I64ab38dda78345c1f3d7d3f2bf3cb04c19290ceb Gerrit-Change-Number: 25256 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>

1 0

Change in coreboot[master]: mainboard/intel/glkrvp:Re-size flash WP_RO segment
by build bot (Jenkins) (Code Review) 16 Mar '18

16 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25255 ) Change subject: mainboard/intel/glkrvp:Re-size flash WP_RO segment ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23112/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68719/ : SUCCESS -- To view, visit https://review.coreboot.org/25255 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b24422e1eef2d0a81006286d4fc58f238fdce11 Gerrit-Change-Number: 25255 Gerrit-PatchSet: 1 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Mar 2018 22:37:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/intel/glkrvp:Re-size flash WP_RO segment
by Srinidhi N Kaushik (Code Review) 16 Mar '18

16 Mar '18

Srinidhi N Kaushik has uploaded this change for review. ( https://review.coreboot.org/25255 Change subject: mainboard/intel/glkrvp:Re-size flash WP_RO segment ...................................................................... mainboard/intel/glkrvp:Re-size flash WP_RO segment Update the size in WP_RO segment of the flash to accommodate builds using debug FSP. Change-Id: I8b24422e1eef2d0a81006286d4fc58f238fdce11 Signed-off-by: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> --- M src/mainboard/intel/glkrvp/chromeos.fmd 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/25255/1 diff --git a/src/mainboard/intel/glkrvp/chromeos.fmd b/src/mainboard/intel/glkrvp/chromeos.fmd index fad3537..84808ab 100644 --- a/src/mainboard/intel/glkrvp/chromeos.fmd +++ b/src/mainboard/intel/glkrvp/chromeos.fmd @@ -7,9 +7,9 @@ FMAP@0x0 0x800 RO_FRID@0x800 0x40 RO_FRID_PAD@0x840 0x7c0 - COREBOOT(CBFS)@0x1000 0x19b000 - GBB@0x19c000 0x40000 - RO_UNUSED@0x1dc000 0x20000 + COREBOOT(CBFS)@0x1000 0x1ab000 + GBB@0x1ac000 0x40000 + RO_UNUSED@0x1ec000 0x10000 } } MISC_RW@0x400000 0x4a000 { -- To view, visit https://review.coreboot.org/25255 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8b24422e1eef2d0a81006286d4fc58f238fdce11 Gerrit-Change-Number: 25255 Gerrit-PatchSet: 1 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: change type of board_sku_id() to uint32_t
by build bot (Jenkins) (Code Review) 16 Mar '18

16 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25252 ) Change subject: mb/google/poppy/variants/nami: change type of board_sku_id() to uint32_t ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23111/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68718/ : SUCCESS -- To view, visit https://review.coreboot.org/25252 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3baa8419f138abeb412ac09c2e7dc608e3b758b Gerrit-Change-Number: 25252 Gerrit-PatchSet: 2 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Mar 2018 21:58:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: MAINTAINERS: change second PC Engines maintainer
by build bot (Jenkins) (Code Review) 16 Mar '18

16 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25254 ) Change subject: MAINTAINERS: change second PC Engines maintainer ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23109/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68716/ : SUCCESS -- To view, visit https://review.coreboot.org/25254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eac0ae55e759ac9eb26783c11057db15fa62574 Gerrit-Change-Number: 25254 Gerrit-PatchSet: 1 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Mar 2018 21:56:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Configure PCH_WP_OD early.
by build bot (Jenkins) (Code Review) 16 Mar '18

16 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25250 ) Change subject: mb/google/octopus: Configure PCH_WP_OD early. ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23110/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68717/ : SUCCESS -- To view, visit https://review.coreboot.org/25250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf296ba6aad75b890afabd6f7c7c51fbaf911214 Gerrit-Change-Number: 25250 Gerrit-PatchSet: 3 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Mar 2018 21:56:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/octopus:Re-size flash WP_RO segment
by build bot (Jenkins) (Code Review) 16 Mar '18

16 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25253 ) Change subject: mainboard/google/octopus:Re-size flash WP_RO segment ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23108/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68715/ : SUCCESS -- To view, visit https://review.coreboot.org/25253 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a0d1d0121b503ff390adf3ce25973d72e59fdeb Gerrit-Change-Number: 25253 Gerrit-PatchSet: 1 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Mar 2018 21:50:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: change type of board_sku_id() to uint32_t
by Zhuohao Lee (Code Review) 16 Mar '18

16 Mar '18

Hello build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/25252 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/nami: change type of board_sku_id() to uint32_t ...................................................................... mb/google/poppy/variants/nami: change type of board_sku_id() to uint32_t Tools/scripts, like mosys/arc-setup, use int(4 bytes) to read the sku id. In order to support "-1", we need to use uint32_t(4 bytes) instead of using uint16_t(2 bytes) data type. Otherwise, tools/scripts will read 65535 instead of -1. Another reason to change this is that sku_id can be supported by ec up to 4 bytes. BUG=b:73792190 TEST=mosys output "Platform not Supported" for -1 sku id arc-setup read -1 sku id Change-Id: Ib3baa8419f138abeb412ac09c2e7dc608e3b758b Signed-off-by: Zhuohao Lee <zhuohao(a)chromium.org> --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 9 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/25252/2 -- To view, visit https://review.coreboot.org/25252 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib3baa8419f138abeb412ac09c2e7dc608e3b758b Gerrit-Change-Number: 25252 Gerrit-PatchSet: 2 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: change type of board_sku_id() to uint32_t
by build bot (Jenkins) (Code Review) 16 Mar '18

16 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25252 ) Change subject: mb/google/poppy/variants/nami: change type of board_sku_id() to uint32_t ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23107/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68714/ : SUCCESS -- To view, visit https://review.coreboot.org/25252 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3baa8419f138abeb412ac09c2e7dc608e3b758b Gerrit-Change-Number: 25252 Gerrit-PatchSet: 1 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Mar 2018 21:44:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: MAINTAINERS: change second PC Engines maintainer
by Piotr Król (Code Review) 16 Mar '18

16 Mar '18

Piotr Król has uploaded this change for review. ( https://review.coreboot.org/25254 Change subject: MAINTAINERS: change second PC Engines maintainer ...................................................................... MAINTAINERS: change second PC Engines maintainer Change-Id: I5eac0ae55e759ac9eb26783c11057db15fa62574 Signed-off-by: Piotr Król <piotr.krol(a)3mdeb.com> --- M MAINTAINERS 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/25254/1 diff --git a/MAINTAINERS b/MAINTAINERS index 71adc51..0875fdd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -280,7 +280,7 @@ PC ENGINES ALL MAINBOARDS M: Piotr Król <piotr.krol(a)3mdeb.com> -M: Kamil Wcisło <kamil.wcislo(a)3mdeb.com> +M: Michał Żygowski <michal.zygowski(a)3mdeb.com> S: Supported F: src/mainboard/pcengines/ -- To view, visit https://review.coreboot.org/25254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5eac0ae55e759ac9eb26783c11057db15fa62574 Gerrit-Change-Number: 25254 Gerrit-PatchSet: 1 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018