coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: commonlib/cbfs: Add hook function
by build bot (Jenkins) (Code Review) 02 Mar '18

02 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24967 ) Change subject: commonlib/cbfs: Add hook function ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/68141/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22593/ : SUCCESS -- To view, visit https://review.coreboot.org/24967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5d51c1f5a353fbcdec3ce9b4c051c4621780582 Gerrit-Change-Number: 24967 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Mar 2018 02:24:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: commonlib/cbfs: Add hook function
by Philipp Deppenwiese (Code Review) 02 Mar '18

02 Mar '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/24967 to look at the new patch set (#2). Change subject: commonlib/cbfs: Add hook function ...................................................................... commonlib/cbfs: Add hook function * Add hook function to access rdev. Change-Id: Ie5d51c1f5a353fbcdec3ce9b4c051c4621780582 Signed-off-by: zaolin <zaolin(a)das-labor.org> --- M src/commonlib/cbfs.c M src/commonlib/include/commonlib/cbfs.h M src/lib/cbfs.c 3 files changed, 27 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/24967/2 -- To view, visit https://review.coreboot.org/24967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie5d51c1f5a353fbcdec3ce9b4c051c4621780582 Gerrit-Change-Number: 24967 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants: Set pch_trip_temp to 75C
by build bot (Jenkins) (Code Review) 02 Mar '18

02 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24968 ) Change subject: mb/google/poppy/variants: Set pch_trip_temp to 75C ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22592/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68140/ : SUCCESS -- To view, visit https://review.coreboot.org/24968 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic46fa0681796b821dfb014ab91734c960df7846a Gerrit-Change-Number: 24968 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Mar 2018 02:15:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: commonlib/cbfs: Add hook function
by build bot (Jenkins) (Code Review) 02 Mar '18

02 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24967 ) Change subject: commonlib/cbfs: Add hook function ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/68139/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22591/ : SUCCESS -- To view, visit https://review.coreboot.org/24967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5d51c1f5a353fbcdec3ce9b4c051c4621780582 Gerrit-Change-Number: 24967 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Mar 2018 02:14:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants: Set pch_trip_temp to 75C
by Furquan Shaikh (Code Review) 02 Mar '18

02 Mar '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/24968 Change subject: mb/google/poppy/variants: Set pch_trip_temp to 75C ...................................................................... mb/google/poppy/variants: Set pch_trip_temp to 75C Similar to Soraka, this change sets the pch_trip_temp value to 75C. This is important so that PMC can shutdown the thermal sensor when CPU is in C-state and DTS temp <= pch_trip_temp. BUG=b:74089135 Change-Id: Ic46fa0681796b821dfb014ab91734c960df7846a Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/poppy/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nautilus/devicetree.cb 3 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/24968/1 diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb index 76ec693..1027dda 100644 --- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb @@ -264,6 +264,9 @@ # Lock Down register "chipset_lockdown" = "CHIPSET_LOCKDOWN_COREBOOT" + # PCH Trip Temperature in degree C + register "pch_trip_temp" = "75" + device cpu_cluster 0 on device lapic 0 on end end diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index c4aabcf..9d6dcd8 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -234,6 +234,9 @@ # Lock Down register "chipset_lockdown" = "CHIPSET_LOCKDOWN_COREBOOT" + # PCH Trip Temperature in degree C + register "pch_trip_temp" = "75" + device cpu_cluster 0 on device lapic 0 on end end diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb index 0f24685..fe4e1fa 100644 --- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb @@ -282,6 +282,9 @@ # Lock Down register "chipset_lockdown" = "CHIPSET_LOCKDOWN_COREBOOT" + # PCH Trip Temperature in degree C + register "pch_trip_temp" = "75" + device cpu_cluster 0 on device lapic 0 on end end -- To view, visit https://review.coreboot.org/24968 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic46fa0681796b821dfb014ab91734c960df7846a Gerrit-Change-Number: 24968 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: commonlib/cbfs: Add hook function
by Philipp Deppenwiese (Code Review) 02 Mar '18

02 Mar '18

Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/24967 Change subject: commonlib/cbfs: Add hook function ...................................................................... commonlib/cbfs: Add hook function * Add hook function to access rdev. Change-Id: Ie5d51c1f5a353fbcdec3ce9b4c051c4621780582 Signed-off-by: zaolin <zaolin(a)das-labor.org> --- M src/commonlib/cbfs.c M src/commonlib/include/commonlib/cbfs.h M src/lib/cbfs.c 3 files changed, 24 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/24967/1 diff --git a/src/commonlib/cbfs.c b/src/commonlib/cbfs.c index 1db8d31..4518a8e 100644 --- a/src/commonlib/cbfs.c +++ b/src/commonlib/cbfs.c @@ -61,6 +61,11 @@ return 0; } +void __attribute__((weak)) +hook_cbfs_data(const char *name, const struct region_device *area) +{ +} + int cbfs_for_each_file(const struct region_device *cbfs, const struct cbfsf *prev, struct cbfsf *fh) { diff --git a/src/commonlib/include/commonlib/cbfs.h b/src/commonlib/include/commonlib/cbfs.h index 163bef2..9589380 100644 --- a/src/commonlib/include/commonlib/cbfs.h +++ b/src/commonlib/include/commonlib/cbfs.h @@ -26,6 +26,9 @@ struct region_device data; }; +/* Hook function for access to rdev in locate functions */ +void hook_cbfs_data(const char *name, const struct region_device *area); + /* Locate file by name and optional type. Returns 0 on succcess else < 0 on * error.*/ int cbfs_locate(struct cbfsf *fh, const struct region_device *cbfs, diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c index 596abc5..259704b 100644 --- a/src/lib/cbfs.c +++ b/src/lib/cbfs.c @@ -53,7 +53,12 @@ if (rdev_chain(&rdev, boot_dev, props.offset, props.size)) return -1; - return cbfs_locate(fh, &rdev, name, type); + if (cbfs_locate(fh, &rdev, name, type)) + return -1; + + hook_cbfs_data(name, fh->data); + + return 0; } void *cbfs_boot_map_with_leak(const char *name, uint32_t type, size_t *size) @@ -69,6 +74,8 @@ if (size != NULL) *size = fsize; + hook_cbfs_data(name, &fh.data); + return rdev_mmap(&fh.data, 0, fsize); } @@ -83,7 +90,12 @@ return -1; } - return cbfs_locate(fh, &rdev, name, type); + if (cbfs_locate(fh, &rdev, name, type)) + return -1; + + hook_cbfs_data(name, fh->data); + + return 0; } size_t cbfs_load_and_decompress(const struct region_device *rdev, size_t offset, @@ -197,6 +209,8 @@ || decompressed_size > buf_size) return 0; + hook_cbfs_data(name, &fh.data); + return cbfs_load_and_decompress(&fh.data, 0, region_device_sz(&fh.data), buf, buf_size, compression_algo); } -- To view, visit https://review.coreboot.org/24967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie5d51c1f5a353fbcdec3ce9b4c051c4621780582 Gerrit-Change-Number: 24967 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>

1 0

Change in coreboot[master]: soc/intel/common/block/smm: Add delay(configurable) before entering S5
by build bot (Jenkins) (Code Review) 02 Mar '18

02 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24964 ) Change subject: soc/intel/common/block/smm: Add delay(configurable) before entering S5 ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22589/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68137/ : SUCCESS -- To view, visit https://review.coreboot.org/24964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaee19b5aba0aad7eb34bd126fda5b0f6ef394ed7 Gerrit-Change-Number: 24964 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Mar 2018 02:09:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/x86/mp_init: Increase AP check-in timeout to 1second
by build bot (Jenkins) (Code Review) 02 Mar '18

02 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24965 ) Change subject: cpu/x86/mp_init: Increase AP check-in timeout to 1second ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22590/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68138/ : SUCCESS -- To view, visit https://review.coreboot.org/24965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I979c11a10e6888aef0f71b5632ea803a67bbb0ff Gerrit-Change-Number: 24965 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Mar 2018 02:06:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lib/fmap: Add hook function.
by build bot (Jenkins) (Code Review) 02 Mar '18

02 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24966 ) Change subject: lib/fmap: Add hook function. ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22588/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68136/ : SUCCESS -- To view, visit https://review.coreboot.org/24966 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I699eec879e2c61976832c394b70cd6cfa5bae584 Gerrit-Change-Number: 24966 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 02 Mar 2018 01:57:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib/fmap: Add hook function.
by Philipp Deppenwiese (Code Review) 02 Mar '18

02 Mar '18

Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/24966 Change subject: lib/fmap: Add hook function. ...................................................................... lib/fmap: Add hook function. * Add hook function for accessing rdev by calling locate functions. Change-Id: I699eec879e2c61976832c394b70cd6cfa5bae584 Signed-off-by: zaolin <zaolin(a)das-labor.org> --- M src/include/fmap.h M src/lib/fmap.c 2 files changed, 20 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/24966/1 diff --git a/src/include/fmap.h b/src/include/fmap.h index 5834831..300f962 100644 --- a/src/include/fmap.h +++ b/src/include/fmap.h @@ -19,6 +19,9 @@ #include <commonlib/region.h> #include <commonlib/fmap_serialized.h> +/* Hook function for access to rdev in locate functions */ +void hook_fmap_rdev(const char *name, const struct region_device *area); + /* Locate the fmap directory. Return 0 on success, < 0 on error. */ int find_fmap_directory(struct region_device *fmrd); diff --git a/src/lib/fmap.c b/src/lib/fmap.c index 9602134..e4231e0 100644 --- a/src/lib/fmap.c +++ b/src/lib/fmap.c @@ -29,6 +29,11 @@ static int fmap_print_once CAR_GLOBAL; +void __attribute__((weak)) +hook_fmap_rdev(const char *name, const struct region_device *area) +{ +} + int find_fmap_directory(struct region_device *fmrd) { const struct region_device *boot; @@ -77,7 +82,12 @@ if (fmap_locate_area(name, &ar)) return -1; - return boot_device_ro_subregion(&ar, area); + if (boot_device_ro_subregion(&ar, area)) + return -1; + + hook_fmap_rdev(name, area); + + return 0; } int fmap_locate_area_as_rdev_rw(const char *name, struct region_device *area) @@ -87,7 +97,12 @@ if (fmap_locate_area(name, &ar)) return -1; - return boot_device_rw_subregion(&ar, area); + if (boot_device_rw_subregion(&ar, area)) + return -1; + + hook_fmap_rdev(name, area); + + return 0; } int fmap_locate_area(const char *name, struct region *ar) -- To view, visit https://review.coreboot.org/24966 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I699eec879e2c61976832c394b70cd6cfa5bae584 Gerrit-Change-Number: 24966 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018