coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: drivers/tpm: Add TPM ramstage driver for devices without vboot.
by Philipp Deppenwiese (Code Review) 01 Mar '18

01 Mar '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/24905 ) Change subject: drivers/tpm: Add TPM ramstage driver for devices without vboot. ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/#/c/24905/5/src/drivers/tpm/tpm.c File src/drivers/tpm/tpm.c: https://review.coreboot.org/#/c/24905/5/src/drivers/tpm/tpm.c@35 PS5, Line 35: BOOT_STATE_INIT_ENTRY(BS_DEV_INIT_CHIPS, BS_ON_ENTRY, init_tpm_dev, NULL); > why not use chip_operations like it's done in drivers/pc80/tpm/tis.c ? […] Yes. No PCI device tree, no chip operations ;) -- To view, visit https://review.coreboot.org/24905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7536c9734732aeaa85ccc7916c12eecb9ca26b2e Gerrit-Change-Number: 24905 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 01 Mar 2018 18:29:18 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/{amd/gardenia, google/kahlee}: Initialize GPIOs earlier
by build bot (Jenkins) (Code Review) 01 Mar '18

01 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24916 ) Change subject: mb/{amd/gardenia,google/kahlee}: Initialize GPIOs earlier ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68109/ : SUCCESS -- To view, visit https://review.coreboot.org/24916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I568a3240a54817ab6dcf15fe39f7f1336943852b Gerrit-Change-Number: 24916 Gerrit-PatchSet: 9 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Mar 2018 16:10:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Remove printk for GPIO
by build bot (Jenkins) (Code Review) 01 Mar '18

01 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24915 ) Change subject: soc/amd/stoneyridge: Remove printk for GPIO ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68107/ : SUCCESS -- To view, visit https://review.coreboot.org/24915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I064291decf47d86132e36469e029b3262ec20172 Gerrit-Change-Number: 24915 Gerrit-PatchSet: 3 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Mar 2018 16:03:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/kahlee: Initialize WLAN GPIOs early.
by build bot (Jenkins) (Code Review) 01 Mar '18

01 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24916 ) Change subject: mb/google/kahlee: Initialize WLAN GPIOs early. ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68108/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22563/ : SUCCESS -- To view, visit https://review.coreboot.org/24916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I568a3240a54817ab6dcf15fe39f7f1336943852b Gerrit-Change-Number: 24916 Gerrit-PatchSet: 8 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Mar 2018 16:02:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/kahlee: Initialize WLAN GPIOs early.
by build bot (Jenkins) (Code Review) 01 Mar '18

01 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24916 ) Change subject: mb/google/kahlee: Initialize WLAN GPIOs early. ...................................................................... Patch Set 7: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68106/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22561/ : SUCCESS -- To view, visit https://review.coreboot.org/24916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I568a3240a54817ab6dcf15fe39f7f1336943852b Gerrit-Change-Number: 24916 Gerrit-PatchSet: 7 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Mar 2018 15:57:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Remove printk for GPIO
by build bot (Jenkins) (Code Review) 01 Mar '18

01 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24915 ) Change subject: soc/amd/stoneyridge: Remove printk for GPIO ...................................................................... Patch Set 2: Verified+1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/22562/ : SUCCESS -- To view, visit https://review.coreboot.org/24915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I064291decf47d86132e36469e029b3262ec20172 Gerrit-Change-Number: 24915 Gerrit-PatchSet: 2 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Mar 2018 15:57:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/denverton_ns: Update UART legacy mode to keep FSP traces
by build bot (Jenkins) (Code Review) 01 Mar '18

01 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23623 ) Change subject: soc/intel/denverton_ns: Update UART legacy mode to keep FSP traces ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68104/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22560/ : SUCCESS -- To view, visit https://review.coreboot.org/23623 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8801e178ffd8eeee78ece07da7bd6b8dbd88538 Gerrit-Change-Number: 23623 Gerrit-PatchSet: 5 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: FEI WANG <wangfei.jimei(a)gmail.com> Gerrit-Reviewer: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shine Liu <shine.liu(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Thu, 01 Mar 2018 14:58:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/common: Fix conflicting OIC register definition
by build bot (Jenkins) (Code Review) 01 Mar '18

01 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24924 ) Change subject: sb/intel/common: Fix conflicting OIC register definition ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68101/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22557/ : SUCCESS -- To view, visit https://review.coreboot.org/24924 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9e554c072f01412164dc35e0b09272142e3796f Gerrit-Change-Number: 24924 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Mar 2018 12:53:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/common: Fix conflicting OIC register definition
by Nico Huber (Code Review) 01 Mar '18

01 Mar '18

Hello Patrick Rudolph, Arthur Heymans, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/24924 to look at the new patch set (#2). Change subject: sb/intel/common: Fix conflicting OIC register definition ...................................................................... sb/intel/common: Fix conflicting OIC register definition Commit d2d2aef6a3 (sb/intel/{bd82x6,ibexpeak}: Move RCBA macros to a common location) makes some platforms use the wrong OIC register defi- nition. It was extended to 16-bit in the corporate version of ICH10. So let's give the new size and location a new name: EOIC (extended OIC). This only touches the systems affected by the mentioned change. Other platforms still need to be adapted before they can use the common RCBA definitions. Change-Id: If9e554c072f01412164dc35e0b09272142e3796f Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M src/mainboard/google/butterfly/romstage.c M src/mainboard/google/link/romstage.c M src/mainboard/google/parrot/romstage.c M src/mainboard/google/stout/romstage.c M src/mainboard/samsung/lumpy/romstage.c M src/mainboard/samsung/stumpy/romstage.c M src/southbridge/intel/bd82x6x/early_rcba.c M src/southbridge/intel/common/rcba.h 8 files changed, 15 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/24924/2 -- To view, visit https://review.coreboot.org/24924 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If9e554c072f01412164dc35e0b09272142e3796f Gerrit-Change-Number: 24924 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: sb/intel/common: Fix conflicting OIC register definition
by build bot (Jenkins) (Code Review) 01 Mar '18

01 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24924 ) Change subject: sb/intel/common: Fix conflicting OIC register definition ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/68100/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22556/ : SUCCESS -- To view, visit https://review.coreboot.org/24924 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9e554c072f01412164dc35e0b09272142e3796f Gerrit-Change-Number: 24924 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Mar 2018 12:42:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018