coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: soc/intel/cannonlake: Increase bootblock size
by Duncan Laurie (Code Review) 02 Dec '18

02 Dec '18

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29996 Change subject: soc/intel/cannonlake: Increase bootblock size ...................................................................... soc/intel/cannonlake: Increase bootblock size Increase the bootblock size to 48K to match skylake. With UART enabled we are very near the 32K limit, and with upcoming changes to add USB devices in devicetree for a cannonlake board it is over the current 32K limit. Change-Id: I155cb0a6af1746af6833fa9f35c2ea6fe0bc709f Signed-off-by: Duncan Laurie <dlaurie(a)google.com> --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/29996/1 diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index 9452b6d..78c6dfe 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -230,7 +230,7 @@ config C_ENV_BOOTBLOCK_SIZE hex - default 0x8000 + default 0xC000 config CBFS_SIZE hex -- To view, visit https://review.coreboot.org/c/coreboot/+/29996 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I155cb0a6af1746af6833fa9f35c2ea6fe0bc709f Gerrit-Change-Number: 29996 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mainboard/asus/am1i-a: add missing GPIO IO ports to devicetree.cb to ...
by Kevin Cody-Little (Code Review) 02 Dec '18

02 Dec '18

Hello Angel Pons, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29994 to look at the new patch set (#3). Change subject: mainboard/asus/am1i-a: add missing GPIO IO ports to devicetree.cb to fix non-boot condition ...................................................................... mainboard/asus/am1i-a: add missing GPIO IO ports to devicetree.cb to fix non-boot condition Change-Id: Id96fbfd5c815431dba2f030fca62a5ea16b97393 Signed-off-by: Kevin Cody-Little <kcodyjr(a)gmail.com> --- M src/mainboard/asus/am1i-a/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/29994/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/29994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id96fbfd5c815431dba2f030fca62a5ea16b97393 Gerrit-Change-Number: 29994 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Cody-Little <kcodyjr(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: arch/x86/Kconfig: move MAX_REBOOT_CNT option
by Marcello Sylvester Bauer (Code Review) 02 Dec '18

02 Dec '18

Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29979 ) Change subject: arch/x86/Kconfig: move MAX_REBOOT_CNT option ...................................................................... Patch Set 2: (1 comment) > Patch Set 2: > > (1 comment) > > Currently, you can't set wrong values. That's a feature I'd like to > have maintained. i'll keep that in mind :) > Everything below the currently defined defaults is > wrong. why are they wrong? I tested it with values below and it behaves like it should. > In other words, this option was hidden on purpose. You can add another > option for instance and take the minimum of both or something like > that. But you mustn't lower it. An other option would be to adapt the range in the Kconfig or fix the issue which cause this wrong behavior. https://review.coreboot.org/#/c/29979/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29979/1//COMMIT_MSG@11 PS1, Line 11: > It's not about complete reboots. If you'd set it to 2 you […] sounds like an unintended behavior if that is true. but i don't understand why it shouldn't be optional. The default value of 3 sounds good IMHO, but in some use cases, your may want to change it. -- To view, visit https://review.coreboot.org/c/coreboot/+/29979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice26e2ef349f1172b564edc14f1012c33546a93c Gerrit-Change-Number: 29979 Gerrit-PatchSet: 2 Gerrit-Owner: Marcello Sylvester Bauer <sylvblck(a)sylv.io> Gerrit-Reviewer: Marcello Sylvester Bauer <sylvblck(a)sylv.io> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 01 Dec 2018 23:18:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Marcello Sylvester Bauer <sylvblck(a)sylv.io> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: MAINTAINERS: Add myself
by Angel Pons (Code Review) 01 Dec '18

01 Dec '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29995 Change subject: MAINTAINERS: Add myself ...................................................................... MAINTAINERS: Add myself Add myself as a maintainer of the four mainboards I ported. For those which were added as a variant, add myself as a maintainer of the whole mainboard group. Change-Id: I0e1b54279027fae82ea9f2825e6f27d38ef3c746 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M MAINTAINERS 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/29995/1 diff --git a/MAINTAINERS b/MAINTAINERS index e70a15c..d3526a9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -188,6 +188,11 @@ S: Odd Fixes F: src/mainboard/gigabyte/ga-g41m-es2l +GIGABYTE GA-H61M-S2PV MAINBOARD +M: Angel Pons <th3fanbus(a)gmail.com> +S: Maintained +F: src/mainboard/gigabyte/ga-h61m-s2pv + GOOGLE PANTHER MAINBOARD M: Stefan Reinauer <stefan.reinauer(a)coreboot.org> S: Supported @@ -313,6 +318,11 @@ S: Maintained F: src/soc/intel/apollolake/ +ASROCK G41C-GS MAINBOARD & VARIANTS +M: Angel Pons <th3fanbus(a)gmail.com> +S: Maintained +F: src/mainboard/asrock/g41c-gs/ + ASUS KFSN4-DRE & KFSN4-DRE_K8 MAINBOARDS M: Timothy Pearson <tpearson(a)raptorengineeringinc.com> S: Supported @@ -329,6 +339,16 @@ S: Supported F: src/mainboard/asus/kgpe-d16/ +ASUS P5QC PRO MAINBOARD & VARIANTS +M: Angel Pons <th3fanbus(a)gmail.com> +S: Maintained +F: src/mainboard/asus/p5qc/ + +ASUS P8H61-M PRO MAINBOARD +M: Angel Pons <th3fanbus(a)gmail.com> +S: Maintained +F: src/mainboard/asus/p8h61-m_pro/ + PC ENGINES ALL MAINBOARDS M: Piotr Król <piotr.krol(a)3mdeb.com> M: Michał Żygowski <michal.zygowski(a)3mdeb.com> -- To view, visit https://review.coreboot.org/c/coreboot/+/29995 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e1b54279027fae82ea9f2825e6f27d38ef3c746 Gerrit-Change-Number: 29995 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mainboard/asus/am1i-a: add missing GPIO IO ports to devtree
by Angel Pons (Code Review) 01 Dec '18

01 Dec '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29994 ) Change subject: mainboard/asus/am1i-a: add missing GPIO IO ports to devtree ...................................................................... Patch Set 2: Code-Review+2 I would optionally describe what issue this fixes, but other than that I believe this is good enough. -- To view, visit https://review.coreboot.org/c/coreboot/+/29994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id96fbfd5c815431dba2f030fca62a5ea16b97393 Gerrit-Change-Number: 29994 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Cody-Little <kcodyjr(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Dec 2018 22:00:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mainboard/asus/am1i-a: add missing GPIO IO ports to devtree
by Kevin Cody-Little (Code Review) 01 Dec '18

01 Dec '18

Hello Angel Pons, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29994 to look at the new patch set (#2). Change subject: mainboard/asus/am1i-a: add missing GPIO IO ports to devtree ...................................................................... mainboard/asus/am1i-a: add missing GPIO IO ports to devtree Change-Id: Id96fbfd5c815431dba2f030fca62a5ea16b97393 Signed-off-by: Kevin Cody-Little <kcodyjr(a)gmail.com> --- M src/mainboard/asus/am1i-a/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/29994/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id96fbfd5c815431dba2f030fca62a5ea16b97393 Gerrit-Change-Number: 29994 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Cody-Little <kcodyjr(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: Add additional IO ports for GPIO to devtree, for ASUS am1i-a port, fi...
by Angel Pons (Code Review) 01 Dec '18

01 Dec '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29994 ) Change subject: Add additional IO ports for GPIO to devtree, for ASUS am1i-a port, fixes failure to boot (for me). ...................................................................... Patch Set 1: Code-Review-1 Good to know this fixes your issues, but: - There is no signed-off line - The commit summary is way too long Please check other commits as a reference and please correct these issues. -- To view, visit https://review.coreboot.org/c/coreboot/+/29994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id96fbfd5c815431dba2f030fca62a5ea16b97393 Gerrit-Change-Number: 29994 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Cody-Little <kcodyjr(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Dec 2018 21:34:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Add additional IO ports for GPIO to devtree, for ASUS am1i-a port, fi...
by Kevin Cody-Little (Code Review) 01 Dec '18

01 Dec '18

Kevin Cody-Little has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29994 Change subject: Add additional IO ports for GPIO to devtree, for ASUS am1i-a port, fixes failure to boot (for me). ...................................................................... Add additional IO ports for GPIO to devtree, for ASUS am1i-a port, fixes failure to boot (for me). Change-Id: Id96fbfd5c815431dba2f030fca62a5ea16b97393 --- M src/mainboard/asus/am1i-a/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/29994/1 diff --git a/src/mainboard/asus/am1i-a/devicetree.cb b/src/mainboard/asus/am1i-a/devicetree.cb index 4fcd13e..3aeb5c7 100644 --- a/src/mainboard/asus/am1i-a/devicetree.cb +++ b/src/mainboard/asus/am1i-a/devicetree.cb @@ -82,7 +82,9 @@ irq 0x70 = 12 end device pnp 2e.7 on # GPIO + io 0x60 = 0x320 io 0x62 = 0x300 + io 0x64 = 0x321 end end #superio/ite/it8623e chip drivers/pc80/tpm -- To view, visit https://review.coreboot.org/c/coreboot/+/29994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id96fbfd5c815431dba2f030fca62a5ea16b97393 Gerrit-Change-Number: 29994 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Cody-Little <kcodyjr(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: src: Remove unused variables
by build bot (Jenkins) (Code Review) 01 Dec '18

01 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 ) Change subject: src: Remove unused variables ...................................................................... Patch Set 14: (1 comment) https://review.coreboot.org/#/c/29917/14/src/cpu/amd/family_10h-family_15h/… File src/cpu/amd/family_10h-family_15h/init_cpus.c: https://review.coreboot.org/#/c/29917/14/src/cpu/amd/family_10h-family_15h/… PS14, Line 1061: if ((get_option(&nvram, "cpu_c_states") == CB_SUCCESS) && line over 80 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/29917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837 Gerrit-Change-Number: 29917 Gerrit-PatchSet: 14 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Dec 2018 17:29:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: riscv: fix non-SMP support
by Philipp Hug (Code Review) 01 Dec '18

01 Dec '18

Philipp Hug has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29993 Change subject: riscv: fix non-SMP support ...................................................................... riscv: fix non-SMP support Change an incorrect zero default of RISCV_HART_NUM to 1. This causes causes a call to address 0. Add a die() call to fail gracefully. Change-Id: I4e3aa09b787ae0f26a4aae375f4e5fcd745a0a1e Signed-off-by: Philipp Hug <philipp(a)hug.cx> --- M src/arch/riscv/Kconfig M src/arch/riscv/smp.c 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/29993/1 diff --git a/src/arch/riscv/Kconfig b/src/arch/riscv/Kconfig index ae83be8..2d2ef5d 100644 --- a/src/arch/riscv/Kconfig +++ b/src/arch/riscv/Kconfig @@ -35,6 +35,7 @@ config RISCV_HART_NUM int + default 1 config RISCV_WORKING_HARTID int diff --git a/src/arch/riscv/smp.c b/src/arch/riscv/smp.c index 8d07d39..b3feb9e 100644 --- a/src/arch/riscv/smp.c +++ b/src/arch/riscv/smp.c @@ -81,5 +81,8 @@ if (i != hartid) set_msip(i, 1); + if (HLS()->entry.fn == NULL) + die("entry fn not set\n"); + HLS()->entry.fn(HLS()->entry.arg); } -- To view, visit https://review.coreboot.org/c/coreboot/+/29993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e3aa09b787ae0f26a4aae375f4e5fcd745a0a1e Gerrit-Change-Number: 29993 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Hug <philipp(a)hug.cx> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018