coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in ...coreboot[master]: mainboard/ocp/wedge100s: Add vboot support
by Philipp Deppenwiese (Code Review) 21 Nov '18

21 Nov '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29593 ) Change subject: mainboard/ocp/wedge100s: Add vboot support ...................................................................... mainboard/ocp/wedge100s: Add vboot support * Add RO only FMAP. * Add kconfig options. Tested=OCP Wedge100s Change-Id: I1979e0263e41f21c01c407ac81ad1198a53741e8 Signed-off-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/29593 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/ocp/wedge100s/Kconfig M src/mainboard/ocp/wedge100s/cmos.layout A src/mainboard/ocp/wedge100s/vboot-ro.fmd 3 files changed, 33 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved diff --git a/src/mainboard/ocp/wedge100s/Kconfig b/src/mainboard/ocp/wedge100s/Kconfig index 5d4349d..df6c57e 100644 --- a/src/mainboard/ocp/wedge100s/Kconfig +++ b/src/mainboard/ocp/wedge100s/Kconfig @@ -16,6 +16,14 @@ select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM1 +config VBOOT + select VBOOT_VBNV_CMOS + select VBOOT_NO_BOARD_SUPPORT + select GBB_FLAG_DISABLE_LID_SHUTDOWN + select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC + select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC + select GBB_FLAG_DISABLE_FWMP + config MAINBOARD_DIR string default "ocp/wedge100s" @@ -30,6 +38,7 @@ config CBFS_SIZE hex + default 0x006fa000 if VBOOT default 0x00200000 config VIRTUAL_ROM_SIZE @@ -45,6 +54,7 @@ config FMDFILE string + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/vboot-ro.fmd" if VBOOT default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd" endif # BOARD_OCP_WEDGE100S diff --git a/src/mainboard/ocp/wedge100s/cmos.layout b/src/mainboard/ocp/wedge100s/cmos.layout index 3c5bc3b..3aaa56b 100644 --- a/src/mainboard/ocp/wedge100s/cmos.layout +++ b/src/mainboard/ocp/wedge100s/cmos.layout @@ -81,6 +81,7 @@ 408 1 e 1 nmi 409 2 e 7 power_on_after_fail #411 5 r 0 unused +416 128 r 0 vbnv # MRC Scrambler Seed values 896 32 r 0 mrc_scrambler_seed diff --git a/src/mainboard/ocp/wedge100s/vboot-ro.fmd b/src/mainboard/ocp/wedge100s/vboot-ro.fmd new file mode 100644 index 0000000..a591bae --- /dev/null +++ b/src/mainboard/ocp/wedge100s/vboot-ro.fmd @@ -0,0 +1,22 @@ +FLASH 16M { + SI_ALL@0x0 0x800000 { + SI_DESC@0x0 0x1000 + SI_ME@0x1000 0x7ff000 + } + SI_BIOS@0x800000 0x800000 { + MISC_RW@0x0 0x20000 { + RW_MRC_CACHE@0x0 0x10000 + RW_VPD@0x010000 0x4000 + } + WP_RO@0x020000 0x7e0000 { + RO_VPD@0x0 0x4000 + RO_SECTION@0x4000 0x7dc000 { + FMAP@0x0 0x800 + RO_FRID@0x800 0x40 + RO_FRID_PAD@0x840 0x7c0 + GBB@0x1000 0xef000 + COREBOOT(CBFS)@0xf0000 0x6ec000 + } + } + } +} -- To view, visit https://review.coreboot.org/c/coreboot/+/29593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1979e0263e41f21c01c407ac81ad1198a53741e8 Gerrit-Change-Number: 29593 Gerrit-PatchSet: 9 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...coreboot[master]: mainboard/ocp/wedge100s: Add vboot support
by Philipp Deppenwiese (Code Review) 21 Nov '18

21 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29593 ) Change subject: mainboard/ocp/wedge100s: Add vboot support ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1979e0263e41f21c01c407ac81ad1198a53741e8 Gerrit-Change-Number: 29593 Gerrit-PatchSet: 8 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Nov 2018 16:03:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/fsp_broadwell_de: Add vboot support
by Philipp Deppenwiese (Code Review) 21 Nov '18

21 Nov '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29590 ) Change subject: soc/intel/fsp_broadwell_de: Add vboot support ...................................................................... soc/intel/fsp_broadwell_de: Add vboot support Enable vboot2 in romstage. Change-Id: I7f1a1e8538999c5e4e54f3a4aa0cdf6d8a309c4f Signed-off-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/29590 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/intel/fsp_broadwell_de/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved diff --git a/src/soc/intel/fsp_broadwell_de/Kconfig b/src/soc/intel/fsp_broadwell_de/Kconfig index 7046ff0..fe0fa8d 100644 --- a/src/soc/intel/fsp_broadwell_de/Kconfig +++ b/src/soc/intel/fsp_broadwell_de/Kconfig @@ -29,6 +29,9 @@ select TSC_MONOTONIC_TIMER select TSC_CONSTANT_RATE +config VBOOT + select VBOOT_STARTS_IN_ROMSTAGE + config CBFS_SIZE hex default 0x200000 -- To view, visit https://review.coreboot.org/c/coreboot/+/29590 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f1a1e8538999c5e4e54f3a4aa0cdf6d8a309c4f Gerrit-Change-Number: 29590 Gerrit-PatchSet: 8 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...coreboot[master]: soc/intel/fsp_broadwell_de: Add vboot support
by Philipp Deppenwiese (Code Review) 21 Nov '18

21 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29590 ) Change subject: soc/intel/fsp_broadwell_de: Add vboot support ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29590 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f1a1e8538999c5e4e54f3a4aa0cdf6d8a309c4f Gerrit-Change-Number: 29590 Gerrit-PatchSet: 7 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Nov 2018 16:03:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: payloads/tianocore: rebase patches to UDK2018 release
by Philipp Deppenwiese (Code Review) 21 Nov '18

21 Nov '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/27615 ) Change subject: payloads/tianocore: rebase patches to UDK2018 release ...................................................................... payloads/tianocore: rebase patches to UDK2018 release Patches should be applied against edk2 release instead of arbitrary commit. This aims to simplify Tianocore payload support by other platforms. Change-Id: Ib409f6f93eb64d7a9a2f09a75f8e637ab8689410 Signed-off-by: Piotr Król <piotr.krol(a)3mdeb.com> Reviewed-on: https://review.coreboot.org/c/27615 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> --- M payloads/external/tianocore/Makefile M payloads/external/tianocore/patches/01_CorebootPayloadPkg_pcinoenum.patch M payloads/external/tianocore/patches/02_CorebootPayloadPkg_bds.patch M payloads/external/tianocore/patches/03_Library_EndofDXE.patch M payloads/external/tianocore/patches/04_CorebootPayloadPkg_addps2.patch M payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch M payloads/external/tianocore/patches/07_CorebootPayloadPkg-Use-correct-BytesPerScanLine.patch M payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch D payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch 9 files changed, 52 insertions(+), 88 deletions(-) Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved diff --git a/payloads/external/tianocore/Makefile b/payloads/external/tianocore/Makefile index 747ee47..bd02f48 100644 --- a/payloads/external/tianocore/Makefile +++ b/payloads/external/tianocore/Makefile @@ -16,7 +16,8 @@ # force the shell to bash - the edksetup.sh script doesn't work with dash export SHELL := env bash -STABLE_COMMIT_ID=315d9d08fd77db1024ccc5307823da8aaed85e2f +# STABLE_COMMIT_ID represent official edk2 release, currently UDK2018 +STABLE_COMMIT_ID=3e72ffe8afdd03f1f89eba65c921cbdcb004cfee TAG-$(CONFIG_TIANOCORE_MASTER)=origin/master TAG-$(CONFIG_TIANOCORE_STABLE)=$(STABLE_COMMIT_ID) TAG-$(CONFIG_TIANOCORE_REVISION)=$(CONFIG_TIANOCORE_REVISION_ID) diff --git a/payloads/external/tianocore/patches/01_CorebootPayloadPkg_pcinoenum.patch b/payloads/external/tianocore/patches/01_CorebootPayloadPkg_pcinoenum.patch index 448da4a..7036f36 100644 --- a/payloads/external/tianocore/patches/01_CorebootPayloadPkg_pcinoenum.patch +++ b/payloads/external/tianocore/patches/01_CorebootPayloadPkg_pcinoenum.patch @@ -1,4 +1,4 @@ -From 4f9d41e69356ce7486b0c74a754ff494256723de Mon Sep 17 00:00:00 2001 +From c3da734cd08117ce2d5cd48367f5a94848aa9321 Mon Sep 17 00:00:00 2001 From: CoolStar <coolstarorganization(a)gmail.com> Date: Sun, 4 Dec 2016 11:23:38 -0800 Subject: [PATCH] PCI: use Duet's PciNoEnumeration @@ -10,7 +10,7 @@ 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/CorebootPayloadPkg/CorebootPayloadPkg.fdf b/CorebootPayloadPkg/CorebootPayloadPkg.fdf -index 303e626842..a39e3999ba 100644 +index 7994f0c94928..d71b3ec55690 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkg.fdf +++ b/CorebootPayloadPkg/CorebootPayloadPkg.fdf @@ -124,8 +124,8 @@ INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf @@ -25,7 +25,7 @@ # # ISA Support diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc -index cdfcb75b59..e838aca61d 100644 +index ace1bc0a3726..0f4e475187ee 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc @@ -450,11 +450,8 @@ @@ -43,7 +43,7 @@ # # SCSI/ATA/IDE/DISK Support diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc -index 6b16af63ba..c25d821fd4 100644 +index 2492142b972d..97bb0a8ae0a1 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc @@ -451,11 +451,8 @@ @@ -61,5 +61,5 @@ # # SCSI/ATA/IDE/DISK Support -- -2.13.2.725.g09c95d1e9-goog +2.17.0 diff --git a/payloads/external/tianocore/patches/02_CorebootPayloadPkg_bds.patch b/payloads/external/tianocore/patches/02_CorebootPayloadPkg_bds.patch index 8013ccd..9c61263 100644 --- a/payloads/external/tianocore/patches/02_CorebootPayloadPkg_bds.patch +++ b/payloads/external/tianocore/patches/02_CorebootPayloadPkg_bds.patch @@ -1,20 +1,20 @@ -From 5121087836c1ad2a08857d494c0d9ecb183f4f98 Mon Sep 17 00:00:00 2001 +From e72cac80c845429b042c7f9c36ede642cbe9e150 Mon Sep 17 00:00:00 2001 From: CoolStar <coolstarorganization(a)gmail.com> Date: Tue, 18 Jul 2017 15:50:38 -0600 Subject: [PATCH] Rebasing --- - CorebootModulePkg/CorebootModulePkg.dec | 8 + - .../Include/Guid/LdrMemoryDescriptor.h | 33 + - .../Include/Guid/PciExpressBaseAddress.h | 46 + - CorebootModulePkg/Include/Guid/PciOptionRomTable.h | 41 + - .../Library/CorebootBdsLib/BdsPlatform.c | 1731 ++++++++++++++++++++ - .../Library/CorebootBdsLib/BdsPlatform.h | 288 ++++ - .../Library/CorebootBdsLib/PlatformBds.inf | 65 + - .../Library/CorebootBdsLib/PlatformData.c | 161 ++ - CorebootPayloadPkg/CorebootPayloadPkg.fdf | 5 +- - CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 12 +- - CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 12 +- + CorebootModulePkg/CorebootModulePkg.dec | 8 + + .../Include/Guid/LdrMemoryDescriptor.h | 33 + + .../Include/Guid/PciExpressBaseAddress.h | 46 + + .../Include/Guid/PciOptionRomTable.h | 41 + + .../Library/CorebootBdsLib/BdsPlatform.c | 1731 +++++++++++++++++ + .../Library/CorebootBdsLib/BdsPlatform.h | 288 +++ + .../Library/CorebootBdsLib/PlatformBds.inf | 65 + + .../Library/CorebootBdsLib/PlatformData.c | 161 ++ + CorebootPayloadPkg/CorebootPayloadPkg.fdf | 5 +- + CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 12 +- + .../CorebootPayloadPkgIa32X64.dsc | 12 +- 11 files changed, 2388 insertions(+), 14 deletions(-) create mode 100644 CorebootModulePkg/Include/Guid/LdrMemoryDescriptor.h create mode 100644 CorebootModulePkg/Include/Guid/PciExpressBaseAddress.h @@ -25,7 +25,7 @@ create mode 100644 CorebootModulePkg/Library/CorebootBdsLib/PlatformData.c diff --git a/CorebootModulePkg/CorebootModulePkg.dec b/CorebootModulePkg/CorebootModulePkg.dec -index 7f1309bdae..20932a1d04 100644 +index 7f1309bdae61..20932a1d0467 100644 --- a/CorebootModulePkg/CorebootModulePkg.dec +++ b/CorebootModulePkg/CorebootModulePkg.dec @@ -33,8 +33,16 @@ @@ -47,7 +47,7 @@ diff --git a/CorebootModulePkg/Include/Guid/LdrMemoryDescriptor.h b/CorebootModulePkg/Include/Guid/LdrMemoryDescriptor.h new file mode 100644 -index 0000000000..38a997deea +index 000000000000..38a997deea0c --- /dev/null +++ b/CorebootModulePkg/Include/Guid/LdrMemoryDescriptor.h @@ -0,0 +1,33 @@ @@ -86,7 +86,7 @@ +#endif diff --git a/CorebootModulePkg/Include/Guid/PciExpressBaseAddress.h b/CorebootModulePkg/Include/Guid/PciExpressBaseAddress.h new file mode 100644 -index 0000000000..ff554383c1 +index 000000000000..ff554383c11b --- /dev/null +++ b/CorebootModulePkg/Include/Guid/PciExpressBaseAddress.h @@ -0,0 +1,46 @@ @@ -138,7 +138,7 @@ +#endif diff --git a/CorebootModulePkg/Include/Guid/PciOptionRomTable.h b/CorebootModulePkg/Include/Guid/PciOptionRomTable.h new file mode 100644 -index 0000000000..a2fb99710a +index 000000000000..a2fb99710a69 --- /dev/null +++ b/CorebootModulePkg/Include/Guid/PciOptionRomTable.h @@ -0,0 +1,41 @@ @@ -185,7 +185,7 @@ + diff --git a/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.c b/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.c new file mode 100644 -index 0000000000..b6253a17f8 +index 000000000000..b6253a17f8ea --- /dev/null +++ b/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.c @@ -0,0 +1,1731 @@ @@ -1922,7 +1922,7 @@ +} diff --git a/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.h b/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.h new file mode 100644 -index 0000000000..d447f77747 +index 000000000000..d447f77747e3 --- /dev/null +++ b/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.h @@ -0,0 +1,288 @@ @@ -2216,7 +2216,7 @@ +#endif // _PLATFORM_SPECIFIC_BDS_PLATFORM_H_ diff --git a/CorebootModulePkg/Library/CorebootBdsLib/PlatformBds.inf b/CorebootModulePkg/Library/CorebootBdsLib/PlatformBds.inf new file mode 100644 -index 0000000000..578c74afae +index 000000000000..578c74afae22 --- /dev/null +++ b/CorebootModulePkg/Library/CorebootBdsLib/PlatformBds.inf @@ -0,0 +1,65 @@ @@ -2287,7 +2287,7 @@ + diff --git a/CorebootModulePkg/Library/CorebootBdsLib/PlatformData.c b/CorebootModulePkg/Library/CorebootBdsLib/PlatformData.c new file mode 100644 -index 0000000000..fbdcc7de81 +index 000000000000..fbdcc7de8166 --- /dev/null +++ b/CorebootModulePkg/Library/CorebootBdsLib/PlatformData.c @@ -0,0 +1,161 @@ @@ -2453,7 +2453,7 @@ +EFI_DEVICE_PATH_PROTOCOL *gPlatformConnectSequence[] = { NULL }; + diff --git a/CorebootPayloadPkg/CorebootPayloadPkg.fdf b/CorebootPayloadPkg/CorebootPayloadPkg.fdf -index a39e3999ba..623ff9c344 100644 +index d71b3ec55690..22987093da58 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkg.fdf +++ b/CorebootPayloadPkg/CorebootPayloadPkg.fdf @@ -95,8 +95,9 @@ INF MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntime @@ -2469,7 +2469,7 @@ INF PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf !else diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc -index e838aca61d..a329b78f08 100644 +index 0f4e475187ee..053f380a8608 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc @@ -165,6 +165,7 @@ @@ -2508,7 +2508,7 @@ PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf !else diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc -index c25d821fd4..790efd7810 100644 +index 97bb0a8ae0a1..bb328349b44a 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc @@ -165,6 +165,7 @@ @@ -2547,5 +2547,5 @@ PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf !else -- -2.13.2.932.g7449e964c-goog +2.17.0 diff --git a/payloads/external/tianocore/patches/03_Library_EndofDXE.patch b/payloads/external/tianocore/patches/03_Library_EndofDXE.patch index 02ba42b..cca3eea 100644 --- a/payloads/external/tianocore/patches/03_Library_EndofDXE.patch +++ b/payloads/external/tianocore/patches/03_Library_EndofDXE.patch @@ -1,16 +1,16 @@ -From 760f1cafdd689beedc8418ab89e856b54296389c Mon Sep 17 00:00:00 2001 +From 1e9c5c97a55f3ad3c0d6d5dde380b4d73bd15860 Mon Sep 17 00:00:00 2001 From: CoolStar <coolstarorganization(a)gmail.com> Date: Sun, 4 Dec 2016 12:07:30 -0800 Subject: [PATCH] CorebootBdsLib: Call End of DXE event to allow booting 3rd party efi binaries. --- - .../Library/CorebootBdsLib/BdsPlatform.c | 42 ++++++++++++++++++++++ - .../Library/CorebootBdsLib/PlatformBds.inf | 1 + + .../Library/CorebootBdsLib/BdsPlatform.c | 42 +++++++++++++++++++ + .../Library/CorebootBdsLib/PlatformBds.inf | 1 + 2 files changed, 43 insertions(+) diff --git a/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.c b/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.c -index b6253a17f8..cf3e5320cb 100644 +index b6253a17f8ea..cf3e5320cbe8 100644 --- a/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.c +++ b/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.c @@ -1129,6 +1129,46 @@ Returns: @@ -70,7 +70,7 @@ // Init the time out value // diff --git a/CorebootModulePkg/Library/CorebootBdsLib/PlatformBds.inf b/CorebootModulePkg/Library/CorebootBdsLib/PlatformBds.inf -index 578c74afae..992bd846bd 100644 +index 578c74afae22..992bd846bdc4 100644 --- a/CorebootModulePkg/Library/CorebootBdsLib/PlatformBds.inf +++ b/CorebootModulePkg/Library/CorebootBdsLib/PlatformBds.inf @@ -58,6 +58,7 @@ @@ -82,5 +82,5 @@ [Pcd] gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut -- -2.13.2.725.g09c95d1e9-goog +2.17.0 diff --git a/payloads/external/tianocore/patches/04_CorebootPayloadPkg_addps2.patch b/payloads/external/tianocore/patches/04_CorebootPayloadPkg_addps2.patch index e90b70e..2b7da9d 100644 --- a/payloads/external/tianocore/patches/04_CorebootPayloadPkg_addps2.patch +++ b/payloads/external/tianocore/patches/04_CorebootPayloadPkg_addps2.patch @@ -1,4 +1,4 @@ -From 77c5dfcce842819215490fe63c481860fa7d752d Mon Sep 17 00:00:00 2001 +From e8d6ed35c15b92497cd3ede6cd35523b0e7366ac Mon Sep 17 00:00:00 2001 From: CoolStar <coolstarorganization(a)gmail.com> Date: Sun, 4 Dec 2016 11:50:00 -0800 Subject: [PATCH] CorebootPayloadPkg: Add PS/2 keyboard drivers. @@ -10,7 +10,7 @@ 3 files changed, 9 insertions(+) diff --git a/CorebootPayloadPkg/CorebootPayloadPkg.fdf b/CorebootPayloadPkg/CorebootPayloadPkg.fdf -index 347e9c75ce..a347af0c9a 100644 +index 22987093da58..0961e96c250d 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkg.fdf +++ b/CorebootPayloadPkg/CorebootPayloadPkg.fdf @@ -132,6 +132,9 @@ INF DuetPkg/PciBusNoEnumerationDxe/PciBusNoEnumeration.inf @@ -24,7 +24,7 @@ # # Console Support diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc -index 5ce823bb95..60ee064c59 100644 +index 053f380a8608..6ddd64faf7a5 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc @@ -492,6 +492,9 @@ @@ -38,7 +38,7 @@ # # Console Support diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc -index fea297a77a..167329c897 100644 +index bb328349b44a..19c203e6cbb6 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc @@ -493,6 +493,9 @@ @@ -52,5 +52,5 @@ # # Console Support -- -2.13.2.725.g09c95d1e9-goog +2.17.0 diff --git a/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch b/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch index da8fc7f..10024d8 100644 --- a/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch +++ b/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch @@ -1,4 +1,4 @@ -From 336ce69129206ea6cb5bea2a99c5f00e77850518 Mon Sep 17 00:00:00 2001 +From 9c28ac87eb2df7319d4f5a48124c837b8bf123b3 Mon Sep 17 00:00:00 2001 From: ReddestDream <reddestdream(a)gmail.com> Date: Wed, 3 May 2017 00:13:28 -0400 Subject: [PATCH] CbSupportPei: prevent lower coreboot table from being diff --git a/payloads/external/tianocore/patches/07_CorebootPayloadPkg-Use-correct-BytesPerScanLine.patch b/payloads/external/tianocore/patches/07_CorebootPayloadPkg-Use-correct-BytesPerScanLine.patch index 6370efc..9b2569a 100644 --- a/payloads/external/tianocore/patches/07_CorebootPayloadPkg-Use-correct-BytesPerScanLine.patch +++ b/payloads/external/tianocore/patches/07_CorebootPayloadPkg-Use-correct-BytesPerScanLine.patch @@ -1,4 +1,4 @@ -From 07dec11fe965e73cfef7df38af70c945b6ff21a2 Mon Sep 17 00:00:00 2001 +From 2e75f9ad6ef625575185dfc262c6803a89850dd5 Mon Sep 17 00:00:00 2001 From: Arthur Heymans <arthur(a)aheymans.xyz> Date: Wed, 24 Jan 2018 10:07:08 +0100 Subject: [PATCH] CorebootPayloadPkg: Use correct BytesPerScanLine @@ -12,9 +12,12 @@ Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> +--- + CorebootPayloadPkg/FbGop/FbGop.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CorebootPayloadPkg/FbGop/FbGop.c b/CorebootPayloadPkg/FbGop/FbGop.c -index 37d6def7f7..6790617033 100644 +index 37d6def7f780..679061703358 100644 --- a/CorebootPayloadPkg/FbGop/FbGop.c +++ b/CorebootPayloadPkg/FbGop/FbGop.c @@ -822,7 +822,7 @@ FbGopCheckForVbe ( @@ -27,5 +30,5 @@ ModeBuffer = (FB_VIDEO_MODE_DATA *) AllocatePool ( ModeNumber * sizeof (FB_VIDEO_MODE_DATA) -- -2.16.1 +2.17.0 diff --git a/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch b/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch index 06ddd56..4881fff 100644 --- a/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch +++ b/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch @@ -1,4 +1,4 @@ -From b652262ed0dd554c44e7b1bf7134d3458f5edef1 Mon Sep 17 00:00:00 2001 +From 8cb365e9ec90420e3d04b77f6e7999a65d5983a6 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph <siro(a)das-labor.org> Date: Sun, 17 Jun 2018 08:44:51 +0200 Subject: [PATCH] BaseTools: Fix building with -Werror=stringop-truncation @@ -9,7 +9,7 @@ 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/C/GenVtf/GenVtf.c b/BaseTools/Source/C/GenVtf/GenVtf.c -index acc142a6d1..5d77016eba 100644 +index 65ae08eeceb8..d4200621457c 100644 --- a/BaseTools/Source/C/GenVtf/GenVtf.c +++ b/BaseTools/Source/C/GenVtf/GenVtf.c @@ -129,9 +129,9 @@ Returns: @@ -24,7 +24,7 @@ } sscanf ( -@@ -1529,7 +1529,7 @@ Returns: +@@ -1521,7 +1521,7 @@ Returns: // FitStartPtr = (FIT_TABLE *) RelativeAddress; diff --git a/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch b/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch deleted file mode 100644 index 7016759..0000000 --- a/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch +++ /dev/null @@ -1,40 +0,0 @@ -From 5546ab29b2c0c2fc3a963bc71221918dc77b6152 Mon Sep 17 00:00:00 2001 -From: Patrick Rudolph <siro(a)das-labor.org> -Date: Sun, 17 Jun 2018 08:53:25 +0200 -Subject: [PATCH] gcc7: Fix building with -fpermissive - -Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> ---- - BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp | 2 +- - MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 2 +- - 2 files changed, 2 insertions(+), 2 deletions(-) - -diff --git a/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp b/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp -index 3ca57ed741..4fa066dd9f 100644 ---- a/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp -+++ b/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp -@@ -3372,7 +3372,7 @@ CVfrStringDB::GetVarStoreNameFormStringId ( - UINT8 BlockType; - EFI_HII_STRING_PACKAGE_HDR *PkgHeader; - -- if (mStringFileName == '\0' ) { -+ if (mStringFileName == NULL ) { - return NULL; - } - -diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c -index 857950118f..de0aa5f7bc 100644 ---- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c -+++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c -@@ -2181,7 +2181,7 @@ InternalHiiIfrValueAction ( - - StringPtr = ConfigAltResp; - -- while (StringPtr != L'\0') { -+ while (StringPtr != NULL) { - // - // 1. Find <ConfigHdr> GUID=...&NAME=...&PATH=... - // --- -2.17.0 - -- To view, visit https://review.coreboot.org/c/coreboot/+/27615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib409f6f93eb64d7a9a2f09a75f8e637ab8689410 Gerrit-Change-Number: 27615 Gerrit-PatchSet: 3 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...coreboot[master]: payloads/tianocore: rebase patches to UDK2018 release
by Philipp Deppenwiese (Code Review) 21 Nov '18

21 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27615 ) Change subject: payloads/tianocore: rebase patches to UDK2018 release ...................................................................... Patch Set 2: Tested on Google Chromebook Reef -- To view, visit https://review.coreboot.org/c/coreboot/+/27615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib409f6f93eb64d7a9a2f09a75f8e637ab8689410 Gerrit-Change-Number: 27615 Gerrit-PatchSet: 2 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Nov 2018 15:51:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: payloads/tianocore: rebase patches to UDK2018 release
by Philipp Deppenwiese (Code Review) 21 Nov '18

21 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27615 ) Change subject: payloads/tianocore: rebase patches to UDK2018 release ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/27615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib409f6f93eb64d7a9a2f09a75f8e637ab8689410 Gerrit-Change-Number: 27615 Gerrit-PatchSet: 2 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Nov 2018 15:50:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/dragonegg: Add initial mainboard code support
by Subrata Banik (Code Review) 21 Nov '18

21 Nov '18

Subrata Banik has uploaded a new patch set (#9) to the change originally created by Shelley Chen. ( https://review.coreboot.org/c/coreboot/+/29749 ) Change subject: mb/google/dragonegg: Add initial mainboard code support ...................................................................... mb/google/dragonegg: Add initial mainboard code support This patch includes support for both ICL ES0 and ES1 samples. Change-Id: I2cc269cb0050bf5b031f48cfe114485c55ab8fa9 Signed-off-by: Aamir Bohra <aamir.bohra(a)intel.com> --- A src/mainboard/google/dragonegg/Kconfig A src/mainboard/google/dragonegg/Kconfig.name A src/mainboard/google/dragonegg/Makefile.inc A src/mainboard/google/dragonegg/acpi_tables.c A src/mainboard/google/dragonegg/board_info.txt A src/mainboard/google/dragonegg/bootblock.c A src/mainboard/google/dragonegg/chromeos.c A src/mainboard/google/dragonegg/chromeos.fmd A src/mainboard/google/dragonegg/dsdt.asl A src/mainboard/google/dragonegg/ec.c A src/mainboard/google/dragonegg/mainboard.c A src/mainboard/google/dragonegg/ramstage.c A src/mainboard/google/dragonegg/romstage_fsp_params.c A src/mainboard/google/dragonegg/smihandler.c A src/mainboard/google/dragonegg/spd/Hynix_H9HCNNN8KUMLHR_2GB.spd.hex A src/mainboard/google/dragonegg/spd/Hynix_H9HCNNNCPMMLHR_4GB.spd.hex A src/mainboard/google/dragonegg/spd/Makefile.inc A src/mainboard/google/dragonegg/spd/Micron_MT53E2G32D8QD_8GB.spd.hex A src/mainboard/google/dragonegg/spd/Micron_MT53E512M32D2NP_2GB.spd.hex A src/mainboard/google/dragonegg/spd/empty.spd.hex A src/mainboard/google/dragonegg/variants/baseboard/Makefile.inc A src/mainboard/google/dragonegg/variants/baseboard/devicetree.cb A src/mainboard/google/dragonegg/variants/baseboard/gpio.c A src/mainboard/google/dragonegg/variants/baseboard/include/baseboard/ec.h A src/mainboard/google/dragonegg/variants/baseboard/include/baseboard/gpio.h A src/mainboard/google/dragonegg/variants/baseboard/include/baseboard/variants.h A src/mainboard/google/dragonegg/variants/baseboard/memory.c A src/mainboard/google/dragonegg/variants/dragonegg/include/variant/ec.h A src/mainboard/google/dragonegg/variants/dragonegg/include/variant/gpio.h 29 files changed, 1,356 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/29749/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/29749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cc269cb0050bf5b031f48cfe114485c55ab8fa9 Gerrit-Change-Number: 29749 Gerrit-PatchSet: 9 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: payloads/tianocore: rebase patches to UDK2018 release
by Philipp Deppenwiese (Code Review) 21 Nov '18

21 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27615 ) Change subject: payloads/tianocore: rebase patches to UDK2018 release ...................................................................... Patch Set 1: Code-Review+2 As you told me everything works out-of-the-box. I don't like patches where it can be integrated in upstream open source projects -- To view, visit https://review.coreboot.org/c/coreboot/+/27615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib409f6f93eb64d7a9a2f09a75f8e637ab8689410 Gerrit-Change-Number: 27615 Gerrit-PatchSet: 1 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Nov 2018 15:05:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Kconfig: Unify power-after-failure options
by Subrata Banik (Code Review) 21 Nov '18

21 Nov '18

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29680 ) Change subject: Kconfig: Unify power-after-failure options ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/29680/3/src/soc/intel/common/block/pmc/pmcl… File src/soc/intel/common/block/pmc/pmclib.c: https://review.coreboot.org/#/c/29680/3/src/soc/intel/common/block/pmc/pmcl… PS3, Line 590: return CONFIG_MAINBOARD_POWER_FAILURE_STATE; > `config MAINBOARD_POWER_FAILURE_STATE` is an `int` taking either 0, 1 or 2. […] got it -- To view, visit https://review.coreboot.org/c/coreboot/+/29680 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61259f864c8a8cfc7099cc2699059f972fa056c0 Gerrit-Change-Number: 29680 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 21 Nov 2018 15:04:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018