coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: northbridge/intel/fsp_*: Remove legacy SoCs
by Philipp Deppenwiese (Code Review) 06 Nov '18

06 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29402 ) Change subject: northbridge/intel/fsp_*: Remove legacy SoCs ...................................................................... Patch Set 3: Thanks Nico missed the sb stuff. Should be added now. -- To view, visit https://review.coreboot.org/29402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b6bc4bfdd0481c8fe5b2b3d8f8b2eb9aa3c3b9e Gerrit-Change-Number: 29402 Gerrit-PatchSet: 3 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 06 Nov 2018 13:48:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/{lenovo/x201, packardbell/ms2290}/romstage: Fix comments
by Angel Pons (Code Review) 06 Nov '18

06 Nov '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/29511 ) Change subject: mb/{lenovo/x201,packardbell/ms2290}/romstage: Fix comments ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/29511/1/src/mainboard/lenovo/x201/romstage.c File src/mainboard/lenovo/x201/romstage.c: https://review.coreboot.org/#/c/29511/1/src/mainboard/lenovo/x201/romstage.… PS1, Line 123: : : These are not comments, or did I forget how to C? -- To view, visit https://review.coreboot.org/29511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e521acdac17959586bc0af7d8a2f7182f1e6721 Gerrit-Change-Number: 29511 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 06 Nov 2018 13:24:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: payload/external/Linux: capitalize directory
by Marcello Sylvester Bauer (Code Review) 06 Nov '18

06 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29512 to look at the new patch set (#2). Change subject: payload/external/Linux: capitalize directory ...................................................................... payload/external/Linux: capitalize directory Capitalize the Linux payload directory referring to the “Linux®” Trademark. All Linux based payload will be merged here, due to their similarity. Change-Id: Iaae8dbde30028355c2f0194cf309abb565c4be54 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- R payloads/external/Linux/Kconfig R payloads/external/Linux/Kconfig.name 2 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/29512/2 -- To view, visit https://review.coreboot.org/29512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iaae8dbde30028355c2f0194cf309abb565c4be54 Gerrit-Change-Number: 29512 Gerrit-PatchSet: 2 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: security/vboot: Add selection for firmware slots used by VBOOT
by Philipp Deppenwiese (Code Review) 06 Nov '18

06 Nov '18

1 0

Change in coreboot[master]: payload/external/Linux: capitalize directory
by Marcello Sylvester Bauer (Code Review) 06 Nov '18

06 Nov '18

Marcello Sylvester Bauer has uploaded this change for review. ( https://review.coreboot.org/29512 Change subject: payload/external/Linux: capitalize directory ...................................................................... payload/external/Linux: capitalize directory Capitalize the Linux payload directory referring to the “Linux®” Trademark. Change-Id: Iaae8dbde30028355c2f0194cf309abb565c4be54 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- R payloads/external/Linux/Kconfig R payloads/external/Linux/Kconfig.name 2 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/29512/1 diff --git a/payloads/external/linux/Kconfig b/payloads/external/Linux/Kconfig similarity index 100% rename from payloads/external/linux/Kconfig rename to payloads/external/Linux/Kconfig diff --git a/payloads/external/linux/Kconfig.name b/payloads/external/Linux/Kconfig.name similarity index 100% rename from payloads/external/linux/Kconfig.name rename to payloads/external/Linux/Kconfig.name -- To view, visit https://review.coreboot.org/29512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iaae8dbde30028355c2f0194cf309abb565c4be54 Gerrit-Change-Number: 29512 Gerrit-PatchSet: 1 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com>

1 0

Change in coreboot[master]: mb/intel/icelake_rvp: Move CNVi ASL entry from static DSDT to dynamic...
by Subrata Banik (Code Review) 06 Nov '18

06 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29507 to look at the new patch set (#3). Change subject: mb/intel/icelake_rvp: Move CNVi ASL entry from static DSDT to dynamic SSDT generation ...................................................................... mb/intel/icelake_rvp: Move CNVi ASL entry from static DSDT to dynamic SSDT generation This changes uses drivers/intel/wifi chip for CNVi device to ensure that: 1. Correct device name shows in ACPI name space 2. Correct wake up shows in cat /proc/acpi/wakeup Change-Id: I21d3818ac9e384b0dbaa330d231022bdb8b8a547 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb M src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb D src/soc/intel/icelake/acpi/cnvi.asl M src/soc/intel/icelake/acpi/southbridge.asl M src/soc/intel/icelake/chip.h 5 files changed, 9 insertions(+), 37 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/29507/3 -- To view, visit https://review.coreboot.org/29507 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I21d3818ac9e384b0dbaa330d231022bdb8b8a547 Gerrit-Change-Number: 29507 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: security/vboot: Add selection for firmware slots used by VBOOT
by Philipp Deppenwiese (Code Review) 06 Nov '18

06 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27714 ) Change subject: security/vboot: Add selection for firmware slots used by VBOOT ...................................................................... Patch Set 5: (2 comments) https://review.coreboot.org/#/c/27714/5/src/security/vboot/Kconfig File src/security/vboot/Kconfig: https://review.coreboot.org/#/c/27714/5/src/security/vboot/Kconfig@31 PS5, Line 31: default y if MAINBOARD_HAS_VBOOT_SLOTS_A || USER_VBOOT_SLOTS_AB|| USER_VBOOT_SLOTS_A space https://review.coreboot.org/#/c/27714/5/src/security/vboot/Makefile.inc File src/security/vboot/Makefile.inc: https://review.coreboot.org/#/c/27714/5/src/security/vboot/Makefile.inc@251 PS5, Line 251: ifeq ($(CONFIG_VBOOT_SLOTS_RW_A)$(CONFIG_VBOOT_SLOTS_RO_RW_A),y) remove CONFIG_VBOOT_SLOTS_RO_RW_A -- To view, visit https://review.coreboot.org/27714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I278fc060522b13048b00090b8e5261c14496f56e Gerrit-Change-Number: 27714 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Tue, 06 Nov 2018 12:23:17 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/lenovo/*/*: Fix non-local header treated as local
by Elyes HAOUAS (Code Review) 06 Nov '18

06 Nov '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/29501 ) Change subject: mb/lenovo/*/*: Fix non-local header treated as local ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/29501 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idea19b52198e6f46b0da6022558a46246a52f2e7 Gerrit-Change-Number: 29501 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Nov 2018 12:19:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/lenovo/x201: Remove unnecessary include - delay.h
by Elyes HAOUAS (Code Review) 06 Nov '18

06 Nov '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/29499 ) Change subject: mb/lenovo/x201: Remove unnecessary include - delay.h ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/29499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia997c5188aef0c18d871658209c2d5f718ee2a19 Gerrit-Change-Number: 29499 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Nov 2018 12:17:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Linuxboot: add current kernel releases
by Marcello Sylvester Bauer (Code Review) 06 Nov '18

06 Nov '18

Hello Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29443 to look at the new patch set (#9). Change subject: Linuxboot: add current kernel releases ...................................................................... Linuxboot: add current kernel releases Add current kernel releases instead of hardcode the version number. Also add the option to select a custom version of the kernel. Change-Id: Ieb071696cfbb466521faaef045fc488a06f6db0c Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/Makefile M payloads/external/Makefile.inc 3 files changed, 48 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/29443/9 -- To view, visit https://review.coreboot.org/29443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieb071696cfbb466521faaef045fc488a06f6db0c Gerrit-Change-Number: 29443 Gerrit-PatchSet: 9 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018