coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: mb/lenovo/x201/romstage: Remove duplicated lines
by Peter Lemenkov (Code Review) 06 Nov '18

06 Nov '18

Peter Lemenkov has abandoned this change. ( https://review.coreboot.org/29500 ) Change subject: mb/lenovo/x201/romstage: Remove duplicated lines ...................................................................... Abandoned See https://review.coreboot.org/#/c/coreboot/+/29511/ -- To view, visit https://review.coreboot.org/29500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ib30940e671be8c13a28128bd1e7e6d690283c8cb Gerrit-Change-Number: 29500 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/lenovo/x201/romstage: Remove duplicated lines
by Peter Lemenkov (Code Review) 06 Nov '18

06 Nov '18

Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/29500 ) Change subject: mb/lenovo/x201/romstage: Remove duplicated lines ...................................................................... Patch Set 1: > This simply makes all the other comments wrong... Agree. I've fixed RCBA addresses in comments instead. See #29511. -- To view, visit https://review.coreboot.org/29500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib30940e671be8c13a28128bd1e7e6d690283c8cb Gerrit-Change-Number: 29500 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Nov 2018 11:53:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/{lenovo/x201, packardbell/ms2290}/romstage: Fix comments
by Peter Lemenkov (Code Review) 06 Nov '18

06 Nov '18

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/29511 Change subject: mb/{lenovo/x201,packardbell/ms2290}/romstage: Fix comments ...................................................................... mb/{lenovo/x201,packardbell/ms2290}/romstage: Fix comments RCBA address numbers in comments looks wrong and confusing. Let's fix them. This is a cosmetic change since no actual data is added or removed. Change-Id: I0e521acdac17959586bc0af7d8a2f7182f1e6721 Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com> --- M src/mainboard/lenovo/x201/romstage.c M src/mainboard/packardbell/ms2290/romstage.c 2 files changed, 14 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/29511/1 diff --git a/src/mainboard/lenovo/x201/romstage.c b/src/mainboard/lenovo/x201/romstage.c index cfa11b4..5e9937f 100644 --- a/src/mainboard/lenovo/x201/romstage.c +++ b/src/mainboard/lenovo/x201/romstage.c @@ -121,8 +121,6 @@ /* 35f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3600 */ 0x0a001f00, 0x00000000, 0x00000000, 0x00000001, /* 3610 */ 0x00010000, 0x00000000, 0x00000000, 0x00000000, - /* 3600 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3610 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3620 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3630 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3640 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, @@ -132,12 +130,14 @@ /* 3680 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3690 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 36a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36b0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000, - /* 36c0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000, - /* 36d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 36b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 36c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 36d0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000, + /* 36e0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000, /* 36f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3710 */ 0x00000000, 0x4e564d49, 0x00000000, 0x00000000, + /* 3700 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 3710 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 3720 */ 0x00000000, 0x4e564d49, 0x00000000, 0x00000000, }; unsigned i; for (i = 0; i < sizeof(rcba_dump3) / 4; i++) { diff --git a/src/mainboard/packardbell/ms2290/romstage.c b/src/mainboard/packardbell/ms2290/romstage.c index 56f11a1..ae48b90 100644 --- a/src/mainboard/packardbell/ms2290/romstage.c +++ b/src/mainboard/packardbell/ms2290/romstage.c @@ -116,8 +116,6 @@ /* 35f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3600 */ 0x0a001f00, 0x00000000, 0x00000000, 0x00000001, /* 3610 */ 0x00010000, 0x00000000, 0x00000000, 0x00000000, - /* 3600 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3610 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3620 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3630 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3640 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, @@ -127,12 +125,14 @@ /* 3680 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3690 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 36a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36b0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000, - /* 36c0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000, - /* 36d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 36b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 36c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 36d0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000, + /* 36e0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000, /* 36f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3710 */ 0x00000000, 0x4e564d49, 0x00000000, 0x00000000, + /* 3700 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 3710 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 3720 */ 0x00000000, 0x4e564d49, 0x00000000, 0x00000000, }; unsigned i; -- To view, visit https://review.coreboot.org/29511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0e521acdac17959586bc0af7d8a2f7182f1e6721 Gerrit-Change-Number: 29511 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com>

1 0

Change in coreboot[master]: siemens/mc_apl3: Disable I2C7 over devicetree
by Werner Zeh (Code Review) 06 Nov '18

06 Nov '18

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/29506 ) Change subject: siemens/mc_apl3: Disable I2C7 over devicetree ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29506 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9877d40b06f4a849163a873fd308ff03995fcdc Gerrit-Change-Number: 29506 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Nov 2018 11:47:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: siemens/mc_apl3: Enable all PCIe root ports
by Werner Zeh (Code Review) 06 Nov '18

06 Nov '18

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/29505 ) Change subject: siemens/mc_apl3: Enable all PCIe root ports ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62c7ba5048b4c2288bb502a78b9621edda333f2a Gerrit-Change-Number: 29505 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Nov 2018 11:47:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Linuxboot: add current kernel releases
by Marcello Sylvester Bauer (Code Review) 06 Nov '18

06 Nov '18

Marcello Sylvester Bauer has removed a vote on this change. Change subject: Linuxboot: add current kernel releases ...................................................................... Removed Code-Review-1 by Marcello Sylvester Bauer <info(a)marcellobauer.com> -- To view, visit https://review.coreboot.org/29443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ieb071696cfbb466521faaef045fc488a06f6db0c Gerrit-Change-Number: 29443 Gerrit-PatchSet: 8 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: siemens/mc_apl3: Remove reduced clock rate for I2C0
by Werner Zeh (Code Review) 06 Nov '18

06 Nov '18

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/29504 ) Change subject: siemens/mc_apl3: Remove reduced clock rate for I2C0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9ad4d9026267d2079e95245994d84c163b28dbb Gerrit-Change-Number: 29504 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Nov 2018 11:44:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: siemens/mc_apl3: Disable CLKREQ of PCIe root ports
by Werner Zeh (Code Review) 06 Nov '18

06 Nov '18

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/29502 ) Change subject: siemens/mc_apl3: Disable CLKREQ of PCIe root ports ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29502 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59c1132c6d273ccefeb1be6243577e1ae5064ef4 Gerrit-Change-Number: 29502 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Nov 2018 11:43:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Linux/Linuxboot: share cmdline and initrd parser
by Marcello Sylvester Bauer (Code Review) 06 Nov '18

06 Nov '18

Marcello Sylvester Bauer has uploaded this change for review. ( https://review.coreboot.org/29510 Change subject: Linux/Linuxboot: share cmdline and initrd parser ...................................................................... Linux/Linuxboot: share cmdline and initrd parser Merge the command-line and initramfs parser from 'a linux paylod' and 'LinuxBoot'. GOAL: merge 'a Linux payload' and 'LinuxBoot' Change-Id: I2d2aef5d07453b98e115af6ee06318c690def785 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/Makefile M payloads/external/Makefile.inc 3 files changed, 8 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/29510/1 diff --git a/payloads/external/LinuxBoot/Kconfig b/payloads/external/LinuxBoot/Kconfig index 4225330..fe85206 100644 --- a/payloads/external/LinuxBoot/Kconfig +++ b/payloads/external/LinuxBoot/Kconfig @@ -98,7 +98,7 @@ Add your own kernel configuration file. Otherwise a default minimal defconfig is used. -config LINUXBOOT_KERNEL_COMMANDLINE +config LINUX_COMMAND_LINE string "Kernel command-line" default "" help @@ -153,7 +153,7 @@ Path to directory containing root structure for embedding into the initramfs. -config PAYLOAD_USERSPACE +config LINUX_INITRD string default "payloads/external/LinuxBoot/linuxboot/initramfs.cpio.xz" diff --git a/payloads/external/LinuxBoot/Makefile b/payloads/external/LinuxBoot/Makefile index 3ea7658..4f6e98a 100644 --- a/payloads/external/LinuxBoot/Makefile +++ b/payloads/external/LinuxBoot/Makefile @@ -91,20 +91,20 @@ $(project_dir)/vmlinux.bin.lzma: $(project_dir)/vmlinux.bin xz -c -k -f --format=lzma --lzma1=dict=1MiB,lc=3,lp=0,pb=3 $< > $@ -$(project_dir)/kernel-image: $(project_dir)/vmlinux.bin.lzma $(project_dir)/../arm64/kernel_fdt_lzma.its $(project_dir)/target.dtb $(PWD)/$(CONFIG_PAYLOAD_USERSPACE) +$(project_dir)/kernel-image: $(project_dir)/vmlinux.bin.lzma $(project_dir)/../arm64/kernel_fdt_lzma.its $(project_dir)/target.dtb $(PWD)/$(CONFIG_LINUX_INITRD) cp $(project_dir)/../arm64/kernel_fdt_lzma.its $(project_dir) mkimage -f $(project_dir)/kernel_fdt_lzma.its $@ endif ifeq ($(CONFIG_LINUXBOOT_UROOT),y) -$(PWD)/$(CONFIG_PAYLOAD_USERSPACE): +$(PWD)/$(CONFIG_LINUX_INITRD): $(MAKE) -f targets/u-root.mk else -$(PWD)/$(CONFIG_PAYLOAD_USERSPACE): +$(PWD)/$(CONFIG_LINUX_INITRD): echo "Building without u-root support" endif -linuxboot: $(project_dir)/kernel-image $(PWD)/$(CONFIG_PAYLOAD_USERSPACE) +linuxboot: $(project_dir)/kernel-image $(PWD)/$(CONFIG_LINUX_INITRD) clean: if [ -d "$(kernel_dir)" ]; then rm -rf $(kernel_dir); fi diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index cb806b7..706f4f2 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -32,18 +32,7 @@ #TODO: Figure out version endif -ifeq ($(CONFIG_PAYLOAD_LINUXBOOT),y) - ifeq ($(CONFIG_ARCH_X86),y) - ifneq ($(strip $(call strip_quotes,$(CONFIG_LINUXBOOT_KERNEL_COMMANDLINE))),) - ADDITIONAL_PAYLOAD_CONFIG+=-C $(CONFIG_LINUXBOOT_KERNEL_COMMANDLINE) - endif - ifneq ($(strip $(call strip_quotes,$(CONFIG_PAYLOAD_USERSPACE))),) - ADDITIONAL_PAYLOAD_CONFIG+=-I $(strip $(call strip_quotes,$(CONFIG_PAYLOAD_USERSPACE))) - endif - endif -endif - -ifeq ($(CONFIG_PAYLOAD_LINUX),y) +ifeq ($(CONFIG_PAYLOAD_LINUX)$(CONFIG_PAYLOAD_LINUXBOOT),y) ifneq ($(strip $(call strip_quotes,$(CONFIG_LINUX_COMMAND_LINE))),) ADDITIONAL_PAYLOAD_CONFIG+=-C $(CONFIG_LINUX_COMMAND_LINE) endif @@ -271,14 +260,13 @@ CONFIG_LINUXBOOT_KERNEL_CUSTOM=$(CONFIG_LINUXBOOT_KERNEL_CUSTOM) \ CONFIG_LINUXBOOT_KERNEL_CUSTOM_VERSION=$(CONFIG_LINUXBOOT_KERNEL_CUSTOM_VERSION) \ CONFIG_LINUXBOOT_KERNEL_CONFIGFILE=$(CONFIG_LINUXBOOT_KERNEL_CONFIGFILE) \ - CONFIG_LINUXBOOT_KERNEL_COMMANDLINE=$(CONFIG_LINUXBOOT_KERNEL_COMMANDLINE) \ CONFIG_LINUXBOOT_UROOT_VERSION=$(CONFIG_LINUXBOOT_UROOT_VERSION) \ CONFIG_LINUXBOOT_UROOT_COMMANDS=$(CONFIG_LINUXBOOT_UROOT_COMMANDS) \ CONFIG_LINUXBOOT_ARCH=$(CONFIG_LINUXBOOT_ARCH) \ CONFIG_LINUXBOOT_UROOT=$(CONFIG_LINUXBOOT_UROOT) \ CONFIG_LINUXBOOT_UROOT_FILES=$(CONFIG_LINUXBOOT_UROOT_FILES) \ CONFIG_LINUXBOOT_DTB_FILE=$(CONFIG_LINUXBOOT_DTB_FILE) \ - CONFIG_PAYLOAD_USERSPACE=$(CONFIG_PAYLOAD_USERSPACE) + CONFIG_LINUX_INITRD=$(CONFIG_LINUX_INITRD) payloads/external/LinuxBoot/linuxboot/kernel-image: linuxboot -- To view, visit https://review.coreboot.org/29510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2d2aef5d07453b98e115af6ee06318c690def785 Gerrit-Change-Number: 29510 Gerrit-PatchSet: 1 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com>

1 0

Change in coreboot[master]: Linuxboot: add current kernel releases
by Marcello Sylvester Bauer (Code Review) 06 Nov '18

06 Nov '18

Hello Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29443 to look at the new patch set (#8). Change subject: Linuxboot: add current kernel releases ...................................................................... Linuxboot: add current kernel releases Add current kernel releases instead of hardcode the version number. Also add the option to select a custom version of the kernel. Change-Id: Ieb071696cfbb466521faaef045fc488a06f6db0c Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/Makefile M payloads/external/Makefile.inc 3 files changed, 46 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/29443/8 -- To view, visit https://review.coreboot.org/29443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieb071696cfbb466521faaef045fc488a06f6db0c Gerrit-Change-Number: 29443 Gerrit-PatchSet: 8 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018