coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: payloads/external/Linuxboot/targets: use go get to install u-root
by Jens Drenhaus (Code Review) 06 Nov '18

06 Nov '18

Jens Drenhaus has uploaded this change for review. ( https://review.coreboot.org/29515 Change subject: payloads/external/Linuxboot/targets: use go get to install u-root ...................................................................... payloads/external/Linuxboot/targets: use go get to install u-root make sure, there is proper go tree set up in inside the linuxboot build directory. Then use go get to to download u-root from github. It also builds the code and installs u-root into the bin directory of the lokal go tree. Change-Id: I72866944165823300566e2e9bdaba59599a88178 Signed-off-by: Jens Drenhaus <jens.drenhaus(a)9elements.com> --- M payloads/external/LinuxBoot/targets/u-root.mk 1 file changed, 12 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/29515/1 diff --git a/payloads/external/LinuxBoot/targets/u-root.mk b/payloads/external/LinuxBoot/targets/u-root.mk index d4a0837..75499d7 100644 --- a/payloads/external/LinuxBoot/targets/u-root.mk +++ b/payloads/external/LinuxBoot/targets/u-root.mk @@ -12,7 +12,7 @@ ## GNU General Public License for more details. ## -uroot_git_repo=https://github.com/u-root/u-root.git +uroot_git_repo=github.com/u-root/u-root uroot_dir=$(project_dir)/go/src/github.com/u-root/u-root go_version=$(shell go version | sed -nr 's/.*go([0-9]+\.[0-9]+.?[0-9]?).*/\1/p' ) go_version_major=$(shell echo $(go_version) | sed -nr 's/^([0-9]+)\.([0-9]+)\.?([0-9]*)$$/\1/p') @@ -36,58 +36,35 @@ exit 1 endif endif - mkdir -p $(project_dir)/go/src/github.com/u-root + mkdir -p $(go_path_dir)/src + mkdir -p $(go_path_dir)/bin -$(uroot_dir)/.git: - @echo " Git Cloning u-root $(CONFIG_LINUXBOOT_UROOT_VERSION)" - git clone $(uroot_git_repo) $(uroot_dir) - -fetch: check $(uroot_dir)/.git - -cd "$(uroot_dir)" && git fetch origin - -checkout: fetch - cd "$(uroot_dir)" && \ - if ! git diff --quiet _cb_checkout "$(CONFIG_LINUXBOOT_UROOT_VERSION)" -- 2>/dev/null; \ - then \ - printf " CHECKOUT $(project_name) [$(CONFIG_LINUXBOOT_UROOT_VERSION)]\n"; \ - git checkout $$(git rev-parse HEAD) >/dev/null 2>&1; \ - git branch -f _cb_checkout "$(CONFIG_LINUXBOOT_UROOT_VERSION)" && \ - git checkout _cb_checkout && \ - $(if $(project_patches), \ - for patch in $(project_patches); do \ - printf " PATCH $$patch\n"; \ - git am --keep-cr "$$patch" || \ - ( printf "Error when applying patches.\n"; \ - git am --abort; exit 1; ); \ - done;,true;) \ - fi - -$(uroot_dir)/u-root: $(uroot_dir)/u-root.go +$(go_path_dir)/bin/u-root: @echo " GO u-root" - cd $(uroot_dir); \ - GOPATH=$(go_path_dir) go build u-root.go + cd $(go_path_dir)/src; \ + GOPATH=$(go_path_dir) go get -u $(uroot_git_repo) -$(project_dir)/initramfs.cpio.xz: checkout $(uroot_dir)/u-root +$(project_dir)/initramfs.cpio.xz: check $(go_path_dir)/bin/u-root @echo " MAKE u-root $(CONFIG_LINUXBOOT_UROOT_VERSION)" ifneq ($(CONFIG_LINUXBOOT_UROOT_COMMANDS),) ifneq ($(CONFIG_LINUXBOOT_UROOT_FILES),) - cd $(uroot_dir); \ + cd $(go_path_dir)/bin; \ GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \ -build=bb -files $(CONFIG_LINUXBOOT_UROOT_FILES) -o $(project_dir)/initramfs.cpio \ $(patsubst %,cmds/%,$(CONFIG_LINUXBOOT_UROOT_COMMANDS)) else - cd $(uroot_dir); \ + cd $(go_path_dir)/bin; \ GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \ -build=bb -o $(project_dir)/initramfs.cpio \ $(patsubst %,cmds/%,$(CONFIG_LINUXBOOT_UROOT_COMMANDS)) endif else ifneq ($(CONFIG_LINUXBOOT_UROOT_FILES),) - cd $(uroot_dir); \ + cd $(go_path_dir)/bin; \ GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \ -build=bb -files $(CONFIG_LINUXBOOT_UROOT_FILES) -o $(project_dir)/initramfs.cpio coreboot-app else - cd $(uroot_dir); \ + cd $(go_path_dir)/bin; \ GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \ -build=bb -o $(project_dir)/initramfs.cpio coreboot-app endif @@ -96,4 +73,4 @@ build: $(project_dir)/initramfs.cpio.xz -.PHONY: build checkout fetch all check +.PHONY: build all check -- To view, visit https://review.coreboot.org/29515 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I72866944165823300566e2e9bdaba59599a88178 Gerrit-Change-Number: 29515 Gerrit-PatchSet: 1 Gerrit-Owner: Jens Drenhaus <jens.drenhaus(a)9elements.com>

1 0

Change in coreboot[master]: paayloads/external/Linuxboot: support u-root versions
by Jens Drenhaus (Code Review) 06 Nov '18

06 Nov '18

Jens Drenhaus has uploaded this change for review. ( https://review.coreboot.org/29516 Change subject: paayloads/external/Linuxboot: support u-root versions ...................................................................... paayloads/external/Linuxboot: support u-root versions Since u-root uses release tags on github, now these releases can be checked out in u-root.mk. A specific release can be selected in the Kbuild system when u-root is set in Linuxboot payload. The default vlalue is v2.0.0. Change-Id: I65e1ccf0319809f7fab23142b31882e9928a5ec2 Signed-off-by: Jens Drenhaus <jens.drenhaus(a)9elements.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/targets/u-root.mk 2 files changed, 21 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/29516/1 diff --git a/payloads/external/LinuxBoot/Kconfig b/payloads/external/LinuxBoot/Kconfig index a872d49..5e90fe5 100644 --- a/payloads/external/LinuxBoot/Kconfig +++ b/payloads/external/LinuxBoot/Kconfig @@ -102,17 +102,29 @@ choice prompt "U-root version" - default LINUXBOOT_UROOT_MASTER + default LINUXBOOT_UROOT_2_0_0 config LINUXBOOT_UROOT_MASTER bool "master" help Latest u-root version + +config LINUXBOOT_UROOT_2_0_0 + bool "v2.0.0" + help + Latest stable u-root release version + +config LINUXBOOT_UROOT_1_0_0 + bool "v1.0.0" + help + Initial u-root release endchoice config LINUXBOOT_UROOT_VERSION string default "master" if LINUXBOOT_UROOT_MASTER + default "v2.0.0" if LINUXBOOT_UROOT_2_0_0 + default "v1.0.0" if LINUXBOOT_UROOT_1_0_0 config LINUXBOOT_UROOT_COMMANDS string "Select u-root commands" diff --git a/payloads/external/LinuxBoot/targets/u-root.mk b/payloads/external/LinuxBoot/targets/u-root.mk index 75499d7..d25902a 100644 --- a/payloads/external/LinuxBoot/targets/u-root.mk +++ b/payloads/external/LinuxBoot/targets/u-root.mk @@ -44,7 +44,13 @@ cd $(go_path_dir)/src; \ GOPATH=$(go_path_dir) go get -u $(uroot_git_repo) -$(project_dir)/initramfs.cpio.xz: check $(go_path_dir)/bin/u-root +checkout: $(go_path_dir)/bin/u-root +ifneq ($(CONFIG_LINUXBOOT_UROOT_VERSION), master) + cd $(uroot_dir); \ + git checkout $(CONFIG_LINUXBOOT_UROOT_VERSION) +endif + +$(project_dir)/initramfs.cpio.xz: check checkout @echo " MAKE u-root $(CONFIG_LINUXBOOT_UROOT_VERSION)" ifneq ($(CONFIG_LINUXBOOT_UROOT_COMMANDS),) ifneq ($(CONFIG_LINUXBOOT_UROOT_FILES),) @@ -73,4 +79,4 @@ build: $(project_dir)/initramfs.cpio.xz -.PHONY: build all check +.PHONY: build all check checkout -- To view, visit https://review.coreboot.org/29516 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I65e1ccf0319809f7fab23142b31882e9928a5ec2 Gerrit-Change-Number: 29516 Gerrit-PatchSet: 1 Gerrit-Owner: Jens Drenhaus <jens.drenhaus(a)9elements.com>

1 0

Change in coreboot[master]: payloads/external/Linuxboot/targets: fix Makefile output of u-root
by Jens Drenhaus (Code Review) 06 Nov '18

06 Nov '18

Jens Drenhaus has uploaded this change for review. ( https://review.coreboot.org/29514 Change subject: payloads/external/Linuxboot/targets: fix Makefile output of u-root ...................................................................... payloads/external/Linuxboot/targets: fix Makefile output of u-root suppress printing echo commandlines and split long output in multiple lines. Change-Id: Ic63a8f498720fda6d4ac3e287572dbf76500adfa Signed-off-by: Jens Drenhaus <jens.drenhaus(a)9elements.com> --- M payloads/external/LinuxBoot/targets/u-root.mk 1 file changed, 13 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/29514/1 diff --git a/payloads/external/LinuxBoot/targets/u-root.mk b/payloads/external/LinuxBoot/targets/u-root.mk index 27f184e..d4a0837 100644 --- a/payloads/external/LinuxBoot/targets/u-root.mk +++ b/payloads/external/LinuxBoot/targets/u-root.mk @@ -39,7 +39,7 @@ mkdir -p $(project_dir)/go/src/github.com/u-root $(uroot_dir)/.git: - echo " Git Cloning u-root $(CONFIG_LINUXBOOT_UROOT_VERSION)" + @echo " Git Cloning u-root $(CONFIG_LINUXBOOT_UROOT_VERSION)" git clone $(uroot_git_repo) $(uroot_dir) fetch: check $(uroot_dir)/.git @@ -63,27 +63,32 @@ fi $(uroot_dir)/u-root: $(uroot_dir)/u-root.go - echo " GO u-root" - cd $(uroot_dir); GOPATH=$(go_path_dir) go build u-root.go + @echo " GO u-root" + cd $(uroot_dir); \ + GOPATH=$(go_path_dir) go build u-root.go $(project_dir)/initramfs.cpio.xz: checkout $(uroot_dir)/u-root - echo " MAKE u-root $(CONFIG_LINUXBOOT_UROOT_VERSION)" + @echo " MAKE u-root $(CONFIG_LINUXBOOT_UROOT_VERSION)" ifneq ($(CONFIG_LINUXBOOT_UROOT_COMMANDS),) ifneq ($(CONFIG_LINUXBOOT_UROOT_FILES),) - cd $(uroot_dir); GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \ + cd $(uroot_dir); \ + GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \ -build=bb -files $(CONFIG_LINUXBOOT_UROOT_FILES) -o $(project_dir)/initramfs.cpio \ $(patsubst %,cmds/%,$(CONFIG_LINUXBOOT_UROOT_COMMANDS)) else - cd $(uroot_dir); GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \ + cd $(uroot_dir); \ + GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \ -build=bb -o $(project_dir)/initramfs.cpio \ $(patsubst %,cmds/%,$(CONFIG_LINUXBOOT_UROOT_COMMANDS)) endif else ifneq ($(CONFIG_LINUXBOOT_UROOT_FILES),) - cd $(uroot_dir); GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \ + cd $(uroot_dir); \ + GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \ -build=bb -files $(CONFIG_LINUXBOOT_UROOT_FILES) -o $(project_dir)/initramfs.cpio coreboot-app else - cd $(uroot_dir); GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \ + cd $(uroot_dir); \ + GOARCH=$(CONFIG_LINUXBOOT_ARCH) GOPATH=$(go_path_dir) ./u-root \ -build=bb -o $(project_dir)/initramfs.cpio coreboot-app endif endif -- To view, visit https://review.coreboot.org/29514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic63a8f498720fda6d4ac3e287572dbf76500adfa Gerrit-Change-Number: 29514 Gerrit-PatchSet: 1 Gerrit-Owner: Jens Drenhaus <jens.drenhaus(a)9elements.com>

1 0

Change in coreboot[master]: mb/google/kahlee: edp panel initialization time tuning
by Richard Spiegel (Code Review) 06 Nov '18

06 Nov '18

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29469 ) Change subject: mb/google/kahlee: edp panel initialization time tuning ...................................................................... Patch Set 6: (5 comments) Sorry I did not noticed the other issues in the commit message... The explanation on commit message is now clear, thanks. https://review.coreboot.org/#/c/29469/6//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29469/6//COMMIT_MSG@7 PS6, Line 7: e Capital letter https://review.coreboot.org/#/c/29469/6//COMMIT_MSG@9 PS6, Line 9: a Capital letter https://review.coreboot.org/#/c/29469/6//COMMIT_MSG@12 PS6, Line 12: t Capital letter https://review.coreboot.org/#/c/29469/6//COMMIT_MSG@17 PS6, Line 17: emerge-grunt coreboot Add a dot to the end. https://review.coreboot.org/#/c/29469/6/src/soc/amd/stoneyridge/chip.h File src/soc/amd/stoneyridge/chip.h: https://review.coreboot.org/#/c/29469/6/src/soc/amd/stoneyridge/chip.h@67 PS6, Line 67: * This specifies the LVDS/eDP power up sequence time for the delay from : * active to active. : * 0 - Use the VBIOS default (default). The video BIOS default is 32ms. : * n - Values other than zero specify a setting of (4 * n) milliseconds : * time delay. : Nice, I like it. -- To view, visit https://review.coreboot.org/29469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib20c48813b208d697b950b2f02a70a690e483fdb Gerrit-Change-Number: 29469 Gerrit-PatchSet: 6 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: chris wang <Chris.Wang(a)amd.com> Gerrit-Comment-Date: Tue, 06 Nov 2018 15:46:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/kahlee/variants/liara: Adjust 20ms for edp panel power sequ...
by Richard Spiegel (Code Review) 06 Nov '18

06 Nov '18

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29473 ) Change subject: mb/google/kahlee/variants/liara: Adjust 20ms for edp panel power sequences ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/29473 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab46f6fc653047a1ec6e8528eefa0999d7019690 Gerrit-Change-Number: 29473 Gerrit-PatchSet: 4 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: chris wang <Chris.Wang(a)amd.com> Gerrit-Comment-Date: Tue, 06 Nov 2018 15:39:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: siemens/mc_apl3: Adjust Legacy IRQ routing for PCI devices
by Mario Scheithauer (Code Review) 06 Nov '18

06 Nov '18

Hello Werner Zeh, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29513 to look at the new patch set (#2). Change subject: siemens/mc_apl3: Adjust Legacy IRQ routing for PCI devices ...................................................................... siemens/mc_apl3: Adjust Legacy IRQ routing for PCI devices On this mainboard there is a legacy PCI device, which is connected to the PCIe root port via a PCIe-2-PCI bridge. This device only supports legacy interrupt routing. For this reason we have to adjust the PIR6 register (0x314c) which is responsible for PCIe device 13h and 14h. This means that the interrupt routing will also be the same for both PCIe devices. The bridge is connected to PCIe root port 2 and 3 over two lanes (Device 13.0 and 13.1). The following routing is required: INTA#->PIRQD#, INTB#->PIRQA#, INTC#->PIRQB#, INTD#->PIRQC# Change-Id: I5028c26769a2122b1c609ad7789c9949e3cb7a87 Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/29513/2 -- To view, visit https://review.coreboot.org/29513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5028c26769a2122b1c609ad7789c9949e3cb7a87 Gerrit-Change-Number: 29513 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: siemens/mc_apl3: Adjust Legacy IRQ routing for PCI devices
by Mario Scheithauer (Code Review) 06 Nov '18

06 Nov '18

Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/29513 Change subject: siemens/mc_apl3: Adjust Legacy IRQ routing for PCI devices ...................................................................... siemens/mc_apl3: Adjust Legacy IRQ routing for PCI devices On this mainboard there is a legacy PCI device, which is connected to the PCIe root port via a PCIe-2-PCI bridge. This device only supports legacy interrupt routing. For this reason we have to adjust the PIR6 register (0x314c) which is responsible for PCIe device 13h and 14h. This means that the interrupt routing will also be the same for both PCIe devices. The bridge is connected to PCIe root port 2 and 3 over two lanes (Device 13.0 and 13.1). The following routing is required: INTA#->PIRQD#, INTB#->PIRQA#, INTC#->PIRQB#, INTD#->PIRQC# Change-Id: I5028c26769a2122b1c609ad7789c9949e3cb7a87 Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/29513/1 diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c index ccf3ab8..f6858b0 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c @@ -34,9 +34,9 @@ /* * PIR6 register mapping for PCIe root ports - * INTA#->PIRQB#, INTB#->PIRQC#, INTC#->PIRQD#, INTD#-> PIRQA# + * INTA#->PIRQD#, INTB#->PIRQA#, INTC#->PIRQB#, INTD#-> PIRQC# */ - pcr_write16(PID_ITSS, 0x314c, 0x0321); + pcr_write16(PID_ITSS, 0x314c, 0x2103); /* Disable clock outputs 1-5 (CLKOUT) for XIO2001 PCIe to PCI Bridge. */ dev = dev_find_device(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_XIO2001, 0); -- To view, visit https://review.coreboot.org/29513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5028c26769a2122b1c609ad7789c9949e3cb7a87 Gerrit-Change-Number: 29513 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>

1 0

Change in coreboot[master]: soc/intel/icelake: Make correct IRQ mapping for ICL SA and PCH PCI de...
by Arthur Heymans (Code Review) 06 Nov '18

06 Nov '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/29508 ) Change subject: soc/intel/icelake: Make correct IRQ mapping for ICL SA and PCH PCI devices ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/29508/3/src/soc/intel/icelake/acpi/pci_irqs… File src/soc/intel/icelake/acpi/pci_irqs.asl: https://review.coreboot.org/#/c/29508/3/src/soc/intel/icelake/acpi/pci_irqs… PS3, Line 137: Return (^PICN) these are supposed to be PIC interrupts, which are relative to the PRT A-H settings (at least on older hardware). Is this not configurable anymore or what is the reason behind this change, which hardcodes them? -- To view, visit https://review.coreboot.org/29508 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idec00c3b8a97cb5aa7b4000840aba914aea478c9 Gerrit-Change-Number: 29508 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 06 Nov 2018 13:59:08 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: x86/acpi.c: Be more verbose when finding the wakeup vector
by Patrick Georgi (Code Review) 06 Nov '18

06 Nov '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/29449 ) Change subject: x86/acpi.c: Be more verbose when finding the wakeup vector ...................................................................... x86/acpi.c: Be more verbose when finding the wakeup vector Since S3 resume sometimes breaks when trying to find the wakeup vector, it is useful to log whether it errors or not. Since it is an error, print it as such. Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/29449 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M src/arch/x86/acpi.c 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index 24db7c0..f54aa19 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -1278,8 +1278,11 @@ break; } - if (rsdp == NULL) + if (rsdp == NULL) { + printk(BIOS_ALERT, + "No RSDP found, wake up from S3 not possible.\n"); return NULL; + } printk(BIOS_DEBUG, "RSDP found at %p\n", rsdp); rsdt = (acpi_rsdt_t *)(uintptr_t)rsdp->rsdt_address; @@ -1294,15 +1297,18 @@ fadt = NULL; } - if (fadt == NULL) + if (fadt == NULL) { + printk(BIOS_ALERT, + "No FADT found, wake up from S3 not possible.\n"); return NULL; + } printk(BIOS_DEBUG, "FADT found at %p\n", fadt); facs = (acpi_facs_t *)(uintptr_t)fadt->firmware_ctrl; if (facs == NULL) { - printk(BIOS_DEBUG, "No FACS found, wake up from S3 not " - "possible.\n"); + printk(BIOS_ALERT, + "No FACS found, wake up from S3 not possible.\n"); return NULL; } -- To view, visit https://review.coreboot.org/29449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4 Gerrit-Change-Number: 29449 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/icelake: Add PCIE ASL entry
by Arthur Heymans (Code Review) 06 Nov '18

06 Nov '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/29509 ) Change subject: soc/intel/icelake: Add PCIE ASL entry ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/29509/3/src/soc/intel/icelake/acpi/pcie.asl File src/soc/intel/icelake/acpi/pcie.asl: https://review.coreboot.org/#/c/29509/3/src/soc/intel/icelake/acpi/pcie.asl… PS3, Line 27: Package () { 0x0000ffff, 0, 0, 11 }, : Package () { 0x0000ffff, 1, 0, 10 }, : Package () { 0x0000ffff, 2, 0, 11 }, : Package () { 0x0000ffff, 3, 0, 11 } }) you are mapping multiple pins to the same link? Could you explain it in the commit message as the commit message does not seem to match at all what you are doing... -- To view, visit https://review.coreboot.org/29509 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9693f2a52529961e6b611b69e389f01f77f77d63 Gerrit-Change-Number: 29509 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 06 Nov 2018 13:50:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018