coreboot-gerrit October 2018

coreboot-gerrit@coreboot.org

1 participants
1285 discussions

Change in coreboot[master]: intel/common/block: Fix issue found by klockwork
by John Zhao (Code Review) 17 Oct '18

17 Oct '18

John Zhao has uploaded this change for review. ( https://review.coreboot.org/29149 Change subject: intel/common/block: Fix issue found by klockwork ...................................................................... intel/common/block: Fix issue found by klockwork src/soc/intel/common/block/pmc/pmclib.c Function acpi_get_sleep_type: Pointer ps checked for NULL may be dereferenced. BRANCH=None TEST=Built & booted Yorp board. Change-Id: I15fe39fd9f930be56d03c2ffe62fb6f17249d4b5 Signed-off-by: John Zhao <john.zhao(a)intel.com> --- M src/soc/intel/common/block/pmc/pmclib.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/29149/1 diff --git a/src/soc/intel/common/block/pmc/pmclib.c b/src/soc/intel/common/block/pmc/pmclib.c index cfe8011..ef4384d 100644 --- a/src/soc/intel/common/block/pmc/pmclib.c +++ b/src/soc/intel/common/block/pmc/pmclib.c @@ -95,9 +95,13 @@ int acpi_get_sleep_type(void) { struct chipset_power_state *ps; + int prev_sleep_state = ACPI_S0; ps = pmc_get_power_state(); - return ps->prev_sleep_state; + if (ps) + prev_sleep_state = ps->prev_sleep_state; + + return prev_sleep_state; } static uint32_t pmc_reset_smi_status(void) -- To view, visit https://review.coreboot.org/29149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I15fe39fd9f930be56d03c2ffe62fb6f17249d4b5 Gerrit-Change-Number: 29149 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.com>

1 0

Change in coreboot[master]: mb/lenovo/z61t: Add VBT-file
by Peter Lemenkov (Code Review) 16 Oct '18

16 Oct '18

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/29148 Change subject: mb/lenovo/z61t: Add VBT-file ...................................................................... mb/lenovo/z61t: Add VBT-file This file was extracted directly from the vendor's firmware ver. 2.27. Change-Id: Ic2d2b259f3b535a791c9dcfdf962c03a0bab87a2 Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com> --- M src/mainboard/lenovo/z61t/Kconfig A src/mainboard/lenovo/z61t/data.vbt 2 files changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/29148/1 diff --git a/src/mainboard/lenovo/z61t/Kconfig b/src/mainboard/lenovo/z61t/Kconfig index ae50e81..d071ef6 100644 --- a/src/mainboard/lenovo/z61t/Kconfig +++ b/src/mainboard/lenovo/z61t/Kconfig @@ -23,6 +23,7 @@ select MAINBOARD_HAS_NATIVE_VGA_INIT select H8_DOCK_EARLY_INIT select HAVE_CMOS_DEFAULT + select INTEL_GMA_HAVE_VBT config MAINBOARD_DIR string diff --git a/src/mainboard/lenovo/z61t/data.vbt b/src/mainboard/lenovo/z61t/data.vbt new file mode 100644 index 0000000..0adbce1 --- /dev/null +++ b/src/mainboard/lenovo/z61t/data.vbt Binary files differ -- To view, visit https://review.coreboot.org/29148 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic2d2b259f3b535a791c9dcfdf962c03a0bab87a2 Gerrit-Change-Number: 29148 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com>

1 0

Change in coreboot[master]: src/mainboard: Add dell/gx520
by Elyes HAOUAS (Code Review) 16 Oct '18

16 Oct '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/29109 ) Change subject: src/mainboard: Add dell/gx520 ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/29109/2/src/mainboard/dell/gx520/romstage.c File src/mainboard/dell/gx520/romstage.c: https://review.coreboot.org/#/c/29109/2/src/mainboard/dell/gx520/romstage.c… PS2, Line 43: 0x0000 0x0010 ? -- To view, visit https://review.coreboot.org/29109 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0016dd35be67803e91ffefb0c87f54e35c93efcd Gerrit-Change-Number: 29109 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 16 Oct 2018 10:43:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/superio/smsc/smscsuperio/superio.c: Add SCH5504
by build bot (Jenkins) (Code Review) 16 Oct '18

16 Oct '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28971 ) Change subject: src/superio/smsc/smscsuperio/superio.c: Add SCH5504 ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/28971/3/src/superio/smsc/smscsuperio/superi… File src/superio/smsc/smscsuperio/superio.c: https://review.coreboot.org/#/c/28971/3/src/superio/smsc/smscsuperio/superi… PS3, Line 135: {SCH5504, {0, 3, 4, 5, -1, 7, -1, -1, -1, -1, -1, -1, 10, -1, -1}}, space required after that close brace '}' -- To view, visit https://review.coreboot.org/28971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c433fa04c01ba6315bcdca699030dfce18a169a Gerrit-Change-Number: 28971 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 16 Oct 2018 10:21:54 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/mainboard: Add dell/gx520
by Angel Pons (Code Review) 16 Oct '18

16 Oct '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29109 to look at the new patch set (#2). Change subject: src/mainboard: Add dell/gx520 ...................................................................... src/mainboard: Add dell/gx520 What works: - Compiling What does not work: - Getting the computer to display any signs of life with coreboot. Change-Id: I0016dd35be67803e91ffefb0c87f54e35c93efcd Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- A src/mainboard/dell/Kconfig A src/mainboard/dell/Kconfig.name A src/mainboard/dell/gx520/Kconfig A src/mainboard/dell/gx520/Kconfig.name A src/mainboard/dell/gx520/Makefile.inc A src/mainboard/dell/gx520/acpi/ec.asl A src/mainboard/dell/gx520/acpi/ich7_pci_irqs.asl A src/mainboard/dell/gx520/acpi/mainboard.asl A src/mainboard/dell/gx520/acpi/platform.asl A src/mainboard/dell/gx520/acpi/superio.asl A src/mainboard/dell/gx520/acpi/thermal.asl A src/mainboard/dell/gx520/acpi_tables.c A src/mainboard/dell/gx520/board_info.txt A src/mainboard/dell/gx520/cmos.default A src/mainboard/dell/gx520/cmos.layout A src/mainboard/dell/gx520/cstates.c A src/mainboard/dell/gx520/data.vbt A src/mainboard/dell/gx520/devicetree.cb A src/mainboard/dell/gx520/dsdt.asl A src/mainboard/dell/gx520/gpio.c A src/mainboard/dell/gx520/hda_verb.c A src/mainboard/dell/gx520/romstage.c 22 files changed, 984 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/29109/2 -- To view, visit https://review.coreboot.org/29109 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0016dd35be67803e91ffefb0c87f54e35c93efcd Gerrit-Change-Number: 29109 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/octopus/variants/fleex: Update DPTF parameters
by John Su (Code Review) 16 Oct '18

16 Oct '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29146 to look at the new patch set (#2). Change subject: mb/google/octopus/variants/fleex: Update DPTF parameters ...................................................................... mb/google/octopus/variants/fleex: Update DPTF parameters Update PSV and power limit2 values BUG=b:112448519 TEST=Build coreboot for Octopus board Change-Id: I7c7df0f54374fdaa4cf57d5c255d841d7db38cfc Signed-off-by: John_Su <john_su(a)compal.corp-partner.google.com> --- M src/mainboard/google/octopus/variants/fleex/include/variant/acpi/dptf.asl 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/29146/2 -- To view, visit https://review.coreboot.org/29146 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7c7df0f54374fdaa4cf57d5c255d841d7db38cfc Gerrit-Change-Number: 29146 Gerrit-PatchSet: 2 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/octopus/variants/fleex: Update DPTF parameters
by John Su (Code Review) 16 Oct '18

16 Oct '18

John Su has uploaded this change for review. ( https://review.coreboot.org/29146 Change subject: mb/google/octopus/variants/fleex: Update DPTF parameters ...................................................................... mb/google/octopus/variants/fleex: Update DPTF parameters Update PSV and power limit2 values BUG=b:112448519 TEST=Build coreboot for Octopus board Change-Id: I7c7df0f54374fdaa4cf57d5c255d841d7db38cfc --- M src/mainboard/google/octopus/variants/fleex/include/variant/acpi/dptf.asl 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/29146/1 diff --git a/src/mainboard/google/octopus/variants/fleex/include/variant/acpi/dptf.asl b/src/mainboard/google/octopus/variants/fleex/include/variant/acpi/dptf.asl index d72b4d0..730ef37 100644 --- a/src/mainboard/google/octopus/variants/fleex/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/octopus/variants/fleex/include/variant/acpi/dptf.asl @@ -13,12 +13,12 @@ * GNU General Public License for more details. */ -#define DPTF_CPU_PASSIVE 90 +#define DPTF_CPU_PASSIVE 100 #define DPTF_CPU_CRITICAL 127 #define DPTF_TSR1_SENSOR_ID 1 #define DPTF_TSR1_SENSOR_NAME "Ambient" -#define DPTF_TSR1_PASSIVE 90 +#define DPTF_TSR1_PASSIVE 63 #define DPTF_TSR1_CRITICAL 127 #define DPTF_TSR2_SENSOR_ID 2 @@ -55,7 +55,7 @@ 0x2, /* Revision */ Package () { /* Power Limit 1 */ 0, /* PowerLimitIndex, 0 for Power Limit 1 */ - 3000, /* PowerLimitMinimum */ + 4500, /* PowerLimitMinimum */ 10000, /* PowerLimitMaximum */ 1000, /* TimeWindowMinimum */ 1000, /* TimeWindowMaximum */ -- To view, visit https://review.coreboot.org/29146 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7c7df0f54374fdaa4cf57d5c255d841d7db38cfc Gerrit-Change-Number: 29146 Gerrit-PatchSet: 1 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Enable HDA driver support
by PraveenX Hodagatta Pranesh (Code Review) 16 Oct '18

16 Oct '18

PraveenX Hodagatta Pranesh has uploaded this change for review. ( https://review.coreboot.org/29145 Change subject: soc/intel/cannonlake: Enable HDA driver support ...................................................................... soc/intel/cannonlake: Enable HDA driver support this patch select common HDA driver and add audio controller device id to enable audio on coffee lake platforms. BUG: None TEST: boot to yocto linux and windows os on CFL RVP11 & RVP8, verified audio functionalities. Change-Id: I4a60a4d7d8babcd0c14664a304ca81d47c668a6c Signed-off-by: praveen hodagatta pranesh <praveenx.hodagatta.pranesh(a)intel.com> --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/common/block/hda/hda.c 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/29145/1 diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index e39aaad..0845052 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -7,6 +7,7 @@ bool default n select SOC_INTEL_CANNONLAKE + select SOC_INTEL_COMMON_BLOCK_HDA help Intel Coffeelake support diff --git a/src/soc/intel/common/block/hda/hda.c b/src/soc/intel/common/block/hda/hda.c index 2409b75..50f847e 100644 --- a/src/soc/intel/common/block/hda/hda.c +++ b/src/soc/intel/common/block/hda/hda.c @@ -75,6 +75,7 @@ PCI_DEVICE_ID_INTEL_SKL_AUDIO, PCI_DEVICE_ID_INTEL_KBL_AUDIO, PCI_DEVICE_ID_INTEL_CNL_AUDIO, + PCI_DEVICE_ID_INTEL_CNP_H_AUDIO, 0 }; -- To view, visit https://review.coreboot.org/29145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4a60a4d7d8babcd0c14664a304ca81d47c668a6c Gerrit-Change-Number: 29145 Gerrit-PatchSet: 1 Gerrit-Owner: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh(a)intel.com>

1 0

Change in coreboot[master]: ec/google/common: Add a common MEC interface
by Duncan Laurie (Code Review) 16 Oct '18

16 Oct '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29111 to look at the new patch set (#2). Change subject: ec/google/common: Add a common MEC interface ...................................................................... ec/google/common: Add a common MEC interface In order to re-use the MEC interface code in the Chrome EC driver move it to a common directory within the ec/google directory. The Chrome EC driver itself is changed to use this interface in the next commit, and future commits will introduce a new EC that also uses this interface. Change-Id: I13516b5e4c4c49f53bb998366284a26703142e2a Signed-off-by: Duncan Laurie <dlaurie(a)google.com> --- A src/ec/google/common/Kconfig A src/ec/google/common/Makefile.inc A src/ec/google/common/mec.c A src/ec/google/common/mec.h 4 files changed, 174 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/29111/2 -- To view, visit https://review.coreboot.org/29111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I13516b5e4c4c49f53bb998366284a26703142e2a Gerrit-Change-Number: 29111 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Enable UART log for debug UEFI payload
by Wonkyu Kim (Code Review) 16 Oct '18

16 Oct '18

Wonkyu Kim has abandoned this change. ( https://review.coreboot.org/28941 ) Change subject: Enable UART log for debug UEFI payload ...................................................................... Abandoned other patch fixed the issue -- To view, visit https://review.coreboot.org/28941 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I34dd6ac342c7bcafe1f1deb1e3fd0e28c6706353 Gerrit-Change-Number: 28941 Gerrit-PatchSet: 2 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2018