Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/29240
Change subject: board-status.html: improve instructions
......................................................................
board-status.html: improve instructions
The foreword mentioned that you need a gerrit account, but not how to
have git push with the right credentials.
To ease onboarding, point out where to get them.
Change-Id: I0b022bc064e3bc89568617c1a3a3e0e5236ba520
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
---
M util/docker/coreboot.org-status/board-status.html/foreword.html
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/29240/1
diff --git a/util/docker/coreboot.org-status/board-status.html/foreword.html b/util/docker/coreboot.org-status/board-status.html/foreword.html
index 4d77c3f..b2d2822 100644
--- a/util/docker/coreboot.org-status/board-status.html/foreword.html
+++ b/util/docker/coreboot.org-status/board-status.html/foreword.html
@@ -18,7 +18,11 @@
<a href='https://review.coreboot.org/cgit/coreboot.git/tree/util/board_status'>a tool in the coreboot repository</a>
to make contributing easy. The data resides in the
<a href='https://review.coreboot.org/gitweb/cgit/board-status.git'>board status repository</a>.
-Contributing requires an account on review.coreboot.org</p>
+Contributing requires an account on review.coreboot.org. After
+logging into the site with your preferred OpenID or GitHub/Google
+credentials, you can get a user name and password for git pushes on <a
+href="https://review.coreboot.org/settings/#HTTPCredentials">gerrit's
+settings screen</a>.</p>
<p>Sometimes the same board is sold under different names, we've tried to
list all known names but some names might be missing.</p>
--
To view, visit https://review.coreboot.org/29240
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b022bc064e3bc89568617c1a3a3e0e5236ba520
Gerrit-Change-Number: 29240
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/29237 )
Change subject: Revert "drivers/intel/fsp2_0: Hook up IntelFSP repo"
......................................................................
Patch Set 2:
uhm, why?
--
To view, visit https://review.coreboot.org/29237
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadde396e5f75fa2f045026be3a0927c1e17f5f7f
Gerrit-Change-Number: 29237
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Comment-Date: Tue, 23 Oct 2018 12:30:16 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Ren Kuo has abandoned this change. ( https://review.coreboot.org/29237 )
Change subject: Revert "drivers/intel/fsp2_0: Hook up IntelFSP repo"
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/29237
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Iadde396e5f75fa2f045026be3a0927c1e17f5f7f
Gerrit-Change-Number: 29237
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Ren Kuo has uploaded a new patch set (#2). ( https://review.coreboot.org/29237 )
Change subject: Revert "drivers/intel/fsp2_0: Hook up IntelFSP repo"
......................................................................
Revert "drivers/intel/fsp2_0: Hook up IntelFSP repo"
This reverts commit 6539e10c4f209ea4273a78528b26c1f9ff4a3047.
Change-Id: Iadde396e5f75fa2f045026be3a0927c1e17f5f7f
---
M 3rdparty/blobs
M src/drivers/intel/fsp2_0/Kconfig
M src/drivers/intel/fsp2_0/Makefile.inc
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/apollolake/Makefile.inc
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/skylake/Kconfig
M src/soc/intel/skylake/Makefile.inc
A src/vendorcode/intel/fsp/fsp2_0/apollolake/FspUpd.h
A src/vendorcode/intel/fsp/fsp2_0/apollolake/FspmUpd.h
A src/vendorcode/intel/fsp/fsp2_0/apollolake/FspsUpd.h
A src/vendorcode/intel/fsp/fsp2_0/coffeelake/FirmwareVersionInfoHob.h
A src/vendorcode/intel/fsp/fsp2_0/coffeelake/FspUpd.h
A src/vendorcode/intel/fsp/fsp2_0/coffeelake/FspmUpd.h
A src/vendorcode/intel/fsp/fsp2_0/coffeelake/FspsUpd.h
A src/vendorcode/intel/fsp/fsp2_0/coffeelake/FsptUpd.h
A src/vendorcode/intel/fsp/fsp2_0/coffeelake/MemInfoHob.h
A src/vendorcode/intel/fsp/fsp2_0/skykabylake/ConfigBlock/CpuConfigFspData.h
A src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspUpd.h
A src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspmUpd.h
A src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspsUpd.h
A src/vendorcode/intel/fsp/fsp2_0/skykabylake/MemInfoHob.h
22 files changed, 14,245 insertions(+), 66 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/29237/2
--
To view, visit https://review.coreboot.org/29237
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iadde396e5f75fa2f045026be3a0927c1e17f5f7f
Gerrit-Change-Number: 29237
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Ren Kuo has restored this change. ( https://review.coreboot.org/29237 )
Change subject: Revert "drivers/intel/fsp2_0: Hook up IntelFSP repo"
......................................................................
Restored
--
To view, visit https://review.coreboot.org/29237
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: restore
Gerrit-Change-Id: Iadde396e5f75fa2f045026be3a0927c1e17f5f7f
Gerrit-Change-Number: 29237
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29234 )
Change subject: security/tpm: Add function to measure a region device
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/29234/2/src/security/tpm/Makefile.inc
File src/security/tpm/Makefile.inc:
https://review.coreboot.org/#/c/29234/2/src/security/tpm/Makefile.inc@51
PS2, Line 51: postcar-srcs += $(VB2_LIB)
Add bootblock if not already built in
https://review.coreboot.org/#/c/29234/2/src/security/tpm/tspi/tspi.c
File src/security/tpm/tspi/tspi.c:
https://review.coreboot.org/#/c/29234/2/src/security/tpm/tspi/tspi.c@231
PS2, Line 231: buf = rdev_mmap_full(rdev);
Will fuckup measurements because of memory constraints. See my previous code :)
--
To view, visit https://review.coreboot.org/29234
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I126cc3500fd039d63743db78002a04d201ab18aa
Gerrit-Change-Number: 29234
Gerrit-PatchSet: 3
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 23 Oct 2018 12:27:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Ren Kuo has abandoned this change. ( https://review.coreboot.org/29238 )
Change subject: mb/google/poppy/variants/nami: Enable radium touchscreen support
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/29238
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia0a4dfa525adbae003071976e45391bdfcfdcac0
Gerrit-Change-Number: 29238
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Ren Kuo has abandoned this change. ( https://review.coreboot.org/29237 )
Change subject: Revert "drivers/intel/fsp2_0: Hook up IntelFSP repo"
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/29237
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Iadde396e5f75fa2f045026be3a0927c1e17f5f7f
Gerrit-Change-Number: 29237
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>