coreboot-gerrit October 2018

coreboot-gerrit@coreboot.org

1 participants
1285 discussions

Change in coreboot[master]: mb/google/kahlee: Enable 2T mode for liara
by build bot (Jenkins) (Code Review) 24 Oct '18

24 Oct '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29179 ) Change subject: mb/google/kahlee: Enable 2T mode for liara ...................................................................... Patch Set 6: (2 comments) https://review.coreboot.org/#/c/29179/6/src/mainboard/google/kahlee/OemCust… File src/mainboard/google/kahlee/OemCustomize.c: https://review.coreboot.org/#/c/29179/6/src/mainboard/google/kahlee/OemCust… PS6, Line 60: (PSO_ENTRY *)DDR4LiaraMemoryConfiguration; line over 80 characters https://review.coreboot.org/#/c/29179/6/src/mainboard/google/kahlee/OemCust… PS6, Line 63: (PSO_ENTRY *)DDR4PlatformMemoryConfiguration; line over 80 characters -- To view, visit https://review.coreboot.org/29179 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a96276d88ffb70530d72b15c07b59a01cc6209a Gerrit-Change-Number: 29179 Gerrit-PatchSet: 6 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: chris wang <Chris.Wang(a)amd.com> Gerrit-Comment-Date: Wed, 24 Oct 2018 06:22:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Remove "else" after a return
by Richard Spiegel (Code Review) 24 Oct '18

24 Oct '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/29247 Change subject: soc/amd/stoneyridge: Remove "else" after a return ...................................................................... soc/amd/stoneyridge: Remove "else" after a return File ramtop.c has one instance of if()/else where the if tests for top mem in lower 4GiB, and returns just before the "else" statement. These "else" statements are not needed. BUG=b:117648025 TEST=Build and boot grunt. Change-Id: Iba16a416e78dae75a95a11d38179161c5a11b2ad Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/soc/amd/stoneyridge/ramtop.c 1 file changed, 4 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/29247/1 diff --git a/src/soc/amd/stoneyridge/ramtop.c b/src/soc/amd/stoneyridge/ramtop.c index 72db8ec..0dca034 100644 --- a/src/soc/amd/stoneyridge/ramtop.c +++ b/src/soc/amd/stoneyridge/ramtop.c @@ -63,11 +63,10 @@ if (!tom.lo) return 0; - else - /* 8MB alignment to keep MTRR usage low */ - return (void *)ALIGN_DOWN(restore_top_of_low_cacheable() - - CONFIG_SMM_TSEG_SIZE - - BERT_REGION_MAX_SIZE, 8*MiB); + /* 8MB alignment to keep MTRR usage low */ + return (void *)ALIGN_DOWN(restore_top_of_low_cacheable() + - CONFIG_SMM_TSEG_SIZE + - BERT_REGION_MAX_SIZE, 8*MiB); } static uintptr_t smm_region_start(void) -- To view, visit https://review.coreboot.org/29247 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iba16a416e78dae75a95a11d38179161c5a11b2ad Gerrit-Change-Number: 29247 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: soc/amd/common/def_callouts.c: Prefer using '"%s...", __func__'
by Richard Spiegel (Code Review) 24 Oct '18

24 Oct '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/29246 Change subject: soc/amd/common/def_callouts.c: Prefer using '"%s...", __func__' ...................................................................... soc/amd/common/def_callouts.c: Prefer using '"%s...", __func__' In function agesa_GfxGetVbiosImage(), the function name is used in a print string. Use __func__ instead. BUG=b:117642170 TEST=Build grunt. Change-Id: I95a042bd95cc729305a8a008e3bb464f60c2668d Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/soc/amd/common/block/pi/def_callouts.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/29246/1 diff --git a/src/soc/amd/common/block/pi/def_callouts.c b/src/soc/amd/common/block/pi/def_callouts.c index d136084..2da00cb 100644 --- a/src/soc/amd/common/block/pi/def_callouts.c +++ b/src/soc/amd/common/block/pi/def_callouts.c @@ -152,8 +152,8 @@ pVbiosImageInfo->ImagePtr = cbfs_boot_map_with_leak( "pci"CONFIG_VGA_BIOS_ID".rom", CBFS_TYPE_OPTIONROM, NULL); - printk(BIOS_DEBUG, "agesa_GfxGetVbiosImage: IMGptr=%p\n", - pVbiosImageInfo->ImagePtr); + printk(BIOS_DEBUG, "%s: IMGptr=%p\n", __func__, + pVbiosImageInfo->ImagePtr); return pVbiosImageInfo->ImagePtr ? AGESA_SUCCESS : AGESA_WARNING; } -- To view, visit https://review.coreboot.org/29246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I95a042bd95cc729305a8a008e3bb464f60c2668d Gerrit-Change-Number: 29246 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: mb/google/kahlee/irq_tables.c: Prefer using '"%s...", __func__'
by Richard Spiegel (Code Review) 24 Oct '18

24 Oct '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/29245 Change subject: mb/google/kahlee/irq_tables.c: Prefer using '"%s...", __func__' ...................................................................... mb/google/kahlee/irq_tables.c: Prefer using '"%s...", __func__' In function write_pirq_routing_table(), the function name is used in a print string. Use __func__ instead. BUG=b:117642170 TEST=Build grunt. Change-Id: Ibf8673c5b2cda1105aae1edb46f6589d55208c50 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/mainboard/google/kahlee/irq_tables.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/29245/1 diff --git a/src/mainboard/google/kahlee/irq_tables.c b/src/mainboard/google/kahlee/irq_tables.c index bf1daec..31cfbc1 100644 --- a/src/mainboard/google/kahlee/irq_tables.c +++ b/src/mainboard/google/kahlee/irq_tables.c @@ -94,7 +94,7 @@ if (sum != pirq->checksum) pirq->checksum = sum; - printk(BIOS_INFO, "write_pirq_routing_table done.\n"); + printk(BIOS_INFO, "%s done.\n", __func__); return (unsigned long)pirq_info; } -- To view, visit https://review.coreboot.org/29245 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf8673c5b2cda1105aae1edb46f6589d55208c50 Gerrit-Change-Number: 29245 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: mb/google/poppy: add the smi_events back
by Furquan Shaikh (Code Review) 24 Oct '18

24 Oct '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29191 ) Change subject: mb/google/poppy: add the smi_events back ...................................................................... Patch Set 5: > Patch Set 4: Code-Review+2 > > Nocturne on recovery screen goes to sleep when lid is closed and wakes up when it is opened. Thanks Nick! -- To view, visit https://review.coreboot.org/29191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529 Gerrit-Change-Number: 29191 Gerrit-PatchSet: 5 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 23 Oct 2018 19:58:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy: add the smi_events back
by Furquan Shaikh (Code Review) 24 Oct '18

24 Oct '18

Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/29191 ) Change subject: mb/google/poppy: add the smi_events back ...................................................................... mb/google/poppy: add the smi_events back Before entering the OS, the AP relies on the smi handler to shutdown the system when the lid closes. Without the smi_events setting, the AP will not receive the smi handler. As a result, the AP won't shutdown and will always keep in S0. This problem is caused by the https://review.coreboot.org/c/coreboot/+/28983 and this patch adds the smi_events back to support the smi handler for the lid close. BRANCH=master BUG=b:115572596 TEST=test_that -b ${BOARD} ${IP} firmware_ECLidShutdown Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529 Signed-off-by: Zhuohao Lee <zhuohao(a)chromium.org> Reviewed-on: https://review.coreboot.org/29191 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Furquan Shaikh <furquan(a)google.com> Reviewed-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/poppy/ec.c M src/mainboard/google/poppy/variants/nocturne/ec.c 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Nick Vaccaro: Looks good to me, approved diff --git a/src/mainboard/google/poppy/ec.c b/src/mainboard/google/poppy/ec.c index 71327be..a93bf19 100644 --- a/src/mainboard/google/poppy/ec.c +++ b/src/mainboard/google/poppy/ec.c @@ -24,6 +24,7 @@ static const struct google_chromeec_event_info info = { .log_events = MAINBOARD_EC_LOG_EVENTS, .sci_events = MAINBOARD_EC_SCI_EVENTS, + .smi_events = MAINBOARD_EC_SMI_EVENTS, .s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS, .s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS, .s0ix_wake_events = MAINBOARD_EC_S0IX_WAKE_EVENTS, diff --git a/src/mainboard/google/poppy/variants/nocturne/ec.c b/src/mainboard/google/poppy/variants/nocturne/ec.c index 3e187fc..76d80d2 100644 --- a/src/mainboard/google/poppy/variants/nocturne/ec.c +++ b/src/mainboard/google/poppy/variants/nocturne/ec.c @@ -25,6 +25,7 @@ static struct google_chromeec_event_info info = { .log_events = MAINBOARD_EC_LOG_EVENTS, .sci_events = MAINBOARD_EC_SCI_EVENTS, + .smi_events = MAINBOARD_EC_SMI_EVENTS, .s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS, .s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS, .s0ix_wake_events = MAINBOARD_EC_S0IX_WAKE_EVENTS, -- To view, visit https://review.coreboot.org/29191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529 Gerrit-Change-Number: 29191 Gerrit-PatchSet: 5 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy: add the smi_events back
by Nick Vaccaro (Code Review) 24 Oct '18

24 Oct '18

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/29191 ) Change subject: mb/google/poppy: add the smi_events back ...................................................................... Patch Set 4: Code-Review+2 Nocturne on recovery screen goes to sleep when lid is closed and wakes up when it is opened. -- To view, visit https://review.coreboot.org/29191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529 Gerrit-Change-Number: 29191 Gerrit-PatchSet: 4 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 23 Oct 2018 19:55:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: {cpu, drivers, sb}/amd: Replace MTRR addresses with macros
by Richard Spiegel (Code Review) 24 Oct '18

24 Oct '18

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29243 ) Change subject: {cpu,drivers,sb}/amd: Replace MTRR addresses with macros ...................................................................... Patch Set 2: There are more files with this 2 MTRR that should be changed. northbridge/amd/amdmct/mct_ddr3/s3utils.c 16 files under vendorcode (these I might accept not changing to keep close to original). -- To view, visit https://review.coreboot.org/29243 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e8de35dcdad52bb311b34bfa9b272d17ed3186b Gerrit-Change-Number: 29243 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 23 Oct 2018 19:53:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy: add the smi_events back
by Nick Vaccaro (Code Review) 24 Oct '18

24 Oct '18

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/29191 ) Change subject: mb/google/poppy: add the smi_events back ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/29191/1/src/mainboard/google/poppy/ec.c File src/mainboard/google/poppy/ec.c: https://review.coreboot.org/#/c/29191/1/src/mainboard/google/poppy/ec.c@27 PS1, Line 27: .smi_events = MAINBOARD_EC_SMI_EVENTS, > +Nick, can you please test this on a nocturne? I've been working on verifying this change, but ran into build issues. I got around the build issue, working on verifying this change now. -- To view, visit https://review.coreboot.org/29191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529 Gerrit-Change-Number: 29191 Gerrit-PatchSet: 4 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 23 Oct 2018 19:44:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: {cpu, drivers, sb}/amd: Replace MTRR addresses with macros
by Elyes HAOUAS (Code Review) 24 Oct '18

24 Oct '18

Hello Richard Spiegel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29243 to look at the new patch set (#2). Change subject: {cpu,drivers,sb}/amd: Replace MTRR addresses with macros ...................................................................... {cpu,drivers,sb}/amd: Replace MTRR addresses with macros Change-Id: I7e8de35dcdad52bb311b34bfa9b272d17ed3186b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/amd/agesa/family12/fixme.c M src/cpu/amd/agesa/family14/fixme.c M src/cpu/amd/agesa/family15tn/fixme.c M src/cpu/amd/agesa/family16kb/fixme.c M src/cpu/amd/pi/00630F01/fixme.c M src/cpu/amd/pi/00660F01/fixme.c M src/cpu/amd/pi/00730F01/fixme.c M src/drivers/amd/agesa/s3_mtrr.c M src/southbridge/amd/rs780/gfx.c M src/southbridge/amd/sr5650/sr5650.c 10 files changed, 21 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/29243/2 -- To view, visit https://review.coreboot.org/29243 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7e8de35dcdad52bb311b34bfa9b272d17ed3186b Gerrit-Change-Number: 29243 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2018