coreboot-gerrit October 2018

coreboot-gerrit@coreboot.org

1 participants
1285 discussions

Change in coreboot[master]: mb/emulation/*-riscv: Remove "UCB" from RISC-V board names
by Angel Pons (Code Review) 06 Oct '18

06 Oct '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28951 ) Change subject: mb/emulation/*-riscv: Remove "UCB" from RISC-V board names ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/28951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I301d9d0091a714e62375052e5af06a9197876688 Gerrit-Change-Number: 28951 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 06 Oct 2018 14:28:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Documentation/mb/sifive: Fix dead links
by Jonathan Neuschäfer (Code Review) 06 Oct '18

06 Oct '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28952 Change subject: Documentation/mb/sifive: Fix dead links ...................................................................... Documentation/mb/sifive: Fix dead links SiFive's website was reorganized, which broke our links to PDF files. Update these links to the current ones, obtained by browsing https://sifive.com/documentation/. Change-Id: I312de84bf12abb0789bdd971c40033f1e4ea0dd1 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M Documentation/mainboard/sifive/hifive-unleashed.md 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/28952/1 diff --git a/Documentation/mainboard/sifive/hifive-unleashed.md b/Documentation/mainboard/sifive/hifive-unleashed.md index 1d07cb7..cd7c93c 100644 --- a/Documentation/mainboard/sifive/hifive-unleashed.md +++ b/Documentation/mainboard/sifive/hifive-unleashed.md @@ -96,8 +96,8 @@ [HiFive Unleashed]: https://www.crowdsupply.com/sifive/hifive-unleashed [SiFive]: https://www.sifive.com/ -[Getting Started Guide]: https://www.sifive.com/documentation/boards/hifive-unleashed/hifive-unleash… +[Getting Started Guide]: https://sifive.cdn.prismic.io/sifive%2Ffa3a584a-a02f-4fda-b758-a2def05f49f9… [RISC-V fork of OpenOCD]: https://github.com/riscv/riscv-openocd [OpenOCD script]: https://github.com/sifive/freedom-u-sdk/blob/057a47f657fa33e2c60df7f183884a… [flashrom]: https://flashrom.org/Flashrom -[schematics]: https://www.sifive.com/documentation/boards/hifive-unleashed/hifive-unleash… +[schematics]: https://sifive.cdn.prismic.io/sifive%2Ff7173056-bf37-4407-87cb-d5ab76abf61a… -- To view, visit https://review.coreboot.org/28952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I312de84bf12abb0789bdd971c40033f1e4ea0dd1 Gerrit-Change-Number: 28952 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: mb/emulation/*-riscv: Remove "UCB" from RISC-V board names
by Jonathan Neuschäfer (Code Review) 06 Oct '18

06 Oct '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28951 Change subject: mb/emulation/*-riscv: Remove "UCB" from RISC-V board names ...................................................................... mb/emulation/*-riscv: Remove "UCB" from RISC-V board names RISC-V is not a project of the University of California, Berkeley, anymore; it stands on its own feet now. Remove the "UCB" component from the RISC-V mainboards in the "emulation" directory, and don't set MAINBOARD_VENDOR to UCB, either. Change-Id: I301d9d0091a714e62375052e5af06a9197876688 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/mainboard/emulation/qemu-riscv/Kconfig M src/mainboard/emulation/qemu-riscv/Kconfig.name M src/mainboard/emulation/spike-riscv/Kconfig M src/mainboard/emulation/spike-riscv/Kconfig.name 4 files changed, 8 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/28951/1 diff --git a/src/mainboard/emulation/qemu-riscv/Kconfig b/src/mainboard/emulation/qemu-riscv/Kconfig index 5e4ea2d..45ef629 100644 --- a/src/mainboard/emulation/qemu-riscv/Kconfig +++ b/src/mainboard/emulation/qemu-riscv/Kconfig @@ -15,7 +15,7 @@ # To execute, do: # qemu-system-arm -M vexpress-a9 -m 1024M -nographic -kernel build/coreboot.rom -if BOARD_EMULATION_QEMU_UCB_RISCV +if BOARD_EMULATION_QEMU_RISCV config BOARD_SPECIFIC_OPTIONS # dummy def_bool y @@ -36,12 +36,8 @@ int default 1 -config MAINBOARD_VENDOR - string - default "UCB" - config DRAM_SIZE_MB int default 32768 -endif # BOARD_EMULATION_QEMU_UCB_RISCV +endif # BOARD_EMULATION_QEMU_RISCV diff --git a/src/mainboard/emulation/qemu-riscv/Kconfig.name b/src/mainboard/emulation/qemu-riscv/Kconfig.name index 5482f22..e9243e6 100644 --- a/src/mainboard/emulation/qemu-riscv/Kconfig.name +++ b/src/mainboard/emulation/qemu-riscv/Kconfig.name @@ -1,2 +1,2 @@ -config BOARD_EMULATION_QEMU_UCB_RISCV - bool "QEMU ucb riscv" +config BOARD_EMULATION_QEMU_RISCV + bool "QEMU riscv" diff --git a/src/mainboard/emulation/spike-riscv/Kconfig b/src/mainboard/emulation/spike-riscv/Kconfig index 67161f3..43d14cb 100644 --- a/src/mainboard/emulation/spike-riscv/Kconfig +++ b/src/mainboard/emulation/spike-riscv/Kconfig @@ -12,7 +12,7 @@ ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the ## GNU General Public License for more details. -if BOARD_EMULATION_SPIKE_UCB_RISCV +if BOARD_EMULATION_SPIKE_RISCV config BOARD_SPECIFIC_OPTIONS # dummy def_bool y @@ -33,8 +33,4 @@ int default 1 -config MAINBOARD_VENDOR - string - default "UCB" - -endif # BOARD_EMULATION_SPIKE_UCB_RISCV +endif # BOARD_EMULATION_SPIKE_RISCV diff --git a/src/mainboard/emulation/spike-riscv/Kconfig.name b/src/mainboard/emulation/spike-riscv/Kconfig.name index 2869425..3a82ab1 100644 --- a/src/mainboard/emulation/spike-riscv/Kconfig.name +++ b/src/mainboard/emulation/spike-riscv/Kconfig.name @@ -1,5 +1,5 @@ -config BOARD_EMULATION_SPIKE_UCB_RISCV - bool "SPIKE ucb riscv" +config BOARD_EMULATION_SPIKE_RISCV + bool "SPIKE riscv" help To run coreboot in spike: * run "make" as usual -- To view, visit https://review.coreboot.org/28951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I301d9d0091a714e62375052e5af06a9197876688 Gerrit-Change-Number: 28951 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Nico Huber (Code Review) 06 Oct '18

06 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 2: >> Patch Set 2: >> >> I'm not sure about the name, aren't there competing FHD mods available? > > There is a similiar module, but it even might work the same way. Or > should I name the exact name? Hmm, does it use the 3rd DP (DP-D) as well? Then it shouldn't matter indeed. -- To view, visit https://review.coreboot.org/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 06 Oct 2018 11:43:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Alexander Couzens (Code Review) 06 Oct '18

06 Oct '18

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 2: > Patch Set 2: > > I'm not sure about the name, aren't there competing FHD mods available? There is a similiar module, but it even might work the same way. Or should I name the exact name? -- To view, visit https://review.coreboot.org/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 06 Oct 2018 11:27:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Nico Huber (Code Review) 06 Oct '18

06 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 2: I'm not sure about the name, aren't there competing FHD mods available? -- To view, visit https://review.coreboot.org/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 06 Oct 2018 11:22:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Nico Huber (Code Review) 06 Oct '18

06 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/28950/2//COMMIT_MSG Commit Message: PS2: Please mention what panel you tested. Without proper panel power sequencing (which libgfxinit lacks atm for DP-D) it likely only works by chance. -- To view, visit https://review.coreboot.org/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 06 Oct 2018 11:21:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Alexander Couzens (Code Review) 06 Oct '18

06 Oct '18

Alexander Couzens has uploaded a new patch set (#2). ( https://review.coreboot.org/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... lenovo/x230: introduce FHD variant The FHD (Full HD mod) is a modification to the x230 which uses the 2nd DP from the dock connector as internal display connection. Further the old LVDS based display can be replaced with an eDP. When using the FHD, the LVDS connector should be disabled in libgfxinit. Further modifing of the VBT allows to make the brightness works out of the box. The VBT has been modified by: - removing LVDS port - move 3rd DP (which is the 2nd DP from Dock) to the first connector in the list - set the 3rd DP as internal connected Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> --- M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name M src/mainboard/lenovo/x230/Makefile.inc R src/mainboard/lenovo/x230/variants/x230/data.vbt R src/mainboard/lenovo/x230/variants/x230/gma-mainboard.ads A src/mainboard/lenovo/x230/variants/x230fhd/data.vbt A src/mainboard/lenovo/x230/variants/x230fhd/gma-mainboard.ads 7 files changed, 44 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/28950/2 -- To view, visit https://review.coreboot.org/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>

1 0

Change in coreboot[master]: lenovo/x230: introduce variant FHD
by Alexander Couzens (Code Review) 06 Oct '18

06 Oct '18

Alexander Couzens has uploaded this change for review. ( https://review.coreboot.org/28950 Change subject: lenovo/x230: introduce variant FHD ...................................................................... lenovo/x230: introduce variant FHD The FHD (Full HD mod) is a modification to the x230 which uses the 2nd DP from the dock connector as internal display connection. Further the old LVDS based display can be replaced with an eDP. When using the FHD, the LVDS connector should be disabled in libgfxinit. Further modifing of the VBT allows to make the brightness works out of the box. The VBT has been modified by: - removing LVDS port - move 3rd DP (which is the 2nd DP from Dock) to the first connector in the list - set the 3rd DP as internal connected Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> --- M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name M src/mainboard/lenovo/x230/Makefile.inc R src/mainboard/lenovo/x230/variants/x230/data.vbt R src/mainboard/lenovo/x230/variants/x230/gma-mainboard.ads A src/mainboard/lenovo/x230/variants/x230fhd/data.vbt A src/mainboard/lenovo/x230/variants/x230fhd/gma-mainboard.ads 7 files changed, 44 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/28950/1 diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index 2725dcd..276754d 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -1,4 +1,4 @@ -if BOARD_LENOVO_X230 +if BOARD_LENOVO_X230 || BOARD_LENOVO_X230_FHD config BOARD_SPECIFIC_OPTIONS # dummy def_bool y @@ -63,4 +63,9 @@ hex default 0x21fa -endif # BOARD_LENOVO_X230 +config VARIANT_DIR + string + default "x230fhd" if BOARD_LENOVO_X230_FHD + default "x230" if BOARD_LENOVO_X230 + +endif # BOARD_LENOVO_X230 || BOARD_LENOVO_X230_FHD diff --git a/src/mainboard/lenovo/x230/Kconfig.name b/src/mainboard/lenovo/x230/Kconfig.name index d207653..e8e1032 100644 --- a/src/mainboard/lenovo/x230/Kconfig.name +++ b/src/mainboard/lenovo/x230/Kconfig.name @@ -1,2 +1,5 @@ config BOARD_LENOVO_X230 bool "ThinkPad X230" + +config BOARD_LENOVO_X230_FHD + bool "ThinkPad X230 Full HD mod" diff --git a/src/mainboard/lenovo/x230/Makefile.inc b/src/mainboard/lenovo/x230/Makefile.inc index 2dab950..b47278d 100644 --- a/src/mainboard/lenovo/x230/Makefile.inc +++ b/src/mainboard/lenovo/x230/Makefile.inc @@ -16,4 +16,4 @@ smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c romstage-y += gpio.c -ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads +ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += variants/$(VARIANT_DIR)/gma-mainboard.ads diff --git a/src/mainboard/lenovo/x230/data.vbt b/src/mainboard/lenovo/x230/variants/x230/data.vbt similarity index 100% rename from src/mainboard/lenovo/x230/data.vbt rename to src/mainboard/lenovo/x230/variants/x230/data.vbt Binary files differ diff --git a/src/mainboard/lenovo/x230/gma-mainboard.ads b/src/mainboard/lenovo/x230/variants/x230/gma-mainboard.ads similarity index 100% rename from src/mainboard/lenovo/x230/gma-mainboard.ads rename to src/mainboard/lenovo/x230/variants/x230/gma-mainboard.ads diff --git a/src/mainboard/lenovo/x230/variants/x230fhd/data.vbt b/src/mainboard/lenovo/x230/variants/x230fhd/data.vbt new file mode 100644 index 0000000..1aaf542 --- /dev/null +++ b/src/mainboard/lenovo/x230/variants/x230fhd/data.vbt Binary files differ diff --git a/src/mainboard/lenovo/x230/variants/x230fhd/gma-mainboard.ads b/src/mainboard/lenovo/x230/variants/x230fhd/gma-mainboard.ads new file mode 100644 index 0000000..816a87d --- /dev/null +++ b/src/mainboard/lenovo/x230/variants/x230fhd/gma-mainboard.ads @@ -0,0 +1,33 @@ +-- +-- This file is part of the coreboot project. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 2 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- + +with HW.GFX.GMA; +with HW.GFX.GMA.Display_Probing; + +use HW.GFX.GMA; +use HW.GFX.GMA.Display_Probing; + +private package GMA.Mainboard is + + ports : constant Port_List := + (DP1, + DP2, + DP3, + HDMI1, + HDMI2, + HDMI3, + Analog, + others => Disabled); + +end GMA.Mainboard; -- To view, visit https://review.coreboot.org/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>

1 0

Change in coreboot[master]: soc/intel/common/block/pcr: Add NULL pointer check in pcr_execute_sid...
by Subrata Banik (Code Review) 06 Oct '18

06 Oct '18

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/28949 Change subject: soc/intel/common/block/pcr: Add NULL pointer check in pcr_execute_sideband_msg() ...................................................................... soc/intel/common/block/pcr: Add NULL pointer check in pcr_execute_sideband_msg() This patch to fix KW issue due to msg, data and response pointers NULL check fail. Change-Id: I39324514079f240ba1683a04e579de85485299bf Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/common/block/pcr/pcr.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/28949/1 diff --git a/src/soc/intel/common/block/pcr/pcr.c b/src/soc/intel/common/block/pcr/pcr.c index b8d798f..024059a 100644 --- a/src/soc/intel/common/block/pcr/pcr.c +++ b/src/soc/intel/common/block/pcr/pcr.c @@ -263,7 +263,10 @@ uint16_t sbi_status; uint16_t sbi_rid; - assert(msg && data && response); + if (!msg || !data || !response) { + die("Pointer msg/ data/ response checked for NULL Fail!"); + return -1; + } switch (msg->opcode) { case MEM_READ: -- To view, visit https://review.coreboot.org/28949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I39324514079f240ba1683a04e579de85485299bf Gerrit-Change-Number: 28949 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2018