coreboot-gerrit October 2018

coreboot-gerrit@coreboot.org

1 participants
1285 discussions

Change in coreboot[master]: treewide: use /usr/bin/env where appropriate
by Angel Pons (Code Review) 07 Oct '18

07 Oct '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28953 ) Change subject: treewide: use /usr/bin/env where appropriate ...................................................................... Patch Set 1: (3 comments) https://review.coreboot.org/#/c/28953/1/util/amdtools/k8-compare-pci-space.… File util/amdtools/k8-compare-pci-space.pl: https://review.coreboot.org/#/c/28953/1/util/amdtools/k8-compare-pci-space.… PS1, Line 5: use warnings; Why has this been added? https://review.coreboot.org/#/c/28953/1/util/chromeos/extract_blobs.sh File util/chromeos/extract_blobs.sh: https://review.coreboot.org/#/c/28953/1/util/chromeos/extract_blobs.sh@17 PS1, Line 17: set -x What is this for? https://review.coreboot.org/#/c/28953/1/util/ipqheader/mbn_tools.py File util/ipqheader/mbn_tools.py: https://review.coreboot.org/#/c/28953/1/util/ipqheader/mbn_tools.py@1 PS1, Line 1: #!/usr/bin/env python This resolves to Python 3 in my system (Arch Linux), but this script seems Python 2 (I get syntax errors not present when explicitly invoking Python 2)... There are other Python scripts which may fail as well. -- To view, visit https://review.coreboot.org/28953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7546bcb881c532adc984577ecb0ee2ec4f2efe00 Gerrit-Change-Number: 28953 Gerrit-PatchSet: 1 Gerrit-Owner: Yegor Timoshenko <yegortimoshenko(a)riseup.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 07 Oct 2018 11:29:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Patrick Rudolph (Code Review) 07 Oct '18

07 Oct '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 3: Code-Review+1 Please add documentation explaining the variants and how the FHD mod works. -- To view, visit https://review.coreboot.org/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 3 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sun, 07 Oct 2018 09:20:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: No need to include acpi_tables.c to Makefiles
by Peter Lemenkov (Code Review) 07 Oct '18

07 Oct '18

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/28954 Change subject: No need to include acpi_tables.c to Makefiles ...................................................................... No need to include acpi_tables.c to Makefiles It always included if ACP is supported since commit 822bc65b0e8cb9c17721b8b776ec7ecf6ac4129e. Change-Id: If17a6f43e368ccf850031b349714fa1ec4d02c1d Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com> --- M src/mainboard/compulab/intense_pc/Makefile.inc M src/mainboard/intel/harcuvar/Makefile.inc M src/mainboard/lenovo/l520/Makefile.inc M src/mainboard/lenovo/t430/Makefile.inc M src/mainboard/scaleway/tagada/Makefile.inc 5 files changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/28954/1 diff --git a/src/mainboard/compulab/intense_pc/Makefile.inc b/src/mainboard/compulab/intense_pc/Makefile.inc index ed24e18..3dae61e 100644 --- a/src/mainboard/compulab/intense_pc/Makefile.inc +++ b/src/mainboard/compulab/intense_pc/Makefile.inc @@ -1,2 +1 @@ romstage-y += gpio.c -ramstage-y += acpi_tables.c diff --git a/src/mainboard/intel/harcuvar/Makefile.inc b/src/mainboard/intel/harcuvar/Makefile.inc index d100688..271a577 100644 --- a/src/mainboard/intel/harcuvar/Makefile.inc +++ b/src/mainboard/intel/harcuvar/Makefile.inc @@ -22,7 +22,6 @@ ramstage-y += ramstage.c ramstage-y += boardid.c ramstage-y += hsio.c -ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c CPPFLAGS_common += -Isrc/mainboard/$(MAINBOARDDIR)/ diff --git a/src/mainboard/lenovo/l520/Makefile.inc b/src/mainboard/lenovo/l520/Makefile.inc index 892c815..5331f25 100644 --- a/src/mainboard/lenovo/l520/Makefile.inc +++ b/src/mainboard/lenovo/l520/Makefile.inc @@ -15,5 +15,4 @@ romstage-y += romstage.c romstage-y += gpio.c -ramstage-y += acpi_tables.c smm-y += smihandler.c diff --git a/src/mainboard/lenovo/t430/Makefile.inc b/src/mainboard/lenovo/t430/Makefile.inc index 794b5cd..558ab0a 100644 --- a/src/mainboard/lenovo/t430/Makefile.inc +++ b/src/mainboard/lenovo/t430/Makefile.inc @@ -1,6 +1,5 @@ romstage-y += romstage.c romstage-y += gpio.c -ramstage-y += acpi_tables.c smm-y += smihandler.c ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads diff --git a/src/mainboard/scaleway/tagada/Makefile.inc b/src/mainboard/scaleway/tagada/Makefile.inc index 7d426df..c33e993 100644 --- a/src/mainboard/scaleway/tagada/Makefile.inc +++ b/src/mainboard/scaleway/tagada/Makefile.inc @@ -20,7 +20,6 @@ ramstage-y += ramstage.c ramstage-y += hsio.c -ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c bootblock-y += bmcinfo.c -- To view, visit https://review.coreboot.org/28954 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If17a6f43e368ccf850031b349714fa1ec4d02c1d Gerrit-Change-Number: 28954 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com>

1 0

Change in coreboot[master]: soc/intel/common/block/pcr: Add NULL pointer check in pcr_execute_sid...
by build bot (Jenkins) (Code Review) 07 Oct '18

07 Oct '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28949 ) Change subject: soc/intel/common/block/pcr: Add NULL pointer check in pcr_execute_sideband_msg() ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/28949/2/src/soc/intel/common/block/pcr/pcr.c File src/soc/intel/common/block/pcr/pcr.c: https://review.coreboot.org/#/c/28949/2/src/soc/intel/common/block/pcr/pcr.… PS2, Line 267: printk(BIOS_ERR, "Pointer checked for NULL Fail! " \ Avoid unnecessary line continuations -- To view, visit https://review.coreboot.org/28949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39324514079f240ba1683a04e579de85485299bf Gerrit-Change-Number: 28949 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Sun, 07 Oct 2018 04:01:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: treewide: use /usr/bin/env where appropriate
by Yegor Timoshenko (Code Review) 07 Oct '18

07 Oct '18

Yegor Timoshenko has uploaded this change for review. ( https://review.coreboot.org/28953 Change subject: treewide: use /usr/bin/env where appropriate ...................................................................... treewide: use /usr/bin/env where appropriate Some Unix systems (GuixSD, NixOS) do not install programs like Bash and Python to /usr/bin, and /usr/bin/env has to be used to locate these instead. Change-Id: I7546bcb881c532adc984577ecb0ee2ec4f2efe00 Signed-off-by: Yegor Timoshenko <yegortimoshenko(a)riseup.net> --- M util/acpi/acpidump-all M util/amdtools/k8-compare-pci-space.pl M util/amdtools/k8-interpret-extended-memory-settings.pl M util/amdtools/k8-read-mem-settings.sh M util/amdtools/parse-bkdg.pl M util/board_status/set_up_live_image.sh M util/broadcom/secimage/test/hmac.sh M util/cavium/devicetree_convert.py M util/cbfstool/Makefile M util/cbmem/Makefile M util/chromeos/crosfirmware.sh M util/chromeos/extract_blobs.sh M util/ectool/Makefile M util/genprof/log2dress M util/gitconfig/gitconfig.sh M util/ifdtool/Makefile M util/intelmetool/Makefile M util/inteltool/Makefile M util/ipqheader/createxbl.py M util/ipqheader/mbn_tools.py M util/k8resdump/Makefile M util/kconfig/miniconfig M util/lint/check_lint_tests M util/lint/checkpatch_json.py M util/lint/kconfig_lint M util/me_cleaner/me_cleaner.py M util/me_cleaner/setup.py M util/mma/mma_automated_test.sh M util/mma/mma_get_result.sh M util/mma/mma_setup_test.sh M util/nvramtool/Makefile M util/pmh7tool/Makefile M util/release/build-release M util/release/genrelnotes M util/riscv/sifive-gpt.py M util/scripts/config M util/scripts/dts-to-fmd.sh M util/scripts/gerrit-rebase M util/scripts/get_maintainer.pl M util/scripts/parse-maintainers.pl M util/scripts/prepare-commit-msg.clang-format M util/scripts/ucode_h_to_bin.sh M util/scripts/update_submodules M util/superiotool/Makefile M util/util_readme/util_readme.sh M util/viatool/Makefile 46 files changed, 53 insertions(+), 46 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/28953/1 diff --git a/util/acpi/acpidump-all b/util/acpi/acpidump-all index 2a04af0..f43b7ef 100755 --- a/util/acpi/acpidump-all +++ b/util/acpi/acpidump-all @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # Copyright (C) 2007-2010 by coresystems GmbH # diff --git a/util/amdtools/k8-compare-pci-space.pl b/util/amdtools/k8-compare-pci-space.pl index 77fdb59..505d5b4 100755 --- a/util/amdtools/k8-compare-pci-space.pl +++ b/util/amdtools/k8-compare-pci-space.pl @@ -1,7 +1,8 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl use Getopt::Long; use strict; +use warnings; my $NAME = $0; my $VERSION = '0.01'; diff --git a/util/amdtools/k8-interpret-extended-memory-settings.pl b/util/amdtools/k8-interpret-extended-memory-settings.pl index 176defc..104e669 100755 --- a/util/amdtools/k8-interpret-extended-memory-settings.pl +++ b/util/amdtools/k8-interpret-extended-memory-settings.pl @@ -1,7 +1,8 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl use Getopt::Long; use strict; +use warnings; my $NAME = $0; my $VERSION = '0.01'; diff --git a/util/amdtools/k8-read-mem-settings.sh b/util/amdtools/k8-read-mem-settings.sh index a0e6254..55b7071 100755 --- a/util/amdtools/k8-read-mem-settings.sh +++ b/util/amdtools/k8-read-mem-settings.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # This is an example that generates data files that are understood by the # k8-interpret-extended-memory-settings.pl script. Adjust the pci ids for your diff --git a/util/amdtools/parse-bkdg.pl b/util/amdtools/parse-bkdg.pl index d0bb4c7..31f3873 100755 --- a/util/amdtools/parse-bkdg.pl +++ b/util/amdtools/parse-bkdg.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl my $NAME = $0; my $VERSION = '0.01'; @@ -11,6 +11,7 @@ my $DEBUG = 0; use strict; +use warnings; # Run the bkdg for k8 through pdftotext first (from the poppler package) diff --git a/util/board_status/set_up_live_image.sh b/util/board_status/set_up_live_image.sh index d80434e..9fac153 100755 --- a/util/board_status/set_up_live_image.sh +++ b/util/board_status/set_up_live_image.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # This script is used to set up a ubuntu-based live image to be used # with coreboot's board_status script. It modifies the system so that diff --git a/util/broadcom/secimage/test/hmac.sh b/util/broadcom/secimage/test/hmac.sh index 21176bd..ded0eb7 100755 --- a/util/broadcom/secimage/test/hmac.sh +++ b/util/broadcom/secimage/test/hmac.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash ## ## This file is part of the coreboot project. diff --git a/util/cavium/devicetree_convert.py b/util/cavium/devicetree_convert.py index 70d89af..656fdf6 100644 --- a/util/cavium/devicetree_convert.py +++ b/util/cavium/devicetree_convert.py @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/env python # devicetree_convert Tool to convert a DTB to a static C file # Copyright (C) 2018 Facebook Inc. diff --git a/util/cbfstool/Makefile b/util/cbfstool/Makefile index ba8fdff..365641b 100644 --- a/util/cbfstool/Makefile +++ b/util/cbfstool/Makefile @@ -6,7 +6,7 @@ HOSTCC ?= $(CC) PREFIX ?= /usr/local BINDIR ?= $(PREFIX)/bin -INSTALL ?= /usr/bin/install +INSTALL ?= /usr/bin/env install OBJCOPY ?= objcopy VBOOT_SOURCE ?= $(top)/3rdparty/vboot diff --git a/util/cbmem/Makefile b/util/cbmem/Makefile index 694cac7..664d575 100644 --- a/util/cbmem/Makefile +++ b/util/cbmem/Makefile @@ -16,7 +16,7 @@ PROGRAM = cbmem ROOT = ../../src CC ?= $(CROSS_COMPILE)gcc -INSTALL ?= /usr/bin/install +INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local CFLAGS ?= -O2 CFLAGS += -Wall -Werror diff --git a/util/chromeos/crosfirmware.sh b/util/chromeos/crosfirmware.sh index 9e00ba6..ba0c259 100755 --- a/util/chromeos/crosfirmware.sh +++ b/util/chromeos/crosfirmware.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # This file is part of the coreboot project. # diff --git a/util/chromeos/extract_blobs.sh b/util/chromeos/extract_blobs.sh index af9d026..a674ada 100755 --- a/util/chromeos/extract_blobs.sh +++ b/util/chromeos/extract_blobs.sh @@ -1,4 +1,4 @@ -#!/bin/bash -x +#!/usr/bin/env bash # # This file is part of the coreboot project. # @@ -14,6 +14,8 @@ # GNU General Public License for more details. # +set -x + IMAGE=$1 if [ ! -r "$IMAGE" ]; then diff --git a/util/ectool/Makefile b/util/ectool/Makefile index 234e931..c4b94da 100644 --- a/util/ectool/Makefile +++ b/util/ectool/Makefile @@ -17,7 +17,7 @@ CC = gcc CFLAGS = -O2 -Wall -W PROGRAM = ectool -INSTALL = /usr/bin/install +INSTALL = /usr/bin/env install PREFIX = /usr/local OS_ARCH = $(shell uname) diff --git a/util/genprof/log2dress b/util/genprof/log2dress index 99d1f2f..a7ec4bf 100755 --- a/util/genprof/log2dress +++ b/util/genprof/log2dress @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash #Parse a log and get back the function names and line numbers #Provide a log file as first argument diff --git a/util/gitconfig/gitconfig.sh b/util/gitconfig/gitconfig.sh index 5d6fe36..4df93cf 100755 --- a/util/gitconfig/gitconfig.sh +++ b/util/gitconfig/gitconfig.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash ## ## This file is part of the coreboot project. diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index cf6d378..e1188b2 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -16,7 +16,7 @@ PROGRAM = ifdtool CC = gcc -INSTALL = /usr/bin/install +INSTALL = /usr/bin/env install PREFIX = /usr/local CFLAGS = -O2 -g -Wall -W -Werror -I../../src/commonlib/include LDFLAGS = diff --git a/util/intelmetool/Makefile b/util/intelmetool/Makefile index d8c056c..128c1fe 100644 --- a/util/intelmetool/Makefile +++ b/util/intelmetool/Makefile @@ -15,7 +15,7 @@ PROGRAM = intelmetool CC ?= gcc -INSTALL ?= /usr/bin/install +INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local CFLAGS ?= -O0 -g -Wall -W -Wno-unused-parameter -Wno-sign-compare -Wno-unused-function LDFLAGS += -lpci -lz diff --git a/util/inteltool/Makefile b/util/inteltool/Makefile index 96fd140..d88063b 100644 --- a/util/inteltool/Makefile +++ b/util/inteltool/Makefile @@ -20,7 +20,7 @@ top ?= $(abspath ../..) CC ?= gcc -INSTALL ?= /usr/bin/install +INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local CFLAGS ?= -O2 -g -Wall -W LDFLAGS += -lpci -lz diff --git a/util/ipqheader/createxbl.py b/util/ipqheader/createxbl.py index b01e628..7f2d987 100755 --- a/util/ipqheader/createxbl.py +++ b/util/ipqheader/createxbl.py @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/env python #============================================================================ # #/** @file createxbl.py diff --git a/util/ipqheader/mbn_tools.py b/util/ipqheader/mbn_tools.py index c4d26c1..8a17563 100755 --- a/util/ipqheader/mbn_tools.py +++ b/util/ipqheader/mbn_tools.py @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/env python #=============================================================================== # # MBN TOOLS diff --git a/util/k8resdump/Makefile b/util/k8resdump/Makefile index e260351..a1d4dfa 100644 --- a/util/k8resdump/Makefile +++ b/util/k8resdump/Makefile @@ -16,7 +16,7 @@ PROGRAM = k8resdump CC = gcc -INSTALL = /usr/bin/install +INSTALL = /usr/bin/env install PREFIX = /usr/local #CFLAGS = -O2 -g -Wall -Werror CFLAGS = -Os -Wall -Werror diff --git a/util/kconfig/miniconfig b/util/kconfig/miniconfig index 065a784..29a4035 100755 --- a/util/kconfig/miniconfig +++ b/util/kconfig/miniconfig @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # miniconfig - utility to minimize your coreboot config files # diff --git a/util/lint/check_lint_tests b/util/lint/check_lint_tests index 741d245..5ba33c8 100755 --- a/util/lint/check_lint_tests +++ b/util/lint/check_lint_tests @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # test to make sure the lint tests fail SPACE=' ' diff --git a/util/lint/checkpatch_json.py b/util/lint/checkpatch_json.py index 44b2a8b..74ad96a 100755 --- a/util/lint/checkpatch_json.py +++ b/util/lint/checkpatch_json.py @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/env python # Copyright (C) 2018 Intel Corporation. # written by Naresh G Solanki<naresh.solanki(a)intel.com> and # Maulik V Vaghela <maulik.v.vaghela(a)intel.com> diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 62997dd..eddd8de 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -1,4 +1,4 @@ -#!/usr/bin/perl +#!/usr/bin/env perl # # This file is part of the coreboot project. diff --git a/util/me_cleaner/me_cleaner.py b/util/me_cleaner/me_cleaner.py index 03fbbcb..f592863 100755 --- a/util/me_cleaner/me_cleaner.py +++ b/util/me_cleaner/me_cleaner.py @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/env python # me_cleaner - Tool for partial deblobbing of Intel ME/TXE firmware images # Copyright (C) 2016-2018 Nicola Corna <nicola(a)corna.info> diff --git a/util/me_cleaner/setup.py b/util/me_cleaner/setup.py index 92fd359..c831ef8 100755 --- a/util/me_cleaner/setup.py +++ b/util/me_cleaner/setup.py @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/env python from setuptools import setup diff --git a/util/mma/mma_automated_test.sh b/util/mma/mma_automated_test.sh index b43325b..1c324f3 100755 --- a/util/mma/mma_automated_test.sh +++ b/util/mma/mma_automated_test.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # This file is part of the coreboot project. diff --git a/util/mma/mma_get_result.sh b/util/mma/mma_get_result.sh index cb30a80..f797e7f 100755 --- a/util/mma/mma_get_result.sh +++ b/util/mma/mma_get_result.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # This file is part of the coreboot project. diff --git a/util/mma/mma_setup_test.sh b/util/mma/mma_setup_test.sh index ec7baf9..b2a0de9 100755 --- a/util/mma/mma_setup_test.sh +++ b/util/mma/mma_setup_test.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # This file is part of the coreboot project. diff --git a/util/nvramtool/Makefile b/util/nvramtool/Makefile index 8da7c76..f5a4fd5 100644 --- a/util/nvramtool/Makefile +++ b/util/nvramtool/Makefile @@ -17,7 +17,7 @@ PROGRAM = nvramtool CC = gcc -INSTALL = /usr/bin/install +INSTALL = /usr/bin/env install PREFIX = /usr/local CFLAGS = -O2 -g -Wall -W -I. -DCMOS_HAL=1 #CFLAGS = -Os -Wall diff --git a/util/pmh7tool/Makefile b/util/pmh7tool/Makefile index 091fbc5..384d3d9 100644 --- a/util/pmh7tool/Makefile +++ b/util/pmh7tool/Makefile @@ -16,7 +16,7 @@ CC = gcc CFLAGS = -O2 -Wall -W -Werror PROGRAM = pmh7tool -INSTALL = /usr/bin/install +INSTALL = /usr/bin/env install PREFIX = /usr/local all: $(PROGRAM) diff --git a/util/release/build-release b/util/release/build-release index a3cec3e..e4330d4 100755 --- a/util/release/build-release +++ b/util/release/build-release @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # ${VERSION_NAME}: new version name # ${COMMIT_ID}: commit id (if not master) # ${USERNAME}: username (if not default to https) diff --git a/util/release/genrelnotes b/util/release/genrelnotes index 3038eb3..42848a1 100755 --- a/util/release/genrelnotes +++ b/util/release/genrelnotes @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # This file is part of the coreboot project. # diff --git a/util/riscv/sifive-gpt.py b/util/riscv/sifive-gpt.py index fd82997..7f522d9 100755 --- a/util/riscv/sifive-gpt.py +++ b/util/riscv/sifive-gpt.py @@ -1,4 +1,4 @@ -#!/usr/bin/python3 +#!/usr/bin/env python3 # This file is part of the coreboot project. # # Copyright (C) 2018 Jonathan Neuschäfer diff --git a/util/scripts/config b/util/scripts/config index e0e3982..ba11e35 100755 --- a/util/scripts/config +++ b/util/scripts/config @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # SPDX-License-Identifier: GPL-2.0 # Manipulate options in a .config file from the command line diff --git a/util/scripts/dts-to-fmd.sh b/util/scripts/dts-to-fmd.sh index 00e718be..b468b35 100755 --- a/util/scripts/dts-to-fmd.sh +++ b/util/scripts/dts-to-fmd.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # Copyright 2015 Google Inc. # diff --git a/util/scripts/gerrit-rebase b/util/scripts/gerrit-rebase index c4f8a80..276142d 100755 --- a/util/scripts/gerrit-rebase +++ b/util/scripts/gerrit-rebase @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # Copyright 2016 Google Inc. # diff --git a/util/scripts/get_maintainer.pl b/util/scripts/get_maintainer.pl index 4f34a4e..c24a6d4 100755 --- a/util/scripts/get_maintainer.pl +++ b/util/scripts/get_maintainer.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl # (c) 2007, Joe Perches <joe(a)perches.com> # created from checkpatch.pl # @@ -11,6 +11,7 @@ # Licensed under the terms of the GNU GPL License version 2 use strict; +use warnings; my $P = $0; my $V = '0.26'; diff --git a/util/scripts/parse-maintainers.pl b/util/scripts/parse-maintainers.pl index a0fe343..c0fd88c 100755 --- a/util/scripts/parse-maintainers.pl +++ b/util/scripts/parse-maintainers.pl @@ -1,6 +1,7 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl use strict; +use warnings; my %map; diff --git a/util/scripts/prepare-commit-msg.clang-format b/util/scripts/prepare-commit-msg.clang-format index 7033f3c..a6b3d08 100755 --- a/util/scripts/prepare-commit-msg.clang-format +++ b/util/scripts/prepare-commit-msg.clang-format @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash files=`git diff --cached --name-only | grep '\.[ch]$'` if [ -z "$files" ]; then exit 0 diff --git a/util/scripts/ucode_h_to_bin.sh b/util/scripts/ucode_h_to_bin.sh index 2d7f5fa..f08b053 100755 --- a/util/scripts/ucode_h_to_bin.sh +++ b/util/scripts/ucode_h_to_bin.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # This file is part of the coreboot project. # diff --git a/util/scripts/update_submodules b/util/scripts/update_submodules index b555495..68d8a94 100755 --- a/util/scripts/update_submodules +++ b/util/scripts/update_submodules @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # This file is part of the coreboot project. # diff --git a/util/superiotool/Makefile b/util/superiotool/Makefile index cedd631..3a0bcf0 100644 --- a/util/superiotool/Makefile +++ b/util/superiotool/Makefile @@ -17,7 +17,7 @@ PROGRAM = superiotool CC ?= gcc -INSTALL ?= /usr/bin/install +INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local # Set the superiotool version string to the output of 'git describe'. diff --git a/util/util_readme/util_readme.sh b/util/util_readme/util_readme.sh index 420ffae..cdd94dc 100755 --- a/util/util_readme/util_readme.sh +++ b/util/util_readme/util_readme.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # Creates `./util/README.md` and `./Documentation/Util.md` of description files # in `./util` subdirectories diff --git a/util/viatool/Makefile b/util/viatool/Makefile index 365497a..b2a6291 100644 --- a/util/viatool/Makefile +++ b/util/viatool/Makefile @@ -19,7 +19,7 @@ PROGRAM = viatool CC ?= gcc -INSTALL ?= /usr/bin/install +INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local CFLAGS ?= -O2 -g -Wall -W -I$(CURDIR) LDFLAGS += -lpci -lz -- To view, visit https://review.coreboot.org/28953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7546bcb881c532adc984577ecb0ee2ec4f2efe00 Gerrit-Change-Number: 28953 Gerrit-PatchSet: 1 Gerrit-Owner: Yegor Timoshenko <yegortimoshenko(a)riseup.net>

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Alexander Couzens (Code Review) 06 Oct '18

06 Oct '18

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 3: > Patch Set 3: Code-Review+1 > > I might be bikeshedding, but I think the folder name "x230fhd" is a bit hard to read. I'd use "x230-fhd" or "x230_fhd" instead, just like the macro names and topic on gerrit. I would then rename it to oem and fhd as variant -- To view, visit https://review.coreboot.org/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 3 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 06 Oct 2018 17:32:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/i945: Check if IGD is enabled before R/W to dev(0, 2)
by Elyes HAOUAS (Code Review) 06 Oct '18

06 Oct '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28935 ) Change subject: nb/i945: Check if IGD is enabled before R/W to dev(0, 2) ...................................................................... Patch Set 1: Code-Review-1 (3 comments) I do not have a datasheet, but, if I'm not wrong, using r2 on vendor bios of d945gclf (supported board), it seems making a test before writing : MEMORY[0xFED14F08] |= 0x6000u; MEMORY[0xFED14F0A] |= 0x6000u; MEMORY[0xFED14F0C] |= 0x6000u; https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c: https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.… PS1, Line 2151: here by default, IGD is "enabled" even if it is not (case we use an external GPU for example) https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.… PS1, Line 2306: : : : as we have : "int integrated_graphics = 1;" this will never happen even if IGD is disabled https://review.coreboot.org/#/c/28935/1/src/northbridge/intel/i945/raminit.… PS1, Line 2317: : : this will never happen -- To view, visit https://review.coreboot.org/28935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ab94393710ce0222b353ab0cef28621fafaacf Gerrit-Change-Number: 28935 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 06 Oct 2018 15:51:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Documentation/mb/sifive: Fix dead links
by Angel Pons (Code Review) 06 Oct '18

06 Oct '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28952 ) Change subject: Documentation/mb/sifive: Fix dead links ...................................................................... Patch Set 1: Code-Review+2 Looks good -- To view, visit https://review.coreboot.org/28952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I312de84bf12abb0789bdd971c40033f1e4ea0dd1 Gerrit-Change-Number: 28952 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 06 Oct 2018 14:50:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Angel Pons (Code Review) 06 Oct '18

06 Oct '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 3: Code-Review+1 I might be bikeshedding, but I think the folder name "x230fhd" is a bit hard to read. I'd use "x230-fhd" or "x230_fhd" instead, just like the macro names and topic on gerrit. -- To view, visit https://review.coreboot.org/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 3 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 06 Oct 2018 14:48:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Angel Pons (Code Review) 06 Oct '18

06 Oct '18

Angel Pons has uploaded a new patch set (#3) to the change originally created by Alexander Couzens. ( https://review.coreboot.org/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... lenovo/x230: introduce FHD variant There is a modification for the x230 which uses the 2nd DP from the dock as the integrated panel's connection, which allows using a Full HD (FHD) eDP panel instead of the stock LVDS display. To make this work with coreboot, the internal LVDS connector should be disabled in libgfxinit. The VBT has been modified as well, which allows brightness controls to work out of the box. The modifications done to the VBT are: - Remove the LVDS port entry. - Move the DP-3 (which is the 2nd DP on the dock) entry to the first position on the list. - Set the DP-3 as internally connected. Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> --- M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name M src/mainboard/lenovo/x230/Makefile.inc R src/mainboard/lenovo/x230/variants/x230/data.vbt R src/mainboard/lenovo/x230/variants/x230/gma-mainboard.ads A src/mainboard/lenovo/x230/variants/x230fhd/data.vbt A src/mainboard/lenovo/x230/variants/x230fhd/gma-mainboard.ads 7 files changed, 44 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/28950/3 -- To view, visit https://review.coreboot.org/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 3 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2018