coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 45: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61120/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16288/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 45 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 15:51:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Enable SSE
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21697 ) Change subject: soc/amd/stoneyridge: Enable SSE ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61116/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16284/ : SUCCESS -- To view, visit https://review.coreboot.org/21697 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c1aed9ecfa6f3496760dcda422ddf184e2a043c Gerrit-Change-Number: 21697 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 15:46:23 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Enable SSE
by Martin Roth (Code Review) 26 Sep '17

26 Sep '17

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/21697 Change subject: soc/amd/stoneyridge: Enable SSE ...................................................................... soc/amd/stoneyridge: Enable SSE Change-Id: I7c1aed9ecfa6f3496760dcda422ddf184e2a043c Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/soc/amd/stoneyridge/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/21697/1 diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig index f8768e7..62b0262 100644 --- a/src/soc/amd/stoneyridge/Kconfig +++ b/src/soc/amd/stoneyridge/Kconfig @@ -49,6 +49,8 @@ select SOC_AMD_COMMON_BLOCK_CAR select C_ENVIRONMENT_BOOTBLOCK select BOOTBLOCK_CONSOLE + select SSE + select SSE2 config VBOOT select AMDFW_OUTSIDE_CBFS -- To view, visit https://review.coreboot.org/21697 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7c1aed9ecfa6f3496760dcda422ddf184e2a043c Gerrit-Change-Number: 21697 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: mb/google/*: Use newly added Chrome EC boardid function
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21682 ) Change subject: mb/google/*: Use newly added Chrome EC boardid function ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61115/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16283/ : SUCCESS -- To view, visit https://review.coreboot.org/21682 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1671c0a0b87d0c4c45da5340e8f17a4a798317ca Gerrit-Change-Number: 21682 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 13:52:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Coral: Add Synaptics touchpad support
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21696 ) Change subject: Coral: Add Synaptics touchpad support ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61114/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16282/ : SUCCESS -- To view, visit https://review.coreboot.org/21696 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5a650338d5a7e6f01e9525d28588b871d390e50 Gerrit-Change-Number: 21696 Gerrit-PatchSet: 2 Gerrit-Owner: Peggy Chuang <peggychuang(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 13:20:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Coral: Add Synaptics touchpad support
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21696 ) Change subject: Coral: Add Synaptics touchpad support ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/61113/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/16281/ : SUCCESS -- To view, visit https://review.coreboot.org/21696 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5a650338d5a7e6f01e9525d28588b871d390e50 Gerrit-Change-Number: 21696 Gerrit-PatchSet: 1 Gerrit-Owner: Peggy Chuang <peggychuang(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 12:57:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Coral: Add Synaptics touchpad support
by Peggy Chuang (Code Review) 26 Sep '17

26 Sep '17

Peggy Chuang has uploaded this change for review. ( https://review.coreboot.org/21696 Change subject: Coral: Add Synaptics touchpad support ...................................................................... Coral: Add Synaptics touchpad support We need support two touchpad for Robo project, so adding Synaptices touchpad to coral. BUG=b:63134907 TEST=Compiled, verified by ODM Change-Id: If5a650338d5a7e6f01e9525d28588b871d390e50 Signed-off-by: Peggy Chuang <peggychuang(a)ami.corp-partner.google.com> --- M src/mainboard/google/reef/variants/coral/devicetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/21696/1 diff --git a/src/mainboard/google/reef/variants/coral/devicetree.cb b/src/mainboard/google/reef/variants/coral/devicetree.cb index 4f889d8..8208b10 100644 --- a/src/mainboard/google/reef/variants/coral/devicetree.cb +++ b/src/mainboard/google/reef/variants/coral/devicetree.cb @@ -205,6 +205,15 @@ register "probed" = "1" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_18_IRQ)" + register "generic.wake" = "GPE0_DW1_15" + register "generic.probed" = "1" + register "hid_dsc_reg_offset" = "0x20" + device i2c 0x2c on end + end end # - I2C 4 device pci 17.1 on chip drivers/i2c/hid -- To view, visit https://review.coreboot.org/21696 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If5a650338d5a7e6f01e9525d28588b871d390e50 Gerrit-Change-Number: 21696 Gerrit-PatchSet: 1 Gerrit-Owner: Peggy Chuang <peggychuang(a)ami.corp-partner.google.com>

1 0

Change in coreboot[master]: mainboard/google/soraka: Reduce Wacom resume time
by Sumeet R Pawnikar (Code Review) 26 Sep '17

26 Sep '17

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/21692 ) Change subject: mainboard/google/soraka: Reduce Wacom resume time ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/21692/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/soraka/devicetree.cb: https://review.coreboot.org/#/c/21692/1/src/mainboard/google/poppy/variants… PS1, Line 227: 10 Why can't we make this as 1 ? Any reason for setting as 10 ? As per the discussion on BUG, I feel we can set it to 1 ms. -- To view, visit https://review.coreboot.org/21692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59d070977a95316414018af69d5b43e3147ccf4e Gerrit-Change-Number: 21692 Gerrit-PatchSet: 1 Gerrit-Owner: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com> Gerrit-Reviewer: Anshuman Gupta <anshuman.gupta(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 12:26:35 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mainboard/google/soraka: Reduce Wacom resume time
by Furquan Shaikh (Code Review) 26 Sep '17

26 Sep '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/21692 ) Change subject: mainboard/google/soraka: Reduce Wacom resume time ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/21692/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/21692/1//COMMIT_MSG@21 PS1, Line 21: manual testing on Soraka board to ensue that touchscreen works at boot : and after suspend/resume. I think this change should be fine, but I have a few questions: 1. Did you timestamp the two points -- touchscreen device being taken out of reset and the first communication from the driver to the device? Can you please do it over multiple iterations to ensure that the delay is > 100ms? 2. If #1 is true, why even add a delay of 10ms? 3. What happens if suspend fails and system resumes mid-way i.e. suppose touchscreen device is suspended and then system starts resuming without completing the suspend? Can this lead to a race condition? -- To view, visit https://review.coreboot.org/21692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59d070977a95316414018af69d5b43e3147ccf4e Gerrit-Change-Number: 21692 Gerrit-PatchSet: 1 Gerrit-Owner: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com> Gerrit-Reviewer: Anshuman Gupta <anshuman.gupta(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.corp-partner.google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 12:17:46 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: siemens/nc_fpga: Move some parameters to another function
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21694 ) Change subject: siemens/nc_fpga: Move some parameters to another function ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61105/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16273/ : SUCCESS -- To view, visit https://review.coreboot.org/21694 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b8f770c768f3dacf96087eb0194cc99f0d11e17 Gerrit-Change-Number: 21694 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 11:47:00 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017