coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: siemens/nc_fpga: Move some parameters to another function
by Mario Scheithauer (Code Review) 26 Sep '17

26 Sep '17

Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/21694 Change subject: siemens/nc_fpga: Move some parameters to another function ...................................................................... siemens/nc_fpga: Move some parameters to another function For general use of this driver it is necessary to move some parameters from init_fan_ctrl() to init_temp_mon(). This shift does not lead to any functional change. Change-Id: I6b8f770c768f3dacf96087eb0194cc99f0d11e17 Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/drivers/siemens/nc_fpga/nc_fpga.c 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/21694/1 diff --git a/src/drivers/siemens/nc_fpga/nc_fpga.c b/src/drivers/siemens/nc_fpga/nc_fpga.c index 61d9e08..28fc6e2 100644 --- a/src/drivers/siemens/nc_fpga/nc_fpga.c +++ b/src/drivers/siemens/nc_fpga/nc_fpga.c @@ -53,6 +53,11 @@ } } ctrl->sensornum = num; + + /* Program sensor selection and temperature thresholds. */ + FPGA_SET_PARAM(FANSensorSelect, ctrl->sensorselect); + FPGA_SET_PARAM(T_Warn, ctrl->t_warn); + FPGA_SET_PARAM(T_Crit, ctrl->t_crit); } static void init_fan_ctrl (void *base_adr) @@ -61,9 +66,6 @@ volatile fan_ctrl_t *ctrl = (fan_ctrl_t *)base_adr; /* Program all needed fields of FAN controller. */ - FPGA_SET_PARAM(FANSensorSelect, ctrl->sensorselect); - FPGA_SET_PARAM(T_Warn, ctrl->t_warn); - FPGA_SET_PARAM(T_Crit, ctrl->t_crit); FPGA_SET_PARAM(FANSamplingTime, ctrl->samplingtime); FPGA_SET_PARAM(FANSetPoint, ctrl->setpoint); FPGA_SET_PARAM(FANHystCtrl, ctrl->hystctrl); -- To view, visit https://review.coreboot.org/21694 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6b8f770c768f3dacf96087eb0194cc99f0d11e17 Gerrit-Change-Number: 21694 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>

1 0

Change in coreboot[master]: configs: Add intel/harcuvar FSP 2.0 configurations
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21693 ) Change subject: configs: Add intel/harcuvar FSP 2.0 configurations ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/61104/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/16272/ : SUCCESS -- To view, visit https://review.coreboot.org/21693 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60ec6921eca17a910cd1b9f8b0b86a1a1bf9bbea Gerrit-Change-Number: 21693 Gerrit-PatchSet: 1 Gerrit-Owner: Mariusz Szafranski Gerrit-Reviewer: FEI WANG <wangfei.jimei(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 10:37:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: configs: Add intel/harcuvar FSP 2.0 configurations
by Mariusz Szafranski (Code Review) 26 Sep '17

26 Sep '17

Mariusz Szafranski has uploaded this change for review. ( https://review.coreboot.org/21693 Change subject: configs: Add intel/harcuvar FSP 2.0 configurations ...................................................................... configs: Add intel/harcuvar FSP 2.0 configurations Add Intel Harcuvar CRB FSP 2.0 configuration. Change-Id: I60ec6921eca17a910cd1b9f8b0b86a1a1bf9bbea Signed-off-by: Mariusz Szafranski <mariuszx.szafranski(a)intel.com> --- A configs/config.intel_harcuvar 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/21693/1 diff --git a/configs/config.intel_harcuvar b/configs/config.intel_harcuvar new file mode 100644 index 0000000..1d1ecc0 --- /dev/null +++ b/configs/config.intel_harcuvar @@ -0,0 +1,14 @@ +CONFIG_COLLECT_TIMESTAMPS=y +CONFIG_VENDOR_INTEL=y +CONFIG_CBFS_SIZE=0x800000 +CONFIG_BOARD_INTEL_HARCUVAR=y +# CONFIG_DRIVERS_UART_8250IO is not set +CONFIG_ADD_FSP_BINARIES=y +CONFIG_FSP_M_FILE="../intel/fsp/denverton_ns/DENVERTON-NS_FSP_M.fd" +CONFIG_FSP_S_FILE="../intel/fsp/denverton_ns/DENVERTON-NS_FSP_S.fd" +CONFIG_ENABLE_HSUART=y +CONFIG_CPU_MICROCODE_HEADER_FILES="../intel/cpu/denverton_ns/microcode/microcode_blob.h" +CONFIG_UART_PCI_ADDR=0x8000d000 +CONFIG_CPU_MICROCODE_CBFS_EXTERNAL_HEADER=y +CONFIG_FSP_T_FILE="../intel/fsp/denverton_ns/DENVERTON-NS_FSP_T.fd" +CONFIG_FSP_CAR=y -- To view, visit https://review.coreboot.org/21693 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I60ec6921eca17a910cd1b9f8b0b86a1a1bf9bbea Gerrit-Change-Number: 21693 Gerrit-PatchSet: 1 Gerrit-Owner: Mariusz Szafranski

1 0

Change in coreboot[master]: mainboard/google/soraka: Reduce Wacom resume time
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21692 ) Change subject: mainboard/google/soraka: Reduce Wacom resume time ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61103/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16271/ : SUCCESS -- To view, visit https://review.coreboot.org/21692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59d070977a95316414018af69d5b43e3147ccf4e Gerrit-Change-Number: 21692 Gerrit-PatchSet: 1 Gerrit-Owner: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com> Gerrit-Reviewer: Anshuman Gupta <anshuman.gupta(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.corp-partner.google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 10:05:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: device/dram/ddr2.c: fix a hidden syntax error introduced earlier
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21673 ) Change subject: device/dram/ddr2.c: fix a hidden syntax error introduced earlier ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61102/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16270/ : SUCCESS -- To view, visit https://review.coreboot.org/21673 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If956435bd0c39b1f3e722c2cfc48d2d0f35abc9b Gerrit-Change-Number: 21673 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 09:46:01 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 44: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61101/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16269/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 44 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 09:41:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region-permission-related functions
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related functions ...................................................................... Patch Set 50: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61099/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16267/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 50 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 09:41:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: Port the feature to jail ME from me_cleaner
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21607 ) Change subject: ifdtool: Port the feature to jail ME from me_cleaner ...................................................................... Patch Set 15: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61100/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16268/ : SUCCESS -- To view, visit https://review.coreboot.org/21607 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00533f4e2569c4763fbfc302bb460db1e60e5564 Gerrit-Change-Number: 21607 Gerrit-PatchSet: 15 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 09:39:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: improve the "new layout" feature
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: improve the "new layout" feature ...................................................................... Patch Set 59: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61098/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16266/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 59 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Christopher Douglass <cdouglass.orion(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 09:36:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/soraka: Reduce Wacom resume time
by Rajneesh Bhardwaj (Code Review) 26 Sep '17

26 Sep '17

Hello Anshuman Gupta, I'd like you to do a code review. Please visit https://review.coreboot.org/21692 to review the following change. Change subject: mainboard/google/soraka: Reduce Wacom resume time ...................................................................... mainboard/google/soraka: Reduce Wacom resume time Currently the WCOMCOHO registers a reset delay of 110ms to execute their _ON_ asl power on method. This seems to be correct as per WACOM product design specifications but it introduces an unwanted delay in overall system resume time. This delay should be removed from ACPI critical path since the entire kernel resume gets blocked on this sleep call unless this is over. In the kernel I2C communication with WACOM driver starts with the resume callbacks of I2C HID driver which gets triggered after display is completely resumed. The display resume process takes at least 230ms so its safe to reduce the delay from coreboot and unblock the critical ACPI path. BUG=b:65358919 BRANCH=None TEST=manual testing on Soraka board to ensue that touchscreen works at boot and after suspend/resume. Also verify that the overall S3 resume time is reduced by 100ms. Change-Id: I59d070977a95316414018af69d5b43e3147ccf4e Signed-off-by: Anshuman Gupta <anshuman.gupta(a)intel.com> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com> --- M src/mainboard/google/poppy/variants/soraka/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/21692/1 diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb index b874093..93d9b7a 100644 --- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb +++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb @@ -224,7 +224,7 @@ register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E7_IRQ)" register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E3)" - register "generic.reset_delay_ms" = "110" + register "generic.reset_delay_ms" = "10" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C22)" register "generic.enable_delay_ms" = "1" register "generic.has_power_resource" = "1" -- To view, visit https://review.coreboot.org/21692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I59d070977a95316414018af69d5b43e3147ccf4e Gerrit-Change-Number: 21692 Gerrit-PatchSet: 1 Gerrit-Owner: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com> Gerrit-Reviewer: Anshuman Gupta <anshuman.gupta(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.corp-partner.google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017