coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: mb/asrock/g41c-gs: Add IO decode range for SIO HWMON
by build bot (Jenkins) (Code Review) 09 Sep '17

09 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21464 ) Change subject: mb/asrock/g41c-gs: Add IO decode range for SIO HWMON ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/60143/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15374/ : SUCCESS -- To view, visit https://review.coreboot.org/21464 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic02c3a6265f11c1571369bc04371d28b6f989736 Gerrit-Change-Number: 21464 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Sep 2017 10:27:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/asrock/g41c-gs: Add IO decode range for SIO HWMON
by Arthur Heymans (Code Review) 09 Sep '17

09 Sep '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21464 Change subject: mb/asrock/g41c-gs: Add IO decode range for SIO HWMON ...................................................................... mb/asrock/g41c-gs: Add IO decode range for SIO HWMON Change-Id: Ic02c3a6265f11c1571369bc04371d28b6f989736 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/asrock/g41c-gs/romstage.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/21464/1 diff --git a/src/mainboard/asrock/g41c-gs/romstage.c b/src/mainboard/asrock/g41c-gs/romstage.c index 73fd935..ea0d995 100644 --- a/src/mainboard/asrock/g41c-gs/romstage.c +++ b/src/mainboard/asrock/g41c-gs/romstage.c @@ -75,6 +75,7 @@ /* Decode range */ pci_write_config16(PCI_DEV(0, 0x1f, 0), LPC_EN, CNF1_LPC_EN | KBC_LPC_EN | LPT_LPC_EN | COMA_LPC_EN); + pci_write_config8(PCI_DEV(0, 0x1f, 0), LPC_GEN1_DEC, 0x00fc0281); } void mainboard_romstage_entry(unsigned long bist) -- To view, visit https://review.coreboot.org/21464 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic02c3a6265f11c1571369bc04371d28b6f989736 Gerrit-Change-Number: 21464 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: [UNTESTED, NOTFORMERGE]mb/gigabyte/m57sli-s4: Implement s3 resume
by build bot (Jenkins) (Code Review) 09 Sep '17

09 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21460 ) Change subject: [UNTESTED,NOTFORMERGE]mb/gigabyte/m57sli-s4: Implement s3 resume ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/60139/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15370/ : SUCCESS -- To view, visit https://review.coreboot.org/21460 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I088029c78c3f09edf1a81483db5f269ae7ab9604 Gerrit-Change-Number: 21460 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Sep 2017 07:34:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [UNTESTED, NOTFORMERGE]mb/gigabyte/m57sli-s4: Implement s3 resume
by Arthur Heymans (Code Review) 09 Sep '17

09 Sep '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21460 Change subject: [UNTESTED,NOTFORMERGE]mb/gigabyte/m57sli-s4: Implement s3 resume ...................................................................... [UNTESTED,NOTFORMERGE]mb/gigabyte/m57sli-s4: Implement s3 resume Change-Id: I088029c78c3f09edf1a81483db5f269ae7ab9604 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/gigabyte/m57sli/Kconfig M src/mainboard/gigabyte/m57sli/dsdt.asl M src/northbridge/amd/amdk8/raminit_f_dqs.c M src/southbridge/nvidia/mcp55/early_setup_car.c M src/southbridge/nvidia/mcp55/mcp55.h 5 files changed, 41 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/21460/1 diff --git a/src/mainboard/gigabyte/m57sli/Kconfig b/src/mainboard/gigabyte/m57sli/Kconfig index 2847377..94c1412 100644 --- a/src/mainboard/gigabyte/m57sli/Kconfig +++ b/src/mainboard/gigabyte/m57sli/Kconfig @@ -22,6 +22,7 @@ select QRANK_DIMM_SUPPORT select K8_ALLOCATE_IO_RANGE select SET_FIDVID + select HAVE_ACPI_RESUME config MAINBOARD_DIR string diff --git a/src/mainboard/gigabyte/m57sli/dsdt.asl b/src/mainboard/gigabyte/m57sli/dsdt.asl index c53f36a..101d9da 100644 --- a/src/mainboard/gigabyte/m57sli/dsdt.asl +++ b/src/mainboard/gigabyte/m57sli/dsdt.asl @@ -25,9 +25,11 @@ /* For now only define 2 power states: * - S0 which is fully on + * - S3 * - S5 which is soft off */ Name (\_S0, Package () { 0x00, 0x00, 0x00, 0x00 }) + Name (\_S3, Package () { 0x05, 0x00, 0x00, 0x00 }) Name (\_S5, Package () { 0x07, 0x00, 0x00, 0x00 }) /* Root of the bus hierarchy */ diff --git a/src/northbridge/amd/amdk8/raminit_f_dqs.c b/src/northbridge/amd/amdk8/raminit_f_dqs.c index 64b0c64..8cda2d6 100644 --- a/src/northbridge/amd/amdk8/raminit_f_dqs.c +++ b/src/northbridge/amd/amdk8/raminit_f_dqs.c @@ -20,8 +20,10 @@ #include <arch/early_variables.h> #if IS_ENABLED(CONFIG_SOUTHBRIDGE_AMD_SB700) #include <southbridge/amd/sb700/sb700.h> -#else /* IS_ENABLED(CONFIG_SOUTHBRIDGE_VIA_K8T890) */ +#elseif IS_ENABLED(CONFIG_SOUTHBRIDGE_VIA_K8T890) #include <southbridge/via/k8t890/k8t890.h> +#else /* IS_ENABLED(CONFIG_SOUTHBRIDGE_NVIDIA_MCP55) */ +#include <southbridge/nvidia/mcp55/mcp55.h> #endif //0: mean no debug info diff --git a/src/southbridge/nvidia/mcp55/early_setup_car.c b/src/southbridge/nvidia/mcp55/early_setup_car.c index 8019a8e..10ac99c 100644 --- a/src/southbridge/nvidia/mcp55/early_setup_car.c +++ b/src/southbridge/nvidia/mcp55/early_setup_car.c @@ -15,6 +15,8 @@ * GNU General Public License for more details. */ +#include <arch/acpi.h> + #ifdef UNUSED_CODE int set_ht_link_buffer_counts_chain(u8 ht_c_num, unsigned vendorid, unsigned val); @@ -390,3 +392,34 @@ return 0; } + + +int acpi_get_sleep_type(void) +{ + u16 tmp; + tmp = inw(ACPICTRL_IO_BASE + 0x04); + return ((tmp & (7 << 10) >> 10)); +} + +int s3_save_nvram_early(u32 dword, int size, int nvram_pos) +{ + int i; + printk(BIOS_DEBUG, "Writing %x of size %d to nvram pos: %d\n", dword, size, nvram_pos); + for (i = 0; i < size; i++) + cmos_write((dword >> (8 * i)) & 0xff, 128 + nvram_pos++); + return nvram_pos; +} + +int s3_load_nvram_early(int size, u32 *old_dword, int nvram_pos) +{ + int i; + + *old_dword = 0; + + for (i = 0; i < size; i++) + *old_dword |= cmos_read(128 + nvram_pos++) << (i * 8); + + printk(BIOS_DEBUG, "Loading %x of size %d to nvram pos:%d\n", + *old_dword, size, nvram_pos-size); + return nvram_pos; +} diff --git a/src/southbridge/nvidia/mcp55/mcp55.h b/src/southbridge/nvidia/mcp55/mcp55.h index a244b82..a87acf8 100644 --- a/src/southbridge/nvidia/mcp55/mcp55.h +++ b/src/southbridge/nvidia/mcp55/mcp55.h @@ -40,6 +40,8 @@ int smbusx_read_byte(unsigned smb_index, unsigned device, unsigned address); int smbusx_write_byte(unsigned smb_index, unsigned device, unsigned address, unsigned char val); +int s3_save_nvram_early(u32 dword, int size, int nvram_pos); +int s3_load_nvram_early(int size, u32 *old_dword, int nvram_pos); #endif #endif -- To view, visit https://review.coreboot.org/21460 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I088029c78c3f09edf1a81483db5f269ae7ab9604 Gerrit-Change-Number: 21460 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: mb/asus/f2a85-m_fam10: Add ASUS F2A85-M (using non-AGESA)
by Raptor Engineering Automated Test Stand (Code Review) 09 Sep '17

09 Sep '17

Raptor Engineering Automated Test Stand has posted comments on this change. ( https://review.coreboot.org/13712 ) Change subject: mb/asus/f2a85-m_fam10: Add ASUS F2A85-M (using non-AGESA) ...................................................................... Patch Set 9: Verified+1 ASUS KFSN4-DRE: Boot and extended test successful. Boot log: https://testlab.coreboot.org/raptor/1504939470-0-13712,9.log.bz2 QEMU x86_64 Q35: Boot successful. Boot log: https://testlab.coreboot.org/raptor/1504939557-1-13712,9.log.bz2 -- To view, visit https://review.coreboot.org/13712 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28717d9e78336e6097fd91f270cac2bfed9534d8 Gerrit-Change-Number: 13712 Gerrit-PatchSet: 9 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Sep 2017 06:46:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/asus/f2a85-m_fam10: Add ASUS F2A85-M (using non-AGESA)
by build bot (Jenkins) (Code Review) 09 Sep '17

09 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/13712 ) Change subject: mb/asus/f2a85-m_fam10: Add ASUS F2A85-M (using non-AGESA) ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15369/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60138/ : SUCCESS -- To view, visit https://review.coreboot.org/13712 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28717d9e78336e6097fd91f270cac2bfed9534d8 Gerrit-Change-Number: 13712 Gerrit-PatchSet: 9 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Sep 2017 06:42:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: southbridge/amd/sb900: Add southbridge sb900 (hudson) non-AGESA
by build bot (Jenkins) (Code Review) 09 Sep '17

09 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/13711 ) Change subject: southbridge/amd/sb900: Add southbridge sb900 (hudson) non-AGESA ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15367/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60136/ : SUCCESS -- To view, visit https://review.coreboot.org/13711 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bcb926d55a00993ba4d0a3c45541dbd883bbae1 Gerrit-Change-Number: 13711 Gerrit-PatchSet: 8 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Sep 2017 06:40:14 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: southbridge/amd/sb900: Add southbridge sb900 (hudson) non-AGESA
by Raptor Engineering Automated Test Stand (Code Review) 09 Sep '17

09 Sep '17

Raptor Engineering Automated Test Stand has posted comments on this change. ( https://review.coreboot.org/13711 ) Change subject: southbridge/amd/sb900: Add southbridge sb900 (hudson) non-AGESA ...................................................................... Patch Set 8: Verified+1 ASUS KFSN4-DRE: Boot and extended test successful. Boot log: https://testlab.coreboot.org/raptor/1504938898-0-13711,8.log.bz2 QEMU x86_64 Q35: Boot successful. Boot log: https://testlab.coreboot.org/raptor/1504938974-1-13711,8.log.bz2 -- To view, visit https://review.coreboot.org/13711 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9bcb926d55a00993ba4d0a3c45541dbd883bbae1 Gerrit-Change-Number: 13711 Gerrit-PatchSet: 8 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Sep 2017 06:36:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/asus/f2a85-m_fam10: Add ASUS F2A85-M (using non-AGESA)
by build bot (Jenkins) (Code Review) 09 Sep '17

09 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/13712 ) Change subject: mb/asus/f2a85-m_fam10: Add ASUS F2A85-M (using non-AGESA) ...................................................................... Patch Set 8: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/60137/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/15368/ : SUCCESS -- To view, visit https://review.coreboot.org/13712 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28717d9e78336e6097fd91f270cac2bfed9534d8 Gerrit-Change-Number: 13712 Gerrit-PatchSet: 8 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Sep 2017 06:28:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region-permission-related feature
by build bot (Jenkins) (Code Review) 09 Sep '17

09 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related feature ...................................................................... Patch Set 13: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15365/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60134/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 13 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Sep 2017 02:42:26 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017