coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: google/snappy: Update EC keyboard backlight flag by SKU ID
by build bot (Jenkins) (Code Review) 09 Sep '17

09 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21400 ) Change subject: google/snappy: Update EC keyboard backlight flag by SKU ID ...................................................................... Patch Set 11: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/60119/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/15352/ : SUCCESS -- To view, visit https://review.coreboot.org/21400 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1153aa0b89250c55f311dd93a01fcef47afd7292 Gerrit-Change-Number: 21400 Gerrit-PatchSet: 11 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quantatw.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Sep 2017 00:19:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vboot: Use "Google_" as VBOOT_FWID_MODEL prefix if CHROMEOS is set
by build bot (Jenkins) (Code Review) 08 Sep '17

08 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21458 ) Change subject: vboot: Use "Google_" as VBOOT_FWID_MODEL prefix if CHROMEOS is set ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60117/ : SUCCESS -- To view, visit https://review.coreboot.org/21458 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2280bfd6d535586bc14d9a3c4a8198287f08bc Gerrit-Change-Number: 21458 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 08 Sep 2017 22:54:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vboot: Use "Google_" as VBOOT_FWID_MODEL prefix if CHROMEOS is set
by build bot (Jenkins) (Code Review) 08 Sep '17

08 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21458 ) Change subject: vboot: Use "Google_" as VBOOT_FWID_MODEL prefix if CHROMEOS is set ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15351/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60116/ : SUCCESS -- To view, visit https://review.coreboot.org/21458 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2280bfd6d535586bc14d9a3c4a8198287f08bc Gerrit-Change-Number: 21458 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 08 Sep 2017 22:33:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: device/dram/ddr2: Fix decoding tRR
by build bot (Jenkins) (Code Review) 08 Sep '17

08 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21457 ) Change subject: device/dram/ddr2: Fix decoding tRR ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15350/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60115/ : SUCCESS -- To view, visit https://review.coreboot.org/21457 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a698ec9c15a2611a34c5965edf93638553775f0 Gerrit-Change-Number: 21457 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 08 Sep 2017 22:21:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: device/dram/ddr2: Fix decoding tRR
by Nico Huber (Code Review) 08 Sep '17

08 Sep '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21457 ) Change subject: device/dram/ddr2: Fix decoding tRR ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/21457/2/src/device/dram/ddr2.c File src/device/dram/ddr2.c: https://review.coreboot.org/#/c/21457/2/src/device/dram/ddr2.c@184 PS2, Line 184: printk(BIOS_DEBUG, BIOS_WARNING? -- To view, visit https://review.coreboot.org/21457 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a698ec9c15a2611a34c5965edf93638553775f0 Gerrit-Change-Number: 21457 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 08 Sep 2017 22:17:27 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: vboot: Use "Google_" as VBOOT_FWID_MODEL prefix if CHROMEOS is set
by Furquan Shaikh (Code Review) 08 Sep '17

08 Sep '17

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/21458 Change subject: vboot: Use "Google_" as VBOOT_FWID_MODEL prefix if CHROMEOS is set ...................................................................... vboot: Use "Google_" as VBOOT_FWID_MODEL prefix if CHROMEOS is set BUG=b:65493192 Change-Id: I0a2280bfd6d535586bc14d9a3c4a8198287f08bc Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/vboot/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/21458/1 diff --git a/src/vboot/Kconfig b/src/vboot/Kconfig index c4b4687..8c8dffe 100644 --- a/src/vboot/Kconfig +++ b/src/vboot/Kconfig @@ -199,6 +199,7 @@ config VBOOT_FWID_MODEL string "Firmware ID model" + default "Google_$(CONFIG_MAINBOARD_PART_NUMBER)" if CHROMEOS default "$(CONFIG_MAINBOARD_VENDOR)_$(CONFIG_MAINBOARD_PART_NUMBER)" help This is the first part of the FWID written to various regions of a -- To view, visit https://review.coreboot.org/21458 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0a2280bfd6d535586bc14d9a3c4a8198287f08bc Gerrit-Change-Number: 21458 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: device/dram/ddr2: Fix decoding tRR
by build bot (Jenkins) (Code Review) 08 Sep '17

08 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21457 ) Change subject: device/dram/ddr2: Fix decoding tRR ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/60114/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/15348/ : SUCCESS -- To view, visit https://review.coreboot.org/21457 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a698ec9c15a2611a34c5965edf93638553775f0 Gerrit-Change-Number: 21457 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 08 Sep 2017 22:14:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: device/dram/ddr2: Fix decoding tRR
by Arthur Heymans (Code Review) 08 Sep '17

08 Sep '17

Hello Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21457 to look at the new patch set (#2). Change subject: device/dram/ddr2: Fix decoding tRR ...................................................................... device/dram/ddr2: Fix decoding tRR Bit 7 is set on all options. Change-Id: I6a698ec9c15a2611a34c5965edf93638553775f0 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/device/dram/ddr2.c 1 file changed, 9 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/21457/2 -- To view, visit https://review.coreboot.org/21457 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6a698ec9c15a2611a34c5965edf93638553775f0 Gerrit-Change-Number: 21457 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: device/dram/ddr2: Fix decoding tRR
by Arthur Heymans (Code Review) 08 Sep '17

08 Sep '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21457 ) Change subject: device/dram/ddr2: Fix decoding tRR ...................................................................... Patch Set 1: > (4 comments) > > Have you checked any actual SPD value? I have dimms with reduced refresh rate (7.8us) -- To view, visit https://review.coreboot.org/21457 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a698ec9c15a2611a34c5965edf93638553775f0 Gerrit-Change-Number: 21457 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 08 Sep 2017 22:14:01 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/i945/raminit: Use common ddr2 decode functions
by build bot (Jenkins) (Code Review) 08 Sep '17

08 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18305 ) Change subject: nb/i945/raminit: Use common ddr2 decode functions ...................................................................... Patch Set 52: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15349/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60113/ : SUCCESS -- To view, visit https://review.coreboot.org/18305 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97c93939d11807752797785dd88c70b43a236ee3 Gerrit-Change-Number: 18305 Gerrit-PatchSet: 52 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Comment-Date: Fri, 08 Sep 2017 22:08:38 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017