coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: nb/intel/i440bx/debug.c: Bugfix and cleanup
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21203 ) Change subject: nb/intel/i440bx/debug.c: Bugfix and cleanup ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59320/ : ABORTED -- To view, visit https://review.coreboot.org/21203 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60e272b29417039feb15540e49d7300f86e5ed21 Gerrit-Change-Number: 21203 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 19:54:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/i440bx/debug.c: Bugfix and cleanup
by Keith Hui (Code Review) 25 Aug '17

25 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21203 to look at the new patch set (#2). Change subject: nb/intel/i440bx/debug.c: Bugfix and cleanup ...................................................................... nb/intel/i440bx/debug.c: Bugfix and cleanup Fix dump_pci_device() broken by commit 65b72ab5 (Drop print_ implementation from non-romcc boards) in 2015 (!) where only one in 16 bytes were being dumped. Also remove the #if made redundant by commit aef8542 (Compile debug.c only if CONFIG_DEBUG_RAM_SETUP) as this whole file is only compiled in that case. Also clean up headers that were included twice. Change-Id: I60e272b29417039feb15540e49d7300f86e5ed21 Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/northbridge/intel/i440bx/debug.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/21203/2 -- To view, visit https://review.coreboot.org/21203 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I60e272b29417039feb15540e49d7300f86e5ed21 Gerrit-Change-Number: 21203 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in libgfxinit[master]: gma: Fix refined contract of Initialize()
by Nico Huber (Code Review) 25 Aug '17

25 Aug '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21207 ) Change subject: gma: Fix refined contract of Initialize() ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/21207 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86e42163d7847f7011bcf9a0ef5c2c7f25b4b1be Gerrit-Change-Number: 21207 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 25 Aug 2017 19:03:58 +0000 Gerrit-HasComments: No

1 0

Change in libhwbase[master]: linux pci: Add dummy PCI access for shared contracts
by Nico Huber (Code Review) 25 Aug '17

25 Aug '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21206 ) Change subject: linux pci: Add dummy PCI access for shared contracts ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/21206 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libhwbase Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If994db22d91eb3707e555871d854c3a25a13678b Gerrit-Change-Number: 21206 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 25 Aug 2017 19:03:04 +0000 Gerrit-HasComments: No

1 0

Change in libhwbase[master]: direct pci: Always initialize Address_State
by Nico Huber (Code Review) 25 Aug '17

25 Aug '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21205 ) Change subject: direct pci: Always initialize Address_State ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/21205 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libhwbase Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0454dfd6c36f7d4298edeec5b84d929e3160eb7b Gerrit-Change-Number: 21205 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 25 Aug 2017 19:02:41 +0000 Gerrit-HasComments: No

1 0

Change in libgfxinit[master]: gma: Fix refined contract of Initialize()
by Nico Huber (Code Review) 25 Aug '17

25 Aug '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21207 Change subject: gma: Fix refined contract of Initialize() ...................................................................... gma: Fix refined contract of Initialize() To be compatible with HW.PCI.Dev implementations that do actual register accesses, we have to account for hardware state updates. Change-Id: I86e42163d7847f7011bcf9a0ef5c2c7f25b4b1be Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma.adb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/07/21207/1 diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index 94f3ceb..101de18 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -301,7 +301,7 @@ with Refined_Global => (In_Out => - (Config.Valid_Port_GPU, + (Config.Valid_Port_GPU, Dev.PCI_State, Registers.Register_State, Port_IO.State), Input => (Time.State), -- To view, visit https://review.coreboot.org/21207 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I86e42163d7847f7011bcf9a0ef5c2c7f25b4b1be Gerrit-Change-Number: 21207 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libhwbase[master]: linux pci: Add dummy PCI access for shared contracts
by Nico Huber (Code Review) 25 Aug '17

25 Aug '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21206 Change subject: linux pci: Add dummy PCI access for shared contracts ...................................................................... linux pci: Add dummy PCI access for shared contracts Other implementations may update the PCI_State in Resource_Size() and Map(). To share the contract with those implementations, we have to simulate such accesses. Change-Id: If994db22d91eb3707e555871d854c3a25a13678b Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/linux/hw-pci-dev.adb 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libhwbase refs/changes/06/21206/1 diff --git a/common/linux/hw-pci-dev.adb b/common/linux/hw-pci-dev.adb index a768002..294d976 100644 --- a/common/linux/hw-pci-dev.adb +++ b/common/linux/hw-pci-dev.adb @@ -41,6 +41,19 @@ procedure Write16 (Offset : Index; Value : Word16) renames MM.Write16; procedure Write32 (Offset : Index; Value : Word32) renames MM.Write32; + package Dummy is + -- No-op PCI config update to share contracts + -- with implementations that do actual updates. + procedure PCI_Update + with + Global => (In_Out => MM.PCI_State); + end Dummy; + package body Dummy is + procedure PCI_Update is null + with + SPARK_Mode => Off; + end Dummy; + function Hex (Val : Natural) return Character with Pre => Val < 16 @@ -85,6 +98,8 @@ Path : String (1 .. 49) := "/sys/devices/pci0000:xx/0000:xx:xx.x/resourcex_wc"; begin + Dummy.PCI_Update; + Patch_Sysfs_Path (Path); Path (46) := Character'Val (Character'Pos ('0') + Resource'Pos (Res)); if not WC then @@ -123,6 +138,8 @@ Path : String (1 .. 46) := "/sys/devices/pci0000:xx/0000:xx:xx.x/resourcex"; begin + Dummy.PCI_Update; + Patch_Sysfs_Path (Path); Path (46) := Character'Val (Character'Pos ('0') + Resource'Pos (Res)); -- To view, visit https://review.coreboot.org/21206 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libhwbase Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If994db22d91eb3707e555871d854c3a25a13678b Gerrit-Change-Number: 21206 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libhwbase[master]: direct pci: Always initialize Address_State
by Nico Huber (Code Review) 25 Aug '17

25 Aug '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21205 Change subject: direct pci: Always initialize Address_State ...................................................................... direct pci: Always initialize Address_State Let Initialize() always initialize the Address_State. This is not only the expected behaviour but also necessary to share the contract with other implementations. Change-Id: I0454dfd6c36f7d4298edeec5b84d929e3160eb7b Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/direct/hw-pci-dev.adb 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libhwbase refs/changes/05/21205/1 diff --git a/common/direct/hw-pci-dev.adb b/common/direct/hw-pci-dev.adb index 9bd7d1d..3d76521 100644 --- a/common/direct/hw-pci-dev.adb +++ b/common/direct/hw-pci-dev.adb @@ -108,6 +108,8 @@ begin if MMConf_Base /= 0 then MM.Set_Base_Address (MMConf_Base); + else + MM.Set_Base_Address (Config.Default_MMConf_Base); end if; Success := MMConf_Base /= 0 or Config.Default_MMConf_Base_Set; end Initialize; -- To view, visit https://review.coreboot.org/21205 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libhwbase Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0454dfd6c36f7d4298edeec5b84d929e3160eb7b Gerrit-Change-Number: 21205 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Init UPD params based on config
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21175 ) Change subject: soc/intel/cannonlake: Init UPD params based on config ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14639/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59313/ : SUCCESS -- To view, visit https://review.coreboot.org/21175 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ee58f8432a957ef389b40f717533e4cfe774b9 Gerrit-Change-Number: 21175 Gerrit-PatchSet: 5 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Pratik Prajapati <pratik.prajapati(a)gmail.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 18:22:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/i440bx/debug.c: Bugfix and cleanup
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21203 ) Change subject: nb/intel/i440bx/debug.c: Bugfix and cleanup ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14638/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59312/ : SUCCESS -- To view, visit https://review.coreboot.org/21203 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60e272b29417039feb15540e49d7300f86e5ed21 Gerrit-Change-Number: 21203 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 17:17:42 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017