coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: Revert "google/cyan: Use GpioInt for Keyboard IRQ"
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21209 ) Change subject: Revert "google/cyan: Use GpioInt for Keyboard IRQ" ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59329/ : SUCCESS -- To view, visit https://review.coreboot.org/21209 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idef57d1cc7cafaa15768c96febb8f9fd7a81c292 Gerrit-Change-Number: 21209 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 23:13:40 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Revert "google/cyan: Use GpioInt for Keyboard IRQ"
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21209 ) Change subject: Revert "google/cyan: Use GpioInt for Keyboard IRQ" ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/14645/ : ABORTED https://qa.coreboot.org/job/coreboot-gerrit/59328/ : ABORTED -- To view, visit https://review.coreboot.org/21209 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idef57d1cc7cafaa15768c96febb8f9fd7a81c292 Gerrit-Change-Number: 21209 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 23:04:01 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Revert "google/cyan: Use GpioInt for Keyboard IRQ"
by Matt DeVillier (Code Review) 25 Aug '17

25 Aug '17

Matt DeVillier has uploaded a new patch set (#2). ( https://review.coreboot.org/21209 ) Change subject: Revert "google/cyan: Use GpioInt for Keyboard IRQ" ...................................................................... Revert "google/cyan: Use GpioInt for Keyboard IRQ" This reverts commit 3d4f04f6b1c802c2c2126b6a6cc97fb5b49ec0bd. The kernel-side changes needed to support this won't be merged into the mainline kernel until 4.13 (currently in linux-next). My previous testing was with a daily build of ChromiumOS which already had the required kernel changes so I missed the breakage. TEST: Boot cyan on mailine kernel 4.12.x (or earlier), observe keyboard now functional again. Change-Id: Idef57d1cc7cafaa15768c96febb8f9fd7a81c292 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/cyan/acpi/superio.asl M src/mainboard/google/cyan/onboard.h 2 files changed, 9 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/21209/2 -- To view, visit https://review.coreboot.org/21209 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idef57d1cc7cafaa15768c96febb8f9fd7a81c292 Gerrit-Change-Number: 21209 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Change in coreboot[master]: Revert "google/cyan: Use GpioInt for Keyboard IRQ"
by Matt DeVillier (Code Review) 25 Aug '17

25 Aug '17

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/21209 Change subject: Revert "google/cyan: Use GpioInt for Keyboard IRQ" ...................................................................... Revert "google/cyan: Use GpioInt for Keyboard IRQ" This reverts commit 3d4f04f6b1c802c2c2126b6a6cc97fb5b49ec0bd. The kernel-side changes needed to support this won't be merged into the mailing kernel until 4.13 (currently in linux-next). My previous testing was with a daily build of ChromiumOS which already had the required kernel changes so I missed the breakage. TEST: Boot cyan on mailine kernel 4.12.x (or earlier), observe keyboard now functional again. Change-Id: Idef57d1cc7cafaa15768c96febb8f9fd7a81c292 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/cyan/acpi/superio.asl M src/mainboard/google/cyan/onboard.h 2 files changed, 9 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/21209/1 diff --git a/src/mainboard/google/cyan/acpi/superio.asl b/src/mainboard/google/cyan/acpi/superio.asl index f2a7fc0..34ae348 100644 --- a/src/mainboard/google/cyan/acpi/superio.asl +++ b/src/mainboard/google/cyan/acpi/superio.asl @@ -23,8 +23,8 @@ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ /* Override default IRQ settings */ -#define SIO_EC_PS2K_IRQ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,\ - "\\_SB.GPNC") { BOARD_I8042_GPIO_INDEX } +#define SIO_EC_PS2K_IRQ Interrupt(ResourceConsumer, Edge, ActiveLow){\ + BOARD_I8042_IRQ} /* ACPI code for EC SuperIO functions */ #include <ec/google/chromeec/acpi/superio.asl> diff --git a/src/mainboard/google/cyan/onboard.h b/src/mainboard/google/cyan/onboard.h index c891aa8..706f306 100644 --- a/src/mainboard/google/cyan/onboard.h +++ b/src/mainboard/google/cyan/onboard.h @@ -30,10 +30,15 @@ * GPSE_SIZE = 86 */ +/* + * gpio based irq for kbd, 17th index in North Bank + * MAX_DIRECT_IRQ + GPSW_SIZE + 18 + */ +/* ToDO: change kbd irq to gpio bank index */ +#define BOARD_I8042_IRQ 182 #define BOARD_TOUCH_IRQ 184 -/* KBD: Gpio index in N bank */ -#define BOARD_I8042_GPIO_INDEX 17 + /* SCI: Gpio index in N bank */ #define BOARD_SCI_GPIO_INDEX 15 /* Trackpad: Gpio index in N bank */ -- To view, visit https://review.coreboot.org/21209 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idef57d1cc7cafaa15768c96febb8f9fd7a81c292 Gerrit-Change-Number: 21209 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Change in coreboot[master]: mainboard/google/poppy: Tune I2C params (hcnt, lcnt, hold time)
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21208 ) Change subject: mainboard/google/poppy: Tune I2C params (hcnt, lcnt, hold time) ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14644/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59324/ : SUCCESS -- To view, visit https://review.coreboot.org/21208 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie30e1a12b66c4660b648a585c4dfd66faf004129 Gerrit-Change-Number: 21208 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 20:28:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Tune I2C params (hcnt, lcnt, hold time)
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21208 ) Change subject: mainboard/google/poppy: Tune I2C params (hcnt, lcnt, hold time) ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/14643/ : ABORTED https://qa.coreboot.org/job/coreboot-gerrit/59323/ : ABORTED -- To view, visit https://review.coreboot.org/21208 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie30e1a12b66c4660b648a585c4dfd66faf004129 Gerrit-Change-Number: 21208 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 20:23:26 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Tune I2C params (hcnt, lcnt, hold time)
by Furquan Shaikh (Code Review) 25 Aug '17

25 Aug '17

Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/21208 ) Change subject: mainboard/google/poppy: Tune I2C params (hcnt, lcnt, hold time) ...................................................................... mainboard/google/poppy: Tune I2C params (hcnt, lcnt, hold time) Tune I2C params for I2C buses 0, 1, 2, 4 and 5 to ensure that the frequency does not exceed 400KHz. BUG=b:35948024 TEST=Verified for 25 iterations that the frequency on each bus ranges <= 400KHz. I2C0: 375 - 400 I2C1: 377 - 400 I2C2: 377 - 400 I2C4: 375 - 397 I2C5: 375 - 397 Change-Id: Ie30e1a12b66c4660b648a585c4dfd66faf004129 Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/mainboard/google/poppy/variants/baseboard/devicetree.cb 1 file changed, 65 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/21208/2 -- To view, visit https://review.coreboot.org/21208 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie30e1a12b66c4660b648a585c4dfd66faf004129 Gerrit-Change-Number: 21208 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: mainboard/google/poppy: Tune I2C params (hcnt, lcnt, hold time)
by Furquan Shaikh (Code Review) 25 Aug '17

25 Aug '17

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/21208 Change subject: mainboard/google/poppy: Tune I2C params (hcnt, lcnt, hold time) ...................................................................... mainboard/google/poppy: Tune I2C params (hcnt, lcnt, hold time) Tune I2C params for I2C buses 0, 1, 2, 4 and 5 to ensure that the frequency does not exceed 400KHz. BUG=b:35948024 TEST=Verified for 25 iterations that the frequency on each bus ranges <= 400KHz. I2C0: 375 - 400 I2C1: 377 - 400 I2C2: 377 - 400 I2C4: 375 - 397 I2C5: 375 - 397 Change-Id: Ie30e1a12b66c4660b648a585c4dfd66faf004129 Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/mainboard/google/poppy/variants/baseboard/devicetree.cb 1 file changed, 66 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/21208/1 diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb index 2324557..d4f8fde 100644 --- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb @@ -165,23 +165,77 @@ register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-A Port register "usb3_ports[3]" = "USB3_PORT_EMPTY" # Empty - register "i2c_voltage[0]" = "I2C_VOLTAGE_3V3" # Touchscreen - register "i2c_voltage[1]" = "I2C_VOLTAGE_3V3" # H1 - register "i2c_voltage[2]" = "I2C_VOLTAGE_1V8" # Camera - register "i2c_voltage[3]" = "I2C_VOLTAGE_1V8" # Pen - register "i2c_voltage[4]" = "I2C_VOLTAGE_1V8" # Camera - register "i2c_voltage[5]" = "I2C_VOLTAGE_1V8" # Audio + # Touchscreen + register "i2c_voltage[0]" = "I2C_VOLTAGE_3V3" + register "i2c[0]" = "{ + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 185, + .scl_hcnt = 90, + .sda_hold = 36, + }, + }" + + # H1 + + register "i2c_voltage[1]" = "I2C_VOLTAGE_3V3" + register "i2c[1]" = "{ + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 100, + .sda_hold = 36, + }, + .early_init = 1, + }" + + + # Camera + register "i2c_voltage[2]" = "I2C_VOLTAGE_1V8" + register "i2c[2]" = "{ + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 97, + .sda_hold = 36, + }, + }" + + # Pen + register "i2c_voltage[3]" = "I2C_VOLTAGE_1V8" + + # Camera + register "i2c_voltage[4]" = "I2C_VOLTAGE_1V8" + register "i2c[4]" = "{ + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 97, + .sda_hold = 36, + }, + }" + + # Audio + register "i2c_voltage[5]" = "I2C_VOLTAGE_1V8" + register "i2c[5]" = "{ + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 190, + .scl_hcnt = 98, + .sda_hold = 36, + }, + }" + # Use GSPI0 for cr50 TPM. Early init is required to set up a BAR for TPM # communication before memory is up. register "gspi[0]" = "{ .speed_mhz = 1, - .early_init = 1, - }" - - # Configure I2C1 for cr50 TPM. Early init is required to set up a BAR - # for TPM communication before memory is up. - register "i2c[1]" = "{ .early_init = 1, }" -- To view, visit https://review.coreboot.org/21208 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie30e1a12b66c4660b648a585c4dfd66faf004129 Gerrit-Change-Number: 21208 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: nb/intel/i440bx: [WIP] Implement CBMEM in romstage
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20977 ) Change subject: nb/intel/i440bx: [WIP] Implement CBMEM in romstage ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14641/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59321/ : SUCCESS -- To view, visit https://review.coreboot.org/20977 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I432f145a5343c1bb5f2b0de3b6b88f57124d1bd9 Gerrit-Change-Number: 20977 Gerrit-PatchSet: 5 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 20:16:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/i440bx/debug.c: Bugfix and cleanup
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21203 ) Change subject: nb/intel/i440bx/debug.c: Bugfix and cleanup ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14642/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59322/ : SUCCESS -- To view, visit https://review.coreboot.org/21203 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60e272b29417039feb15540e49d7300f86e5ed21 Gerrit-Change-Number: 21203 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 20:00:32 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017