coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
by Nico Huber (Code Review) 26 Aug '17

26 Aug '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21178 ) Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ...................................................................... Patch Set 7: (1 comment) Looks good now. Alas, I spotted a semantical problem. https://review.coreboot.org/#/c/21178/7/src/southbridge/intel/bd82x6x/pch.c File src/southbridge/intel/bd82x6x/pch.c: https://review.coreboot.org/#/c/21178/7/src/southbridge/intel/bd82x6x/pch.c… PS7, Line 294: [PCI_FUNC(dev->path.pci.devfn)]; This should be done before the `if`. Slots that didn't move need the hotplug setting copied too. Alternatively you could initialize `new_hotplug_map` with the values of the old map. -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 7 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 11:44:06 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
by build bot (Jenkins) (Code Review) 26 Aug '17

26 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21178 ) Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14656/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59345/ : SUCCESS -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 7 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 11:34:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
by Bill XIE (Code Review) 26 Aug '17

26 Aug '17

Hello Arthur Heymans, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21178 to look at the new patch set (#7). Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ...................................................................... sb/intel/bd82x6x: make hotplug map consistent to remapped ports "pcie_port_coalesce" will cause pcie being remapped under certain conditions, but flags within "pcie_hotplug_map" should be updated along with ports. Test on my lenovo t430s. Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M src/southbridge/intel/bd82x6x/pch.c 1 file changed, 24 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/21178/7 -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 7 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
by Nico Huber (Code Review) 26 Aug '17

26 Aug '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21178 ) Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ...................................................................... Patch Set 6: (2 comments) https://review.coreboot.org/#/c/21178/6/src/southbridge/intel/bd82x6x/pch.c File src/southbridge/intel/bd82x6x/pch.c: https://review.coreboot.org/#/c/21178/6/src/southbridge/intel/bd82x6x/pch.c… PS6, Line 259: southbridge_intel_bd82x6x_config > In order to make the 80-char-per-line limit happy, I have to write it like just write it like this: static void pch_pcie_devicetree_update( struct southbridge_intel_bd82x6x_config *config) (two tabs indent is common in this case) https://review.coreboot.org/#/c/21178/6/src/southbridge/intel/bd82x6x/pch.c… PS6, Line 312: return; Not that I care, but others demand that code follows declarations. So this should come after the `u32 reg32;`. -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 11:24:54 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
by build bot (Jenkins) (Code Review) 26 Aug '17

26 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21178 ) Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14654/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59343/ : SUCCESS -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 10:55:37 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/*: add option to lockdown chipset on normal boot path
by build bot (Jenkins) (Code Review) 26 Aug '17

26 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21129 ) Change subject: sb/intel/*: add option to lockdown chipset on normal boot path ...................................................................... Patch Set 18: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14655/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59344/ : SUCCESS -- To view, visit https://review.coreboot.org/21129 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d4142291c8737b29738c41e8c484328b297b55 Gerrit-Change-Number: 21129 Gerrit-PatchSet: 18 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 10:46:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
by Bill XIE (Code Review) 26 Aug '17

26 Aug '17

Bill XIE has posted comments on this change. ( https://review.coreboot.org/21178 ) Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/21178/6/src/southbridge/intel/bd82x6x/pch.c File src/southbridge/intel/bd82x6x/pch.c: https://review.coreboot.org/#/c/21178/6/src/southbridge/intel/bd82x6x/pch.c… PS6, Line 259: southbridge_intel_bd82x6x_config In order to make the 80-char-per-line limit happy, I have to write it like this. -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 10:41:29 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
by Bill XIE (Code Review) 26 Aug '17

26 Aug '17

Hello Arthur Heymans, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21178 to look at the new patch set (#6). Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ...................................................................... sb/intel/bd82x6x: make hotplug map consistent to remapped ports "pcie_port_coalesce" will cause pcie being remapped under certain conditions, but flags within "pcie_hotplug_map" should be updated along with ports. Test on my lenovo t430s. Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M src/southbridge/intel/bd82x6x/pch.c 1 file changed, 25 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/21178/6 -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
by Bill XIE (Code Review) 26 Aug '17

26 Aug '17

Bill XIE has posted comments on this change. ( https://review.coreboot.org/21178 ) Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c File src/southbridge/intel/bd82x6x/pch.c: https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c… PS5, Line 258: void *chip_info > No need for `void *` here, just give it the correct type please. but its original type will break the 80-char-per-line limit. -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 10:28:07 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
by Nico Huber (Code Review) 26 Aug '17

26 Aug '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21178 ) Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ...................................................................... Patch Set 5: (4 comments) https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c File src/southbridge/intel/bd82x6x/pch.c: https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c… PS5, Line 258: void *chip_info No need for `void *` here, just give it the correct type please. https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c… PS5, Line 261: = NULL The initialization is unnecessary and compilers might even warn about it. https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c… PS5, Line 292: if (config) { Check in pch_pcie_enable() instead please. https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c… PS5, Line 313: If you really want to check `config` for `NULL`, do it here and just `return` in case. By the time you check it in pci_pcie_devicetree_update() it's already been dereferenced multiple times. -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 09:07:29 +0000 Gerrit-HasComments: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017