coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: amd/sb/sb700: Allocate wide LPC I/O devices where possible
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21217 ) Change subject: amd/sb/sb700: Allocate wide LPC I/O devices where possible ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14670/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59360/ : SUCCESS -- To view, visit https://review.coreboot.org/21217 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I004bd0be31c91b76ae2a5e72690b44dca2fd9297 Gerrit-Change-Number: 21217 Gerrit-PatchSet: 1 Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 04:16:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/sb/sb700: Allocate wide LPC I/O devices where possible
by Timothy Pearson (Code Review) 27 Aug '17

27 Aug '17

Timothy Pearson has uploaded this change for review. ( https://review.coreboot.org/21217 Change subject: amd/sb/sb700: Allocate wide LPC I/O devices where possible ...................................................................... amd/sb/sb700: Allocate wide LPC I/O devices where possible When more than 2 wide I/O LPC devices were requested, none of the devices were actually allocated. Furthermore, even though more than three wide I/O devices are not permitted, it is better to allocate the first three than to allocate none. Always allocate the first three wide I/O devices from the wide I/O request list. Change-Id: I004bd0be31c91b76ae2a5e72690b44dca2fd9297 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineering.com> --- M src/southbridge/amd/sb700/lpc.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/21217/1 diff --git a/src/southbridge/amd/sb700/lpc.c b/src/southbridge/amd/sb700/lpc.c index 8ee0395..98d6256 100644 --- a/src/southbridge/amd/sb700/lpc.c +++ b/src/southbridge/amd/sb700/lpc.c @@ -217,8 +217,11 @@ reg_x |= (1 << 23); break; default: - if (var_num >= 3) + if (var_num >= 3) { + printk(BIOS_WARNING, "%s: Ignoring resource %s [base=0x%08x, end=0x%08x] due to" + "I/O window exhaustion\n", __func__, dev_path(child), base, end); continue; /* only 3 var ; compact them ? */ + } switch (var_num) { case 0: reg_x |= (1 << 2); @@ -232,7 +235,6 @@ break; case 2: reg_x |= (1 << 25); - reg_x |= (1 << 24); if ((end - base) < 16) wiosize |= (1 << 3); break; @@ -248,6 +250,7 @@ pci_write_config32(dev, 0x48, reg_x); /* Set WideIO for as many IOs found (fall through is on purpose) */ switch (var_num) { + default: case 2: pci_write_config16(dev, 0x90, reg_var[2]); case 1: -- To view, visit https://review.coreboot.org/21217 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I004bd0be31c91b76ae2a5e72690b44dca2fd9297 Gerrit-Change-Number: 21217 Gerrit-PatchSet: 1 Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com>

1 0

Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21178 ) Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14668/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59358/ : SUCCESS -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 9 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 02:10:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/*: add option to lockdown chipset on normal boot path
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21129 ) Change subject: sb/intel/*: add option to lockdown chipset on normal boot path ...................................................................... Patch Set 19: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14669/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59359/ : SUCCESS -- To view, visit https://review.coreboot.org/21129 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d4142291c8737b29738c41e8c484328b297b55 Gerrit-Change-Number: 21129 Gerrit-PatchSet: 19 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 02:09:44 +0000 Gerrit-HasComments: No

1 0

Change in libgfxinit[master]: dp training: Allow to adjust pre-emphasis during clock recovery
by Felix Held (Code Review) 27 Aug '17

27 Aug '17

Felix Held has posted comments on this change. ( https://review.coreboot.org/21216 ) Change subject: dp training: Allow to adjust pre-emphasis during clock recovery ...................................................................... Patch Set 1: Code-Review+2 this fixes the issue on the apple minidp->vga adapter -- To view, visit https://review.coreboot.org/21216 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibef5236ca771e0e02beb4e76650ffb6974657846 Gerrit-Change-Number: 21216 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 27 Aug 2017 00:59:12 +0000 Gerrit-HasComments: No

1 0

Change in libgfxinit[master]: dp training: Fix channel equalization phase
by Felix Held (Code Review) 27 Aug '17

27 Aug '17

Felix Held has posted comments on this change. ( https://review.coreboot.org/21215 ) Change subject: dp training: Fix channel equalization phase ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21215 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4673390d8c0f9a5642702872e5b4ab11f54797c7 Gerrit-Change-Number: 21215 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 27 Aug 2017 00:58:43 +0000 Gerrit-HasComments: No

1 0

Change in libgfxinit[master]: dp training: Allow to adjust pre-emphasis during clock recovery
by Nico Huber (Code Review) 27 Aug '17

27 Aug '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21216 Change subject: dp training: Allow to adjust pre-emphasis during clock recovery ...................................................................... dp training: Allow to adjust pre-emphasis during clock recovery That's not demanded by the spec but there are sinks in the wild that need it. Change-Id: Ibef5236ca771e0e02beb4e76650ffb6974657846 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-dp_training.adb 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/16/21216/1 diff --git a/common/hw-gfx-dp_training.adb b/common/hw-gfx-dp_training.adb index e7411d0..a2d00a7 100644 --- a/common/hw-gfx-dp_training.adb +++ b/common/hw-gfx-dp_training.adb @@ -257,8 +257,9 @@ -- According to DP spec, only change preemphasis during channel -- equalization. What to do if sink requests it during clock recovery? - -- Linux always accepts new values from the sink, we don't, for now. - if Success and then (CR_Was_Done and not EQ_Done) then + -- Linux always accepts new values from the sink, we too, now: There + -- are sinks in the wild that need this. + if Success and not EQ_Done then Train_Set.Pre_Emph := DP_Info.Max_Requested_Emph (Status, Link); if Train_Set.Pre_Emph > Max_Pre_Emph (Port, Train_Set) -- To view, visit https://review.coreboot.org/21216 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibef5236ca771e0e02beb4e76650ffb6974657846 Gerrit-Change-Number: 21216 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: dp training: Fix channel equalization phase
by Nico Huber (Code Review) 27 Aug '17

27 Aug '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21215 Change subject: dp training: Fix channel equalization phase ...................................................................... dp training: Fix channel equalization phase First, allow updates to voltage swing too during channel equalization. Spec just says to adjust the settings as requested. Second, the loop conditions differ from the clock recovery phase. We have only 6 tries in total but no particular order is enforced. Change-Id: I4673390d8c0f9a5642702872e5b4ab11f54797c7 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-dp_training.adb 1 file changed, 4 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/15/21215/1 diff --git a/common/hw-gfx-dp_training.adb b/common/hw-gfx-dp_training.adb index 19aa4d3..e7411d0 100644 --- a/common/hw-gfx-dp_training.adb +++ b/common/hw-gfx-dp_training.adb @@ -1,5 +1,6 @@ -- -- Copyright (C) 2015-2016 secunet Security Networks AG +-- Copyright (C) 2017 Nico Huber <nico.h(a)gmx.de> -- -- This program is free software; you can redistribute it and/or modify -- it under the terms of the GNU General Public License as published by @@ -244,7 +245,8 @@ EQ_Done := Success and then DP_Info.All_EQ_Done (Status, Link); Success := Success and then (CR_Done or not CR_Was_Done); - if Success and not CR_Done then + -- Voltage swing may be updated during channel equalization too. + if Success and not EQ_Done then Train_Set.Voltage_Swing := DP_Info.Max_Requested_VS (Status, Link); if Train_Set.Voltage_Swing > Max_V_Swing (Port) @@ -366,25 +368,12 @@ end if; if Success then - Retries := 0; - for Tries in 1 .. 32 loop - pragma Loop_Invariant (Retries <= Max_Retry); - + for Tries in 1 .. 6 loop Time.U_Delay (EQ_Delay); - Last_Train_Set := Train_Set; Sink_Adjust_Training (Port, DP, Link, Train_Set, CR_Done, EQ_Done, Success); exit when EQ_Done or not Success; - - if Train_Set.Pre_Emph = Last_Train_Set.Pre_Emph then - exit when Retries = Max_Retry; - Retries := Retries + 1; - else - exit when Last_Train_Set.Pre_Emph = - Max_Pre_Emph (Port, Last_Train_Set); - Retries := 0; - end if; Set_Signal_Levels (Port, Link, Train_Set); Sink_Set_Signal_Levels (Port, DP, Link, Train_Set, Success); -- To view, visit https://review.coreboot.org/21215 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4673390d8c0f9a5642702872e5b4ab11f54797c7 Gerrit-Change-Number: 21215 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: nb/intel/pineview: Fix typo in DRAM timing computation
by Philippe Mathieu-Daudé (Code Review) 26 Aug '17

26 Aug '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/21214 ) Change subject: nb/intel/pineview: Fix typo in DRAM timing computation ...................................................................... Patch Set 2: Code-Review+1 good catch -- To view, visit https://review.coreboot.org/21214 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iace3dabb8546d7a721ef13526ba02522dc712fdd Gerrit-Change-Number: 21214 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 22:48:14 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
by Nico Huber (Code Review) 26 Aug '17

26 Aug '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21178 ) Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ...................................................................... Patch Set 8: Code-Review+2 I've also looked through the affected devicetrees, looks like if it changes something, than to the better. -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 8 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 20:42:19 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017