coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: drivers/i2c/ck505: Add generic driver to configure clockgen
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20042 ) Change subject: drivers/i2c/ck505: Add generic driver to configure clockgen ...................................................................... Patch Set 20: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14685/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59376/ : SUCCESS -- To view, visit https://review.coreboot.org/20042 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie43c4de7891a39f2f443e78213ecd688134e68d7 Gerrit-Change-Number: 20042 Gerrit-PatchSet: 20 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Korolyov <andrey(a)xdel.ru> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 14:10:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/d510mo: Use common ramstage driver to configure the ck505
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21222 ) Change subject: mb/intel/d510mo: Use common ramstage driver to configure the ck505 ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14686/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59377/ : SUCCESS -- To view, visit https://review.coreboot.org/21222 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfa22daf90f9e2eff13b4fc5994664e96903dd1e Gerrit-Change-Number: 21222 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 13:59:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/d510mo: Use common ramstage driver to configure the ck505
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21222 ) Change subject: mb/intel/d510mo: Use common ramstage driver to configure the ck505 ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59374/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/14684/ : SUCCESS -- To view, visit https://review.coreboot.org/21222 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfa22daf90f9e2eff13b4fc5994664e96903dd1e Gerrit-Change-Number: 21222 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 13:51:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/i2c/ck505: Add generic driver to configure clockgen
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20042 ) Change subject: drivers/i2c/ck505: Add generic driver to configure clockgen ...................................................................... Patch Set 19: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14683/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59375/ : SUCCESS -- To view, visit https://review.coreboot.org/20042 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie43c4de7891a39f2f443e78213ecd688134e68d7 Gerrit-Change-Number: 20042 Gerrit-PatchSet: 19 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Korolyov <andrey(a)xdel.ru> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 13:49:00 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/d510mo: Use common ramstage driver to configure the ck505
by Arthur Heymans (Code Review) 27 Aug '17

27 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21222 to look at the new patch set (#2). Change subject: mb/intel/d510mo: Use common ramstage driver to configure the ck505 ...................................................................... mb/intel/d510mo: Use common ramstage driver to configure the ck505 Untested. Change-Id: Icfa22daf90f9e2eff13b4fc5994664e96903dd1e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/intel/d510mo/Kconfig M src/mainboard/intel/d510mo/devicetree.cb M src/mainboard/intel/d510mo/romstage.c 3 files changed, 13 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/21222/2 -- To view, visit https://review.coreboot.org/21222 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icfa22daf90f9e2eff13b4fc5994664e96903dd1e Gerrit-Change-Number: 21222 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/intel/d510mo: Use common ramstage driver to configure the ck505
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21222 ) Change subject: mb/intel/d510mo: Use common ramstage driver to configure the ck505 ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59373/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14682/ : SUCCESS -- To view, visit https://review.coreboot.org/21222 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfa22daf90f9e2eff13b4fc5994664e96903dd1e Gerrit-Change-Number: 21222 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 13:30:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/d510mo: Use common ramstage driver to configure the ck505
by Arthur Heymans (Code Review) 27 Aug '17

27 Aug '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21222 Change subject: mb/intel/d510mo: Use common ramstage driver to configure the ck505 ...................................................................... mb/intel/d510mo: Use common ramstage driver to configure the ck505 Untested. Change-Id: Icfa22daf90f9e2eff13b4fc5994664e96903dd1e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/intel/d510mo/Kconfig M src/mainboard/intel/d510mo/devicetree.cb M src/mainboard/intel/d510mo/romstage.c 3 files changed, 13 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/21222/1 diff --git a/src/mainboard/intel/d510mo/Kconfig b/src/mainboard/intel/d510mo/Kconfig index 0f747cc..b2ce4b6 100644 --- a/src/mainboard/intel/d510mo/Kconfig +++ b/src/mainboard/intel/d510mo/Kconfig @@ -28,6 +28,7 @@ select INTEL_INT15 select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT + select DRIVERS_I2C_CK505 config MAX_CPUS int diff --git a/src/mainboard/intel/d510mo/devicetree.cb b/src/mainboard/intel/d510mo/devicetree.cb index c5b885f..eaae2e0 100644 --- a/src/mainboard/intel/d510mo/devicetree.cb +++ b/src/mainboard/intel/d510mo/devicetree.cb @@ -92,7 +92,18 @@ end device pci 1f.1 off end device pci 1f.2 on end # SATA - device pci 1f.3 on end # SMbus + device pci 1f.3 on # SMbus + chip drivers/i2c/ck505 # ICS9EPRS525 + register "mask" = "{ 0xff, 0xff, 0xff, 0xff, + 0xff, 0xff, 0xff, 0xff, + 0xff, 0xff, 0xff, 0xff, + 0xff }" + register "regs" = "{ 0x61, 0xd9, 0xfe, 0xff, + 0xff, 0x00, 0x00, 0x01, + 0x03, 0x25, 0x83, 0x17, + 0x0d }" + end + end device pci 1f.4 off end device pci 1f.5 off end device pci 1f.6 off end diff --git a/src/mainboard/intel/d510mo/romstage.c b/src/mainboard/intel/d510mo/romstage.c index 502d220..c6406e6 100644 --- a/src/mainboard/intel/d510mo/romstage.c +++ b/src/mainboard/intel/d510mo/romstage.c @@ -102,9 +102,6 @@ void mainboard_romstage_entry(unsigned long bist) { const u8 spd_addrmap[4] = { 0x50, 0x51, 0, 0 }; - const u8 clockgen_block[13] = { 0x61, 0xd9, 0xfe, 0xff, 0xff, 0x00, - 0x00, 0x01, 0x03, 0x25, 0x83, 0x17, - 0x0d }; int cbmem_was_initted; int s3resume = 0; int boot_path; @@ -127,8 +124,6 @@ report_bist_failure(bist); enable_smbus(); - - smbus_block_write(0x69, 0, 13, clockgen_block); pineview_early_initialization(); -- To view, visit https://review.coreboot.org/21222 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icfa22daf90f9e2eff13b4fc5994664e96903dd1e Gerrit-Change-Number: 21222 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: drivers/i2c/ck505: Add generic driver to configure clockgen
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20042 ) Change subject: drivers/i2c/ck505: Add generic driver to configure clockgen ...................................................................... Patch Set 18: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14681/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59372/ : SUCCESS -- To view, visit https://review.coreboot.org/20042 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie43c4de7891a39f2f443e78213ecd688134e68d7 Gerrit-Change-Number: 20042 Gerrit-PatchSet: 18 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Korolyov <andrey(a)xdel.ru> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 13:26:23 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/i2c/ck505: Add generic driver to configure clockgen
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20042 ) Change subject: drivers/i2c/ck505: Add generic driver to configure clockgen ...................................................................... Patch Set 17: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59371/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/14680/ : SUCCESS -- To view, visit https://review.coreboot.org/20042 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie43c4de7891a39f2f443e78213ecd688134e68d7 Gerrit-Change-Number: 20042 Gerrit-PatchSet: 17 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Korolyov <andrey(a)xdel.ru> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 13:11:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: inteltool: add support for 8 Series/C220 Series Chipset
by Arthur Heymans (Code Review) 27 Aug '17

27 Aug '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21213 ) Change subject: inteltool: add support for 8 Series/C220 Series Chipset ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/21213/1/util/inteltool/gpio.c File util/inteltool/gpio.c: https://review.coreboot.org/#/c/21213/1/util/inteltool/gpio.c@993 PS1, Line 993: ip_pch_desktop_defaults lp_pch_desktop_defaults? https://review.coreboot.org/#/c/21213/1/util/inteltool/gpio.c@1003 PS1, Line 1003: ip_pch_desktop_defaults lp_pch_mobile_defaults? -- To view, visit https://review.coreboot.org/21213 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ec155f67c7b6eda47557d00a3d0bcfe4ef98d08 Gerrit-Change-Number: 21213 Gerrit-PatchSet: 1 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 09:25:44 +0000 Gerrit-HasComments: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017