coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: ec/lenovo/h8/acpi/thermal: Add support for passive cooling
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21223 ) Change subject: ec/lenovo/h8/acpi/thermal: Add support for passive cooling ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14690/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59381/ : SUCCESS -- To view, visit https://review.coreboot.org/21223 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I922923a9029de77158988ac254bab4aad9536935 Gerrit-Change-Number: 21223 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 15:37:26 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/gigabyte/ga-b75m-d3*/acpi: Remove redundant code
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21225 ) Change subject: mb/gigabyte/ga-b75m-d3*/acpi: Remove redundant code ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14691/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59382/ : SUCCESS -- To view, visit https://review.coreboot.org/21225 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic893ddbace73ae8b122c4fb675febc7d1e0b5da9 Gerrit-Change-Number: 21225 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 15:33:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/gigabyte/ga-b75m-d3*/acpi: Remove redundant code
by Patrick Rudolph (Code Review) 27 Aug '17

27 Aug '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/21225 Change subject: mb/gigabyte/ga-b75m-d3*/acpi: Remove redundant code ...................................................................... mb/gigabyte/ga-b75m-d3*/acpi: Remove redundant code Remove obsolete code. The same settings are always done in southbridge. Change-Id: Ic893ddbace73ae8b122c4fb675febc7d1e0b5da9 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c M src/mainboard/gigabyte/ga-b75m-d3v/acpi_tables.c 2 files changed, 0 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/21225/1 diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c b/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c index 05a21ae..bbf3241 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c +++ b/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c @@ -38,9 +38,6 @@ void acpi_create_gnvs(global_nvs_t *gnvs) { memset((void *)gnvs, 0, sizeof(*gnvs)); - gnvs->apic = 1; - gnvs->mpen = 1; /* Enable Multi Processing */ - gnvs->pcnt = dev_count_cpu(); /* Disable USB ports in S3 by default */ gnvs->s3u0 = 0; diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/acpi_tables.c b/src/mainboard/gigabyte/ga-b75m-d3v/acpi_tables.c index 05a21ae..bbf3241 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3v/acpi_tables.c +++ b/src/mainboard/gigabyte/ga-b75m-d3v/acpi_tables.c @@ -38,9 +38,6 @@ void acpi_create_gnvs(global_nvs_t *gnvs) { memset((void *)gnvs, 0, sizeof(*gnvs)); - gnvs->apic = 1; - gnvs->mpen = 1; /* Enable Multi Processing */ - gnvs->pcnt = dev_count_cpu(); /* Disable USB ports in S3 by default */ gnvs->s3u0 = 0; -- To view, visit https://review.coreboot.org/21225 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic893ddbace73ae8b122c4fb675febc7d1e0b5da9 Gerrit-Change-Number: 21225 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi/thermal: Add support for passive cooling
by Patrick Rudolph (Code Review) 27 Aug '17

27 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21223 to look at the new patch set (#2). Change subject: ec/lenovo/h8/acpi/thermal: Add support for passive cooling ...................................................................... ec/lenovo/h8/acpi/thermal: Add support for passive cooling The ACPI spec requires _TSP, _TC1, _TC2 and _PSL for passive cooling. _TSP already has been added in a previous commit. Copy the coefficients used on google devices to activate the feature and add _PSL for SandyBridge, IvyBridge and IbexPeak based Thinkpads. On older Thinkpads the PPKG method needs to be implemented first. Tested on Lenovo T430: The CPU is throttled once the passive threshold has been reached. Change-Id: I922923a9029de77158988ac254bab4aad9536935 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/ec/lenovo/h8/acpi/thermal.asl 1 file changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/21223/2 -- To view, visit https://review.coreboot.org/21223 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I922923a9029de77158988ac254bab4aad9536935 Gerrit-Change-Number: 21223 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi/thermal: Add coefficients for passive cooling
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21223 ) Change subject: ec/lenovo/h8/acpi/thermal: Add coefficients for passive cooling ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14688/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59379/ : SUCCESS -- To view, visit https://review.coreboot.org/21223 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I922923a9029de77158988ac254bab4aad9536935 Gerrit-Change-Number: 21223 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 15:27:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Fix FSP1.1 booting issue with HW based dram top ca...
by Subrata Banik (Code Review) 27 Aug '17

27 Aug '17

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/21224 Change subject: soc/intel/skylake: Fix FSP1.1 booting issue with HW based dram top calculation ...................................................................... soc/intel/skylake: Fix FSP1.1 booting issue with HW based dram top calculation This patch ensures skylake device using FSP1.1 can use HW based DRAM top calculation which was broken due to skylake fsp1.1 not honoring any UPD to know PRMMR size and default reserving 1MB for PRMRR size. This WA is not needed for FSP2.0 implementation due to PrmrrSize UPD is available and considering into hw based dram top calculation. BRANCH=none BUG=b:63974384 TEST=Build and boot lars which is using skylake 1.1 fsp. Change-Id: Iade0d2cb2a290fc4c9f0e6b1eaadc8afff2fa581 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/skylake/memmap.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/21224/1 diff --git a/src/soc/intel/skylake/memmap.c b/src/soc/intel/skylake/memmap.c index d5d3724..5014edc 100644 --- a/src/soc/intel/skylake/memmap.c +++ b/src/soc/intel/skylake/memmap.c @@ -178,8 +178,11 @@ dev = dev_find_slot(0, PCI_DEVFN(SA_DEV_SLOT_ROOT, 0)); config = dev->chip_info; +#if IS_ENABLED(CONFIG_PLATFORM_USES_FSP1_1) + prmrr_size = 1*MiB; +#else prmrr_size = config->PrmrrSize; - +#endif if (prmrr_size > 0) { /* * PRMRR Sizes that are > 1MB and < 32MB are -- To view, visit https://review.coreboot.org/21224 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iade0d2cb2a290fc4c9f0e6b1eaadc8afff2fa581 Gerrit-Change-Number: 21224 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi/thermal: Add coefficients for passive cooling
by Patrick Rudolph (Code Review) 27 Aug '17

27 Aug '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/21223 Change subject: ec/lenovo/h8/acpi/thermal: Add coefficients for passive cooling ...................................................................... ec/lenovo/h8/acpi/thermal: Add coefficients for passive cooling The GNU/Linux kernel requires _TSP, _TC1, _TC2 and _PSL for passive cooling. _TSP already has been added in a previous commit. Copy the coefficients used on google devices to activate the feature and add _PSL for SandyBridge and IvyBridge based Thinkpads. On older Thinkpads the PPKG method needs to be implemented first. Tested on Lenovo T430: The CPU is throttled once the passive threshold has been reached. Change-Id: I922923a9029de77158988ac254bab4aad9536935 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/ec/lenovo/h8/acpi/thermal.asl 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/21223/1 diff --git a/src/ec/lenovo/h8/acpi/thermal.asl b/src/ec/lenovo/h8/acpi/thermal.asl index 84e23f9..a40043c 100644 --- a/src/ec/lenovo/h8/acpi/thermal.asl +++ b/src/ec/lenovo/h8/acpi/thermal.asl @@ -40,6 +40,20 @@ /* Thermal sampling period for passive cooling: 10 seconds */ Name (_TSP, 100) + /* Coefficients for passive cooling */ + Name (_TC1, 0x02) + Name (_TC2, 0x05) + + /* FIXME: Add support for other CPUs as well */ +#if IS_ENABLED(CONFIG_CPU_INTEL_MODEL_206AX) || \ + IS_ENABLED(CONFIG_CPU_INTEL_MODEL_306AX) + /* Processors used for passive cooling */ + Method (_PSL, 0, Serialized) + { + Return (\PPKG ()) + } +#endif + Method(_CRT, 0, NotSerialized) { Store (\TCRT, Local0) if (LGreater(Local0, Zero)) { @@ -76,6 +90,20 @@ /* Thermal sampling period for passive cooling: 10 seconds */ Name (_TSP, 100) + /* Coefficients for passive cooling */ + Name (_TC1, 0x02) + Name (_TC2, 0x05) + + /* FIXME: Add support for other CPUs as well */ +#if IS_ENABLED(CONFIG_CPU_INTEL_MODEL_206AX) || \ + IS_ENABLED(CONFIG_CPU_INTEL_MODEL_306AX) + /* Processors used for passive cooling */ + Method (_PSL, 0, Serialized) + { + Return (\PPKG ()) + } +#endif + Method(_CRT, 0, NotSerialized) { Return (C2K(99)) } -- To view, visit https://review.coreboot.org/21223 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I922923a9029de77158988ac254bab4aad9536935 Gerrit-Change-Number: 21223 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: mb/intel/d510mo: Use common ramstage driver to configure the ck505
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21222 ) Change subject: mb/intel/d510mo: Use common ramstage driver to configure the ck505 ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14687/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59378/ : SUCCESS -- To view, visit https://review.coreboot.org/21222 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfa22daf90f9e2eff13b4fc5994664e96903dd1e Gerrit-Change-Number: 21222 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 14:56:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: clang: Enable integrated assembler on clang builds
by Philippe Mathieu-Daudé (Code Review) 27 Aug '17

27 Aug '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/21221 ) Change subject: clang: Enable integrated assembler on clang builds ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/21221 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I883bf7eb2ab52ba3d7a284c96d4aade8bc1ee4ae Gerrit-Change-Number: 21221 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 14:51:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/d510mo: Use common ramstage driver to configure the ck505
by Arthur Heymans (Code Review) 27 Aug '17

27 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21222 to look at the new patch set (#4). Change subject: mb/intel/d510mo: Use common ramstage driver to configure the ck505 ...................................................................... mb/intel/d510mo: Use common ramstage driver to configure the ck505 Untested. Change-Id: Icfa22daf90f9e2eff13b4fc5994664e96903dd1e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/intel/d510mo/Kconfig M src/mainboard/intel/d510mo/devicetree.cb M src/mainboard/intel/d510mo/romstage.c 3 files changed, 14 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/21222/4 -- To view, visit https://review.coreboot.org/21222 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icfa22daf90f9e2eff13b4fc5994664e96903dd1e Gerrit-Change-Number: 21222 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017