coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: drivers/i2c/ck505: Add generic driver to configure clockgen
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20042 ) Change subject: drivers/i2c/ck505: Add generic driver to configure clockgen ...................................................................... Patch Set 21: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14694/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59386/ : SUCCESS -- To view, visit https://review.coreboot.org/20042 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie43c4de7891a39f2f443e78213ecd688134e68d7 Gerrit-Change-Number: 20042 Gerrit-PatchSet: 21 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Korolyov <andrey(a)xdel.ru> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 16:58:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/pineview: Enable dram remapping.
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21228 ) Change subject: nb/intel/pineview: Enable dram remapping. ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14696/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59385/ : SUCCESS -- To view, visit https://review.coreboot.org/21228 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02e7ceed0cd9db7eb7182481b6989f80cef31ee5 Gerrit-Change-Number: 21228 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 16:57:56 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/d510mo: Use common ramstage driver to configure the ck505
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21222 ) Change subject: mb/intel/d510mo: Use common ramstage driver to configure the ck505 ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14695/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59387/ : SUCCESS -- To view, visit https://review.coreboot.org/21222 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfa22daf90f9e2eff13b4fc5994664e96903dd1e Gerrit-Change-Number: 21222 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 16:56:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/pineview: Enable dram remapping.
by Arthur Heymans (Code Review) 27 Aug '17

27 Aug '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21228 Change subject: nb/intel/pineview: Enable dram remapping. ...................................................................... nb/intel/pineview: Enable dram remapping. Without this remapping code enabled, the system fails to boot properly if the amount of ram inserted is larger than 4G minus the mmio space (hardcoded to 1G here). Change-Id: I02e7ceed0cd9db7eb7182481b6989f80cef31ee5 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/pineview/raminit.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/21228/1 diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c index 9bb8fd8..17cafec 100644 --- a/src/northbridge/intel/pineview/raminit.c +++ b/src/northbridge/intel/pineview/raminit.c @@ -2046,14 +2046,16 @@ reclaim = false; tolud = MIN(0x1000 - mmiosize, tom); if ((tom - tolud) > 0x40) { - // reclaim = true; + reclaim = true; } + if (reclaim) { tolud = tolud & ~0x3f; tom = tom & ~0x3f; reclaimbase = MAX(0x1000, tom); reclaimlimit = reclaimbase + (MIN(0x1000, tom) - tolud) - 0x40; } + touud = tom; if (reclaim) { touud = reclaimlimit + 0x40; -- To view, visit https://review.coreboot.org/21228 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I02e7ceed0cd9db7eb7182481b6989f80cef31ee5 Gerrit-Change-Number: 21228 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: mb/intel/d510mo: Use common ramstage driver to configure the ck505
by Arthur Heymans (Code Review) 27 Aug '17

27 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21222 to look at the new patch set (#5). Change subject: mb/intel/d510mo: Use common ramstage driver to configure the ck505 ...................................................................... mb/intel/d510mo: Use common ramstage driver to configure the ck505 TESTED, the screen doesn't jiggle (caused by wrong clock on reset default clockgen configuration) Change-Id: Icfa22daf90f9e2eff13b4fc5994664e96903dd1e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/intel/d510mo/Kconfig M src/mainboard/intel/d510mo/devicetree.cb M src/mainboard/intel/d510mo/romstage.c 3 files changed, 14 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/21222/5 -- To view, visit https://review.coreboot.org/21222 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icfa22daf90f9e2eff13b4fc5994664e96903dd1e Gerrit-Change-Number: 21222 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi/thermal: Add ACPI fan control
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21227 ) Change subject: ec/lenovo/h8/acpi/thermal: Add ACPI fan control ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14693/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59384/ : SUCCESS -- To view, visit https://review.coreboot.org/21227 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I075ff5c69676927db1c5e731294e18796884f97e Gerrit-Change-Number: 21227 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 16:19:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi/thermal: Add ACPI fan control
by Patrick Rudolph (Code Review) 27 Aug '17

27 Aug '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/21227 Change subject: ec/lenovo/h8/acpi/thermal: Add ACPI fan control ...................................................................... ec/lenovo/h8/acpi/thermal: Add ACPI fan control Disengage the fan 10 degree below passive threshold as the automatic EC fan control does not engage the FAN even when CPU starts melting ... Tested on Lenovo T430: The fan disengages at 80°C and keeps running at full speed until temperature drops below 80°C. Change-Id: I075ff5c69676927db1c5e731294e18796884f97e Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/ec/lenovo/h8/acpi/ec.asl M src/ec/lenovo/h8/acpi/thermal.asl 2 files changed, 53 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/21227/1 diff --git a/src/ec/lenovo/h8/acpi/ec.asl b/src/ec/lenovo/h8/acpi/ec.asl index eed0e16..78ce2da 100644 --- a/src/ec/lenovo/h8/acpi/ec.asl +++ b/src/ec/lenovo/h8/acpi/ec.asl @@ -39,6 +39,10 @@ DKR2, 1, /* Dock register 2 */ Offset (0x2a), EVNT, 8, /* write will trigger EC event */ + Offset (0x2f), + , 6, + FAND, 1, /* Fan disengage */ + FANA, 1, /* Fan automatic mode enable */ Offset (0x30), , 6, ALMT, 1, /* Audio Mute + LED */ diff --git a/src/ec/lenovo/h8/acpi/thermal.asl b/src/ec/lenovo/h8/acpi/thermal.asl index fe765c6..0c72a5b 100644 --- a/src/ec/lenovo/h8/acpi/thermal.asl +++ b/src/ec/lenovo/h8/acpi/thermal.asl @@ -81,6 +81,55 @@ #endif Return (C2K(\_SB.PCI0.LPCB.EC.TMP0)) } + + Method (_AC0) { + Store (\TPSV, Local0) + if (LLessEqual(Local0, Zero)) { + Store (95, Local0) + } + + /* Active fan 10 degree below passive threshold */ + Subtract (Local0, 10, Local0) + + If (LGreater (\_SB.PCI0.LPCB.EC.FAND, Zero)) { + /* Turn of 5 degree below trip point */ + Subtract (Local0, 5, Local0) + } + + Return (C2K (Local0)) + } + + Name (_AL0, Package () { TDP0 }) + + PowerResource (TNP0, 0, 0) + { + Method (_STA) { + If (LLessEqual (\_SB.PCI0.LPCB.EC.FAND, 0)) { + Return (Zero) + } Else { + Return (One) + } + } + + Method (_ON) { + Store (One, \_SB.PCI0.LPCB.EC.FAND) + Store (Zero, \_SB.PCI0.LPCB.EC.FANA) + Notify (\_TZ.THM0, 0x81) + } + + Method (_OFF) { + Store (Zero, \_SB.PCI0.LPCB.EC.FAND) + Store (One, \_SB.PCI0.LPCB.EC.FANA) + Notify (\_TZ.THM0, 0x81) + } + } + + Device (TDP0) + { + Name (_HID, EISAID ("PNP0C0B")) + Name (_UID, 0) + Name (_PR0, Package () { TNP0 }) + } } ThermalZone(THM1) -- To view, visit https://review.coreboot.org/21227 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I075ff5c69676927db1c5e731294e18796884f97e Gerrit-Change-Number: 21227 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: mb/sapphire/pureplatinumh61: Disable the SuperIO serial driver
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21226 ) Change subject: mb/sapphire/pureplatinumh61: Disable the SuperIO serial driver ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14692/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59383/ : SUCCESS -- To view, visit https://review.coreboot.org/21226 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b2c93c51e8ddb8b510f0d7f7e3072befeba5d95 Gerrit-Change-Number: 21226 Gerrit-PatchSet: 1 Gerrit-Owner: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 15:43:40 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Fix FSP1.1 booting issue with HW based dram top ca...
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21224 ) Change subject: soc/intel/skylake: Fix FSP1.1 booting issue with HW based dram top calculation ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14689/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59380/ : SUCCESS -- To view, visit https://review.coreboot.org/21224 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iade0d2cb2a290fc4c9f0e6b1eaadc8afff2fa581 Gerrit-Change-Number: 21224 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 15:39:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/sapphire/pureplatinumh61: Disable the SuperIO serial driver
by Nicola Corna (Code Review) 27 Aug '17

27 Aug '17

Nicola Corna has uploaded this change for review. ( https://review.coreboot.org/21226 Change subject: mb/sapphire/pureplatinumh61: Disable the SuperIO serial driver ...................................................................... mb/sapphire/pureplatinumh61: Disable the SuperIO serial driver There is no serial port on this platform. Change-Id: I4b2c93c51e8ddb8b510f0d7f7e3072befeba5d95 Signed-off-by: Nicola Corna <nicola(a)corna.info> --- M src/mainboard/sapphire/pureplatinumh61/Kconfig 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/21226/1 diff --git a/src/mainboard/sapphire/pureplatinumh61/Kconfig b/src/mainboard/sapphire/pureplatinumh61/Kconfig index 58f7d36..56ac6d8 100644 --- a/src/mainboard/sapphire/pureplatinumh61/Kconfig +++ b/src/mainboard/sapphire/pureplatinumh61/Kconfig @@ -15,7 +15,6 @@ select HAVE_ACPI_RESUME select MAINBOARD_HAS_LIBGFXINIT select INTEL_INT15 - select SERIRQ_CONTINUOUS_MODE config HAVE_IFD_BIN bool @@ -53,4 +52,8 @@ int default 8 +config DRIVERS_UART_8250IO + bool + default n + endif -- To view, visit https://review.coreboot.org/21226 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4b2c93c51e8ddb8b510f0d7f7e3072befeba5d95 Gerrit-Change-Number: 21226 Gerrit-PatchSet: 1 Gerrit-Owner: Nicola Corna <nicola(a)corna.info>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017