Hello Adrian-Ken Rueegsegger,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/21206
to look at the new patch set (#2).
Change subject: linux pci: Add dummy PCI access for shared contracts
......................................................................
linux pci: Add dummy PCI access for shared contracts
Other implementations may update the PCI_State in Resource_Size() and
Map(). To share the contract with those implementations, we have to
simulate such accesses.
Change-Id: If994db22d91eb3707e555871d854c3a25a13678b
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M common/linux/hw-pci-dev.adb
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/libhwbase refs/changes/06/21206/2
--
To view, visit https://review.coreboot.org/21206
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: libhwbase
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If994db22d91eb3707e555871d854c3a25a13678b
Gerrit-Change-Number: 21206
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Adrian-Ken Rueegsegger <ken(a)codelabs.ch>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21217 )
Change subject: amd/sb/sb700: Allocate wide LPC I/O devices where possible
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/21217/1/src/southbridge/amd/sb700/lpc.c
File src/southbridge/amd/sb700/lpc.c:
https://review.coreboot.org/#/c/21217/1/src/southbridge/amd/sb700/lpc.c@a166
PS1, Line 166:
:
> Could the indentation be reduced by simply doing "continue" on the opposite
done in https://review.coreboot.org/#/c/21234/
--
To view, visit https://review.coreboot.org/21217
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I004bd0be31c91b76ae2a5e72690b44dca2fd9297
Gerrit-Change-Number: 21217
Gerrit-PatchSet: 1
Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 28 Aug 2017 11:05:15 +0000
Gerrit-HasComments: Yes
Nico Huber has posted comments on this change. ( https://review.coreboot.org/21206 )
Change subject: linux pci: Add dummy PCI access for shared contracts
......................................................................
Patch Set 1:
(1 comment)
> (1 comment)
>
> Instead of faking an access on Linux another potential approach
> could be to explicitly specify the global contracts and accept/
> justify the warning in the Linux implementation using pragma
> Annotate (GNATprove).
This only just became feasible since GNATprove's flow analysis
doesn't seem to explode any more when you give explicit contracts
in generic packages. A first test seems to work with SPARK GPL
2017.
>
> Have not tested it and will result in more code due to contracts.
> On the other hand one would avoid the automatic contract
> generation...
I'm planning to use more explicit contracts once I've tested newer
GNATprove versions more thoroughly. Especially such cases with a
contract shared among different implementations deserve an explicit
contract (i.e. lesson learned). Though, I'm not fond of warning
justifications and try to avoid them where possible. Maybe that
changes once GNAT developers stop rewording the warnings ;)
https://review.coreboot.org/#/c/21206/1/common/linux/hw-pci-dev.adb
File common/linux/hw-pci-dev.adb:
https://review.coreboot.org/#/c/21206/1/common/linux/hw-pci-dev.adb@44
PS1, Line 44: package Dummy is
> Wrapping the procedure in a Dummy package is not necessary. Is there a part
Hmmm, IIRC, I was forced to this pattern by some upstream GNAT
version once and applied it ever since. I'll retest with coreboot's
current reference toolchain (GCC 6.3). Maybe it's not needed any
more.
--
To view, visit https://review.coreboot.org/21206
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: libhwbase
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If994db22d91eb3707e555871d854c3a25a13678b
Gerrit-Change-Number: 21206
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Adrian-Ken Rueegsegger <ken(a)codelabs.ch>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Mon, 28 Aug 2017 10:24:23 +0000
Gerrit-HasComments: Yes
Pan Sheng-Liang has uploaded this change for review. ( https://review.coreboot.org/21233
Change subject: google/Bruce: Add Raydium touch screen support
......................................................................
google/Bruce: Add Raydium touch screen support
Current coreboot does not create ACPI device for OS to recognize Raydium
touchscreen.
List the touch screen in the devicetree so that the correct ACPI device
are created.
BUG=b:64705535
BRANCH=master
TEST=emerge-coral coreboot
Change-Id: Ifdea897ef66dd10f29a8a0e72f9406d316fbe8c7
Signed-off-by: Pan Sheng-Liang <Sheng-Liang.Pan(a)quantatw.com>
---
M src/mainboard/google/reef/variants/coral/devicetree.cb
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/21233/1
diff --git a/src/mainboard/google/reef/variants/coral/devicetree.cb b/src/mainboard/google/reef/variants/coral/devicetree.cb
index d5f546c..4f889d8 100644
--- a/src/mainboard/google/reef/variants/coral/devicetree.cb
+++ b/src/mainboard/google/reef/variants/coral/devicetree.cb
@@ -188,6 +188,13 @@
register "has_power_resource" = "1"
device i2c 10 on end
end
+ chip drivers/i2c/generic
+ register "hid" = ""RAYD0001""
+ register "desc" = ""Raydium Touchscreen""
+ register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)"
+ register "probed" = "1"
+ device i2c 39 on end
+ end
end # - I2C 3
device pci 17.0 on
chip drivers/i2c/generic
--
To view, visit https://review.coreboot.org/21233
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifdea897ef66dd10f29a8a0e72f9406d316fbe8c7
Gerrit-Change-Number: 21233
Gerrit-PatchSet: 1
Gerrit-Owner: Pan Sheng-Liang <sl.pan.quantw(a)gmail.com>
Adrian-Ken Rueegsegger has posted comments on this change. ( https://review.coreboot.org/21206 )
Change subject: linux pci: Add dummy PCI access for shared contracts
......................................................................
Patch Set 1:
(1 comment)
Instead of faking an access on Linux another potential approach could be to explicitly specify the global contracts and accept/justify the warning in the Linux implementation using pragma Annotate (GNATprove).
Have not tested it and will result in more code due to contracts. On the other hand one would avoid the automatic contract generation...
https://review.coreboot.org/#/c/21206/1/common/linux/hw-pci-dev.adb
File common/linux/hw-pci-dev.adb:
https://review.coreboot.org/#/c/21206/1/common/linux/hw-pci-dev.adb@44
PS1, Line 44: package Dummy is
Wrapping the procedure in a Dummy package is not necessary. Is there a particular reason for it?
--
To view, visit https://review.coreboot.org/21206
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: libhwbase
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If994db22d91eb3707e555871d854c3a25a13678b
Gerrit-Change-Number: 21206
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Adrian-Ken Rueegsegger <ken(a)codelabs.ch>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Mon, 28 Aug 2017 09:07:53 +0000
Gerrit-HasComments: Yes