coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: [WIP, TEST]mb/g41c-gs: Attempt to fix broken SATA (in payload and linux)
by build bot (Jenkins) (Code Review) 28 Aug '17

28 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21212 ) Change subject: [WIP,TEST]mb/g41c-gs: Attempt to fix broken SATA (in payload and linux) ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59409/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/14718/ : SUCCESS -- To view, visit https://review.coreboot.org/21212 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8067080ce7c3f080ad9ebcbb27086f8a048aff6b Gerrit-Change-Number: 21212 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 28 Aug 2017 15:31:38 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP, TEST]mb/g41c-gs: Attempt to fix broken SATA (in payload and linux)
by Arthur Heymans (Code Review) 28 Aug '17

28 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21212 to look at the new patch set (#5). Change subject: [WIP,TEST]mb/g41c-gs: Attempt to fix broken SATA (in payload and linux) ...................................................................... [WIP,TEST]mb/g41c-gs: Attempt to fix broken SATA (in payload and linux) Change-Id: I8067080ce7c3f080ad9ebcbb27086f8a048aff6b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/southbridge/intel/i82801gx/lpc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/21212/5 -- To view, visit https://review.coreboot.org/21212 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8067080ce7c3f080ad9ebcbb27086f8a048aff6b Gerrit-Change-Number: 21212 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: crossgcc/Makefile: don't allow to call buildgcc in parallel
by Philippe Mathieu-Daudé (Code Review) 28 Aug '17

28 Aug '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/21229 ) Change subject: crossgcc/Makefile: don't allow to call buildgcc in parallel ...................................................................... Patch Set 1: Code-Review-1 you just want the 'build_gcc' target, right? .NOTPARALLEL: build_gcc -- To view, visit https://review.coreboot.org/21229 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If296414f8cb3bc87862cdc20f3d3acc1a3f78556 Gerrit-Change-Number: 21229 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 28 Aug 2017 15:24:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/gigabyte/ga-b75m-d3*/acpi: Remove redundant code
by Patrick Rudolph (Code Review) 28 Aug '17

28 Aug '17

Patrick Rudolph has submitted this change and it was merged. ( https://review.coreboot.org/21225 ) Change subject: mb/gigabyte/ga-b75m-d3*/acpi: Remove redundant code ...................................................................... mb/gigabyte/ga-b75m-d3*/acpi: Remove redundant code Remove obsolete code. The same settings are always done in southbridge. Change-Id: Ic893ddbace73ae8b122c4fb675febc7d1e0b5da9 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> Reviewed-on: https://review.coreboot.org/21225 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c M src/mainboard/gigabyte/ga-b75m-d3v/acpi_tables.c 2 files changed, 0 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c b/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c index 05a21ae..bbf3241 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c +++ b/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c @@ -38,9 +38,6 @@ void acpi_create_gnvs(global_nvs_t *gnvs) { memset((void *)gnvs, 0, sizeof(*gnvs)); - gnvs->apic = 1; - gnvs->mpen = 1; /* Enable Multi Processing */ - gnvs->pcnt = dev_count_cpu(); /* Disable USB ports in S3 by default */ gnvs->s3u0 = 0; diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/acpi_tables.c b/src/mainboard/gigabyte/ga-b75m-d3v/acpi_tables.c index 05a21ae..bbf3241 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3v/acpi_tables.c +++ b/src/mainboard/gigabyte/ga-b75m-d3v/acpi_tables.c @@ -38,9 +38,6 @@ void acpi_create_gnvs(global_nvs_t *gnvs) { memset((void *)gnvs, 0, sizeof(*gnvs)); - gnvs->apic = 1; - gnvs->mpen = 1; /* Enable Multi Processing */ - gnvs->pcnt = dev_count_cpu(); /* Disable USB ports in S3 by default */ gnvs->s3u0 = 0; -- To view, visit https://review.coreboot.org/21225 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic893ddbace73ae8b122c4fb675febc7d1e0b5da9 Gerrit-Change-Number: 21225 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP, TEST]mb/g41c-gs: Attempt to fix broken SATA (in payload and linux)
by Arthur Heymans (Code Review) 28 Aug '17

28 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21212 to look at the new patch set (#4). Change subject: [WIP,TEST]mb/g41c-gs: Attempt to fix broken SATA (in payload and linux) ...................................................................... [WIP,TEST]mb/g41c-gs: Attempt to fix broken SATA (in payload and linux) Change-Id: I8067080ce7c3f080ad9ebcbb27086f8a048aff6b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/asrock/g41c-gs/romstage.c 1 file changed, 47 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/21212/4 -- To view, visit https://review.coreboot.org/21212 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8067080ce7c3f080ad9ebcbb27086f8a048aff6b Gerrit-Change-Number: 21212 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/mainboard/Kconfig: split out options into own file
by build bot (Jenkins) (Code Review) 28 Aug '17

28 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21236 ) Change subject: src/mainboard/Kconfig: split out options into own file ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14715/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59406/ : SUCCESS -- To view, visit https://review.coreboot.org/21236 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I732dad9758817b0c5a4ade314489bf4d5662e60b Gerrit-Change-Number: 21236 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 28 Aug 2017 14:57:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Kconfig: move remaining Mainboard options into src/mainboard/Kconfig....
by build bot (Jenkins) (Code Review) 28 Aug '17

28 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21237 ) Change subject: Kconfig: move remaining Mainboard options into src/mainboard/Kconfig.mainboard ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14716/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59408/ : SUCCESS -- To view, visit https://review.coreboot.org/21237 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I909d090ea449dbf0ef0328b7c2741214bc8a07d4 Gerrit-Change-Number: 21237 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 28 Aug 2017 14:56:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Kconfig: move Mainboard selection to the top level
by build bot (Jenkins) (Code Review) 28 Aug '17

28 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21238 ) Change subject: Kconfig: move Mainboard selection to the top level ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59407/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14717/ : SUCCESS -- To view, visit https://review.coreboot.org/21238 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic21abc69a3430475c232d8050626d6bca98c5514 Gerrit-Change-Number: 21238 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 28 Aug 2017 14:47:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Kconfig: move Mainboard selection to the top level
by Alexander Couzens (Code Review) 28 Aug '17

28 Aug '17

Alexander Couzens has uploaded this change for review. ( https://review.coreboot.org/21238 Change subject: Kconfig: move Mainboard selection to the top level ...................................................................... Kconfig: move Mainboard selection to the top level Choosing the mainboard vendor and board is the most important settings. It should be choosen as the first thing before configuring anything else. Change-Id: Ic21abc69a3430475c232d8050626d6bca98c5514 Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> --- M src/Kconfig M src/mainboard/Kconfig 2 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/21238/1 diff --git a/src/Kconfig b/src/Kconfig index 4dd1ded..91dea2a 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -16,6 +16,14 @@ mainmenu "coreboot configuration" +source "src/mainboard/Kconfig" + +menu "Mainboard" + +source "src/mainboard/Kconfig.mainboard" + +endmenu + menu "General setup" config COREBOOT_BUILD @@ -266,12 +274,6 @@ help The path and filename of the file to use as graphical bootsplash screen. The file format has to be jpg. - -endmenu - -menu "Mainboard" - -source "src/mainboard/Kconfig" endmenu diff --git a/src/mainboard/Kconfig b/src/mainboard/Kconfig index 7367367..8d4e0d1 100644 --- a/src/mainboard/Kconfig +++ b/src/mainboard/Kconfig @@ -9,5 +9,3 @@ endchoice source "src/mainboard/*/Kconfig" - -source "src/mainboard/Kconfig.mainboard" -- To view, visit https://review.coreboot.org/21238 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic21abc69a3430475c232d8050626d6bca98c5514 Gerrit-Change-Number: 21238 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>

1 0

Change in coreboot[master]: Kconfig: move remaining Mainboard options into src/mainboard/Kconfig....
by Alexander Couzens (Code Review) 28 Aug '17

28 Aug '17

Alexander Couzens has uploaded this change for review. ( https://review.coreboot.org/21237 Change subject: Kconfig: move remaining Mainboard options into src/mainboard/Kconfig.mainboard ...................................................................... Kconfig: move remaining Mainboard options into src/mainboard/Kconfig.mainboard Change-Id: I909d090ea449dbf0ef0328b7c2741214bc8a07d4 Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> --- M src/Kconfig M src/mainboard/Kconfig.mainboard 2 files changed, 40 insertions(+), 40 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/21237/1 diff --git a/src/Kconfig b/src/Kconfig index 637f575..4dd1ded 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -273,46 +273,6 @@ source "src/mainboard/Kconfig" -config DEVICETREE - string - default "devicetree.cb" - help - This symbol allows mainboards to select a different file under their - mainboard directory for the devicetree.cb file. This allows the board - variants that need different devicetrees to be in the same directory. - - Examples: "devicetree.variant.cb" - "variant/devicetree.cb" - -config CBFS_SIZE - hex "Size of CBFS filesystem in ROM" - # Default value set at the end of the file - help - This is the part of the ROM actually managed by CBFS, located at the - end of the ROM (passed through cbfstool -o) on x86 and at at the start - of the ROM (passed through cbfstool -s) everywhere else. It defaults - to span the whole ROM on all but Intel systems that use an Intel Firmware - Descriptor. It can be overridden to make coreboot live alongside other - components like ChromeOS's vboot/FMAP or Intel's IFD / ME / TXE - binaries. - -config FMDFILE - string "fmap description file in fmd format" - default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" if CHROMEOS - default "" - help - The build system creates a default FMAP from ROM_SIZE and CBFS_SIZE, - but in some cases more complex setups are required. - When an fmd is specified, it overrides the default format. - -config MAINBOARD_HAS_TPM2 - bool - default n - help - There is a TPM device installed on the mainboard, and it is - compliant with version 2 TCG TPM specification. Could be connected - over LPC, SPI or I2C. - endmenu # load site-local kconfig to allow user specific defaults and overrides diff --git a/src/mainboard/Kconfig.mainboard b/src/mainboard/Kconfig.mainboard index babbb95..8983b8a 100644 --- a/src/mainboard/Kconfig.mainboard +++ b/src/mainboard/Kconfig.mainboard @@ -155,3 +155,43 @@ config ENABLE_POWER_BUTTON def_bool y if !POWER_BUTTON_IS_OPTIONAL && POWER_BUTTON_FORCE_ENABLE def_bool n if !POWER_BUTTON_IS_OPTIONAL && POWER_BUTTON_FORCE_DISABLE + +config DEVICETREE + string + default "devicetree.cb" + help + This symbol allows mainboards to select a different file under their + mainboard directory for the devicetree.cb file. This allows the board + variants that need different devicetrees to be in the same directory. + + Examples: "devicetree.variant.cb" + "variant/devicetree.cb" + +config CBFS_SIZE + hex "Size of CBFS filesystem in ROM" + # Default value set at the end of the file + help + This is the part of the ROM actually managed by CBFS, located at the + end of the ROM (passed through cbfstool -o) on x86 and at at the start + of the ROM (passed through cbfstool -s) everywhere else. It defaults + to span the whole ROM on all but Intel systems that use an Intel Firmware + Descriptor. It can be overridden to make coreboot live alongside other + components like ChromeOS's vboot/FMAP or Intel's IFD / ME / TXE + binaries. + +config FMDFILE + string "fmap description file in fmd format" + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos.fmd" if CHROMEOS + default "" + help + The build system creates a default FMAP from ROM_SIZE and CBFS_SIZE, + but in some cases more complex setups are required. + When an fmd is specified, it overrides the default format. + +config MAINBOARD_HAS_TPM2 + bool + default n + help + There is a TPM device installed on the mainboard, and it is + compliant with version 2 TCG TPM specification. Could be connected + over LPC, SPI or I2C. -- To view, visit https://review.coreboot.org/21237 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I909d090ea449dbf0ef0328b7c2741214bc8a07d4 Gerrit-Change-Number: 21237 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017