coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: nb/intel/pineview: Fix typo in DRAM timing computation
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21214 ) Change subject: nb/intel/pineview: Fix typo in DRAM timing computation ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59365/ : SUCCESS -- To view, visit https://review.coreboot.org/21214 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iace3dabb8546d7a721ef13526ba02522dc712fdd Gerrit-Change-Number: 21214 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 08:19:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: clang: Enable integrated assembler on clang builds
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21221 ) Change subject: clang: Enable integrated assembler on clang builds ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14674/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59364/ : SUCCESS -- To view, visit https://review.coreboot.org/21221 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I883bf7eb2ab52ba3d7a284c96d4aade8bc1ee4ae Gerrit-Change-Number: 21221 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 07:10:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: clang: Enable integrated assembler on clang builds
by Damien Zammit (Code Review) 27 Aug '17

27 Aug '17

Damien Zammit has uploaded this change for review. ( https://review.coreboot.org/21221 Change subject: clang: Enable integrated assembler on clang builds ...................................................................... clang: Enable integrated assembler on clang builds Change-Id: I883bf7eb2ab52ba3d7a284c96d4aade8bc1ee4ae Signed-off-by: Damien Zammit <damien(a)zamaudio.com> --- M util/xcompile/xcompile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/21221/1 diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 3918346..408ca71 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -252,7 +252,7 @@ # Clang CLANG_CC_${TARCH}:=${CLANG} CLANG_CFLAGS_${TARCH}:=${CFLAGS_CLANG} -CLANG_CFLAGS_${TARCH}+=-no-integrated-as -Qunused-arguments -m${TWIDTH} +CLANG_CFLAGS_${TARCH}+=-Qunused-arguments -m${TWIDTH} # tone down clang compiler warnings CLANG_CFLAGS_${TARCH}+=-Wno-unused-variable -Wno-unused-function -Wno-tautological-compare CLANG_CFLAGS_${TARCH}+=-Wno-shift-overflow -Wno-address-of-packed-member -Wno-initializer-overrides -- To view, visit https://review.coreboot.org/21221 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I883bf7eb2ab52ba3d7a284c96d4aade8bc1ee4ae Gerrit-Change-Number: 21221 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com>

1 0

Change in coreboot[master]: amd/sb/sb700: Allocate wide LPC I/O devices where possible
by Arthur Heymans (Code Review) 27 Aug '17

27 Aug '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21217 ) Change subject: amd/sb/sb700: Allocate wide LPC I/O devices where possible ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Patch looks fine but indentation levels could be reduced/improved so that's easier to read on smaller screens. Can happen in a follow up patch ofc. https://review.coreboot.org/#/c/21217/1/src/southbridge/amd/sb700/lpc.c File src/southbridge/amd/sb700/lpc.c: https://review.coreboot.org/#/c/21217/1/src/southbridge/amd/sb700/lpc.c@a166 PS1, Line 166: : Could the indentation be reduced by simply doing "continue" on the opposite of this conditional? https://review.coreboot.org/#/c/21217/1/src/southbridge/amd/sb700/lpc.c@222 PS1, Line 222: "I/O window exhaustion\n", __func__, dev_path(child), base, end); could this have a few tabs less so it fits the screen more easily? -- To view, visit https://review.coreboot.org/21217 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I004bd0be31c91b76ae2a5e72690b44dca2fd9297 Gerrit-Change-Number: 21217 Gerrit-PatchSet: 1 Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 06:58:55 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: cpu/x86/smm: Fix explicit 'addr32' usage in clang builds
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21219 ) Change subject: cpu/x86/smm: Fix explicit 'addr32' usage in clang builds ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14673/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59362/ : SUCCESS -- To view, visit https://review.coreboot.org/21219 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia160d3f7da6653ea24c8229dc26f265e5f15aabb Gerrit-Change-Number: 21219 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 06:50:26 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: entry32.inc: Fix inconsistent instructions between gcc/clang
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21220 ) Change subject: entry32.inc: Fix inconsistent instructions between gcc/clang ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14672/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59363/ : SUCCESS -- To view, visit https://review.coreboot.org/21220 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67121754ace0dff58035dd5670219616576789f2 Gerrit-Change-Number: 21220 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 06:49:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: cpu/x86 asm: Just use the correct op suffix
by build bot (Jenkins) (Code Review) 27 Aug '17

27 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21218 ) Change subject: cpu/x86 asm: Just use the correct op suffix ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14671/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59361/ : SUCCESS -- To view, visit https://review.coreboot.org/21218 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6095d03d0289b418a49a10f135de5eb0e117cae0 Gerrit-Change-Number: 21218 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 27 Aug 2017 06:48:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: entry32.inc: Fix inconsistent instructions between gcc/clang
by Damien Zammit (Code Review) 27 Aug '17

27 Aug '17

Damien Zammit has uploaded this change for review. ( https://review.coreboot.org/21220 Change subject: entry32.inc: Fix inconsistent instructions between gcc/clang ...................................................................... entry32.inc: Fix inconsistent instructions between gcc/clang Change-Id: I67121754ace0dff58035dd5670219616576789f2 Signed-off-by: Damien Zammit <damien(a)zamaudio.com> --- M src/cpu/x86/32bit/entry32.inc 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/21220/1 diff --git a/src/cpu/x86/32bit/entry32.inc b/src/cpu/x86/32bit/entry32.inc index 2caeb40..d6c95ce 100644 --- a/src/cpu/x86/32bit/entry32.inc +++ b/src/cpu/x86/32bit/entry32.inc @@ -82,11 +82,11 @@ #endif movw $ROM_DATA_SEG, %ax - movw %ax, %ds - movw %ax, %es - movw %ax, %ss - movw %ax, %fs - movw %ax, %gs + mov %eax, %ds + mov %eax, %es + mov %eax, %ss + mov %eax, %fs + mov %eax, %gs /* Restore the BIST value to %eax */ movl %ebp, %eax -- To view, visit https://review.coreboot.org/21220 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I67121754ace0dff58035dd5670219616576789f2 Gerrit-Change-Number: 21220 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com>

1 0

Change in coreboot[master]: cpu/x86/smm: Fix explicit 'addr32' usage in clang builds
by Damien Zammit (Code Review) 27 Aug '17

27 Aug '17

Damien Zammit has uploaded this change for review. ( https://review.coreboot.org/21219 Change subject: cpu/x86/smm: Fix explicit 'addr32' usage in clang builds ...................................................................... cpu/x86/smm: Fix explicit 'addr32' usage in clang builds The addr32 prefix is required by binutils, because even when given an explicit address which is greater than 64KiB, it will throw a warning about truncation, and stupidly emit the opcode with a 16-bit addressing mode and the wrong address. However, in the case of LLVM, this doesn't happen, and is happy to just use 32-bit addressing whenever it may require it. This means that LLVM never really needs an explicit addr32 prefix to use 32-bit addressing in 16-bit mode. Change-Id: Ia160d3f7da6653ea24c8229dc26f265e5f15aabb Signed-off-by: Edward O'Callaghan <funfunctor(a)folklore1984.net> Signed-off-by: Damien Zammit <damien(a)zamaudio.com> --- M src/cpu/x86/smm/smmrelocate.S 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/21219/1 diff --git a/src/cpu/x86/smm/smmrelocate.S b/src/cpu/x86/smm/smmrelocate.S index 4d388a9..22fbaea 100644 --- a/src/cpu/x86/smm/smmrelocate.S +++ b/src/cpu/x86/smm/smmrelocate.S @@ -112,7 +112,11 @@ */ mov $0x38000 + 0x7efc, %ebx +#if IS_ENABLED(CONFIG_COMPILER_LLVM_CLANG) + mov (%ebx), %al +#else addr32 mov (%ebx), %al +#endif cmp $0x64, %al je 1f @@ -124,7 +128,11 @@ smm_relocate: /* Get this CPU's LAPIC ID */ movl $LAPIC_ID, %esi +#if IS_ENABLED(CONFIG_COMPILER_LLVM_CLANG) + movl (%esi), %ecx +#else addr32 movl (%esi), %ecx +#endif shr $24, %ecx /* calculate offset by multiplying the @@ -136,7 +144,11 @@ movl $0xa0000, %eax subl %edx, %eax /* subtract offset, see above */ +#if IS_ENABLED(CONFIG_COMPILER_LLVM_CLANG) + movl %eax, (%ebx) +#else addr32 movl %eax, (%ebx) +#endif /* The next section of code is potentially southbridge specific */ -- To view, visit https://review.coreboot.org/21219 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia160d3f7da6653ea24c8229dc26f265e5f15aabb Gerrit-Change-Number: 21219 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com>

1 0

Change in coreboot[master]: cpu/x86 asm: Just use the correct op suffix
by Damien Zammit (Code Review) 27 Aug '17

27 Aug '17

Damien Zammit has uploaded this change for review. ( https://review.coreboot.org/21218 Change subject: cpu/x86 asm: Just use the correct op suffix ...................................................................... cpu/x86 asm: Just use the correct op suffix LLVM AS doesn't support as much GNU junk extensions, data16/32 is almost never needed in truth if we just use the correct op suffix. So do that here, fixes clang/llvm builds with the integrated-as toggled on. Change-Id: I6095d03d0289b418a49a10f135de5eb0e117cae0 Also-by: Damien Zammit <damien(a)zamaudio.com> Signed-off-by: Damien Zammit <damien(a)zamaudio.com> --- M src/cpu/x86/lapic/secondary.S M src/cpu/x86/sipi_vector.S M src/cpu/x86/smm/smm_stub.S M src/cpu/x86/smm/smmhandler.S M src/device/oprom/realmode/x86_asm.S 5 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/21218/1 diff --git a/src/cpu/x86/lapic/secondary.S b/src/cpu/x86/lapic/secondary.S index 671114a..48360ad 100644 --- a/src/cpu/x86/lapic/secondary.S +++ b/src/cpu/x86/lapic/secondary.S @@ -31,7 +31,7 @@ movw %cs, %ax movw %ax, %ds - data32 lgdt gdtaddr - _secondary_start + lgdtl gdtaddr - _secondary_start movl %cr0, %eax andl $0x7FFAFFD1, %eax /* PG,AM,WP,NE,TS,EM,MP = 0 */ diff --git a/src/cpu/x86/sipi_vector.S b/src/cpu/x86/sipi_vector.S index e654915..8e6925f 100644 --- a/src/cpu/x86/sipi_vector.S +++ b/src/cpu/x86/sipi_vector.S @@ -79,7 +79,7 @@ movl $(gdtaddr), %ebx sub $(_start), %ebx - data32 lgdt (%ebx) + lgdtl (%ebx) movl %cr0, %eax andl $~CR0_CLEAR_FLAGS, %eax diff --git a/src/cpu/x86/smm/smm_stub.S b/src/cpu/x86/smm/smm_stub.S index 824a26b..32435a0 100644 --- a/src/cpu/x86/smm/smm_stub.S +++ b/src/cpu/x86/smm/smm_stub.S @@ -68,7 +68,7 @@ .global _start _start: movl $(smm_relocate_gdt), %ebx - data32 lgdt (%ebx) + lgdtl (%ebx) movl %cr0, %eax andl $~CR0_CLEAR_FLAGS, %eax @@ -76,7 +76,7 @@ movl %eax, %cr0 /* Enable protected mode */ - data32 ljmp $0x8, $smm_trampoline32 + ljmpl $0x8, $smm_trampoline32 .align 4 smm_relocate_gdt: diff --git a/src/cpu/x86/smm/smmhandler.S b/src/cpu/x86/smm/smmhandler.S index dd8a0c0..b57d015 100644 --- a/src/cpu/x86/smm/smmhandler.S +++ b/src/cpu/x86/smm/smmhandler.S @@ -110,7 +110,7 @@ untampered_lapic: #endif movw $(smm_gdtptr16 - smm_handler_start + SMM_HANDLER_OFFSET), %bx - data32 lgdt %cs:(%bx) + lgdtl %cs:(%bx) movl %cr0, %eax andl $0x7FFAFFD1, %eax /* PG,AM,WP,NE,TS,EM,MP = 0 */ @@ -118,7 +118,7 @@ movl %eax, %cr0 /* Enable protected mode */ - data32 ljmp $0x08, $1f + ljmpl $0x08, $1f .code32 1: diff --git a/src/device/oprom/realmode/x86_asm.S b/src/device/oprom/realmode/x86_asm.S index 2bb2a3f..87348cd 100644 --- a/src/device/oprom/realmode/x86_asm.S +++ b/src/device/oprom/realmode/x86_asm.S @@ -177,7 +177,7 @@ /* Now that we are in protected mode * jump to a 32 bit code segment. */ - data32 ljmp $0x10, $RELOCATED(1f) + ljmpl $0x10, $RELOCATED(1f) 1: .code32 mov $0x18, %ax @@ -253,7 +253,7 @@ movl %eax, %cr0 /* Now really going into real mode */ - data32 ljmp $0, $RELOCATED(1f) + ljmpl $0, $RELOCATED(1f) 1: /* put the stack at the end of page zero. That way we can easily @@ -297,7 +297,7 @@ movl %eax, %cr0 /* Now that we are in protected mode jump to a 32-bit code segment. */ - data32 ljmp $0x10, $RELOCATED(1f) + ljmpl $0x10, $RELOCATED(1f) 1: .code32 mov $0x18, %ax @@ -344,7 +344,7 @@ movl %eax, %cr0 /* ... and jump to a 32 bit code segment. */ - data32 ljmp $0x10, $RELOCATED(1f) + ljmpl $0x10, $RELOCATED(1f) 1: .code32 mov $0x18, %ax -- To view, visit https://review.coreboot.org/21218 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6095d03d0289b418a49a10f135de5eb0e117cae0 Gerrit-Change-Number: 21218 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017