coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: sb/intel/*: add option to lockdown chipset on normal boot path
by build bot (Jenkins) (Code Review) 26 Aug '17

26 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21129 ) Change subject: sb/intel/*: add option to lockdown chipset on normal boot path ...................................................................... Patch Set 17: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14653/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59342/ : SUCCESS -- To view, visit https://review.coreboot.org/21129 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d4142291c8737b29738c41e8c484328b297b55 Gerrit-Change-Number: 21129 Gerrit-PatchSet: 17 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 03:50:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
by build bot (Jenkins) (Code Review) 26 Aug '17

26 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21178 ) Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14652/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59341/ : SUCCESS -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 03:45:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
by Bill XIE (Code Review) 26 Aug '17

26 Aug '17

Hello Arthur Heymans, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21178 to look at the new patch set (#5). Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ...................................................................... sb/intel/bd82x6x: make hotplug map consistent to remapped ports "pcie_port_coalesce" will cause pcie being remapped under certain conditions, but flags within "pcie_hotplug_map" should be updated along with ports. Test on my lenovo t430s. Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M src/southbridge/intel/bd82x6x/pch.c 1 file changed, 24 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/21178/5 -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: arch/x86: Add Kconfig option for ACPI \_PR CPU name string
by build bot (Jenkins) (Code Review) 26 Aug '17

26 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21210 ) Change subject: arch/x86: Add Kconfig option for ACPI \_PR CPU name string ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14649/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59336/ : SUCCESS -- To view, visit https://review.coreboot.org/21210 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc0c56783c6da80501e2177de96a414b592cb74f Gerrit-Change-Number: 21210 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 02:03:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/x86: Add Kconfig option for ACPI \_PR CPU name string
by Marshall Dawson (Code Review) 26 Aug '17

26 Aug '17

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/21210 ) Change subject: arch/x86: Add Kconfig option for ACPI \_PR CPU name string ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/21210/1/src/arch/x86/Kconfig File src/arch/x86/Kconfig: https://review.coreboot.org/#/c/21210/1/src/arch/x86/Kconfig@258 PS1, Line 258: srting string -- To view, visit https://review.coreboot.org/21210 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc0c56783c6da80501e2177de96a414b592cb74f Gerrit-Change-Number: 21210 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Sat, 26 Aug 2017 01:41:25 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: amd/stoneyridge: Change ACPI _PR.CPxx to _PR.Pxxx
by build bot (Jenkins) (Code Review) 26 Aug '17

26 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21165 ) Change subject: amd/stoneyridge: Change ACPI _PR.CPxx to _PR.Pxxx ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14650/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59337/ : SUCCESS -- To view, visit https://review.coreboot.org/21165 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4929f9a1c39705c6df9d965c8d030f4d1f0b5e5f Gerrit-Change-Number: 21165 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 01:30:21 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/x86: Add Kconfig option for ACPI \_PR CPU name string
by Marc Jones (Code Review) 26 Aug '17

26 Aug '17

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/21210 Change subject: arch/x86: Add Kconfig option for ACPI \_PR CPU name string ...................................................................... arch/x86: Add Kconfig option for ACPI \_PR CPU name string Add a Kconfig option to change the \PR.CPxx name string. This provides some flexibility when working with table not generated by coreboot. Change-Id: Ibc0c56783c6da80501e2177de96a414b592cb74f Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/arch/x86/Kconfig M src/arch/x86/acpigen.c 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/21210/1 diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index 14827cf..65feba1 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -249,3 +249,12 @@ Set to allow the payload to control normal/fallback image recovery. Note that it is the responsibility of the payload to reset the normal boot bit to 1 after each successsful boot. + +config ACPI_CPU_STRING + string + default "\\_PR.CP%02d" + depends on HAVE_ACPI_TABLES + help + Sets the ACPI name srting in the processor scope as written by + the acpigen function. Default is \_PR.CPxx. Note that you need + the \ escape character in the string. diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c index f9690b3..758386d 100644 --- a/src/arch/x86/acpigen.c +++ b/src/arch/x86/acpigen.c @@ -338,7 +338,7 @@ void acpigen_write_processor(u8 cpuindex, u32 pblock_addr, u8 pblock_len) { /* - Processor (\_PR.CPUcpuindex, cpuindex, pblock_addr, pblock_len) + Processor (\_PR.CPcpuindex, cpuindex, pblock_addr, pblock_len) { */ char pscope[16]; @@ -346,7 +346,7 @@ acpigen_write_len_f(); snprintf(pscope, sizeof(pscope), - "\\_PR.CP%02d", (unsigned int) cpuindex); + CONFIG_ACPI_CPU_STRING, (unsigned int) cpuindex); acpigen_emit_namestring(pscope); acpigen_emit_byte(cpuindex); acpigen_emit_dword(pblock_addr); -- To view, visit https://review.coreboot.org/21210 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibc0c56783c6da80501e2177de96a414b592cb74f Gerrit-Change-Number: 21210 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Change in coreboot[master]: google/cyan: update SPD functions
by build bot (Jenkins) (Code Review) 26 Aug '17

26 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21197 ) Change subject: google/cyan: update SPD functions ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14648/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59335/ : SUCCESS -- To view, visit https://review.coreboot.org/21197 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iafe99ec0795764f645e0a91f5b321be5b4c6fd88 Gerrit-Change-Number: 21197 Gerrit-PatchSet: 5 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 00:40:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/intel/glkrvp: Add support for audio
by build bot (Jenkins) (Code Review) 26 Aug '17

26 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19799 ) Change subject: mainboard/intel/glkrvp: Add support for audio ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14647/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59334/ : SUCCESS -- To view, visit https://review.coreboot.org/19799 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32022ddacd79917730080889c040f842e0c9e6b9 Gerrit-Change-Number: 19799 Gerrit-PatchSet: 5 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 26 Aug 2017 00:05:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/fizz: Enable support for DPTF
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21147 ) Change subject: mainboard/google/fizz: Enable support for DPTF ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14646/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59331/ : SUCCESS -- To view, visit https://review.coreboot.org/21147 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7d125a763f539158aa425fbba1d8a000a3465ca Gerrit-Change-Number: 21147 Gerrit-PatchSet: 5 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Kevin Cheng <kevin.cheng(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 23:22:27 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017