coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: fsp2_0/mma: Enable EvLoader in FSP for MMA
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20863 ) Change subject: fsp2_0/mma: Enable EvLoader in FSP for MMA ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58198/ : SUCCESS -- To view, visit https://review.coreboot.org/20863 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb860b98d6e6f21c116473a962f647e491e8546f Gerrit-Change-Number: 20863 Gerrit-PatchSet: 3 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 19:34:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/scripts: Add script to update submodules
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20703 ) Change subject: util/scripts: Add script to update submodules ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58197/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13620/ : SUCCESS -- To view, visit https://review.coreboot.org/20703 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e238b539f06ce4031e0e99d26943d226a3c2556 Gerrit-Change-Number: 20703 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 19:01:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: WIP: Add extended tests
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20877 ) Change subject: WIP: Add extended tests ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58196/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13619/ : SUCCESS -- To view, visit https://review.coreboot.org/20877 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8a126c5e12526611e3a02ea46c007bb5a997f55 Gerrit-Change-Number: 20877 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 18:07:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: copy & update test routines from what-jenkins-does
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20874 ) Change subject: copy & update test routines from what-jenkins-does ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58195/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13618/ : SUCCESS -- To view, visit https://review.coreboot.org/20874 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e1256d79531112ff84e47a307f55791533806f Gerrit-Change-Number: 20874 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Chris Ching <chingcodes(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 18:02:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: WIP: Add extended tests
by Martin Roth (Code Review) 03 Aug '17

03 Aug '17

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/20877 Change subject: WIP: Add extended tests ...................................................................... WIP: Add extended tests The basic tests were broken out of the what-jenkins-does target. These start to add additional tests that aren't currently done on the servers. TODO: - Add save/restore of .config file - Add additional QEMU testing - Add additional abuild tests for flags that are typically disabled - Get extended payload test working - Need to create config files for each. Change-Id: If8a126c5e12526611e3a02ea46c007bb5a997f55 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M util/testing/Makefile.inc 1 file changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/20877/1 diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc index 160210b..1ff3b8a 100644 --- a/util/testing/Makefile.inc +++ b/util/testing/Makefile.inc @@ -16,11 +16,14 @@ @echo ' what-jenkins-does - Run platform build tests with junit output' @echo ' lint / lint-stable - run coreboot lint tools (all / minimal)' @echo ' test-basic - Run stardard build tests. All expected to pass.' + @echo ' test-extended - Run extended tests.' @echo ' test-lint - basic: Run stable and extended lint tests.' @echo ' test-tools - basic: Tests a basic list of tools.' @echo ' test-abuild - basic: Builds all platforms' @echo ' test-payloads - basic: Builds internal payloads' @echo ' test-cleanup - basic: Cleans coreboot directories' + @echo ' test-external-payloads - extended: Builds external payloads' + @echo ' test-qemu - extended: Builds & boots QEMU targets' # junit.xml is a helper target to wrap builds that don't create junit.xml output # BLD = Subdirectory the build lives in - The name of the build @@ -63,6 +66,12 @@ coreinfo \ nvramcui +TEST_PAYLOADLIST_EXTERNAL= \ +iPXE \ +Memtest86Plus \ +SeaBIOS \ +tint + JENKINS_PAYLOAD?=none TEST_PAYLOAD?=$(JENKINS_PAYLOAD) CPUS?=4 @@ -82,6 +91,8 @@ test-basic: test-lint test-tools test-abuild test-payloads test-cleanup +test-extended: test-external_payloads test-qemu + test-lint: util/lint/lint lint-stable util/lint/lint-015-final-newlines @@ -100,6 +111,14 @@ $(MAKE) $(payload) -j $(CPUS) V=$(V) Q=$(Q)\ || exit 1; ) +test-external-payloads: + export MFLAGS=;export MAKEFLAGS=;\ + $(foreach payload, $(TEST_PAYLOADLIST_EXTERNAL), \ + echo "*** Making payload $$payload ***"; \ + $(MAKE) -C payloads/exeternal/$(payload) clean; \ + $(MAKE) $(payload) -j $(CPUS) V=$(V) Q=$(Q) \ + || exit 1; ) + test-tools: @echo "Build testing $(TOOLLIST)" $(foreach tool, $(TOOLLIST), $(MAKE) -C util/$(tool) clean ; ) @@ -107,6 +126,16 @@ $(foreach tool, $(TOOLLIST), echo "Building $(tool)";export MFLAGS= ;export MAKEFLAGS= ;$(MAKE) -C util/$(tool) all V=$(V) Q=$(Q) || exit 1; ) echo "Building romcc" $(MAKE) -C util/romcc all test -j $(CPUS) V=$(V) Q=$(Q) + +test-qemu: + cp $(top)/configs/config.emulation_qemu_x86_i440fx $(top)/.config + echo "CONFIG_PAYLOAD_NONE=y" > $(top)/.config + make olddefconfig; make clean; make all + qemu-system-x86_64 -bios build/coreboot.rom -serial file:QEMU.LOG -daemonize -pidfile $(top)/QEMU.PID + sleep 5 + kill $$(cat $(top)/QEMU.PID) + grep -q "Payload not loaded." $(top)/QEMU.LOG + rm $(top)/QEMU.PID $(top)/QEMU.LOG test-cleanup: rm -rf coreboot-builds coreboot-builds-chromeos @@ -118,3 +147,4 @@ .PHONY: test-basic test-lint test-abuild test-payloads .PHONY: test-tools test-cleanup test-help .PHONY: lint lint-stable what-jenkins-does +.PHONY: test-extended test-external_payloads test-qemu -- To view, visit https://review.coreboot.org/20877 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If8a126c5e12526611e3a02ea46c007bb5a997f55 Gerrit-Change-Number: 20877 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: soc/intel/common: Use common PMC for SMM
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20307 ) Change subject: soc/intel/common: Use common PMC for SMM ...................................................................... Patch Set 10: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58194/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/13617/ : SUCCESS -- To view, visit https://review.coreboot.org/20307 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I067b99415e882a24970140280d3b223eb1301e2d Gerrit-Change-Number: 20307 Gerrit-PatchSet: 10 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 17:23:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: payloads/coreinfo: Free buffer before returning
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20876 ) Change subject: payloads/coreinfo: Free buffer before returning ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58193/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13616/ : SUCCESS -- To view, visit https://review.coreboot.org/20876 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71e0d3ae7f9152e1f89f8b3206526f0d344e0351 Gerrit-Change-Number: 20876 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 17:04:21 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: payloads/coreinfo: Free buffer before returning
by Martin Roth (Code Review) 03 Aug '17

03 Aug '17

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/20876 Change subject: payloads/coreinfo: Free buffer before returning ...................................................................... payloads/coreinfo: Free buffer before returning Fixes coverity issue 1373370 - Resource leak Change-Id: I71e0d3ae7f9152e1f89f8b3206526f0d344e0351 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M payloads/coreinfo/timestamps_module.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/20876/1 diff --git a/payloads/coreinfo/timestamps_module.c b/payloads/coreinfo/timestamps_module.c index 020fcc6..fda5a96 100644 --- a/payloads/coreinfo/timestamps_module.c +++ b/payloads/coreinfo/timestamps_module.c @@ -210,8 +210,10 @@ g_max_cursor_line = MAX(g_lines_count - 1 - LINES_SHOWN, 0); g_buf = malloc(chars_count); - if (!g_buf) + if (!g_buf) { + free(buffer); return -3; + } if (sanitize_buffer_for_display(buffer, buff_cur + 1, g_buf, chars_count, SCREEN_X) < 0) { -- To view, visit https://review.coreboot.org/20876 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I71e0d3ae7f9152e1f89f8b3206526f0d344e0351 Gerrit-Change-Number: 20876 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: soc/intel: Remove ACPI notification for fan speed change
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20875 ) Change subject: soc/intel: Remove ACPI notification for fan speed change ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58192/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13615/ : SUCCESS -- To view, visit https://review.coreboot.org/20875 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66efa7a7feb911a458829a54dbd0afefabd42394 Gerrit-Change-Number: 20875 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 16:39:40 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel: Remove ACPI notification for fan speed change
by Sumeet R Pawnikar (Code Review) 03 Aug '17

03 Aug '17

Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/20875 Change subject: soc/intel: Remove ACPI notification for fan speed change ...................................................................... soc/intel: Remove ACPI notification for fan speed change In _FSL ACPI notification 0x83 was incorrectly being sent to DPTF. When there should be no notification on fan speed change. Change-Id: I66efa7a7feb911a458829a54dbd0afefabd42394 Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com> --- M src/soc/intel/common/acpi/dptf/fan.asl M src/soc/intel/skylake/acpi/dptf/fan.asl 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/20875/1 diff --git a/src/soc/intel/common/acpi/dptf/fan.asl b/src/soc/intel/common/acpi/dptf/fan.asl index a748088..8c0e886 100644 --- a/src/soc/intel/common/acpi/dptf/fan.asl +++ b/src/soc/intel/common/acpi/dptf/fan.asl @@ -53,7 +53,6 @@ Method (_FSL, 1, Serialized) { Store (Arg0, \_SB.PCI0.LPCB.EC0.FAND) - Notify (DPTF, 0x83) // Reevaluate _ART } Method (_STA) diff --git a/src/soc/intel/skylake/acpi/dptf/fan.asl b/src/soc/intel/skylake/acpi/dptf/fan.asl index 0e40432..74cdb1b 100644 --- a/src/soc/intel/skylake/acpi/dptf/fan.asl +++ b/src/soc/intel/skylake/acpi/dptf/fan.asl @@ -53,7 +53,6 @@ Method (_FSL, 1, Serialized) { Store (Arg0, \_SB.PCI0.LPCB.EC0.FAND) - Notify (DPTF, 0x83) // Re evaluate _ART } Method (_STA) -- To view, visit https://review.coreboot.org/20875 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I66efa7a7feb911a458829a54dbd0afefabd42394 Gerrit-Change-Number: 20875 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017