coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: soc/intel/common/block: Add LPC Common code and use it for APL
by build bot (Jenkins) (Code Review) 05 Aug '17

05 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20659 ) Change subject: soc/intel/common/block: Add LPC Common code and use it for APL ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58223/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13642/ : SUCCESS -- To view, visit https://review.coreboot.org/20659 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ac2e9c195b9ecda97415890cc615f4efb04a27a Gerrit-Change-Number: 20659 Gerrit-PatchSet: 9 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Aug 2017 23:42:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Add LPC Common code and use it for APL
by build bot (Jenkins) (Code Review) 05 Aug '17

05 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20659 ) Change subject: soc/intel/common/block: Add LPC Common code and use it for APL ...................................................................... Patch Set 8: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58222/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/13641/ : SUCCESS -- To view, visit https://review.coreboot.org/20659 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ac2e9c195b9ecda97415890cc615f4efb04a27a Gerrit-Change-Number: 20659 Gerrit-PatchSet: 8 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Aug 2017 23:26:00 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: libpayload: add USEC_TO_MSEC macro.
by build bot (Jenkins) (Code Review) 05 Aug '17

05 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20882 ) Change subject: libpayload: add USEC_TO_MSEC macro. ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58221/ : SUCCESS -- To view, visit https://review.coreboot.org/20882 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I489dc2d1ff55d137936acec74ac875dc7fbc1713 Gerrit-Change-Number: 20882 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Aug 2017 22:47:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: add __must_check to */compiler.h
by build bot (Jenkins) (Code Review) 05 Aug '17

05 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20881 ) Change subject: add __must_check to */compiler.h ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58219/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13639/ : SUCCESS -- To view, visit https://review.coreboot.org/20881 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1812d957b745d6bebe2a8d34a9c4862316aa8530 Gerrit-Change-Number: 20881 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Aug 2017 22:43:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: libpayload: add USEC_TO_MSEC macro.
by build bot (Jenkins) (Code Review) 05 Aug '17

05 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20882 ) Change subject: libpayload: add USEC_TO_MSEC macro. ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58220/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/13640/ : SUCCESS -- To view, visit https://review.coreboot.org/20882 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I489dc2d1ff55d137936acec74ac875dc7fbc1713 Gerrit-Change-Number: 20882 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Aug 2017 22:35:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: libpayload: add USEC_TO_MSEC macro.
by Caveh Jalali (Code Review) 05 Aug '17

05 Aug '17

Caveh Jalali has uploaded a new patch set (#2). ( https://review.coreboot.org/20882 ) Change subject: libpayload: add USEC_TO_MSEC macro. ...................................................................... libpayload: add USEC_TO_MSEC macro. this adds a helper macro to convert microseconds -> milliseconds. Change-Id: I489dc2d1ff55d137936acec74ac875dc7fbc1713 Signed-off-by: Caveh Jalali <caveh(a)google.com> --- M payloads/libpayload/include/stddef.h 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/20882/2 -- To view, visit https://review.coreboot.org/20882 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I489dc2d1ff55d137936acec74ac875dc7fbc1713 Gerrit-Change-Number: 20882 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh(a)google.com>

1 0

Change in coreboot[master]: add USEC_TO_MSEC macro (microseconds -> milliseconds).
by Caveh Jalali (Code Review) 05 Aug '17

05 Aug '17

Caveh Jalali has uploaded this change for review. ( https://review.coreboot.org/20882 Change subject: add USEC_TO_MSEC macro (microseconds -> milliseconds). ...................................................................... add USEC_TO_MSEC macro (microseconds -> milliseconds). Change-Id: I489dc2d1ff55d137936acec74ac875dc7fbc1713 Signed-off-by: Caveh Jalali <caveh(a)google.com> --- M payloads/libpayload/include/stddef.h 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/20882/1 diff --git a/payloads/libpayload/include/stddef.h b/payloads/libpayload/include/stddef.h index 3288487..ef624a9 100644 --- a/payloads/libpayload/include/stddef.h +++ b/payloads/libpayload/include/stddef.h @@ -28,3 +28,5 @@ #define KHz (1000) #define MHz (1000*KHz) #define GHz (1000*MHz) + +#define USEC_TO_MSEC(us) ((us) / 1000) -- To view, visit https://review.coreboot.org/20882 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I489dc2d1ff55d137936acec74ac875dc7fbc1713 Gerrit-Change-Number: 20882 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com>

1 0

Change in coreboot[master]: add __must_check to */compiler.h
by Caveh Jalali (Code Review) 05 Aug '17

05 Aug '17

Caveh Jalali has uploaded this change for review. ( https://review.coreboot.org/20881 Change subject: add __must_check to */compiler.h ...................................................................... add __must_check to */compiler.h the __must_check function attribute is pretty much straight from the linux kernel - used to encourage callers to consume function return values. Change-Id: I1812d957b745d6bebe2a8d34a9c4862316aa8530 Signed-off-by: Caveh Jalali <caveh(a)google.com> --- M payloads/libpayload/include/compiler.h M src/include/compiler.h M util/cbfstool/compiler.h M util/cbmem/compiler.h 4 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/20881/1 diff --git a/payloads/libpayload/include/compiler.h b/payloads/libpayload/include/compiler.h index f218725..a830239 100644 --- a/payloads/libpayload/include/compiler.h +++ b/payloads/libpayload/include/compiler.h @@ -24,5 +24,6 @@ #define __aligned(x) __attribute__((aligned(x))) #define __always_unused __attribute__((unused)) +#define __must_check __attribute__((warn_unused_result)) #endif diff --git a/src/include/compiler.h b/src/include/compiler.h index f218725..a830239 100644 --- a/src/include/compiler.h +++ b/src/include/compiler.h @@ -24,5 +24,6 @@ #define __aligned(x) __attribute__((aligned(x))) #define __always_unused __attribute__((unused)) +#define __must_check __attribute__((warn_unused_result)) #endif diff --git a/util/cbfstool/compiler.h b/util/cbfstool/compiler.h index f218725..a830239 100644 --- a/util/cbfstool/compiler.h +++ b/util/cbfstool/compiler.h @@ -24,5 +24,6 @@ #define __aligned(x) __attribute__((aligned(x))) #define __always_unused __attribute__((unused)) +#define __must_check __attribute__((warn_unused_result)) #endif diff --git a/util/cbmem/compiler.h b/util/cbmem/compiler.h index f218725..a830239 100644 --- a/util/cbmem/compiler.h +++ b/util/cbmem/compiler.h @@ -24,5 +24,6 @@ #define __aligned(x) __attribute__((aligned(x))) #define __always_unused __attribute__((unused)) +#define __must_check __attribute__((warn_unused_result)) #endif -- To view, visit https://review.coreboot.org/20881 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1812d957b745d6bebe2a8d34a9c4862316aa8530 Gerrit-Change-Number: 20881 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com>

1 0

Change in coreboot[master]: mainboard/google/soraka: Configure GPP_B8 in bootblock
by build bot (Jenkins) (Code Review) 04 Aug '17

04 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20869 ) Change subject: mainboard/google/soraka: Configure GPP_B8 in bootblock ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58218/ : SUCCESS -- To view, visit https://review.coreboot.org/20869 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68e1bd67499262a17daade72e9a9fd32934a184d Gerrit-Change-Number: 20869 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Aug 2017 15:36:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/i82801jx: Add romstage smbus and i2c block operations
by build bot (Jenkins) (Code Review) 04 Aug '17

04 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20880 ) Change subject: sb/intel/i82801jx: Add romstage smbus and i2c block operations ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58217/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13638/ : SUCCESS -- To view, visit https://review.coreboot.org/20880 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76bf1ed392d3d18059792106fc482d2259a3f084 Gerrit-Change-Number: 20880 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Aug 2017 12:49:25 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017