coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: nb/intel/x4x/gma.c: Probe VGA EDID on DVI-I ports
by Arthur Heymans (Code Review) 06 Aug '17

06 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20890 to look at the new patch set (#2). Change subject: nb/intel/x4x/gma.c: Probe VGA EDID on DVI-I ports ...................................................................... nb/intel/x4x/gma.c: Probe VGA EDID on DVI-I ports This allows the use of the native VGA init on boards featuring DVI-I ports. TODO: check if the display is actually an analog display. Change-Id: I11a4dd68746e06c7e27ecf3e765bdd0d8cf40515 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/gma.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/20890/2 -- To view, visit https://review.coreboot.org/20890 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I11a4dd68746e06c7e27ecf3e765bdd0d8cf40515 Gerrit-Change-Number: 20890 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/intel/x4x/gma.c: Probe VGA EDID on DVI-I ports
by build bot (Jenkins) (Code Review) 06 Aug '17

06 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20890 ) Change subject: nb/intel/x4x/gma.c: Probe VGA EDID on DVI-I ports ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58241/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/13659/ : SUCCESS -- To view, visit https://review.coreboot.org/20890 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11a4dd68746e06c7e27ecf3e765bdd0d8cf40515 Gerrit-Change-Number: 20890 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 06 Aug 2017 14:27:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/*/gma.c: Use macros for GMBUS numbers
by build bot (Jenkins) (Code Review) 06 Aug '17

06 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20889 ) Change subject: nb/intel/*/gma.c: Use macros for GMBUS numbers ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58240/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13658/ : SUCCESS -- To view, visit https://review.coreboot.org/20889 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I885b6bd9f5be6b4e3696a530016123a3e81c4b10 Gerrit-Change-Number: 20889 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 06 Aug 2017 14:09:34 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x/gma.c: Probe VGA EDID on DVI-I ports
by Arthur Heymans (Code Review) 06 Aug '17

06 Aug '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20890 Change subject: nb/intel/x4x/gma.c: Probe VGA EDID on DVI-I ports ...................................................................... nb/intel/x4x/gma.c: Probe VGA EDID on DVI-I ports This allows the use of the native VGA init on boards featuring DVI-I ports. TODO: check if the display is actually an analog display. Change-Id: I11a4dd68746e06c7e27ecf3e765bdd0d8cf40515 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/gma.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/20890/1 diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c index e91d778..a71ef83 100644 --- a/src/northbridge/intel/x4x/gma.c +++ b/src/northbridge/intel/x4x/gma.c @@ -74,6 +74,15 @@ u32 pixel_m1 = 1; u32 pixel_m2 = 1; + vga_gmbus = GMBUS_PORT_VGADDC; + + if (IS_ENABLED(GFX_GMA_ANALOG_I2C_HDMI_B)) + vga_gmbus = GMBUS_PORT_DPB; + else if (IS_ENABLED(GFX_GMA_ANALOG_I2C_HDMI_C)) + vga_gmbus = GMBUS_PORT_DPC; + else if (IS_ENABLED(GFX_GMA_ANALOG_I2C_HDMI_D)) + vga_gmbus = GMBUS_PORT_DPD; + vga_gr_write(0x18, 0); /* Set up GTT */ @@ -113,7 +122,8 @@ udelay(1); - intel_gmbus_read_edid(mmio + GMBUS0, GMBUS_PORT_VGADDC, 0x50, edid_data, + /* FIXME: check if it is actually an analog display */ + intel_gmbus_read_edid(mmio + GMBUS0, vga_gmbus, 0x50, edid_data, sizeof(edid_data)); intel_gmbus_stop(mmio + GMBUS0); decode_edid(edid_data, -- To view, visit https://review.coreboot.org/20890 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I11a4dd68746e06c7e27ecf3e765bdd0d8cf40515 Gerrit-Change-Number: 20890 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: nb/intel/*/gma.c: Use macros for GMBUS numbers
by Arthur Heymans (Code Review) 06 Aug '17

06 Aug '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20889 Change subject: nb/intel/*/gma.c: Use macros for GMBUS numbers ...................................................................... nb/intel/*/gma.c: Use macros for GMBUS numbers Change-Id: I885b6bd9f5be6b4e3696a530016123a3e81c4b10 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/gm45/gma.c M src/northbridge/intel/i945/gma.c M src/northbridge/intel/nehalem/gma.c M src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c M src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c M src/northbridge/intel/x4x/gma.c 6 files changed, 15 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/20889/1 diff --git a/src/northbridge/intel/gm45/gma.c b/src/northbridge/intel/gm45/gma.c index 2404671..91aa700 100644 --- a/src/northbridge/intel/gm45/gma.c +++ b/src/northbridge/intel/gm45/gma.c @@ -588,8 +588,8 @@ mmio = res2mmio(gtt_res, 0, 0); printk(BIOS_DEBUG, "VGA EDID\n"); - intel_gmbus_read_edid(mmio + GMBUS0, 2, 0x50, edid_data_vga, - sizeof(edid_data_vga)); + intel_gmbus_read_edid(mmio + GMBUS0, GMBUS_PORT_VGADDC, 0x50, + edid_data_vga, sizeof(edid_data_vga)); intel_gmbus_stop(mmio + GMBUS0); vga_edid_status = decode_edid(edid_data_vga, sizeof(edid_data_vga), &edid_vga); @@ -748,7 +748,8 @@ } printk(BIOS_DEBUG, "LVDS EDID\n"); - intel_gmbus_read_edid(mmio + GMBUS0, 3, 0x50, edid_data_lvds, + intel_gmbus_read_edid(mmio + GMBUS0, GMBUS_PORT_PANEL, 0x50, + edid_data_lvds, sizeof(edid_data_lvds)); intel_gmbus_stop(mmio + GMBUS0); decode_edid(edid_data_lvds, sizeof(edid_data_lvds), &edid_lvds); diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c index cba2860..37f73ed 100644 --- a/src/northbridge/intel/i945/gma.c +++ b/src/northbridge/intel/i945/gma.c @@ -104,8 +104,8 @@ "i915lightup: graphics %p mmio %p addrport %04x physbase %08x\n", (void *)pgfx, mmiobase, piobase, pphysbase); - intel_gmbus_read_edid(mmiobase + GMBUS0, 3, 0x50, edid_data, - sizeof(edid_data)); + intel_gmbus_read_edid(mmiobase + GMBUS0, GMBUS_PORT_PANEL, 0x50, + edid_data, sizeof(edid_data)); decode_edid(edid_data, sizeof(edid_data), &edid); mode = &edid.mode; @@ -663,7 +663,8 @@ /* probe if VGA is connected and always run */ /* VGA init if no LVDS is connected */ - if (!probe_edid(mmiobase, 3) || probe_edid(mmiobase, 2)) + if (!probe_edid(mmiobase, GMBUS_PORT_PANEL) || + probe_edid(mmiobase, GMBUS_PORT_VGADDC)) err = intel_gma_init_vga(conf, pci_read_config32(dev, 0x5c) & ~0xf, iobase, mmiobase, graphics_base); diff --git a/src/northbridge/intel/nehalem/gma.c b/src/northbridge/intel/nehalem/gma.c index 0607f34..56d8523 100644 --- a/src/northbridge/intel/nehalem/gma.c +++ b/src/northbridge/intel/nehalem/gma.c @@ -712,8 +712,8 @@ power_port(mmio); - intel_gmbus_read_edid(mmio + PCH_GMBUS0, 3, 0x50, edid_data, - sizeof(edid_data)); + intel_gmbus_read_edid(mmio + PCH_GMBUS0, GMBUS_PORT_PANEL, 0x50, + edid_data, sizeof(edid_data)); intel_gmbus_stop(mmio + PCH_GMBUS0); decode_edid(edid_data, sizeof(edid_data), &edid); diff --git a/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c b/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c index cad5078..23ecd44 100644 --- a/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c +++ b/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c @@ -182,8 +182,8 @@ enable_port(mmio); - intel_gmbus_read_edid(mmio + PCH_GMBUS0, 3, 0x50, edid_data, - sizeof(edid_data)); + intel_gmbus_read_edid(mmio + PCH_GMBUS0, GMBUS_PORT_PANEL, 0x50, + edid_data, sizeof(edid_data)); intel_gmbus_stop(mmio + PCH_GMBUS0); decode_edid(edid_data, sizeof(edid_data), &edid); diff --git a/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c b/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c index c3139a9..5e8c188 100644 --- a/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c +++ b/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c @@ -176,8 +176,8 @@ power_port(mmio); - intel_gmbus_read_edid(mmio + PCH_GMBUS0, 3, 0x50, edid_data, - sizeof(edid_data)); + intel_gmbus_read_edid(mmio + PCH_GMBUS0, GMBUS_PORT_PANEL, 0x50, + edid_data, sizeof(edid_data)); decode_edid(edid_data, sizeof(edid_data), &edid); mode = &edid.mode; diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c index 561e776..e91d778 100644 --- a/src/northbridge/intel/x4x/gma.c +++ b/src/northbridge/intel/x4x/gma.c @@ -113,7 +113,7 @@ udelay(1); - intel_gmbus_read_edid(mmio + GMBUS0, 2, 0x50, edid_data, + intel_gmbus_read_edid(mmio + GMBUS0, GMBUS_PORT_VGADDC, 0x50, edid_data, sizeof(edid_data)); intel_gmbus_stop(mmio + GMBUS0); decode_edid(edid_data, -- To view, visit https://review.coreboot.org/20889 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I885b6bd9f5be6b4e3696a530016123a3e81c4b10 Gerrit-Change-Number: 20889 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1: Add 4GiB SPD index 2
by build bot (Jenkins) (Code Review) 06 Aug '17

06 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20887 ) Change subject: mb/lenovo/x1_carbon_gen1: Add 4GiB SPD index 2 ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58239/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13657/ : SUCCESS -- To view, visit https://review.coreboot.org/20887 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I218fd48c8e29563ef089d60ebde7bc36ac8ab189 Gerrit-Change-Number: 20887 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 05 Aug 2017 22:28:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1: Add 4GiB SPD index 2
by Nico Huber (Code Review) 06 Aug '17

06 Aug '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/20887 ) Change subject: mb/lenovo/x1_carbon_gen1: Add 4GiB SPD index 2 ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/20887/1/src/mainboard/lenovo/x1_carbon_gen1… File src/mainboard/lenovo/x1_carbon_gen1/romstage.c: https://review.coreboot.org/#/c/20887/1/src/mainboard/lenovo/x1_carbon_gen1… PS1, Line 111: We only support elpida > comment needs to be updated. thanks, done -- To view, visit https://review.coreboot.org/20887 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I218fd48c8e29563ef089d60ebde7bc36ac8ab189 Gerrit-Change-Number: 20887 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 05 Aug 2017 22:23:34 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1: Add 4GiB SPD index 2
by Nico Huber (Code Review) 06 Aug '17

06 Aug '17

Hello Alexander Couzens, Arthur Heymans, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20887 to look at the new patch set (#2). Change subject: mb/lenovo/x1_carbon_gen1: Add 4GiB SPD index 2 ...................................................................... mb/lenovo/x1_carbon_gen1: Add 4GiB SPD index 2 Change-Id: I218fd48c8e29563ef089d60ebde7bc36ac8ab189 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/mainboard/lenovo/x1_carbon_gen1/romstage.c M src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc A src/mainboard/lenovo/x1_carbon_gen1/spd/samsung.hex 3 files changed, 21 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/20887/2 -- To view, visit https://review.coreboot.org/20887 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I218fd48c8e29563ef089d60ebde7bc36ac8ab189 Gerrit-Change-Number: 20887 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1: Add 4GiB SPD index 2
by Alexander Couzens (Code Review) 06 Aug '17

06 Aug '17

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/20887 ) Change subject: mb/lenovo/x1_carbon_gen1: Add 4GiB SPD index 2 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/20887 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I218fd48c8e29563ef089d60ebde7bc36ac8ab189 Gerrit-Change-Number: 20887 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 05 Aug 2017 22:03:40 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1: Add 4GiB SPD index 2
by Arthur Heymans (Code Review) 05 Aug '17

05 Aug '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/20887 ) Change subject: mb/lenovo/x1_carbon_gen1: Add 4GiB SPD index 2 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/20887/1/src/mainboard/lenovo/x1_carbon_gen1… File src/mainboard/lenovo/x1_carbon_gen1/romstage.c: https://review.coreboot.org/#/c/20887/1/src/mainboard/lenovo/x1_carbon_gen1… PS1, Line 111: we only support elpida comment needs to be updated. -- To view, visit https://review.coreboot.org/20887 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I218fd48c8e29563ef089d60ebde7bc36ac8ab189 Gerrit-Change-Number: 20887 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 05 Aug 2017 19:22:09 +0000 Gerrit-HasComments: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017