coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: soc/intel/apollolake: Provide option to use Common MP Init
by Barnali Sarkar (Code Review) 07 Aug '17

07 Aug '17

Barnali Sarkar has uploaded this change for review. ( https://review.coreboot.org/20895 Change subject: soc/intel/apollolake: Provide option to use Common MP Init ...................................................................... soc/intel/apollolake: Provide option to use Common MP Init This patch provides the option to use the common CPU Mp Init code by selecting a Config Token. CONFIG_SOC_INTEL_COMMON_BLOCK_CPU_MPINIT config token can be selected to use the Common MP Init Code, also where CPU MP Init is done before FSP-S Init. And if the config token is not selected, the old way of implementation will exist, where MP Init is been done after FSP-S. CQ-DEPEND=CL:*397551 BUG=none BRANCH=none TEST=Build and boot Reef Change-Id: I35d012785000d3f3bfcc34138cda9cd4591559f6 Signed-off-by: Barnali Sarkar <barnali.sarkar(a)intel.com> --- M src/soc/intel/apollolake/chip.c M src/soc/intel/apollolake/cpu.c M src/soc/intel/apollolake/include/soc/cpu.h 3 files changed, 47 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/20895/1 diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index ec4662c..8eaa319 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -150,7 +150,11 @@ .read_resources = DEVICE_NOOP, .set_resources = DEVICE_NOOP, .enable_resources = DEVICE_NOOP, +#if IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU_MPINIT) + .init = DEVICE_NOOP, +#else .init = apollolake_init_cpus, +#endif .scan_bus = NULL, .acpi_fill_ssdt_generator = generate_cpu_entries, }; diff --git a/src/soc/intel/apollolake/cpu.c b/src/soc/intel/apollolake/cpu.c index 22e3c80..cac528c 100644 --- a/src/soc/intel/apollolake/cpu.c +++ b/src/soc/intel/apollolake/cpu.c @@ -35,6 +35,11 @@ #include <soc/iomap.h> #include <soc/pm.h> #include <cpu/intel/turbo.h> +#if IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU_MPINIT) +#include <fsp/api.h> +#include <intelblocks/mp_init.h> +#include <romstage_handoff.h> +#endif static const struct reg_script core_msr_script[] = { /* Enable C-state and IO/MWAIT redirect */ @@ -57,7 +62,11 @@ REG_SCRIPT_END }; +#if IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU_MPINIT) +void soc_core_init(device_t cpu, const void *microcode) +#else static void soc_core_init(device_t cpu) +#endif { /* Set core MSRs */ reg_script_run(core_msr_script); @@ -69,6 +78,7 @@ enable_pm_timer_emulation(); } +#if !IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU_MPINIT) static struct device_operations cpu_dev_ops = { .init = soc_core_init, }; @@ -85,6 +95,7 @@ .ops = &cpu_dev_ops, .id_table = cpu_table, }; +#endif /* * MP and SMM loading initialization. @@ -97,6 +108,7 @@ static struct smm_relocation_attrs relo_attrs; +#if !IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU_MPINIT) static void read_cpu_topology(unsigned int *num_phys, unsigned int *num_virt) { msr_t msr; @@ -139,6 +151,23 @@ /* Make sure BSP is using the microcode from cbfs */ intel_microcode_load_unlocked(*microcode); } +#else +/* + * Do essential initialization tasks before APs can be fired up - + * + * Skip Pre MP init MTRR programming, as MTRRs are mirrored from BSP, + * that are set prior to ramstage. + * Real MTRRs programming are being done after resource allocation. + * + * Do, FSP loading before MP Init to ensure that the FSP cmponent stored in + * external stage cache in TSEG does not flush off due to SMM relocation + * during MP Init stage. + */ +static void pre_mp_init(void) +{ + fsps_load(romstage_handoff_is_resume()); +} +#endif static void get_smm_info(uintptr_t *perm_smbase, size_t *perm_smsize, size_t *smm_save_state_size) @@ -197,6 +226,14 @@ .post_mp_init = smm_southbridge_enable, }; +#if IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU_MPINIT) +void soc_init_cpus(struct bus *cpu_bus, const void *microcode) +{ + /* Clear for take-off */ + if (mp_init_with_smm(cpu_bus, &mp_ops)) + printk(BIOS_ERR, "MP initialization failure.\n"); +} +#else void apollolake_init_cpus(struct device *dev) { /* Clear for take-off */ @@ -208,3 +245,4 @@ IS_ENABLED(CONFIG_BOOT_DEVICE_SPI_FLASH)) fast_spi_cache_bios_region(); } +#endif diff --git a/src/soc/intel/apollolake/include/soc/cpu.h b/src/soc/intel/apollolake/include/soc/cpu.h index 10e0595..67d7dc8 100644 --- a/src/soc/intel/apollolake/include/soc/cpu.h +++ b/src/soc/intel/apollolake/include/soc/cpu.h @@ -18,15 +18,17 @@ #ifndef _SOC_APOLLOLAKE_CPU_H_ #define _SOC_APOLLOLAKE_CPU_H_ +#if !IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU_MPINIT) #define CPUID_APOLLOLAKE_A0 0x506c8 #define CPUID_APOLLOLAKE_B0 0x506c9 #define CPUID_GLK_A0 0x706a0 #define CPUID_GLK_B0 0x706a1 -/* Common Timer Copy (CTC) frequency - 19.2MHz. */ -#define CTC_FREQ 19200000 - struct device; void apollolake_init_cpus(struct device *dev); +#endif + +/* Common Timer Copy (CTC) frequency - 19.2MHz. */ +#define CTC_FREQ 19200000 #endif /* _SOC_APOLLOLAKE_CPU_H_ */ -- To view, visit https://review.coreboot.org/20895 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I35d012785000d3f3bfcc34138cda9cd4591559f6 Gerrit-Change-Number: 20895 Gerrit-PatchSet: 1 Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: nb/intel/x4x/gma.c: Probe VGA EDID on DVI-I ports
by build bot (Jenkins) (Code Review) 07 Aug '17

07 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20890 ) Change subject: nb/intel/x4x/gma.c: Probe VGA EDID on DVI-I ports ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58255/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13670/ : SUCCESS -- To view, visit https://review.coreboot.org/20890 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11a4dd68746e06c7e27ecf3e765bdd0d8cf40515 Gerrit-Change-Number: 20890 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 Aug 2017 12:25:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: driver/intel/gma: Allow use of GFX_GMA_ANALOG_I2C_HDMI_x in C NGI
by build bot (Jenkins) (Code Review) 07 Aug '17

07 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20894 ) Change subject: driver/intel/gma: Allow use of GFX_GMA_ANALOG_I2C_HDMI_x in C NGI ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58256/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13672/ : SUCCESS -- To view, visit https://review.coreboot.org/20894 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If29c541d414e12b95d96ae9c249a7a20e863fe06 Gerrit-Change-Number: 20894 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 Aug 2017 12:23:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/*/gma.c: Use macros for GMBUS numbers
by build bot (Jenkins) (Code Review) 07 Aug '17

07 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20889 ) Change subject: nb/intel/*/gma.c: Use macros for GMBUS numbers ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58254/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13671/ : SUCCESS -- To view, visit https://review.coreboot.org/20889 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I885b6bd9f5be6b4e3696a530016123a3e81c4b10 Gerrit-Change-Number: 20889 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 Aug 2017 12:21:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: driver/intel/gma: Allow use of GFX_GMA_ANALOG_I2C_HDMI_x in C NGI
by Arthur Heymans (Code Review) 07 Aug '17

07 Aug '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20894 Change subject: driver/intel/gma: Allow use of GFX_GMA_ANALOG_I2C_HDMI_x in C NGI ...................................................................... driver/intel/gma: Allow use of GFX_GMA_ANALOG_I2C_HDMI_x in C NGI These Kconfig option can be reused for the same purpose of selecting the correct i2c pins for probing the analog output EDID in C native graphic init. For this purpose this patch makes those options independent of GFX_GMA and MAINBOARD_HAS_LIBGFXINIT. Change-Id: If29c541d414e12b95d96ae9c249a7a20e863fe06 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/drivers/intel/gma/Kconfig 1 file changed, 11 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/20894/1 diff --git a/src/drivers/intel/gma/Kconfig b/src/drivers/intel/gma/Kconfig index 1e60a42..b63a1c0 100644 --- a/src/drivers/intel/gma/Kconfig +++ b/src/drivers/intel/gma/Kconfig @@ -47,6 +47,17 @@ supported platform with a choice seems to be Pineview, where the alternative is 100MHz vs. the default 96MHz. +config GFX_GMA_ANALOG_I2C_HDMI_B + bool + default n + +config GFX_GMA_ANALOG_I2C_HDMI_C + bool + default n + +config GFX_GMA_ANALOG_I2C_HDMI_D + bool + default n config GFX_GMA def_bool y @@ -84,18 +95,6 @@ string default "DP" if GFX_GMA_INTERNAL_IS_EDP default "LVDS" - -config GFX_GMA_ANALOG_I2C_HDMI_B - bool - default n - -config GFX_GMA_ANALOG_I2C_HDMI_C - bool - default n - -config GFX_GMA_ANALOG_I2C_HDMI_D - bool - default n config GFX_GMA_ANALOG_I2C_PORT string -- To view, visit https://review.coreboot.org/20894 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If29c541d414e12b95d96ae9c249a7a20e863fe06 Gerrit-Change-Number: 20894 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: mb/intel/d510mo: Configure clockgen
by build bot (Jenkins) (Code Review) 07 Aug '17

07 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19595 ) Change subject: mb/intel/d510mo: Configure clockgen ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58253/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13669/ : SUCCESS -- To view, visit https://review.coreboot.org/19595 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08449f0b8b90a1781e6dec91140bf219ea07aaf9 Gerrit-Change-Number: 19595 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 Aug 2017 11:33:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/d510mo: Configure clockgen
by build bot (Jenkins) (Code Review) 07 Aug '17

07 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19595 ) Change subject: mb/intel/d510mo: Configure clockgen ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58251/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13667/ : SUCCESS -- To view, visit https://review.coreboot.org/19595 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08449f0b8b90a1781e6dec91140bf219ea07aaf9 Gerrit-Change-Number: 19595 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 Aug 2017 07:24:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: rx6110sa: Make sure that VLF bit will be cleared
by build bot (Jenkins) (Code Review) 07 Aug '17

07 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20893 ) Change subject: rx6110sa: Make sure that VLF bit will be cleared ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58250/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13666/ : SUCCESS -- To view, visit https://review.coreboot.org/20893 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2cfdabf4cd4df834395d6a102c6ae70568e71db Gerrit-Change-Number: 20893 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 Aug 2017 07:14:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: rx6110sa: Make sure that VLF bit will be cleared
by Werner Zeh (Code Review) 07 Aug '17

07 Aug '17

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/20893 Change subject: rx6110sa: Make sure that VLF bit will be cleared ...................................................................... rx6110sa: Make sure that VLF bit will be cleared Ensure that the VLF bit will be cleared after a power loss event even if the stopwatch has expired before the code to clear the bit is reached. Change-Id: Ib2cfdabf4cd4df834395d6a102c6ae70568e71db Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M src/drivers/i2c/rx6110sa/rx6110sa.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/20893/1 diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.c b/src/drivers/i2c/rx6110sa/rx6110sa.c index 761d83d..2c62f23 100644 --- a/src/drivers/i2c/rx6110sa/rx6110sa.c +++ b/src/drivers/i2c/rx6110sa/rx6110sa.c @@ -163,7 +163,8 @@ * VLF-bit can be cleared. */ while (!stopwatch_expired(&sw)) - flags &= ~VLF_BIT; + ; + flags &= ~VLF_BIT; rx6110sa_write(dev, FLAG_REGISTER, flags); /* Before setting the clock stop oscillator. */ -- To view, visit https://review.coreboot.org/20893 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2cfdabf4cd4df834395d6a102c6ae70568e71db Gerrit-Change-Number: 20893 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>

1 0

Change in coreboot[master]: [WIP]console/Kconfig: fix SPI flash console dependencies
by build bot (Jenkins) (Code Review) 07 Aug '17

07 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20892 ) Change subject: [WIP]console/Kconfig: fix SPI flash console dependencies ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58249/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13665/ : SUCCESS -- To view, visit https://review.coreboot.org/20892 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I713389ef9ed5e965fc34b590a86f4b5e2e84d304 Gerrit-Change-Number: 20892 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 06 Aug 2017 23:32:01 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017