coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: sb/intel/i82801jx: Add romstage smbus and i2c block operations
by Arthur Heymans (Code Review) 04 Aug '17

04 Aug '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20880 Change subject: sb/intel/i82801jx: Add romstage smbus and i2c block operations ...................................................................... sb/intel/i82801jx: Add romstage smbus and i2c block operations Change-Id: I76bf1ed392d3d18059792106fc482d2259a3f084 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/southbridge/intel/i82801jx/early_smbus.c M src/southbridge/intel/i82801jx/i82801jx.h 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/20880/1 diff --git a/src/southbridge/intel/i82801jx/early_smbus.c b/src/southbridge/intel/i82801jx/early_smbus.c index a950992..16932e0 100644 --- a/src/southbridge/intel/i82801jx/early_smbus.c +++ b/src/southbridge/intel/i82801jx/early_smbus.c @@ -51,3 +51,19 @@ { return do_smbus_read_byte(SMBUS_IO_BASE, device, address); } + +int i2c_block_read(unsigned int device, unsigned int offset, u32 bytes, u8 *buf) +{ + return do_i2c_block_read(SMBUS_IO_BASE, device, offset, bytes, buf); +} + +int smbus_block_read(unsigned int device, unsigned int cmd, u8 bytes, u8 *buf) +{ + return do_smbus_block_read(SMBUS_IO_BASE, device, cmd, bytes, buf); +} + +int smbus_block_write(unsigned int device, unsigned int cmd, u8 bytes, + const u8 *buf) +{ + return do_smbus_block_write(SMBUS_IO_BASE, device, cmd, bytes, buf); +} diff --git a/src/southbridge/intel/i82801jx/i82801jx.h b/src/southbridge/intel/i82801jx/i82801jx.h index fd74d2a..fe55157 100644 --- a/src/southbridge/intel/i82801jx/i82801jx.h +++ b/src/southbridge/intel/i82801jx/i82801jx.h @@ -224,6 +224,11 @@ #if defined(__PRE_RAM__) void enable_smbus(void); int smbus_read_byte(unsigned device, unsigned address); +int i2c_block_read(unsigned int device, unsigned int cmd, unsigned int bytes, + u8 *buf); +int smbus_block_read(unsigned int device, unsigned int cmd, u8 bytes, u8 *buf); +int smbus_block_write(unsigned int device, unsigned int cmd, u8 bytes, + const u8 *buf); void i82801jx_early_init(void); void i82801jx_dmi_setup(void); void i82801jx_dmi_poll_vc1(void); -- To view, visit https://review.coreboot.org/20880 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I76bf1ed392d3d18059792106fc482d2259a3f084 Gerrit-Change-Number: 20880 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: [WIP] sb/intel/common: limit smbus block read bytes according to slave
by build bot (Jenkins) (Code Review) 04 Aug '17

04 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20879 ) Change subject: [WIP] sb/intel/common: limit smbus block read bytes according to slave ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58216/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13637/ : SUCCESS -- To view, visit https://review.coreboot.org/20879 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9e5d24255a0a03039b52d2863bc278d0eefc311 Gerrit-Change-Number: 20879 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Aug 2017 12:36:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP] sb/intel/common: limit smbus block read bytes according to slave
by Arthur Heymans (Code Review) 04 Aug '17

04 Aug '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20879 Change subject: [WIP] sb/intel/common: limit smbus block read bytes according to slave ...................................................................... [WIP] sb/intel/common: limit smbus block read bytes according to slave Should it also limit to 32? Should it report to the user if slave bytes is less than function input? Change-Id: If9e5d24255a0a03039b52d2863bc278d0eefc311 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/southbridge/intel/common/smbus.c 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/20879/1 diff --git a/src/southbridge/intel/common/smbus.c b/src/southbridge/intel/common/smbus.c index cac9ba7..cb884dc 100644 --- a/src/southbridge/intel/common/smbus.c +++ b/src/southbridge/intel/common/smbus.c @@ -193,13 +193,14 @@ } int do_smbus_block_read(unsigned int smbus_base, u8 device, u8 cmd, - unsigned int bytes, u8 *buf) + unsigned int max_bytes, u8 *buf) { u8 status; int bytes_read = 0; unsigned int loops = SMBUS_TIMEOUT; if (smbus_wait_until_ready(smbus_base) < 0) return SMBUS_WAIT_UNTIL_READY_TIMEOUT; + u8 slave_bytes; /* Set up transaction */ /* Disable interrupts */ @@ -223,6 +224,10 @@ if (smbus_wait_until_active(smbus_base) < 0) return SMBUS_WAIT_UNTIL_ACTIVE_TIMEOUT; + slave_bytes = inb(smbus_base + SMBHSTDAT0); + if (slave_bytes < max_bytes) + max_bytes = slave_bytes; + /* Poll for transaction completion */ do { loops--; @@ -236,7 +241,7 @@ *buf = inb(smbus_base + SMBBLKDAT); buf++; bytes_read++; - if (--bytes == 1) { + if (--max_bytes == 1) { /* indicate that next byte is the last one */ outb(inb(smbus_base + SMBHSTCTL) | SMBHSTCNT_LAST_BYTE, -- To view, visit https://review.coreboot.org/20879 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If9e5d24255a0a03039b52d2863bc278d0eefc311 Gerrit-Change-Number: 20879 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: sb/intel/*: Use common SMBus functions
by build bot (Jenkins) (Code Review) 04 Aug '17

04 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19258 ) Change subject: sb/intel/*: Use common SMBus functions ...................................................................... Patch Set 24: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58215/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13636/ : SUCCESS -- To view, visit https://review.coreboot.org/19258 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93bb186e04e8c32dff04fc1abe4b5ecbc4c9c962 Gerrit-Change-Number: 19258 Gerrit-PatchSet: 24 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Aug 2017 12:12:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/*: Use common SMBus functions
by build bot (Jenkins) (Code Review) 04 Aug '17

04 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19258 ) Change subject: sb/intel/*: Use common SMBus functions ...................................................................... Patch Set 23: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58214/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/13635/ : SUCCESS -- To view, visit https://review.coreboot.org/19258 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93bb186e04e8c32dff04fc1abe4b5ecbc4c9c962 Gerrit-Change-Number: 19258 Gerrit-PatchSet: 23 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Aug 2017 11:54:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Log wakes caused by PME on internal bus and PCIE RP
by build bot (Jenkins) (Code Review) 04 Aug '17

04 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20532 ) Change subject: soc/intel/skylake: Log wakes caused by PME on internal bus and PCIE RP ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58213/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13634/ : SUCCESS -- To view, visit https://review.coreboot.org/20532 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I879a7c332e62ab598942b29d31bad84619b35ea7 Gerrit-Change-Number: 20532 Gerrit-PatchSet: 7 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Aug 2017 10:17:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: rockchip: gpio: Correct rk3399 pmu gpio pull setting
by build bot (Jenkins) (Code Review) 04 Aug '17

04 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20871 ) Change subject: rockchip: gpio: Correct rk3399 pmu gpio pull setting ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58211/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13632/ : SUCCESS -- To view, visit https://review.coreboot.org/20871 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe391273d58ab35df993e149187d67497fcf2acc Gerrit-Change-Number: 20871 Gerrit-PatchSet: 2 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shunqian Zheng <zhengsq(a)rock-chips.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Aug 2017 04:02:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: rockchip: gpio: add gpio_pull argument in gpio_input_irq() function
by build bot (Jenkins) (Code Review) 04 Aug '17

04 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20866 ) Change subject: rockchip: gpio: add gpio_pull argument in gpio_input_irq() function ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58210/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13631/ : SUCCESS -- To view, visit https://review.coreboot.org/20866 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b8e6497f07146dafdb447a6ea10d039a2a2fa33 Gerrit-Change-Number: 20866 Gerrit-PatchSet: 3 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Aug 2017 04:01:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/soraka: Add gpio.c to bootblock
by build bot (Jenkins) (Code Review) 04 Aug '17

04 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20878 ) Change subject: mainboard/google/soraka: Add gpio.c to bootblock ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58209/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13630/ : SUCCESS -- To view, visit https://review.coreboot.org/20878 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77181334257f2fd19982ecafc1f58afe912f4280 Gerrit-Change-Number: 20878 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 23:57:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/soraka: Configure GPP_B8 in bootblock
by build bot (Jenkins) (Code Review) 04 Aug '17

04 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20869 ) Change subject: mainboard/google/soraka: Configure GPP_B8 in bootblock ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58208/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13629/ : SUCCESS -- To view, visit https://review.coreboot.org/20869 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68e1bd67499262a17daade72e9a9fd32934a184d Gerrit-Change-Number: 20869 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 23:55:51 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017