coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: Make: Move testing into a subdirectory
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20873 ) Change subject: Make: Move testing into a subdirectory ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58190/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13612/ : SUCCESS -- To view, visit https://review.coreboot.org/20873 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie252c7555223f9ce76b54e6f7b66d03f3cf60500 Gerrit-Change-Number: 20873 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 16:07:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP] Update testing routines
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20874 ) Change subject: [WIP] Update testing routines ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58191/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13614/ : SUCCESS -- To view, visit https://review.coreboot.org/20874 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e1256d79531112ff84e47a307f55791533806f Gerrit-Change-Number: 20874 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 16:04:40 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/lint: Change final-newlines to lint-test from lint-stable-test
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20872 ) Change subject: util/lint: Change final-newlines to lint-test from lint-stable-test ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58189/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13613/ : SUCCESS -- To view, visit https://review.coreboot.org/20872 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie945dd6caba84e0d23af499d43367d70b1696089 Gerrit-Change-Number: 20872 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 16:03:01 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP] Update testing routines
by Martin Roth (Code Review) 03 Aug '17

03 Aug '17

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/20874 Change subject: [WIP] Update testing routines ...................................................................... [WIP] Update testing routines Currently the only testing we had was 'what-jenkins-does' and 'make lint'. While the lint testing is suitable for developers, the 'what-jenkins-does' target really isn't, as it was designed specifically for testing on jenkins. This adds the infrastructure for tests that are more suitable for the developer. TODO: - Add save/restore of .config file - Add additional QEMU testing - Add additional abuild tests for flags that are typically disabled - Get extended payload test working - Need to create config files for each. Change-Id: I19e1256d79531112ff84e47a307f55791533806f Signed-off-by: Martin Roth <martinroth(a)google.com> --- M Makefile M Makefile.inc M payloads/libpayload/Makefile.inc M util/testing/Makefile.inc 4 files changed, 110 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/20874/1 diff --git a/Makefile b/Makefile index ff9a6b8..343ec65 100644 --- a/Makefile +++ b/Makefile @@ -92,9 +92,7 @@ @echo ' distclean - Remove build artifacts and config files' @echo ' doxygen - Build doxygen documentation for coreboot' @echo ' doxyplatform - Build doxygen documentation for the current platform' - @echo ' what-jenkins-does - Run platform build tests (Use CPUS=# for more cores)' @echo ' printall - print makefile info for debugging' - @echo ' lint / lint-stable - run coreboot lint tools (all / minimal)' @echo ' gitconfig - set up git to submit patches to coreboot' @echo ' ctags / ctags-project - make ctags file for all of coreboot or current board' @echo ' cscope / cscope-project - make cscope.out file for coreboot or current board' diff --git a/Makefile.inc b/Makefile.inc index 9decd65..49344a6 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -75,7 +75,7 @@ ####################################################################### # our phony targets -PHONY+= clean-abuild coreboot lint lint-stable build-dirs build_complete +PHONY+= clean-abuild coreboot build-dirs build_complete ####################################################################### # root source directories of coreboot @@ -555,9 +555,6 @@ update: dongle.py -c /dev/term/1 $(obj)/coreboot.rom EOF - -lint lint-stable: - util/lint/lint $@ gitconfig: [ -d .git ] diff --git a/payloads/libpayload/Makefile.inc b/payloads/libpayload/Makefile.inc index b88cd20..7787762 100644 --- a/payloads/libpayload/Makefile.inc +++ b/payloads/libpayload/Makefile.inc @@ -147,3 +147,12 @@ done echo "</testsuite>" >> $@.tmp mv $@.tmp $@ + +test-configs: + for config in $(filter-out %.old,$(wildcard configs/*)); do \ + $(MAKE) clean; \ + cp "$$config" test_config; \ + echo "*** Making libpayload config $$config ***"; \ + $(MAKE) olddefconfig DOTCONFIG=test_config V=$(V) Q=$(Q) ; \ + $(MAKE) V=$(V) Q=$(Q) CONFIG_LP_CCACHE=$(CONFIG_LP_CCACHE) DOTCONFIG=test_config; \ + done diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc index f5a4c5e..99f4d84 100644 --- a/util/testing/Makefile.inc +++ b/util/testing/Makefile.inc @@ -11,6 +11,24 @@ ## GNU General Public License for more details. ## +test-help help:: + @echo '*** coreboot test targets ***' + @echo ' what-jenkins-does - Run platform build tests with junit output' + @echo ' lint / lint-stable - run coreboot lint tools (all / minimal)' + @echo ' test-basic - Run stardard build tests. All expected to pass.' + @echo ' test-extended - Run extended tests.' + @echo ' test-lint - basic: Run stable and extended lint tests.' + @echo ' test-tools - basic: Tests a basic list of tools.' + @echo ' test-abuild - basic: Builds all platforms' + @echo ' test-payloads - basic: Builds internal payloads' + @echo ' test-cleanup - basic: Cleans coreboot directories' + @echo ' test-external-payloads - extended: Builds external payloads' + @echo ' test-qemu - extended: Builds & boots QEMU targets' + +# junit.xml is a helper target to wrap builds that don't create junit.xml output +# BLD = Subdirectory the build lives in - The name of the build +# BLD_DIR = Top path from coreboot to the build subdirectory +# MAKETARGET = target to build junit.xml: echo "Building $(BLD)" echo '<?xml version="1.0" encoding="utf-8"?><testsuite>' > $@.tmp @@ -35,16 +53,32 @@ echo TOOLLIST= \ - cbmem \ - ectool \ - futility \ - inteltool \ - intelvbttool \ - nvramtool \ - superiotool \ - viatool +cbmem \ +ectool \ +futility \ +inteltool \ +intelvbttool \ +nvramtool \ +superiotool \ +viatool + +TEST_PAYLOADLIST_INTERNAL= \ +coreinfo \ +nvramcui \ + +TEST_PAYLOADLIST_EXTERNAL= \ +iPXE \ +Memtest86Plus \ +SeaBIOS \ +tint + JENKINS_PAYLOAD?=none +TEST_PAYLOAD?=$(JENKINS_PAYLOAD) CPUS?=4 + +lint lint-stable: + util/lint/lint $@ + what-jenkins-does: util/lint/lint lint-stable --junit util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) -x -X $(top)/abuild-chromeos.xml @@ -54,3 +88,61 @@ unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/ BLD=nvramcui MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/ BLD=coreinfo MFLAGS= MAKEFLAGS= MAKETARGET=defaultbuild junit.xml $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=util/ BLD=romcc MFLAGS= MAKEFLAGS= MAKETARGET=test junit.xml + +test-basic: test-lint test-tools test-abuild test-payloads test-cleanup + +test-extended: test-external_payloads test-qemu + +test-lint: + util/lint/lint lint-stable + util/lint/lint-015-final-newlines + +test-abuild: + util/abuild/abuild -B -e $(if $(TEST_NOCCACHE),,-y) -c $(CPUS) -p $(TEST_PAYLOAD) -x COREBOOT_BUILD_DIR=coreboot-builds-chromeos + util/abuild/abuild -B -e $(if $(TEST_NOCCACHE),,-y) -c $(CPUS) -p $(TEST_PAYLOAD) + +test-payloads: + $(MAKE) -C payloads/libpayload test-configs -j $(CPUS) V=$(V) Q=$(Q) MFLAGS= MAKEFLAGS= $(if $(TEST_NOCCACHE),,CONFIG_LP_CCACHE=y) + export MFLAGS=;export MAKEFLAGS=; \ + $(foreach payload, $(TEST_PAYLOADLIST_INTERNAL), \ + echo "*** Making payload $(payload) ***"; \ + $(MAKE) -C payloads/$(payload) distclean ;\ + $(MAKE) $(payload) -j $(CPUS) V=$(V) Q=$(Q)\ + || exit 1; ) + +test-external-payloads: + export MFLAGS=;export MAKEFLAGS=;\ + $(foreach payload, $(TEST_PAYLOADLIST_EXTERNAL), \ + echo "*** Making payload $$payload ***"; \ + $(MAKE) -C payloads/exeternal/$(payload) clean; \ + $(MAKE) $(payload) -j $(CPUS) V=$(V) Q=$(Q) \ + || exit 1; ) + +test-tools: + @echo "Build testing $(TOOLLIST)" + $(foreach tool, $(TOOLLIST), $(MAKE) -C util/$(tool) clean ; ) + $(MAKE) -C util/romcc clean + $(foreach tool, $(TOOLLIST), echo "Building $(tool)";export MFLAGS= ;export MAKEFLAGS= ;$(MAKE) -C util/$(tool) all V=$(V) Q=$(Q) || exit 1; ) + echo "Building romcc" + $(MAKE) -C util/romcc all test -j $(CPUS) V=$(V) Q=$(Q) + +test-qemu: + cp $(top)/configs/config.emulation_qemu_x86_i440fx $(top)/.config + echo "CONFIG_PAYLOAD_NONE=y" > $(top)/.config + make olddefconfig; make clean; make all + qemu-system-x86_64 -bios build/coreboot.rom -serial file:QEMU.LOG -daemonize -pidfile $(top)/QEMU.PID + sleep 5 + kill $$(cat $(top)/QEMU.PID) + grep -q "Payload not loaded." $(top)/QEMU.LOG + rm $(top)/QEMU.PID $(top)/QEMU.LOG + +test-cleanup: + rm -rf coreboot-builds coreboot-builds-chromeos + $(MAKE) clean + $(MAKE) distclean + $(foreach tool, $(TOOLLIST), $(MAKE) -C util/$(tool) clean ; ) + $(MAKE) -C util/romcc clean + +.PHONY: test-basic test-extended test-lint test-abuild test-payloads +.PHONY: test-external_payloads test-tools test-qemu test-cleanup test-help +.PHONY: lint lint-stable what-jenkins-does -- To view, visit https://review.coreboot.org/20874 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I19e1256d79531112ff84e47a307f55791533806f Gerrit-Change-Number: 20874 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: Make: Move testing into a subdirectory
by Martin Roth (Code Review) 03 Aug '17

03 Aug '17

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/20873 Change subject: Make: Move testing into a subdirectory ...................................................................... Make: Move testing into a subdirectory In preparation for expanding the testing, move the test targets out of the top level Makefile.inc and into a separate subdirectory. Change-Id: Ie252c7555223f9ce76b54e6f7b66d03f3cf60500 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M Makefile M Makefile.inc A util/testing/Makefile.inc 3 files changed, 58 insertions(+), 45 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/20873/1 diff --git a/Makefile b/Makefile index 31fb3ad..ff9a6b8 100644 --- a/Makefile +++ b/Makefile @@ -124,6 +124,7 @@ ifeq ($(NOCOMPILE),1) include $(TOPLEVEL)/Makefile.inc include $(TOPLEVEL)/payloads/Makefile.inc +include $(TOPLEVEL)/util/testing/Makefile.inc real-all: @echo "Error: Expected config file ($(DOTCONFIG)) not present." >&2 @echo "Please specify a config file or run 'make menuconfig' to" >&2 diff --git a/Makefile.inc b/Makefile.inc index 5730201..9decd65 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -93,7 +93,7 @@ subdirs-y += payloads payloads/external subdirs-y += site-local -subdirs-y += util/checklist +subdirs-y += util/checklist util/testing ####################################################################### # Add source classes and their build options @@ -1041,47 +1041,3 @@ INTERMEDIATE+=check-ramstage-overlaps PHONY+=check-ramstage-overlaps endif - -junit.xml: - echo "Building $(BLD)" - echo '<?xml version="1.0" encoding="utf-8"?><testsuite>' > $@.tmp - echo "<testcase classname='$(BLD)' name='$(BLD)'>" >> $@.tmp - -$(MAKE) -j $(CPUS) -C "$(BLD_DIR)$(BLD)" clean distclean > $@.tmp.2 2>&1 - $(MAKE) -j $(CPUS) -C "$(BLD_DIR)$(BLD)" $(MAKETARGET) >> $@.tmp.2 2>&1 && type="system-out" || type="failure"; \ - cat $@.tmp.2; \ - if [ "$$type" = "failure" ]; then \ - echo "<failure type='buildFailed'>" >> $@.tmp; \ - echo "Building $(BLD) Failed"; \ - else \ - echo "<$$type>" >> $@.tmp; \ - echo "Building $(BLD) Succeeded"; \ - fi; \ - echo '<![CDATA[' >> $@.tmp; \ - cat $@.tmp.2 >> $@.tmp; \ - echo "]]></$$type>" >>$@.tmp - rm -f $@.tmp.2 - echo "</testcase>" >> $@.tmp - echo "</testsuite>" >> $@.tmp - mv $@.tmp "$(BLD_DIR)$(BLD)/$@" - echo - -TOOLLIST= \ - cbmem \ - ectool \ - futility \ - inteltool \ - intelvbttool \ - nvramtool \ - superiotool \ - viatool -JENKINS_PAYLOAD?=none -CPUS?=4 -what-jenkins-does: - util/lint/lint lint-stable --junit - util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) -x -X $(top)/abuild-chromeos.xml - util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) - (cd payloads/libpayload; unset COREBOOT_BUILD_DIR; $(MAKE) $(if $(JENKINS_NOCCACHE),,CONFIG_LP_CCACHE=y) V=$(V) Q=$(Q) junit.xml) - $(foreach tool, $(TOOLLIST), $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=util/ BLD="$(tool)" MFLAGS= MAKEFLAGS= MAKETARGET= junit.xml; ) - unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/ BLD=nvramcui MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml - unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/ BLD=coreinfo MFLAGS= MAKEFLAGS= MAKETARGET=defaultbuild junit.xml - $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=util/ BLD=romcc MFLAGS= MAKEFLAGS= MAKETARGET=test junit.xml diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc new file mode 100644 index 0000000..f5a4c5e --- /dev/null +++ b/util/testing/Makefile.inc @@ -0,0 +1,56 @@ +## +## This file is part of the coreboot project. +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +junit.xml: + echo "Building $(BLD)" + echo '<?xml version="1.0" encoding="utf-8"?><testsuite>' > $@.tmp + echo "<testcase classname='$(BLD)' name='$(BLD)'>" >> $@.tmp + -$(MAKE) -j $(CPUS) -C "$(BLD_DIR)$(BLD)" clean distclean > $@.tmp.2 2>&1 + $(MAKE) -j $(CPUS) -C "$(BLD_DIR)$(BLD)" $(MAKETARGET) >> $@.tmp.2 2>&1 && type="system-out" || type="failure"; \ + cat $@.tmp.2; \ + if [ "$$type" = "failure" ]; then \ + echo "<failure type='buildFailed'>" >> $@.tmp; \ + echo "Building $(BLD) Failed"; \ + else \ + echo "<$$type>" >> $@.tmp; \ + echo "Building $(BLD) Succeeded"; \ + fi; \ + echo '<![CDATA[' >> $@.tmp; \ + cat $@.tmp.2 >> $@.tmp; \ + echo "]]></$$type>" >>$@.tmp + rm -f $@.tmp.2 + echo "</testcase>" >> $@.tmp + echo "</testsuite>" >> $@.tmp + mv $@.tmp "$(BLD_DIR)$(BLD)/$@" + echo + +TOOLLIST= \ + cbmem \ + ectool \ + futility \ + inteltool \ + intelvbttool \ + nvramtool \ + superiotool \ + viatool +JENKINS_PAYLOAD?=none +CPUS?=4 +what-jenkins-does: + util/lint/lint lint-stable --junit + util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) -x -X $(top)/abuild-chromeos.xml + util/abuild/abuild -B -J $(if $(JENKINS_NOCCACHE),,-y) -c $(CPUS) -z -p $(JENKINS_PAYLOAD) + (cd payloads/libpayload; unset COREBOOT_BUILD_DIR; $(MAKE) $(if $(JENKINS_NOCCACHE),,CONFIG_LP_CCACHE=y) V=$(V) Q=$(Q) junit.xml) + $(foreach tool, $(TOOLLIST), $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=util/ BLD="$(tool)" MFLAGS= MAKEFLAGS= MAKETARGET= junit.xml; ) + unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/ BLD=nvramcui MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml + unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/ BLD=coreinfo MFLAGS= MAKEFLAGS= MAKETARGET=defaultbuild junit.xml + $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=util/ BLD=romcc MFLAGS= MAKEFLAGS= MAKETARGET=test junit.xml -- To view, visit https://review.coreboot.org/20873 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie252c7555223f9ce76b54e6f7b66d03f3cf60500 Gerrit-Change-Number: 20873 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: util/lint: Change final-newlines to lint-test from lint-stable-test
by Martin Roth (Code Review) 03 Aug '17

03 Aug '17

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/20872 Change subject: util/lint: Change final-newlines to lint-test from lint-stable-test ...................................................................... util/lint: Change final-newlines to lint-test from lint-stable-test The final newline check is taking longer than we'd like to run. Since it runs on every commit as part of the pre-commit check, we want that to run faster than it currently does. Change-Id: Ie945dd6caba84e0d23af499d43367d70b1696089 Signed-off-by: Martin Roth <martinroth(a)google.com> --- R util/lint/lint-015-final-newlines 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/20872/1 diff --git a/util/lint/lint-stable-015-final-newlines b/util/lint/lint-015-final-newlines similarity index 100% rename from util/lint/lint-stable-015-final-newlines rename to util/lint/lint-015-final-newlines -- To view, visit https://review.coreboot.org/20872 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie945dd6caba84e0d23af499d43367d70b1696089 Gerrit-Change-Number: 20872 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: [WIP] util/inteltool: Add support for Haswell-E/Wellsburg dumping
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20669 ) Change subject: [WIP] util/inteltool: Add support for Haswell-E/Wellsburg dumping ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58188/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13611/ : SUCCESS -- To view, visit https://review.coreboot.org/20669 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73d289b9fc2064ba53dd0395680523be72adf490 Gerrit-Change-Number: 20669 Gerrit-PatchSet: 2 Gerrit-Owner: Omar Pakker Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 10:29:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP] util/inteltool: Add support for Haswell-E/Wellsburg dumping
by Omar Pakker (Code Review) 03 Aug '17

03 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20669 to look at the new patch set (#2). Change subject: [WIP] util/inteltool: Add support for Haswell-E/Wellsburg dumping ...................................................................... [WIP] util/inteltool: Add support for Haswell-E/Wellsburg dumping This adds support for dumping of Haswell-E and Wellsburg to the inteltool. MCHBAR, EPBAR, PCIEXBAR and AMBs missing. Based on these datasheets: Intel Core i7 Processor Family for LGA2011-v3 vol. 1 & 2, August 2014 Intel C610 Series and Intel X99 Chipset PCH, October 2015 Signed-off-by: Omar Pakker <coreboot(a)opakker.nl> Change-Id: I73d289b9fc2064ba53dd0395680523be72adf490 --- M util/inteltool/gpio.c M util/inteltool/inteltool.c M util/inteltool/inteltool.h M util/inteltool/pcie.c M util/inteltool/powermgt.c M util/inteltool/rootcmplx.c M util/inteltool/spi.c 7 files changed, 91 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/20669/2 -- To view, visit https://review.coreboot.org/20669 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I73d289b9fc2064ba53dd0395680523be72adf490 Gerrit-Change-Number: 20669 Gerrit-PatchSet: 2 Gerrit-Owner: Omar Pakker Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/common/block: Add Intel PMC support
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19349 ) Change subject: soc/intel/common/block: Add Intel PMC support ...................................................................... Patch Set 30: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58187/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13610/ : SUCCESS -- To view, visit https://review.coreboot.org/19349 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3d96fc23a98c30e8ea0969a7be09d217eeaa889 Gerrit-Change-Number: 19349 Gerrit-PatchSet: 30 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 08:51:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: rockchip: rk3399: Correct rk3399 pmu gpio pull setting
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20871 ) Change subject: rockchip: rk3399: Correct rk3399 pmu gpio pull setting ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58186/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13609/ : SUCCESS -- To view, visit https://review.coreboot.org/20871 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe391273d58ab35df993e149187d67497fcf2acc Gerrit-Change-Number: 20871 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shunqian Zheng <zhengsq(a)rock-chips.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 07:01:42 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017