coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: rockchip: rk3399: Correct rk3399 pmu gpio pull setting
by Lin Huang (Code Review) 03 Aug '17

03 Aug '17

Lin Huang has uploaded this change for review. ( https://review.coreboot.org/20871 Change subject: rockchip: rk3399: Correct rk3399 pmu gpio pull setting ...................................................................... rockchip: rk3399: Correct rk3399 pmu gpio pull setting In rk3399 pmu gpio pull register there have enable bit, we need to handle these bit to get right setting. BRANCH=None BUG=None TEST=boot from scarlet Change-Id: Ibe391273d58ab35df993e149187d67497fcf2acc Signed-off-by: Lin Huang <hl(a)rock-chips.com> --- M src/soc/rockchip/common/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/20871/1 diff --git a/src/soc/rockchip/common/gpio.c b/src/soc/rockchip/common/gpio.c index 3c77c3f..5323095 100644 --- a/src/soc/rockchip/common/gpio.c +++ b/src/soc/rockchip/common/gpio.c @@ -30,7 +30,7 @@ static void gpio_set_pull(gpio_t gpio, enum gpio_pull pull) { u32 pull_val = gpio_get_pull_val(gpio, pull); - if (is_pmu_gpio(gpio)) + if (is_pmu_gpio(gpio) && IS_ENABLED(CONFIG_SOC_ROCKCHIP_RK3288)) clrsetbits_le32(gpio_grf_reg(gpio), 3 << (gpio.idx * 2), pull_val << (gpio.idx * 2)); else -- To view, visit https://review.coreboot.org/20871 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibe391273d58ab35df993e149187d67497fcf2acc Gerrit-Change-Number: 20871 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com>

1 0

Change in coreboot[master]: soc/intel/braswell: Fix Coverity Error
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20870 ) Change subject: soc/intel/braswell: Fix Coverity Error ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58185/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13608/ : SUCCESS -- To view, visit https://review.coreboot.org/20870 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I286658a6a4c6832fbd6395440cd5383dc81d3c15 Gerrit-Change-Number: 20870 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 06:16:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/braswell: Fix Coverity Error
by Hannah Williams (Code Review) 03 Aug '17

03 Aug '17

Hannah Williams has uploaded this change for review. ( https://review.coreboot.org/20870 Change subject: soc/intel/braswell: Fix Coverity Error ...................................................................... soc/intel/braswell: Fix Coverity Error Change-Id: I286658a6a4c6832fbd6395440cd5383dc81d3c15 Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- M src/soc/intel/braswell/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/20870/1 diff --git a/src/soc/intel/braswell/acpi.c b/src/soc/intel/braswell/acpi.c index 7a51816..429a2b7 100644 --- a/src/soc/intel/braswell/acpi.c +++ b/src/soc/intel/braswell/acpi.c @@ -570,7 +570,7 @@ /* FIXME if IGD is disabled, we should exit here. */ memcpy(&opregion->header.signature, IGD_OPREGION_SIGNATURE, - sizeof(IGD_OPREGION_SIGNATURE)); + sizeof(IGD_OPREGION_SIGNATURE) - 1); /* 8kb */ opregion->header.size = sizeof(igd_opregion_t) / 1024; -- To view, visit https://review.coreboot.org/20870 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I286658a6a4c6832fbd6395440cd5383dc81d3c15 Gerrit-Change-Number: 20870 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>

1 0

Change in coreboot[master]: rockchip: gpio: add gpio_pull argument in gpio_input_irq() function
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20866 ) Change subject: rockchip: gpio: add gpio_pull argument in gpio_input_irq() function ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58180/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13603/ : SUCCESS -- To view, visit https://review.coreboot.org/20866 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b8e6497f07146dafdb447a6ea10d039a2a2fa33 Gerrit-Change-Number: 20866 Gerrit-PatchSet: 2 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 03:14:37 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: rockchip: gpio: add gpio_pull argument in gpio_input_irq() function
by Lin Huang (Code Review) 03 Aug '17

03 Aug '17

Lin Huang has posted comments on this change. ( https://review.coreboot.org/20866 ) Change subject: rockchip: gpio: add gpio_pull argument in gpio_input_irq() function ...................................................................... Patch Set 2: > Actually, let's fix this in in gpio_input_irq... see my comment on > the bug. done -- To view, visit https://review.coreboot.org/20866 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b8e6497f07146dafdb447a6ea10d039a2a2fa33 Gerrit-Change-Number: 20866 Gerrit-PatchSet: 2 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 03:08:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: rockchip: gpio: add gpio_pull argument in gpio_input_irq() function
by Lin Huang (Code Review) 03 Aug '17

03 Aug '17

Hello Julius Werner, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20866 to look at the new patch set (#2). Change subject: rockchip: gpio: add gpio_pull argument in gpio_input_irq() function ...................................................................... rockchip: gpio: add gpio_pull argument in gpio_input_irq() function some gpio irq need to set input pull initialization status to guarantee get the right irq trigger. let's add this argument in gpio_input_irq() function BRANCH=None BUG=None TEST=boot from bob Change-Id: I9b8e6497f07146dafdb447a6ea10d039a2a2fa33 Signed-off-by: Lin Huang <hl(a)rock-chips.com> --- M src/mainboard/google/gru/bootblock.c M src/soc/rockchip/common/gpio.c M src/soc/rockchip/common/include/soc/gpio.h 3 files changed, 14 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/20866/2 -- To view, visit https://review.coreboot.org/20866 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9b8e6497f07146dafdb447a6ea10d039a2a2fa33 Gerrit-Change-Number: 20866 Gerrit-PatchSet: 2 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/google/poppy: Ensure correct sequencing of PERST signal
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20869 ) Change subject: mainboard/google/poppy: Ensure correct sequencing of PERST signal ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58179/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13602/ : SUCCESS -- To view, visit https://review.coreboot.org/20869 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68e1bd67499262a17daade72e9a9fd32934a184d Gerrit-Change-Number: 20869 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 02:20:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: rockchip: tpm: cr50: set tpm_irq gpio initialization status
by Julius Werner (Code Review) 03 Aug '17

03 Aug '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/20866 ) Change subject: rockchip: tpm: cr50: set tpm_irq gpio initialization status ...................................................................... Patch Set 1: -Code-Review Actually, let's fix this in in gpio_input_irq... see my comment on the bug. -- To view, visit https://review.coreboot.org/20866 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b8e6497f07146dafdb447a6ea10d039a2a2fa33 Gerrit-Change-Number: 20866 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 02:14:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Ensure correct sequencing of PERST signal
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20869 ) Change subject: mainboard/google/poppy: Ensure correct sequencing of PERST signal ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58178/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/13601/ : SUCCESS -- To view, visit https://review.coreboot.org/20869 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68e1bd67499262a17daade72e9a9fd32934a184d Gerrit-Change-Number: 20869 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 02:13:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Ensure correct sequencing of PERST signal
by Furquan Shaikh (Code Review) 03 Aug '17

03 Aug '17

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/20869 Change subject: mainboard/google/poppy: Ensure correct sequencing of PERST signal ...................................................................... mainboard/google/poppy: Ensure correct sequencing of PERST signal PERST# signal has specific requirements that it should be low for ~1msec after applying power to PCIe device. Ensure that this requirement is met by adding a delay of 5ms before setting WLAN_PE_RST to low (There is an inverter which inverts the logic of WLAN_PE_RST to PERST#). (This is a temporary workaround until support is added to do this in ACPI.) BUG=b:64181150,b:62726961 TEST=Verified with warm reboot and suspend-resume stress test that wifi is still functional. Change-Id: I68e1bd67499262a17daade72e9a9fd32934a184d Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/mainboard/google/poppy/ramstage.c M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/poppy/variants/soraka/gpio.c 3 files changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/20869/1 diff --git a/src/mainboard/google/poppy/ramstage.c b/src/mainboard/google/poppy/ramstage.c index 39df3ee..2390013 100644 --- a/src/mainboard/google/poppy/ramstage.c +++ b/src/mainboard/google/poppy/ramstage.c @@ -14,6 +14,9 @@ */ #include <baseboard/variants.h> +#include <delay.h> +#include <gpio.h> +#include <soc/gpio.h> #include <soc/ramstage.h> #include <variant/gpio.h> @@ -25,4 +28,16 @@ pads = variant_gpio_table(&num); gpio_configure_pads(pads, num); + + /* + * TODO(furquan): Temporary work-around until this is properly + * implemented in ACPI. + * Ensure PERST# timing requirements are met by pulling it high for + * >1msec. This is important to ensure that the wifi chip does not get + * into a bad state on warm reboot/suspend-resume. + */ + gpio_set(GPP_B8, 1); + mdelay(5); + gpio_set(GPP_B8, 0); + } diff --git a/src/mainboard/google/poppy/smihandler.c b/src/mainboard/google/poppy/smihandler.c index 1a86d0f..68d071e 100644 --- a/src/mainboard/google/poppy/smihandler.c +++ b/src/mainboard/google/poppy/smihandler.c @@ -31,6 +31,7 @@ { /* Power down camera PMIC */ gpio_set(EN_PP3300_DX_CAM, 0); + gpio_set(GPP_B8, 1); } void mainboard_smi_sleep(u8 slp_typ) diff --git a/src/mainboard/google/poppy/variants/soraka/gpio.c b/src/mainboard/google/poppy/variants/soraka/gpio.c index f0fb34a..ddd5cd7 100644 --- a/src/mainboard/google/poppy/variants/soraka/gpio.c +++ b/src/mainboard/google/poppy/variants/soraka/gpio.c @@ -79,7 +79,7 @@ /* B7 : SRCCLKREQ2# ==> NC */ PAD_CFG_NC(GPP_B7), /* B8 : SRCCLKREQ3# ==> WLAN_PE_RST */ - PAD_CFG_GPO(GPP_B8, 0, DEEP), + PAD_CFG_GPO(GPP_B8, 1, DEEP), /* B9 : SRCCLKREQ4# ==> NC */ PAD_CFG_NC(GPP_B9), /* B10 : SRCCLKREQ5# ==> NC */ -- To view, visit https://review.coreboot.org/20869 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I68e1bd67499262a17daade72e9a9fd32934a184d Gerrit-Change-Number: 20869 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017