coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: 440BX boards: Use combined RAM init routine.
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20868 ) Change subject: 440BX boards: Use combined RAM init routine. ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58177/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13600/ : SUCCESS -- To view, visit https://review.coreboot.org/20868 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I699db882189f99018d4a6fdcb00f9438b2a7a1bc Gerrit-Change-Number: 20868 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 01:58:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: 440BX boards: Use combined RAM init routine.
by Keith Hui (Code Review) 03 Aug '17

03 Aug '17

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/20868 Change subject: 440BX boards: Use combined RAM init routine. ...................................................................... 440BX boards: Use combined RAM init routine. Change all 440BX boards to use the recently combined RAM init routine[1]. A couple 440BX boards were left out of the cleanup job at [2]. They now receive this cleanup as well. [1] https://review.coreboot.org/20676 [2] https://review.coreboot.org/20693 Change-Id: I699db882189f99018d4a6fdcb00f9438b2a7a1bc Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/mainboard/a-trend/atc-6220/romstage.c M src/mainboard/a-trend/atc-6240/romstage.c M src/mainboard/asus/p2b-ds/romstage.c M src/mainboard/asus/p2b-ls/romstage.c M src/mainboard/asus/p2b/romstage.c M src/mainboard/asus/p3b-f/romstage.c M src/mainboard/azza/pt-6ibd/romstage.c M src/mainboard/compaq/deskpro_en_sff_p600/romstage.c M src/mainboard/gigabyte/ga-6bxc/romstage.c M src/mainboard/gigabyte/ga-6bxe/romstage.c M src/mainboard/msi/ms6119/romstage.c M src/mainboard/msi/ms6147/romstage.c M src/mainboard/msi/ms6156/romstage.c M src/mainboard/nokia/ip530/romstage.c M src/mainboard/soyo/sy-6ba-plus-iii/romstage.c M src/mainboard/tyan/s1846/romstage.c 16 files changed, 16 insertions(+), 72 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/20868/1 diff --git a/src/mainboard/a-trend/atc-6220/romstage.c b/src/mainboard/a-trend/atc-6220/romstage.c index 6cf86c1..70e4323 100644 --- a/src/mainboard/a-trend/atc-6220/romstage.c +++ b/src/mainboard/a-trend/atc-6220/romstage.c @@ -39,8 +39,5 @@ report_bist_failure(bist); enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/a-trend/atc-6240/romstage.c b/src/mainboard/a-trend/atc-6240/romstage.c index cbb0207..8dd9686 100644 --- a/src/mainboard/a-trend/atc-6240/romstage.c +++ b/src/mainboard/a-trend/atc-6240/romstage.c @@ -39,8 +39,5 @@ report_bist_failure(bist); enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/asus/p2b-ds/romstage.c b/src/mainboard/asus/p2b-ds/romstage.c index 809f1f6..1d34bd9 100644 --- a/src/mainboard/asus/p2b-ds/romstage.c +++ b/src/mainboard/asus/p2b-ds/romstage.c @@ -39,8 +39,5 @@ report_bist_failure(bist); enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/asus/p2b-ls/romstage.c b/src/mainboard/asus/p2b-ls/romstage.c index 5ed878f..ecfc8b8 100644 --- a/src/mainboard/asus/p2b-ls/romstage.c +++ b/src/mainboard/asus/p2b-ls/romstage.c @@ -40,8 +40,5 @@ report_bist_failure(bist); enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/asus/p2b/romstage.c b/src/mainboard/asus/p2b/romstage.c index 6cf86c1..70e4323 100644 --- a/src/mainboard/asus/p2b/romstage.c +++ b/src/mainboard/asus/p2b/romstage.c @@ -39,8 +39,5 @@ report_bist_failure(bist); enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/asus/p3b-f/romstage.c b/src/mainboard/asus/p3b-f/romstage.c index bb16c78..0bb5bca 100644 --- a/src/mainboard/asus/p3b-f/romstage.c +++ b/src/mainboard/asus/p3b-f/romstage.c @@ -76,10 +76,7 @@ enable_spd(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); disable_spd(); } diff --git a/src/mainboard/azza/pt-6ibd/romstage.c b/src/mainboard/azza/pt-6ibd/romstage.c index c4cfbec..eb031e0 100644 --- a/src/mainboard/azza/pt-6ibd/romstage.c +++ b/src/mainboard/azza/pt-6ibd/romstage.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */ -#include <stdint.h> #include <device/pci_def.h> #include <device/pnp_def.h> #include <console/console.h> @@ -42,8 +41,5 @@ report_bist_failure(bist); enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/compaq/deskpro_en_sff_p600/romstage.c b/src/mainboard/compaq/deskpro_en_sff_p600/romstage.c index 7a59b1b..712ea96 100644 --- a/src/mainboard/compaq/deskpro_en_sff_p600/romstage.c +++ b/src/mainboard/compaq/deskpro_en_sff_p600/romstage.c @@ -14,15 +14,11 @@ * GNU General Public License for more details. */ -#include <stdint.h> #include <device/pci_def.h> -#include <arch/io.h> #include <device/pnp_def.h> -#include <stdlib.h> #include <console/console.h> #include <southbridge/intel/i82371eb/i82371eb.h> #include <northbridge/intel/i440bx/raminit.h> -#include <delay.h> #include <cpu/x86/bist.h> #include <cpu/intel/romstage.h> /* FIXME: This should be PC97307 (but it's buggy at the moment)! */ @@ -45,8 +41,5 @@ report_bist_failure(bist); enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/gigabyte/ga-6bxc/romstage.c b/src/mainboard/gigabyte/ga-6bxc/romstage.c index 425a615..7f85e0e 100644 --- a/src/mainboard/gigabyte/ga-6bxc/romstage.c +++ b/src/mainboard/gigabyte/ga-6bxc/romstage.c @@ -39,8 +39,5 @@ report_bist_failure(bist); enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/gigabyte/ga-6bxe/romstage.c b/src/mainboard/gigabyte/ga-6bxe/romstage.c index 85b36b9..d4bdbe8 100644 --- a/src/mainboard/gigabyte/ga-6bxe/romstage.c +++ b/src/mainboard/gigabyte/ga-6bxe/romstage.c @@ -40,8 +40,5 @@ report_bist_failure(bist); enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/msi/ms6119/romstage.c b/src/mainboard/msi/ms6119/romstage.c index 7791e91..1d34bd9 100644 --- a/src/mainboard/msi/ms6119/romstage.c +++ b/src/mainboard/msi/ms6119/romstage.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */ -#include <stdint.h> #include <device/pci_def.h> #include <device/pnp_def.h> #include <console/console.h> @@ -40,8 +39,5 @@ report_bist_failure(bist); enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/msi/ms6147/romstage.c b/src/mainboard/msi/ms6147/romstage.c index 8cda4b8..6ac5ae1 100644 --- a/src/mainboard/msi/ms6147/romstage.c +++ b/src/mainboard/msi/ms6147/romstage.c @@ -40,8 +40,5 @@ report_bist_failure(bist); enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/msi/ms6156/romstage.c b/src/mainboard/msi/ms6156/romstage.c index cf39f52..6a3b7f4 100644 --- a/src/mainboard/msi/ms6156/romstage.c +++ b/src/mainboard/msi/ms6156/romstage.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */ -#include <stdint.h> #include <device/pci_def.h> #include <device/pnp_def.h> #include <console/console.h> @@ -40,8 +39,5 @@ report_bist_failure(bist); enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/nokia/ip530/romstage.c b/src/mainboard/nokia/ip530/romstage.c index e647aae..fa0585d 100644 --- a/src/mainboard/nokia/ip530/romstage.c +++ b/src/mainboard/nokia/ip530/romstage.c @@ -38,8 +38,5 @@ report_bist_failure(bist); enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c b/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c index 770a7cb..0bb1ab2 100644 --- a/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c +++ b/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */ -#include <stdint.h> #include <device/pci_def.h> #include <device/pnp_def.h> #include <console/console.h> @@ -39,8 +38,5 @@ report_bist_failure(bist); enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/tyan/s1846/romstage.c b/src/mainboard/tyan/s1846/romstage.c index 4819b8a..28aac5d 100644 --- a/src/mainboard/tyan/s1846/romstage.c +++ b/src/mainboard/tyan/s1846/romstage.c @@ -38,8 +38,5 @@ report_bist_failure(bist); enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } -- To view, visit https://review.coreboot.org/20868 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I699db882189f99018d4a6fdcb00f9438b2a7a1bc Gerrit-Change-Number: 20868 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com>

1 0

Change in coreboot[master]: fsp2_0/mma: Enable EvLoader in FSP for MMA
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20863 ) Change subject: fsp2_0/mma: Enable EvLoader in FSP for MMA ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58176/ : SUCCESS -- To view, visit https://review.coreboot.org/20863 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb860b98d6e6f21c116473a962f647e491e8546f Gerrit-Change-Number: 20863 Gerrit-PatchSet: 2 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 01:29:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: rockchip: tpm: cr50: set tpm_irq gpio initialization status
by Julius Werner (Code Review) 03 Aug '17

03 Aug '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/20866 ) Change subject: rockchip: tpm: cr50: set tpm_irq gpio initialization status ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/20866 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b8e6497f07146dafdb447a6ea10d039a2a2fa33 Gerrit-Change-Number: 20866 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 00:51:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Fix Coverity Error
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20867 ) Change subject: soc/intel/apollolake: Fix Coverity Error ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58175/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13599/ : SUCCESS -- To view, visit https://review.coreboot.org/20867 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7e43b195357c723e1ae51f609a8b07ad984380a Gerrit-Change-Number: 20867 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 00:47:29 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Fix Coverity Error
by Hannah Williams (Code Review) 03 Aug '17

03 Aug '17

Hannah Williams has uploaded this change for review. ( https://review.coreboot.org/20867 Change subject: soc/intel/apollolake: Fix Coverity Error ...................................................................... soc/intel/apollolake: Fix Coverity Error Change-Id: Ib7e43b195357c723e1ae51f609a8b07ad984380a Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- M src/soc/intel/apollolake/cse.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/20867/1 diff --git a/src/soc/intel/apollolake/cse.c b/src/soc/intel/apollolake/cse.c index 515d32b..3e1792c 100644 --- a/src/soc/intel/apollolake/cse.c +++ b/src/soc/intel/apollolake/cse.c @@ -92,6 +92,10 @@ return 0; } + if (strnlen(path, sizeof(msg.file_name)) >= sizeof(msg.file_name)) { + printk(BIOS_ERR, "path too big for msg.file_name buffer\n"); + return 0; + } strncpy(msg.file_name, path, sizeof(msg.file_name)); msg.mkhi_hdr.fields.group_id = MKHI_GROUP_ID_MCA; msg.mkhi_hdr.fields.command = READ_FILE; -- To view, visit https://review.coreboot.org/20867 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib7e43b195357c723e1ae51f609a8b07ad984380a Gerrit-Change-Number: 20867 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>

1 0

Change in coreboot[master]: rockchip: tpm: cr50: set tpm_irq gpio initialization status
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20866 ) Change subject: rockchip: tpm: cr50: set tpm_irq gpio initialization status ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58174/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13598/ : SUCCESS -- To view, visit https://review.coreboot.org/20866 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b8e6497f07146dafdb447a6ea10d039a2a2fa33 Gerrit-Change-Number: 20866 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 00:40:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: rockchip: tpm: cr50: set tpm_irq gpio initialization status
by Lin Huang (Code Review) 03 Aug '17

03 Aug '17

Lin Huang has uploaded this change for review. ( https://review.coreboot.org/20866 Change subject: rockchip: tpm: cr50: set tpm_irq gpio initialization status ...................................................................... rockchip: tpm: cr50: set tpm_irq gpio initialization status cr50 tpm_irq gpio use rise edge irq, so need to set this gpio initialization status to input pullup. BRANCH=None BUG=None TEST=boot from bob Change-Id: I9b8e6497f07146dafdb447a6ea10d039a2a2fa33 Signed-off-by: Lin Huang <hl(a)rock-chips.com> --- M src/mainboard/google/gru/bootblock.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/20866/1 diff --git a/src/mainboard/google/gru/bootblock.c b/src/mainboard/google/gru/bootblock.c index c5ab28a..2367674 100644 --- a/src/mainboard/google/gru/bootblock.c +++ b/src/mainboard/google/gru/bootblock.c @@ -112,6 +112,7 @@ write32(&rk3399_grf->iomux_spi0, IOMUX_SPI0); } + gpio_input_pullup(GPIO_TPM_IRQ); gpio_input_irq(GPIO_TPM_IRQ, IRQ_TYPE_EDGE_RISING); } else { gpio_input(GPIO(1, B, 7)); /* I2C0_SDA remove pull-up */ -- To view, visit https://review.coreboot.org/20866 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9b8e6497f07146dafdb447a6ea10d039a2a2fa33 Gerrit-Change-Number: 20866 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com>

1 0

Change in coreboot[master]: soc/intel/common/block: Common ACPI
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20630 ) Change subject: soc/intel/common/block: Common ACPI ...................................................................... Patch Set 13: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58173/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13597/ : SUCCESS -- To view, visit https://review.coreboot.org/20630 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6eb6fd5366e6e28fd81bc22d050b0efa05a2e5d Gerrit-Change-Number: 20630 Gerrit-PatchSet: 13 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 00:23:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Common ACPI
by build bot (Jenkins) (Code Review) 03 Aug '17

03 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20630 ) Change subject: soc/intel/common/block: Common ACPI ...................................................................... Patch Set 12: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58172/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/13596/ : SUCCESS -- To view, visit https://review.coreboot.org/20630 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6eb6fd5366e6e28fd81bc22d050b0efa05a2e5d Gerrit-Change-Number: 20630 Gerrit-PatchSet: 12 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Aug 2017 00:15:21 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017