coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: cpu/amd/fam10: Reduce headers included in init_cpus.h
by build bot (Jenkins) (Code Review) 12 Aug '17

12 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20976 ) Change subject: cpu/amd/fam10: Reduce headers included in init_cpus.h ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58488/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/13890/ : SUCCESS -- To view, visit https://review.coreboot.org/20976 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id91caa7c55367e794802788d9007920817f2d484 Gerrit-Change-Number: 20976 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 12 Aug 2017 21:37:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: cpu/amd/fam10: Reduce headers included in init_cpus.h
by Arthur Heymans (Code Review) 12 Aug '17

12 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20976 to look at the new patch set (#2). Change subject: cpu/amd/fam10: Reduce headers included in init_cpus.h ...................................................................... cpu/amd/fam10: Reduce headers included in init_cpus.h Change-Id: Id91caa7c55367e794802788d9007920817f2d484 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/amd/family_10h-family_15h/defaults.h M src/cpu/amd/family_10h-family_15h/fidvid.c M src/cpu/amd/family_10h-family_15h/init_cpus.c M src/cpu/amd/family_10h-family_15h/init_cpus.h M src/include/cpu/amd/multicore.h M src/northbridge/amd/amdmct/amddefs.h 6 files changed, 13 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/20976/2 -- To view, visit https://review.coreboot.org/20976 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id91caa7c55367e794802788d9007920817f2d484 Gerrit-Change-Number: 20976 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: cpu/amd/fam10: Reduce headers included in init_cpus.h
by build bot (Jenkins) (Code Review) 12 Aug '17

12 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20976 ) Change subject: cpu/amd/fam10: Reduce headers included in init_cpus.h ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58487/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/13889/ : SUCCESS -- To view, visit https://review.coreboot.org/20976 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id91caa7c55367e794802788d9007920817f2d484 Gerrit-Change-Number: 20976 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 12 Aug 2017 21:26:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: cpu/amd/fam10: Reduce headers included in init_cpus.h
by Arthur Heymans (Code Review) 12 Aug '17

12 Aug '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20976 Change subject: cpu/amd/fam10: Reduce headers included in init_cpus.h ...................................................................... cpu/amd/fam10: Reduce headers included in init_cpus.h Change-Id: Id91caa7c55367e794802788d9007920817f2d484 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/amd/family_10h-family_15h/defaults.h M src/cpu/amd/family_10h-family_15h/fidvid.c M src/cpu/amd/family_10h-family_15h/init_cpus.c M src/cpu/amd/family_10h-family_15h/init_cpus.h M src/include/cpu/amd/multicore.h M src/northbridge/amd/amdmct/amddefs.h 6 files changed, 13 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/20976/1 diff --git a/src/cpu/amd/family_10h-family_15h/defaults.h b/src/cpu/amd/family_10h-family_15h/defaults.h index 88950a3..f270510 100644 --- a/src/cpu/amd/family_10h-family_15h/defaults.h +++ b/src/cpu/amd/family_10h-family_15h/defaults.h @@ -16,6 +16,7 @@ #include <northbridge/amd/amdmct/amddefs.h> #include <cpu/amd/mtrr.h> +#include <cpu/amd/msr.h> /* * Default MSR and errata settings. diff --git a/src/cpu/amd/family_10h-family_15h/fidvid.c b/src/cpu/amd/family_10h-family_15h/fidvid.c index af3a674..81baf5d 100644 --- a/src/cpu/amd/family_10h-family_15h/fidvid.c +++ b/src/cpu/amd/family_10h-family_15h/fidvid.c @@ -97,6 +97,7 @@ #include <northbridge/amd/amdht/AsPsDefs.h> #include <northbridge/amd/amdht/ht_wrapper.h> #include <cpu/amd/multicore.h> +#include <cpu/x86/lapic.h> #include "init_cpus.h" diff --git a/src/cpu/amd/family_10h-family_15h/init_cpus.c b/src/cpu/amd/family_10h-family_15h/init_cpus.c index be4f8d4..3f1e288 100644 --- a/src/cpu/amd/family_10h-family_15h/init_cpus.c +++ b/src/cpu/amd/family_10h-family_15h/init_cpus.c @@ -26,6 +26,11 @@ #include <northbridge/amd/amdht/porting.h> #include <northbridge/amd/amdht/h3ncmn.h> +#include <cpu/x86/lapic.h> +#include <cpu/amd/multicore.h> +#include <cpu/amd/msr.h> +#include <reset.h> + #if IS_ENABLED(CONFIG_SOUTHBRIDGE_AMD_SB700) #include <southbridge/amd/sb700/sb700.h> #endif @@ -35,6 +40,7 @@ #endif #include "cpu/amd/car/post_cache_as_ram.c" +#include "defaults.h" #if IS_ENABLED(CONFIG_PCI_IO_CFG_EXT) static void set_EnableCf8ExtCfg(void) diff --git a/src/cpu/amd/family_10h-family_15h/init_cpus.h b/src/cpu/amd/family_10h-family_15h/init_cpus.h index 8ca9c8b..6e1806f 100644 --- a/src/cpu/amd/family_10h-family_15h/init_cpus.h +++ b/src/cpu/amd/family_10h-family_15h/init_cpus.h @@ -16,17 +16,7 @@ #ifndef INIT_CPUS_H #define INIT_CPUS_H -#include <stdlib.h> -#include <console/console.h> -#include <arch/cpu.h> -#include <cpu/x86/lapic.h> -#include <cpu/x86/mtrr.h> -#include <cpu/amd/msr.h> -#include <cpu/amd/multicore.h> -#include <reset.h> #include <northbridge/amd/amdfam10/raminit.h> -#include <northbridge/amd/amdht/porting.h> -#include "defaults.h" #define NODE_HT(x) NODE_PCI(x,0) #define NODE_MP(x) NODE_PCI(x,1) diff --git a/src/include/cpu/amd/multicore.h b/src/include/cpu/amd/multicore.h index 0ddf866..b868093 100644 --- a/src/include/cpu/amd/multicore.h +++ b/src/include/cpu/amd/multicore.h @@ -16,6 +16,8 @@ #ifndef CPU_AMD_QUADCORE_H #define CPU_AMD_QUADCORE_H +#include <stdint.h> + u32 read_nb_cfg_54(void); struct node_core_id { diff --git a/src/northbridge/amd/amdmct/amddefs.h b/src/northbridge/amd/amdmct/amddefs.h index 58f43f1..c4b7e6d3 100644 --- a/src/northbridge/amd/amdmct/amddefs.h +++ b/src/northbridge/amd/amdmct/amddefs.h @@ -16,6 +16,9 @@ #ifndef AMDDEFS_H #define AMDDEFS_H +#include <stdint.h> +#include <device/pci.h> + /* FIXME: this file should be moved to include/cpu/amd/amddefs.h */ /* Public Revisions - USE THESE VERSIONS TO MAKE COMPARE WITH CPULOGICALID RETURN VALUE*/ -- To view, visit https://review.coreboot.org/20976 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id91caa7c55367e794802788d9007920817f2d484 Gerrit-Change-Number: 20976 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: nb/amd/mct_ddr3/mct_d.c: Break out of allow_config_restore loop
by Raptor Engineering Automated Test Stand (Code Review) 12 Aug '17

12 Aug '17

Raptor Engineering Automated Test Stand has posted comments on this change. ( https://review.coreboot.org/20971 ) Change subject: nb/amd/mct_ddr3/mct_d.c: Break out of allow_config_restore loop ...................................................................... Patch Set 3: Verified-1 ASUS KFSN4-DRE: Boot and extended test successful. Boot log: https://testlab.coreboot.org/raptor/1502569947-0-20971,3.log.bz2 QEMU x86_64 Q35: Boot successful. Boot log: https://testlab.coreboot.org/raptor/1502570036-1-20971,3.log.bz2 ASUS KGPE-D16: Test FAILED. Boot log: https://testlab.coreboot.org/raptor/1502572512-3-20971,3.log.bz2 ASUS KGPE-D16: BOOT_FAILURE -- To view, visit https://review.coreboot.org/20971 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie669d1bc38411e40ab95c28b17ee8818874dc741 Gerrit-Change-Number: 20971 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 12 Aug 2017 21:15:14 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/amd/amdfam10/amdfam10.h: Clean up header
by build bot (Jenkins) (Code Review) 12 Aug '17

12 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20974 ) Change subject: nb/amd/amdfam10/amdfam10.h: Clean up header ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58486/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13888/ : SUCCESS -- To view, visit https://review.coreboot.org/20974 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3df97a038cf265423cb7019d1639a3d47d4871f7 Gerrit-Change-Number: 20974 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 12 Aug 2017 20:27:00 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/amd/mct: Fix building with DQS_TRAIN_DEBUG > 0
by build bot (Jenkins) (Code Review) 12 Aug '17

12 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20975 ) Change subject: nb/amd/mct: Fix building with DQS_TRAIN_DEBUG > 0 ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58485/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13887/ : SUCCESS -- To view, visit https://review.coreboot.org/20975 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d56f4cb5660466b7cf193a08adbfc17834c7a50 Gerrit-Change-Number: 20975 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 12 Aug 2017 20:24:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/amd/mct: Fix building with DQS_TRAIN_DEBUG > 0
by Arthur Heymans (Code Review) 12 Aug '17

12 Aug '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20975 Change subject: nb/amd/mct: Fix building with DQS_TRAIN_DEBUG > 0 ...................................................................... nb/amd/mct: Fix building with DQS_TRAIN_DEBUG > 0 Change-Id: I7d56f4cb5660466b7cf193a08adbfc17834c7a50 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/amd/amdmct/mct/mctdqs_d.c M src/northbridge/amd/amdmct/mct/mctsrc.c M src/northbridge/amd/amdmct/mct/mcttmrl.c 3 files changed, 4 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/20975/1 diff --git a/src/northbridge/amd/amdmct/mct/mctdqs_d.c b/src/northbridge/amd/amdmct/mct/mctdqs_d.c index 174c481..0c2bc2d 100644 --- a/src/northbridge/amd/amdmct/mct/mctdqs_d.c +++ b/src/northbridge/amd/amdmct/mct/mctdqs_d.c @@ -16,6 +16,7 @@ #include <northbridge/amd/amdfam10/debug.h> #include <cpu/x86/cr.h> #include <cpu/amd/mtrr.h> +#include <console/console.h> #include "mct_d.h" #include "mct_d_gcc.h" @@ -341,7 +342,7 @@ { u8 val; u8 i; - u8 Channel, Receiver, Dir; + u8 Receiver, Dir; u8 *p; for (Dir = 0; Dir < 2; Dir++) { diff --git a/src/northbridge/amd/amdmct/mct/mctsrc.c b/src/northbridge/amd/amdmct/mct/mctsrc.c index 3a78620..eee7901 100644 --- a/src/northbridge/amd/amdmct/mct/mctsrc.c +++ b/src/northbridge/amd/amdmct/mct/mctsrc.c @@ -16,6 +16,7 @@ #include <northbridge/amd/amdfam10/debug.h> #include <cpu/x86/cr.h> +#include <console/console.h> #include "mct_d.h" #include "mct_d_gcc.h" @@ -460,7 +461,6 @@ #if DQS_TRAIN_DEBUG > 0 { - u8 Channel; printk(BIOS_DEBUG, "TrainRcvrEn: CH_MaxRdLat:\n"); for (Channel = 0; Channel < 2; Channel++) { printk(BIOS_DEBUG, "Channel: %02x: %02x\n", Channel, pDCTstat->CH_MaxRdLat[Channel]); @@ -470,8 +470,6 @@ #if DQS_TRAIN_DEBUG > 0 { - u8 val; - u8 Channel, Receiver; u8 i; u8 *p; diff --git a/src/northbridge/amd/amdmct/mct/mcttmrl.c b/src/northbridge/amd/amdmct/mct/mcttmrl.c index 81ec5f9..67093d9 100644 --- a/src/northbridge/amd/amdmct/mct/mcttmrl.c +++ b/src/northbridge/amd/amdmct/mct/mcttmrl.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */ +#include <console/console.h> #include <cpu/x86/cr.h> #include "mct_d.h" @@ -197,7 +198,6 @@ #if DQS_TRAIN_DEBUG > 0 { - u8 Channel; printk(BIOS_DEBUG, "maxRdLatencyTrain: CH_MaxRdLat:\n"); for (Channel = 0; Channel < 2; Channel++) { printk(BIOS_DEBUG, "Channel: %02x: %02x\n", Channel, pDCTstat->CH_MaxRdLat[Channel]); -- To view, visit https://review.coreboot.org/20975 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7d56f4cb5660466b7cf193a08adbfc17834c7a50 Gerrit-Change-Number: 20975 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: nb/amd/amdfam10/amdfam10.h: Clean up header
by Arthur Heymans (Code Review) 12 Aug '17

12 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20974 to look at the new patch set (#4). Change subject: nb/amd/amdfam10/amdfam10.h: Clean up header ...................................................................... nb/amd/amdfam10/amdfam10.h: Clean up header Remove superfluous includes in amdfam10.h header. Change-Id: I3df97a038cf265423cb7019d1639a3d47d4871f7 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/advansus/a785e-i/romstage.c M src/mainboard/amd/bimini_fam10/romstage.c M src/mainboard/amd/mahogany_fam10/romstage.c M src/mainboard/amd/serengeti_cheetah_fam10/romstage.c M src/mainboard/amd/tilapia_fam10/romstage.c M src/mainboard/asus/kcma-d8/romstage.c M src/mainboard/asus/kfsn4-dre/romstage.c M src/mainboard/asus/kgpe-d16/romstage.c M src/mainboard/asus/m4a78-em/romstage.c M src/mainboard/asus/m4a785-m/romstage.c M src/mainboard/asus/m5a88-v/romstage.c M src/mainboard/avalue/eax-785e/romstage.c M src/mainboard/gigabyte/ma785gm/romstage.c M src/mainboard/gigabyte/ma785gmt/romstage.c M src/mainboard/gigabyte/ma78gm/romstage.c M src/mainboard/hp/dl165_g6_fam10/romstage.c M src/mainboard/iei/kino-780am2-fam10/romstage.c M src/mainboard/jetway/pa78vm5/romstage.c M src/mainboard/msi/ms9652_fam10/romstage.c M src/mainboard/supermicro/h8dmr_fam10/romstage.c M src/mainboard/supermicro/h8qme_fam10/romstage.c M src/mainboard/supermicro/h8scm_fam10/romstage.c M src/mainboard/tyan/s2912_fam10/romstage.c M src/northbridge/amd/amdfam10/Makefile.inc M src/northbridge/amd/amdfam10/amdfam10.h M src/northbridge/amd/amdfam10/inline_helper.c M src/northbridge/amd/amdmct/mct_ddr3/mct_d.c 27 files changed, 30 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/20974/4 -- To view, visit https://review.coreboot.org/20974 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3df97a038cf265423cb7019d1639a3d47d4871f7 Gerrit-Change-Number: 20974 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/amd/mct: Don't include all needed headers in mct_d.h
by build bot (Jenkins) (Code Review) 12 Aug '17

12 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20972 ) Change subject: nb/amd/mct: Don't include all needed headers in mct_d.h ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58481/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13884/ : SUCCESS -- To view, visit https://review.coreboot.org/20972 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I454eb9f00c8ffebd7a48bf9cb65d012b3fc335f2 Gerrit-Change-Number: 20972 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 12 Aug 2017 20:13:11 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017