coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: tint: Use the current time as random seed
by Nicola Corna (Code Review) 13 Aug '17

13 Aug '17

Nicola Corna has uploaded this change for review. ( https://review.coreboot.org/20980 Change subject: tint: Use the current time as random seed ...................................................................... tint: Use the current time as random seed Previously the random seed was fixed, which led to the same sequence of blocks for each run. Change-Id: I2e482bbb9d33cdbbf3c15916458329f99fbc4450 Signed-off-by: Nicola Corna <nicola(a)corna.info> --- M payloads/external/tint/libpayload_tint.patch 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/20980/1 diff --git a/payloads/external/tint/libpayload_tint.patch b/payloads/external/tint/libpayload_tint.patch index b5592dd..21b93a3 100644 --- a/payloads/external/tint/libpayload_tint.patch +++ b/payloads/external/tint/libpayload_tint.patch @@ -939,19 +939,22 @@ /* * Initialize random number generator -@@ -41,8 +43,11 @@ void rand_init () +@@ -41,8 +43,14 @@ void rand_init () #ifdef USE_RAND srand (time (NULL)); #else +#if 0 srandom (time (NULL)); #endif -+ srandom (123); ++ struct timeval tp; ++ ++ gettimeofday (&tp, NULL); ++ srandom (tp.tv_sec); +#endif } /* -@@ -61,6 +66,7 @@ int rand_value (int range) +@@ -61,6 +69,7 @@ int rand_value (int range) * Convert an str to long. Returns TRUE if successful, * FALSE otherwise. */ @@ -959,7 +962,7 @@ bool str2int (int *i,const char *str) { char *endptr; -@@ -69,3 +75,4 @@ bool str2int (int *i,const char *str) +@@ -69,3 +78,4 @@ bool str2int (int *i,const char *str) return TRUE; } -- To view, visit https://review.coreboot.org/20980 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2e482bbb9d33cdbbf3c15916458329f99fbc4450 Gerrit-Change-Number: 20980 Gerrit-PatchSet: 1 Gerrit-Owner: Nicola Corna <nicola(a)corna.info>

1 0

Change in coreboot[master]: ec/lenovo/h8: Add BDC detection support
by build bot (Jenkins) (Code Review) 13 Aug '17

13 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19809 ) Change subject: ec/lenovo/h8: Add BDC detection support ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58497/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13898/ : SUCCESS -- To view, visit https://review.coreboot.org/19809 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I506de2eca4b820e6d82de6b2c48a5440462e1db5 Gerrit-Change-Number: 19809 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Aug 2017 08:21:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: superio/winbond/w83977tf: Drop early_serial.c
by Arthur Heymans (Code Review) 13 Aug '17

13 Aug '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/20978 ) Change subject: superio/winbond/w83977tf: Drop early_serial.c ...................................................................... Patch Set 1: Code-Review+2 It is indeed not even linked in the Makefile.inc. -- To view, visit https://review.coreboot.org/20978 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab8dd93663fc78ed0d8c6a5313bb6a1884d1a043 Gerrit-Change-Number: 20978 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Aug 2017 08:04:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [UNTESTED] nb/intel/x4x/raminit: Move dummy reads after JEDEC init
by Arthur Heymans (Code Review) 13 Aug '17

13 Aug '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/20979 ) Change subject: [UNTESTED] nb/intel/x4x/raminit: Move dummy reads after JEDEC init ...................................................................... Patch Set 1: Although it is wild speculation this might be what caused noisy results in receive enable calibration? -- To view, visit https://review.coreboot.org/20979 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8069f9c08ad5e5268ddbe3711d58bc42522f938c Gerrit-Change-Number: 20979 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Aug 2017 08:02:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [UNTESTED] nb/intel/x4x/raminit: Move dummy reads after JEDEC init
by build bot (Jenkins) (Code Review) 13 Aug '17

13 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20979 ) Change subject: [UNTESTED] nb/intel/x4x/raminit: Move dummy reads after JEDEC init ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58496/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13897/ : SUCCESS -- To view, visit https://review.coreboot.org/20979 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8069f9c08ad5e5268ddbe3711d58bc42522f938c Gerrit-Change-Number: 20979 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Aug 2017 07:59:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [UNTESTED] nb/intel/x4x/raminit: Move dummy reads after JEDEC init
by Arthur Heymans (Code Review) 13 Aug '17

13 Aug '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20979 Change subject: [UNTESTED] nb/intel/x4x/raminit: Move dummy reads after JEDEC init ...................................................................... [UNTESTED] nb/intel/x4x/raminit: Move dummy reads after JEDEC init Vendor only does dummy reads and right after JEDEC init is finished and dram init was marked as finished. Change-Id: I8069f9c08ad5e5268ddbe3711d58bc42522f938c Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/raminit_ddr2.c 1 file changed, 13 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/20979/1 diff --git a/src/northbridge/intel/x4x/raminit_ddr2.c b/src/northbridge/intel/x4x/raminit_ddr2.c index bc012d2..8ec2c79 100644 --- a/src/northbridge/intel/x4x/raminit_ddr2.c +++ b/src/northbridge/intel/x4x/raminit_ddr2.c @@ -2008,6 +2008,19 @@ MCHBAR32(0x400*ch + 0x268) = (MCHBAR32(0x400*ch + 0x268) & ~0xc0000000) | 0xc0000000; } + // Dummy reads + if (s->boot_path == BOOT_PATH_NORMAL) { + volatile u32 data; + FOR_EACH_POPULATED_RANK(s->dimms, ch, r) { + for (bank = 0; bank < 4; bank++) { + data = read32((u32 *)((ch << 29) + | (r * 0x08000000) | (0x800000) + | (bank << 12))); + } + } + } + printk(BIOS_DEBUG, "Done dummy reads\n"); + // Receive enable sdram_program_receive_enable(s); printk(BIOS_DEBUG, "Done rcven\n"); @@ -2022,28 +2035,6 @@ MCHBAR8(0x5dc) = MCHBAR8(0x5dc) | 0x80; MCHBAR8(0x5dc) = MCHBAR8(0x5dc) & ~0x80; MCHBAR8(0x5dc) = MCHBAR8(0x5dc) | 0x80; - - // Dummy writes / reads - if (s->boot_path == BOOT_PATH_NORMAL) { - volatile u32 data; - FOR_EACH_POPULATED_RANK(s->dimms, ch, r) { - for (bank = 0; bank < 4; bank++) { - reg32 = (ch << 29) | (r*0x8000000) | - (bank << 12); - write32((u32 *)reg32, 0xffffffff); - data = read32((u32 *)reg32); - printk(BIOS_DEBUG, "Wrote ones,"); - printk(BIOS_DEBUG, " Read: [0x%08x]=0x%08x\n", - reg32, data); - write32((u32 *)reg32, 0x00000000); - data = read32((u32 *)reg32); - printk(BIOS_DEBUG, "Wrote zeros,"); - printk(BIOS_DEBUG, " Read: [0x%08x]=0x%08x\n", - reg32, data); - } - } - } - printk(BIOS_DEBUG, "Done dummy reads\n"); // XXX tRD -- To view, visit https://review.coreboot.org/20979 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8069f9c08ad5e5268ddbe3711d58bc42522f938c Gerrit-Change-Number: 20979 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: superio/winbond/w83977tf: Drop early_serial.c
by build bot (Jenkins) (Code Review) 13 Aug '17

13 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20978 ) Change subject: superio/winbond/w83977tf: Drop early_serial.c ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58495/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13896/ : SUCCESS -- To view, visit https://review.coreboot.org/20978 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab8dd93663fc78ed0d8c6a5313bb6a1884d1a043 Gerrit-Change-Number: 20978 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Aug 2017 05:18:40 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: superio/winbond/w83977tf: Drop early_serial.c
by Keith Hui (Code Review) 13 Aug '17

13 Aug '17

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/20978 Change subject: superio/winbond/w83977tf: Drop early_serial.c ...................................................................... superio/winbond/w83977tf: Drop early_serial.c Early serial init on this superio is done by superio/winbond/common/early_serial.c and no board currently references this instance anymore. Change-Id: Iab8dd93663fc78ed0d8c6a5313bb6a1884d1a043 Signed-off-by: Keith Hui <buurin(a)gmail.com> --- D src/superio/winbond/w83977tf/early_serial.c 1 file changed, 0 insertions(+), 43 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/20978/1 diff --git a/src/superio/winbond/w83977tf/early_serial.c b/src/superio/winbond/w83977tf/early_serial.c deleted file mode 100644 index b3aa8ac..0000000 --- a/src/superio/winbond/w83977tf/early_serial.c +++ /dev/null @@ -1,43 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2000 AG Electronics Ltd. - * Copyright (C) 2003-2004 Linux Networx - * Copyright (C) 2004 Tyan - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <arch/io.h> -#include "w83977tf.h" - -static void pnp_enter_ext_func_mode(pnp_devfn_t dev) -{ - u16 port = dev >> 8; - outb(0x87, port); - outb(0x87, port); -} - -static void pnp_exit_ext_func_mode(pnp_devfn_t dev) -{ - u16 port = dev >> 8; - outb(0xaa, port); -} - -static void w83977tf_enable_serial(pnp_devfn_t dev, u16 iobase) -{ - pnp_enter_ext_func_mode(dev); - pnp_set_logical_device(dev); - pnp_set_enable(dev, 0); - pnp_set_iobase(dev, PNP_IDX_IO0, iobase); - pnp_set_enable(dev, 1); - pnp_exit_ext_func_mode(dev); -} -- To view, visit https://review.coreboot.org/20978 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iab8dd93663fc78ed0d8c6a5313bb6a1884d1a043 Gerrit-Change-Number: 20978 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com>

1 0

Change in coreboot[master]: nb/intel/i440bx: [WIP] Implement CBMEM in romstage
by build bot (Jenkins) (Code Review) 13 Aug '17

13 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20977 ) Change subject: nb/intel/i440bx: [WIP] Implement CBMEM in romstage ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58494/ : SUCCESS -- To view, visit https://review.coreboot.org/20977 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I432f145a5343c1bb5f2b0de3b6b88f57124d1bd9 Gerrit-Change-Number: 20977 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Aug 2017 03:22:23 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: 440BX boards: Drop more unused #includes from romstage
by build bot (Jenkins) (Code Review) 13 Aug '17

13 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20952 ) Change subject: 440BX boards: Drop more unused #includes from romstage ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58492/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13894/ : SUCCESS -- To view, visit https://review.coreboot.org/20952 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I102a4f6e492eb607b7f88d4c6e15072a8b7fdc46 Gerrit-Change-Number: 20952 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Aug 2017 03:09:03 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017