coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: payloads/external/GRUB2: Sanitize Makefile
by build bot (Jenkins) (Code Review) 14 Aug '17

14 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20990 ) Change subject: payloads/external/GRUB2: Sanitize Makefile ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58515/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13915/ : SUCCESS -- To view, visit https://review.coreboot.org/20990 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaff2c72e89a5a540fe365eacb84811d5cff9d4d4 Gerrit-Change-Number: 20990 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 14 Aug 2017 00:21:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: payloads/external/GRUB2: Only rebuild on config changes
by build bot (Jenkins) (Code Review) 14 Aug '17

14 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20991 ) Change subject: payloads/external/GRUB2: Only rebuild on config changes ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58514/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13914/ : SUCCESS -- To view, visit https://review.coreboot.org/20991 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I376eea9a3e02b03010fc5c5a05199ea7b2813220 Gerrit-Change-Number: 20991 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 14 Aug 2017 00:17:34 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: payloads/Makefile.inc: Add GRUB2 to list of payloads
by Nico Huber (Code Review) 14 Aug '17

14 Aug '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/20992 Change subject: payloads/Makefile.inc: Add GRUB2 to list of payloads ...................................................................... payloads/Makefile.inc: Add GRUB2 to list of payloads Change-Id: Iea4a609631ac2007b7b1845ff540abc912004be0 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M payloads/Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/20992/1 diff --git a/payloads/Makefile.inc b/payloads/Makefile.inc index 63a2a45..b27d7fe 100644 --- a/payloads/Makefile.inc +++ b/payloads/Makefile.inc @@ -31,7 +31,8 @@ payloads/external/Memtest86Plus \ payloads/external/iPXE \ payloads/external/tint \ -payloads/external/tianocore +payloads/external/tianocore \ +payloads/external/GRUB2 \ payloads/coreinfo/build/coreinfo.elf coreinfo: $(MAKE) -C payloads/coreinfo defaultbuild -- To view, visit https://review.coreboot.org/20992 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iea4a609631ac2007b7b1845ff540abc912004be0 Gerrit-Change-Number: 20992 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: payloads/external/GRUB2: Only rebuild on config changes
by Nico Huber (Code Review) 14 Aug '17

14 Aug '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/20991 Change subject: payloads/external/GRUB2: Only rebuild on config changes ...................................................................... payloads/external/GRUB2: Only rebuild on config changes Change-Id: I376eea9a3e02b03010fc5c5a05199ea7b2813220 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M payloads/external/GRUB2/Makefile M payloads/external/Makefile.inc 2 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/20991/1 diff --git a/payloads/external/GRUB2/Makefile b/payloads/external/GRUB2/Makefile index dee7f69..4a0a491 100644 --- a/payloads/external/GRUB2/Makefile +++ b/payloads/external/GRUB2/Makefile @@ -22,7 +22,7 @@ git branch -f $(NAME-y) $(TAG-y) && \ git checkout $(NAME-y) || true -config: checkout +grub2/build/config.h: $(CONFIG_DEP) | checkout echo " CONFIG GRUB2 $(NAME-y)" rm -rf grub2/build mkdir grub2/build @@ -32,6 +32,8 @@ CFLAGS=-O2 TARGET_CFLAGS=-Os \ --with-platform=coreboot --enable-boot-time --disable-werror +config: grub2/build/config.h checkout + grub2: config echo " MAKE GRUB2 $(NAME-y)" $(MAKE) -C grub2/build diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index fb50604..0a9b3d6 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -152,11 +152,12 @@ # Grub -grub2: +grub2: $(obj)/config.h $(MAKE) -C payloads/external/GRUB2 \ HOSTCC="$(HOSTCC)" \ CC="$(CC_x86_32)" LD="$(LD_x86_32)" \ OBJCOPY="$(OBJCOPY_x86_32)" STRIP="$(STRIP_x86_32)" \ + CONFIG_DEP="$(abspath $(obj)/config.h)" \ CONFIG_GRUB2_MASTER=$(CONFIG_GRUB2_MASTER) \ CONFIG_GRUB2_REVISION=$(CONFIG_GRUB2_REVISION) \ CONFIG_GRUB2_REVISION_ID=$(CONFIG_GRUB2_REVISION_ID) \ -- To view, visit https://review.coreboot.org/20991 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I376eea9a3e02b03010fc5c5a05199ea7b2813220 Gerrit-Change-Number: 20991 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: payloads/external/GRUB2: Sanitize Makefile
by Nico Huber (Code Review) 14 Aug '17

14 Aug '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/20990 Change subject: payloads/external/GRUB2: Sanitize Makefile ...................................................................... payloads/external/GRUB2: Sanitize Makefile We were explicitly passing CC and TARGET_CC to configure but overwrote that decision later by passing CC (with the value of TARGET_CC) directly to a recursive make call. The latter overwrite was introduced because `unexport` alone doesn't work on variables that were specified on a make command line (they are added to MAKEOVERRIDES and passed to further re- cursive make calls). Instead of unexporting random variables, unexport those that were actu- ally passed from payloads/external/Makefile.inc and clear MAKEOVERRIDES. Do not pass OBJDUMP as that is nowhere to be found in the GRUB sources. And, last but not least, add --disable-werror because building GRUB is very susceptible to changes in the flex version. Change-Id: Iaff2c72e89a5a540fe365eacb84811d5cff9d4d4 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M payloads/external/GRUB2/Makefile M payloads/external/Makefile.inc 2 files changed, 9 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/20990/1 diff --git a/payloads/external/GRUB2/Makefile b/payloads/external/GRUB2/Makefile index 7cac6a3..dee7f69 100644 --- a/payloads/external/GRUB2/Makefile +++ b/payloads/external/GRUB2/Makefile @@ -6,21 +6,8 @@ project_git_repo=git://git.sv.gnu.org/grub.git project_dir=grub2 -unexport KCONFIG_AUTOCONFIG -unexport CFLAGS -unexport CPPFLAGS -unexport CCASFLAGS -unexport CC -unexport BUILD_CC -unexport TARGET_CC -unexport TARGET_CFLAGS -unexport TARGET_CPPFLAGS -unexport TARGET_STRIP -unexport TARGET_OBJCOPY -unexport HOST_CFLAGS -unexport HOST_CPPFLAGS -unexport HOST_CC - +unexport HOSTCC CC LD OBJCOPY STRIP +MAKEOVERRIDES := all: grub2 @@ -40,19 +27,19 @@ rm -rf grub2/build mkdir grub2/build cd grub2 && ./autogen.sh - cd grub2/build && ../configure BUILD_CC="$(HOSTCC)" CC="$(HOSTCC)" \ - TARGET_CC="$(CC)" \ - TARGET_OBJCOPY="$(OBJCOPY)" TARGET_STRIP="$(STRIP)" CFLAGS=-O2 TARGET_CFLAGS=-Os --with-platform=coreboot \ - --enable-boot-time + cd grub2/build && ../configure CC="$(HOSTCC)" LD="$(LD)" \ + TARGET_CC="$(CC)" TARGET_OBJCOPY="$(OBJCOPY)" TARGET_STRIP="$(STRIP)" \ + CFLAGS=-O2 TARGET_CFLAGS=-Os \ + --with-platform=coreboot --enable-boot-time --disable-werror grub2: config echo " MAKE GRUB2 $(NAME-y)" - $(MAKE) -C grub2/build CC="$(HOSTCC)" + $(MAKE) -C grub2/build $(MAKE) -C grub2/build default_payload.elf \ EXTRA_PAYLOAD_MODULES="$(CONFIG_GRUB2_EXTRA_MODULES)" clean: - test -d grub2 && $(MAKE) -C grub2 clean || exit 0 + test -f grub2/build/Makefile && $(MAKE) -C grub2/build clean || exit 0 distclean: rm -rf grub2 diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index 344fe9f..fb50604 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -155,7 +155,7 @@ grub2: $(MAKE) -C payloads/external/GRUB2 \ HOSTCC="$(HOSTCC)" \ - CC="$(CC_x86_32)" LD="$(LD_x86_32)" OBJDUMP="$(OBJDUMP_x86_32)" \ + CC="$(CC_x86_32)" LD="$(LD_x86_32)" \ OBJCOPY="$(OBJCOPY_x86_32)" STRIP="$(STRIP_x86_32)" \ CONFIG_GRUB2_MASTER=$(CONFIG_GRUB2_MASTER) \ CONFIG_GRUB2_REVISION=$(CONFIG_GRUB2_REVISION) \ -- To view, visit https://review.coreboot.org/20990 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iaff2c72e89a5a540fe365eacb84811d5cff9d4d4 Gerrit-Change-Number: 20990 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Move dummy reads after JEDEC init
by build bot (Jenkins) (Code Review) 14 Aug '17

14 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20979 ) Change subject: nb/intel/x4x/raminit: Move dummy reads after JEDEC init ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58513/ : SUCCESS -- To view, visit https://review.coreboot.org/20979 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8069f9c08ad5e5268ddbe3711d58bc42522f938c Gerrit-Change-Number: 20979 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Aug 2017 22:08:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP] util/bucts: Add tool to flip the BUC.TS bit on Intel targets
by build bot (Jenkins) (Code Review) 13 Aug '17

13 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18224 ) Change subject: [WIP] util/bucts: Add tool to flip the BUC.TS bit on Intel targets ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58512/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13913/ : SUCCESS -- To view, visit https://review.coreboot.org/18224 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12cc2e91396f096fc979e23848e1929cb6c44fc5 Gerrit-Change-Number: 18224 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Aug 2017 21:44:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Allow to add a second bootblock at a 64K offset for BUC.TS
by build bot (Jenkins) (Code Review) 13 Aug '17

13 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18148 ) Change subject: Allow to add a second bootblock at a 64K offset for BUC.TS ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58511/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13912/ : SUCCESS -- To view, visit https://review.coreboot.org/18148 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37e288e710edbe41651d09d2a6981a571df69bde Gerrit-Change-Number: 18148 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Aug 2017 21:38:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: superio/winbond/w83627*: Remove deprecated code
by build bot (Jenkins) (Code Review) 13 Aug '17

13 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20988 ) Change subject: superio/winbond/w83627*: Remove deprecated code ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58510/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13911/ : SUCCESS -- To view, visit https://review.coreboot.org/20988 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idad6e0281f7a272e184feff686ce1407825429c7 Gerrit-Change-Number: 20988 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Aug 2017 20:52:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Boards w/ Winbond superios: Use common config entry code
by build bot (Jenkins) (Code Review) 13 Aug '17

13 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20989 ) Change subject: Boards w/ Winbond superios: Use common config entry code ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58509/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13910/ : SUCCESS -- To view, visit https://review.coreboot.org/20989 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icecd52ec622b9da86edb07c52893f4db001e5562 Gerrit-Change-Number: 20989 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Aug 2017 20:48:45 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017