coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: fintek/f81803a: Add new superio
by build bot (Jenkins) (Code Review) 16 Aug '17

16 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21032 ) Change subject: fintek/f81803a: Add new superio ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58636/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14019/ : SUCCESS -- To view, visit https://review.coreboot.org/21032 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fb1a1d42d004123c3b12caf26cf0b03cd4046ec Gerrit-Change-Number: 21032 Gerrit-PatchSet: 1 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 15:13:16 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Fix if IS_ENABLED()
by build bot (Jenkins) (Code Review) 16 Aug '17

16 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21040 ) Change subject: amd/padmelon: Fix if IS_ENABLED() ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58644/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14026/ : SUCCESS -- To view, visit https://review.coreboot.org/21040 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9f18b40a931c00a0c4d873f40c2ddd853611d63 Gerrit-Change-Number: 21040 Gerrit-PatchSet: 1 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 15:11:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Enable the SATA controller
by build bot (Jenkins) (Code Review) 16 Aug '17

16 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21042 ) Change subject: amd/padmelon: Enable the SATA controller ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58645/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14027/ : FAILURE -- To view, visit https://review.coreboot.org/21042 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide5f0c9d63746a80a83a886dfb62e3475657cea0 Gerrit-Change-Number: 21042 Gerrit-PatchSet: 1 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 15:11:38 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Fix up PCIe settings
by build bot (Jenkins) (Code Review) 16 Aug '17

16 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21039 ) Change subject: amd/padmelon: Fix up PCIe settings ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58643/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14025/ : SUCCESS -- To view, visit https://review.coreboot.org/21039 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id638c2bc980d5d2bfb4d49290fa24b9869543814 Gerrit-Change-Number: 21039 Gerrit-PatchSet: 1 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 15:09:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Add fintek superio to devicetree
by build bot (Jenkins) (Code Review) 16 Aug '17

16 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21038 ) Change subject: amd/padmelon: Add fintek superio to devicetree ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58642/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14024/ : SUCCESS -- To view, visit https://review.coreboot.org/21038 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73d128d5fa4227c05fcebe1ed2a3ac98b4923426 Gerrit-Change-Number: 21038 Gerrit-PatchSet: 1 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 15:08:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Begin new mainboard
by build bot (Jenkins) (Code Review) 16 Aug '17

16 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21035 ) Change subject: amd/padmelon: Begin new mainboard ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58639/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14021/ : SUCCESS -- To view, visit https://review.coreboot.org/21035 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If81d20adc675df1c0b00b9becd68d418740c005c Gerrit-Change-Number: 21035 Gerrit-PatchSet: 1 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 15:08:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Enable DRAM
by build bot (Jenkins) (Code Review) 16 Aug '17

16 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21036 ) Change subject: amd/padmelon: Enable DRAM ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58640/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14022/ : SUCCESS -- To view, visit https://review.coreboot.org/21036 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f0cf3c24a9d0311432f9224b45296ef5167ed91 Gerrit-Change-Number: 21036 Gerrit-PatchSet: 1 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 15:06:56 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/pi/hudson: Expand 48MHz for both osc signals
by build bot (Jenkins) (Code Review) 16 Aug '17

16 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21034 ) Change subject: amd/pi/hudson: Expand 48MHz for both osc signals ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58637/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/14020/ : SUCCESS -- To view, visit https://review.coreboot.org/21034 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaee093d05fa712f62052a3787e56c5eaf4045483 Gerrit-Change-Number: 21034 Gerrit-PatchSet: 1 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 14:47:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/pi/hudson: Expand 48MHz for both osc signals
by John E. Kabat (Code Review) 16 Aug '17

16 Aug '17

Hello Marshall Dawson, John E. Kabat Jr., I'd like you to reexamine a change. Please visit https://review.coreboot.org/21034 to look at the new patch set (#2). Change subject: amd/pi/hudson: Expand 48MHz for both osc signals ...................................................................... amd/pi/hudson: Expand 48MHz for both osc signals There are typically two configurable oscillator outputs available on APUs or FCHs. Convert the enable function to allow either one. Change-Id: Iaee093d05fa712f62052a3787e56c5eaf4045483 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/mainboard/pcengines/apu2/romstage.c M src/southbridge/amd/pi/hudson/early_setup.c M src/southbridge/amd/pi/hudson/hudson.h 3 files changed, 15 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/21034/2 -- To view, visit https://review.coreboot.org/21034 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iaee093d05fa712f62052a3787e56c5eaf4045483 Gerrit-Change-Number: 21034 Gerrit-PatchSet: 2 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

Change in coreboot[master]: amd/pi/hudson: Convert 48Mhz en to read/write32
by Marshall Dawson (Code Review) 16 Aug '17

16 Aug '17

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/21033 ) Change subject: amd/pi/hudson: Convert 48Mhz en to read/write32 ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/21033/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/21033/1//COMMIT_MSG@7 PS1, Line 7: 48Mhz en It looks like this got modified. I'd change it to MHz and enabled. https://review.coreboot.org/#/c/21033/1/src/southbridge/amd/pi/hudson/early… File src/southbridge/amd/pi/hudson/early_setup.c: https://review.coreboot.org/#/c/21033/1/src/southbridge/amd/pi/hudson/early… PS1, Line 272: (u32) This cast should come out. -- To view, visit https://review.coreboot.org/21033 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91e09757e5eea1eaf9b76921ad032ad2b79c14c5 Gerrit-Change-Number: 21033 Gerrit-PatchSet: 1 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Wed, 16 Aug 2017 14:41:07 +0000 Gerrit-HasComments: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017