coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: soc/intel/common/block: Add functions to common CPU library code
by Shaunak Saha (Code Review) 16 Aug '17

16 Aug '17

Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/21051 Change subject: soc/intel/common/block: Add functions to common CPU library code ...................................................................... soc/intel/common/block: Add functions to common CPU library code This patch adds few helper functions in CPU common libraray code which are mainly needed for ACPI module. TEST= System boots properly and no regression observed. Change-Id: Id34eb7e03069656238ca0cbdf6ce33f116e0e413 Signed-off-by: Shaunak Saha <shaunak.saha(a)intel.com> --- M src/soc/intel/common/block/cpu/cpulib.c M src/soc/intel/common/block/include/intelblocks/cpulib.h 2 files changed, 98 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/21051/1 diff --git a/src/soc/intel/common/block/cpu/cpulib.c b/src/soc/intel/common/block/cpu/cpulib.c index 5920512..97629b9 100644 --- a/src/soc/intel/common/block/cpu/cpulib.c +++ b/src/soc/intel/common/block/cpu/cpulib.c @@ -14,6 +14,7 @@ * GNU General Public License for more details. */ +#include <arch/acpigen.h> #include <arch/io.h> #include <console/console.h> #include <cpu/intel/turbo.h> @@ -238,5 +239,66 @@ msr = rdmsr(MSR_CORE_THREAD_COUNT); *num_virt = (msr.lo >> 0) & 0xffff; *num_phys = (msr.lo >> 16) & 0xffff; - return (*num_virt == *num_phys); + return (*num_virt == *num_phys); +} + +__attribute__ ((weak)) +int cpu_get_coord_type(void) +{ + return HW_ALL; +} + +__attribute__ ((weak)) +uint32_t cpu_get_min_ratio(void) +{ + msr_t msr; + /* Get bus ratio limits and calculate clock speeds */ + msr = rdmsr(MSR_PLATFORM_INFO); + return ((msr.hi >> 8) & 0xff); /* Max Efficiency Ratio */ +} + +__attribute__ ((weak)) +uint32_t cpu_get_max_ratio(void) +{ + msr_t msr; + uint32_t ratio_max; + if (cpu_config_tdp_levels()) { + /* Set max ratio to nominal TDP ratio */ + msr = rdmsr(MSR_CONFIG_TDP_NOMINAL); + ratio_max = msr.lo & 0xff; + } else { + msr = rdmsr(MSR_PLATFORM_INFO); + /* Max Non-Turbo Ratio */ + ratio_max = (msr.lo >> 8) & 0xff; + } + return ratio_max; +} + +__attribute__ ((weak)) +uint32_t cpu_get_bus_clock(void) +{ + /* CPU bus clock is set by default here to 100MHz. + * This function returns the bus clock in KHz. + */ + return CONFIG_CPU_BCLK_MHZ * KHz; +} + +__attribute__ ((weak)) +uint32_t cpu_get_power_max(void) +{ + msr_t msr; + int power_unit; + + msr = rdmsr(MSR_PKG_POWER_SKU_UNIT); + power_unit = 2 << ((msr.lo & 0xf) - 1); + msr = rdmsr(MSR_PKG_POWER_SKU); + return ((msr.lo & 0x7fff) / power_unit) * 1000; +} + +__attribute__ ((weak)) +uint32_t cpu_get_max_turbo_ratio(void) +{ + msr_t msr; + msr = rdmsr(MSR_TURBO_RATIO_LIMIT); + return msr.lo & 0xff; } diff --git a/src/soc/intel/common/block/include/intelblocks/cpulib.h b/src/soc/intel/common/block/include/intelblocks/cpulib.h index f414521..3d40a92 100644 --- a/src/soc/intel/common/block/include/intelblocks/cpulib.h +++ b/src/soc/intel/common/block/include/intelblocks/cpulib.h @@ -121,4 +121,39 @@ */ int cpu_read_topology(unsigned int *num_phys, unsigned int *num_virt); +/* + * cpu_get_bus_clock returns the bus clock frequency in KHz. + * This is the value the clock ratio is multiplied with. + */ +uint32_t cpu_get_bus_clock(void); + +/* + * cpu_get_coord_type returns coordination type (SW_ANY or SW_ALL or HW_ALL) + * which is used to populate _PSD object. + */ +int cpu_get_coord_type(void); + +/* + * cpu_get_min_ratio returns the minimum frequency ratio that is supported + * by this processor + */ +uint32_t cpu_get_min_ratio(void); + +/* + * cpu_get_max_ratio returns the nominal TDP ratio if available or the + * maximum non turbo frequency ratio for this processor + */ +uint32_t cpu_get_max_ratio(void); + +/* + * cpu_get_power_max calculates CPU TDP in mW + */ +uint32_t cpu_get_power_max(void); + +/* + * cpu_get_max_turbo_ratio returns the maximum turbo ratio limit for the + * processor + */ +uint32_t cpu_get_max_turbo_ratio(void); + #endif /* SOC_INTEL_COMMON_BLOCK_CPULIB_H */ -- To view, visit https://review.coreboot.org/21051 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id34eb7e03069656238ca0cbdf6ce33f116e0e413 Gerrit-Change-Number: 21051 Gerrit-PatchSet: 1 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com>

1 0

Change in coreboot[master]: mainboard/lenovo: add Lenovo Z61m laptop
by build bot (Jenkins) (Code Review) 16 Aug '17

16 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21019 ) Change subject: mainboard/lenovo: add Lenovo Z61m laptop ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58659/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14042/ : SUCCESS -- To view, visit https://review.coreboot.org/21019 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84c89cc47d3db126d827f92d50270954bc42f224 Gerrit-Change-Number: 21019 Gerrit-PatchSet: 3 Gerrit-Owner: Andrey Korolyov <andrey(a)xdel.ru> Gerrit-Reviewer: Andrey Korolyov <andrey(a)xdel.ru> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 16:53:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/lenovo: add Lenovo Z61m laptop
by build bot (Jenkins) (Code Review) 16 Aug '17

16 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21019 ) Change subject: mainboard/lenovo: add Lenovo Z61m laptop ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58658/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/14041/ : SUCCESS -- To view, visit https://review.coreboot.org/21019 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84c89cc47d3db126d827f92d50270954bc42f224 Gerrit-Change-Number: 21019 Gerrit-PatchSet: 2 Gerrit-Owner: Andrey Korolyov <andrey(a)xdel.ru> Gerrit-Reviewer: Andrey Korolyov <andrey(a)xdel.ru> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 16:45:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/*/*: Remove rtc nvram configurable baud rate
by build bot (Jenkins) (Code Review) 16 Aug '17

16 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19682 ) Change subject: mb/*/*: Remove rtc nvram configurable baud rate ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58657/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14040/ : SUCCESS -- To view, visit https://review.coreboot.org/19682 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71698d9b188eeac73670b18b757dff5fcea0df41 Gerrit-Change-Number: 19682 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 16:28:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/kbc1126: [cosmetic] change Makefile casing
by build bot (Jenkins) (Code Review) 16 Aug '17

16 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21050 ) Change subject: util/kbc1126: [cosmetic] change Makefile casing ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58656/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14039/ : SUCCESS -- To view, visit https://review.coreboot.org/21050 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac616fdb3de79f4f58c30a2eb674ed5152b6a6e4 Gerrit-Change-Number: 21050 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 16:18:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/kbc1126: [cosmetic] change Makefile casing
by Arthur Heymans (Code Review) 16 Aug '17

16 Aug '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21050 ) Change subject: util/kbc1126: [cosmetic] change Makefile casing ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21050 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac616fdb3de79f4f58c30a2eb674ed5152b6a6e4 Gerrit-Change-Number: 21050 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 16 Aug 2017 16:16:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/kbc1126: [cosmetic] change Makefile casing
by Idwer Vollering (Code Review) 16 Aug '17

16 Aug '17

Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/21050 Change subject: util/kbc1126: [cosmetic] change Makefile casing ...................................................................... util/kbc1126: [cosmetic] change Makefile casing Change-Id: Iac616fdb3de79f4f58c30a2eb674ed5152b6a6e4 Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> --- R util/kbc1126/Makefile 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/21050/1 diff --git a/util/kbc1126/makefile b/util/kbc1126/Makefile similarity index 100% rename from util/kbc1126/makefile rename to util/kbc1126/Makefile -- To view, visit https://review.coreboot.org/21050 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iac616fdb3de79f4f58c30a2eb674ed5152b6a6e4 Gerrit-Change-Number: 21050 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com>

1 0

Change in coreboot[master]: mb/*/*: Remove rtc nvram configurable baud rate
by build bot (Jenkins) (Code Review) 16 Aug '17

16 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19682 ) Change subject: mb/*/*: Remove rtc nvram configurable baud rate ...................................................................... Patch Set 7: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58655/ : UNSTABLE -- To view, visit https://review.coreboot.org/19682 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71698d9b188eeac73670b18b757dff5fcea0df41 Gerrit-Change-Number: 19682 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 15:33:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/pi/hudson: Expand 48MHz for both osc signals
by build bot (Jenkins) (Code Review) 16 Aug '17

16 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21034 ) Change subject: amd/pi/hudson: Expand 48MHz for both osc signals ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58653/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14035/ : SUCCESS -- To view, visit https://review.coreboot.org/21034 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaee093d05fa712f62052a3787e56c5eaf4045483 Gerrit-Change-Number: 21034 Gerrit-PatchSet: 2 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 15:25:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Clear GPIO overrides
by build bot (Jenkins) (Code Review) 16 Aug '17

16 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21046 ) Change subject: amd/padmelon: Clear GPIO overrides ...................................................................... Patch Set 1: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58650/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14038/ : SUCCESS -- To view, visit https://review.coreboot.org/21046 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57e5baddf0dc8dcb89d8fbc19f373887c40cd3c3 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 1 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 15:24:30 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017