coreboot-gerrit June 2017

coreboot-gerrit@coreboot.org

1 participants
2269 discussions

Change in coreboot[master]: sb/intel/*/smi: Fix ACPI TRAP
by build bot (Jenkins) (Code Review) 27 Jun '17

27 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20328 ) Change subject: sb/intel/*/smi: Fix ACPI TRAP ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56304/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11899/ : SUCCESS -- To view, visit https://review.coreboot.org/20328 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14c9cee3da0dac7428b24c049e68b95ce099322f Gerrit-Change-Number: 20328 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Jun 2017 17:00:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/*/Kconfig: Add new symbol ENABLE_SMI_TRAP_SUPPORT
by Patrick Rudolph (Code Review) 27 Jun '17

27 Jun '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/20393 Change subject: mb/*/Kconfig: Add new symbol ENABLE_SMI_TRAP_SUPPORT ...................................................................... mb/*/Kconfig: Add new symbol ENABLE_SMI_TRAP_SUPPORT Introduce a new Kconfig that has to be set in mainboard dir to enable ACPI trap support. Mainboards that do not use TRAP or have an conflicting IO region configuration shouldn't enable this symbol. This symbol has no effect yet. Change-Id: Ie042824ee2717140dfff7e99157fe2d3fd17e234 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/Kconfig M src/mainboard/apple/macbook21/Kconfig M src/mainboard/getac/p470/Kconfig M src/mainboard/lenovo/t60/Kconfig M src/mainboard/lenovo/x200/Kconfig M src/mainboard/lenovo/x201/Kconfig M src/mainboard/lenovo/x60/Kconfig M src/mainboard/packardbell/ms2290/Kconfig M src/mainboard/roda/rk886ex/Kconfig 9 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/20393/1 diff --git a/src/Kconfig b/src/Kconfig index 637f575..5419635 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -537,6 +537,10 @@ bool default n +config ENABLE_SMI_TRAP_SUPPORT + bool + default n + config PCI_IO_CFG_EXT bool default n diff --git a/src/mainboard/apple/macbook21/Kconfig b/src/mainboard/apple/macbook21/Kconfig index 34e9f25..57361c0 100644 --- a/src/mainboard/apple/macbook21/Kconfig +++ b/src/mainboard/apple/macbook21/Kconfig @@ -19,6 +19,7 @@ select HAVE_ACPI_RESUME select USE_OPTION_TABLE select I945_LVDS + select ENABLE_SMI_TRAP_SUPPORT config MAINBOARD_DIR string diff --git a/src/mainboard/getac/p470/Kconfig b/src/mainboard/getac/p470/Kconfig index d46c768..13fcac3 100644 --- a/src/mainboard/getac/p470/Kconfig +++ b/src/mainboard/getac/p470/Kconfig @@ -35,6 +35,7 @@ select CHANNEL_XOR_RANDOMIZATION select INTEL_INT15 select I945_LVDS + select ENABLE_SMI_TRAP_SUPPORT config MAINBOARD_DIR string diff --git a/src/mainboard/lenovo/t60/Kconfig b/src/mainboard/lenovo/t60/Kconfig index 3c77a8a..585a88c 100644 --- a/src/mainboard/lenovo/t60/Kconfig +++ b/src/mainboard/lenovo/t60/Kconfig @@ -23,6 +23,7 @@ select H8_DOCK_EARLY_INIT select HAVE_CMOS_DEFAULT select I945_LVDS + select ENABLE_SMI_TRAP_SUPPORT config MAINBOARD_DIR string diff --git a/src/mainboard/lenovo/x200/Kconfig b/src/mainboard/lenovo/x200/Kconfig index d2fcec4..31181bc 100644 --- a/src/mainboard/lenovo/x200/Kconfig +++ b/src/mainboard/lenovo/x200/Kconfig @@ -21,6 +21,7 @@ select INTEL_INT15 select SUPERIO_NSC_PC87382 select DRIVERS_LENOVO_WACOM + select ENABLE_SMI_TRAP_SUPPORT config MAINBOARD_DIR string diff --git a/src/mainboard/lenovo/x201/Kconfig b/src/mainboard/lenovo/x201/Kconfig index ba590eb..2e5d16b 100644 --- a/src/mainboard/lenovo/x201/Kconfig +++ b/src/mainboard/lenovo/x201/Kconfig @@ -18,6 +18,7 @@ select SUPERIO_NSC_PC87382 select DRIVERS_LENOVO_WACOM select MAINBOARD_HAS_LPC_TPM + select ENABLE_SMI_TRAP_SUPPORT config MAINBOARD_DIR string diff --git a/src/mainboard/lenovo/x60/Kconfig b/src/mainboard/lenovo/x60/Kconfig index 1d55f98..f3b6f9a 100644 --- a/src/mainboard/lenovo/x60/Kconfig +++ b/src/mainboard/lenovo/x60/Kconfig @@ -26,6 +26,7 @@ select H8_DOCK_EARLY_INIT select DRIVERS_LENOVO_WACOM select I945_LVDS + select ENABLE_SMI_TRAP_SUPPORT config MAINBOARD_DIR string diff --git a/src/mainboard/packardbell/ms2290/Kconfig b/src/mainboard/packardbell/ms2290/Kconfig index ca25a14..daf8113 100644 --- a/src/mainboard/packardbell/ms2290/Kconfig +++ b/src/mainboard/packardbell/ms2290/Kconfig @@ -16,6 +16,7 @@ select MAINBOARD_HAS_NATIVE_VGA_INIT select INTEL_INT15 select EC_ACPI + select ENABLE_SMI_TRAP_SUPPORT config MAINBOARD_DIR string diff --git a/src/mainboard/roda/rk886ex/Kconfig b/src/mainboard/roda/rk886ex/Kconfig index e5448c9..9ae4f2c 100644 --- a/src/mainboard/roda/rk886ex/Kconfig +++ b/src/mainboard/roda/rk886ex/Kconfig @@ -19,6 +19,7 @@ select BOARD_ROMSIZE_KB_1024 select CHANNEL_XOR_RANDOMIZATION select INTEL_INT15 + select ENABLE_SMI_TRAP_SUPPORT config MAINBOARD_DIR string -- To view, visit https://review.coreboot.org/20393 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie042824ee2717140dfff7e99157fe2d3fd17e234 Gerrit-Change-Number: 20393 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: commonlib/storage: Zero extend MMC capacity
by build bot (Jenkins) (Code Review) 27 Jun '17

27 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20392 ) Change subject: commonlib/storage: Zero extend MMC capacity ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56302/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11897/ : SUCCESS -- To view, visit https://review.coreboot.org/20392 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6aac422fb1dacb75e0cc44a94ff1f467ce9f529e Gerrit-Change-Number: 20392 Gerrit-PatchSet: 1 Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Jun 2017 16:42:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: commonlib/storage: Zero extend MMC capacity
by Lee Leahy (Code Review) 27 Jun '17

27 Jun '17

Lee Leahy has uploaded this change for review. ( https://review.coreboot.org/20392 Change subject: commonlib/storage: Zero extend MMC capacity ...................................................................... commonlib/storage: Zero extend MMC capacity Fix CID 1376472 detected by coverity. Zero extend the capacity instead of sign extending it. TEST=Build and run on reef Change-Id: I6aac422fb1dacb75e0cc44a94ff1f467ce9f529e Signed-off-by: Lee Leahy <Leroy.P.Leahy(a)intel.com> --- M src/commonlib/storage/mmc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/20392/1 diff --git a/src/commonlib/storage/mmc.c b/src/commonlib/storage/mmc.c index b8a3b67..ad78617 100644 --- a/src/commonlib/storage/mmc.c +++ b/src/commonlib/storage/mmc.c @@ -433,7 +433,7 @@ * ext_csd's capacity is valid if the value is * more than 2GB */ - capacity = (ext_csd[EXT_CSD_SEC_CNT + 0] << 0 | + capacity = (uint32_t)(ext_csd[EXT_CSD_SEC_CNT + 0] << 0 | ext_csd[EXT_CSD_SEC_CNT + 1] << 8 | ext_csd[EXT_CSD_SEC_CNT + 2] << 16 | ext_csd[EXT_CSD_SEC_CNT + 3] << 24); -- To view, visit https://review.coreboot.org/20392 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6aac422fb1dacb75e0cc44a94ff1f467ce9f529e Gerrit-Change-Number: 20392 Gerrit-PatchSet: 1 Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com>

1 0

Change in coreboot[master]: abuild: give --silent the silent treatment
by build bot (Jenkins) (Code Review) 27 Jun '17

27 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20390 ) Change subject: abuild: give --silent the silent treatment ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56299/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11894/ : SUCCESS -- To view, visit https://review.coreboot.org/20390 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c1f8bffc2048a79de58cdc2a70651796db6ba6 Gerrit-Change-Number: 20390 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Jun 2017 12:11:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: abuild: give --silent the silent treatment
by Patrick Georgi (Code Review) 27 Jun '17

27 Jun '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/20390 Change subject: abuild: give --silent the silent treatment ...................................................................... abuild: give --silent the silent treatment It's obsolete and without effect. Change-Id: I17c1f8bffc2048a79de58cdc2a70651796db6ba6 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> --- M util/abuild/abuild 1 file changed, 8 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/20390/1 diff --git a/util/abuild/abuild b/util/abuild/abuild index 6473fcf..d988164 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -75,10 +75,6 @@ # this can be changed to junit by -J mode=text -# silent mode.. no compiler calls, only warnings in the log files. -# this is disabled per default but can be enabled with -s -silent= - # quiet mode: only print pass, failure, and 'skipped' messages quiet=false @@ -274,10 +270,10 @@ # shellcheck disable=SC2059 printf "$configoptions" >> "${config_file}" - yes "" 2>/dev/null | $MAKE oldconfig $silent "DOTCONFIG=${config_file}" "obj=${build_dir}" "objutil=$TARGET/sharedutils" &> "${build_dir}/config.log" ; \ + yes "" 2>/dev/null | $MAKE oldconfig $verboseopt "DOTCONFIG=${config_file}" "obj=${build_dir}" "objutil=$TARGET/sharedutils" &> "${build_dir}/config.log" ; \ CONFIG_OK=$? if [ $CONFIG_OK -eq 0 ]; then - $MAKE savedefconfig $silent DEFCONFIG="${defconfig_file}" DOTCONFIG="${config_file}" obj="${build_dir}" objutil="$TARGET/sharedutils" &>> "${build_dir}/config.log" + $MAKE savedefconfig $verboseopt DEFCONFIG="${defconfig_file}" DOTCONFIG="${config_file}" obj="${build_dir}" objutil="$TARGET/sharedutils" &>> "${build_dir}/config.log" return $? else return 1 @@ -344,8 +340,7 @@ CURR=$( pwd ) #stime=`perl -e 'print time();' 2>/dev/null || date +%s` - # shellcheck disable=SC2086 - eval $BUILDPREFIX $MAKE $silent DOTCONFIG="${build_dir}/config.build" obj="${build_dir}" objutil="$TARGET/sharedutils" BUILD_TIMELESS=$TIMELESS \ + eval $BUILDPREFIX $MAKE $verboseopt DOTCONFIG="${build_dir}/config.build" obj="${build_dir}" objutil="$TARGET/sharedutils" BUILD_TIMELESS=$TIMELESS \ &> "${build_dir}/make.log" ; \ MAKE_FAILED=$? cp .xcompile "${build_dir}/xcompile.build" @@ -547,7 +542,6 @@ [-R|--root <path>] Absolute path to coreboot sources (defaults to $ROOT) [--scan-build] Use clang's static analyzer - [-s|--silent] Omit compiler calls in logs [--timeless] Generate timeless builds [-t|--target <vendor/board>] Attempt to build target vendor/board only [-T|--test] Submit image(s) to automated test system @@ -563,6 +557,7 @@ [-V|--version] Print version number and exit [-h|--help] Print this help and exit + [-s|--silent] obsolete __END_OF_HELP } @@ -621,6 +616,7 @@ chromeos=false clean_work=false +verboseopt='V=0' customizing="" configoptions="" # testclass needs to be undefined if not used for variable expansion to work @@ -632,7 +628,7 @@ -a|--all) shift; buildall=true;; -d|--dir) shift; configdir="$1"; shift;; -r|--remove) shift; remove=true;; - -v|--verbose) shift; verbose=true; silent='V=1';; + -v|--verbose) shift; verbose=true; verboseopt='V=1';; -q|--quiet) shift; quiet=true;; -V|--version) shift; myversion; exit 0;; -h|--help) shift; myversion; myhelp; exit 0;; @@ -645,7 +641,8 @@ test "$1" == "1" && cpuconfig=" on 1 cpu" expr "$1" : '-\?[0-9]\+$' > /dev/null && test "0$1" -gt 1 && cpuconfig=" on $1 cpus in parallel" shift;; - -s|--silent) shift; silent="-s";; + # obsolete option + -s|--silent) shift;; --scan-build) shift scanbuild=true customizing="${customizing}, scan-build" -- To view, visit https://review.coreboot.org/20390 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I17c1f8bffc2048a79de58cdc2a70651796db6ba6 Gerrit-Change-Number: 20390 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: xcompile: Also try clang variants under the $triplet-clang s...
by build bot (Jenkins) (Code Review) 27 Jun '17

27 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19660 ) Change subject: xcompile: Also try clang variants under the $triplet-clang scheme ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56298/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11893/ : SUCCESS -- To view, visit https://review.coreboot.org/19660 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14fe767d20f91b64e96c909291760bddcd108e5c Gerrit-Change-Number: 19660 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Jun 2017 11:47:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/soraka: Do not reset PMIC during sleep
by build bot (Jenkins) (Code Review) 27 Jun '17

27 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20264 ) Change subject: mb/google/soraka: Do not reset PMIC during sleep ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56297/ : SUCCESS -- To view, visit https://review.coreboot.org/20264 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93ce4d76b0376b64ae6d1067aca0fd7467af3582 Gerrit-Change-Number: 20264 Gerrit-PatchSet: 5 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ruben Rodriguez Buchillon <coconutruben(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Jun 2017 07:01:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sgx: Move SGX code to intel/common/block
by build bot (Jenkins) (Code Review) 27 Jun '17

27 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20173 ) Change subject: sgx: Move SGX code to intel/common/block ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56295/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11891/ : SUCCESS -- To view, visit https://review.coreboot.org/20173 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fbba364b7342e686a2287ea1a910ef9a4eed595 Gerrit-Change-Number: 20173 Gerrit-PatchSet: 3 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Jun 2017 23:20:13 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Move ACPI MADT table to soc
by build bot (Jenkins) (Code Review) 27 Jun '17

27 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20277 ) Change subject: soc/amd/stoneyridge: Move ACPI MADT table to soc ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56276/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11872/ : SUCCESS -- To view, visit https://review.coreboot.org/20277 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49fb55b1315da8fe65421b43fc4312ed588d5ecb Gerrit-Change-Number: 20277 Gerrit-PatchSet: 6 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Jun 2017 22:57:17 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2017