coreboot-gerrit June 2017

coreboot-gerrit@coreboot.org

1 participants
2269 discussions

Change in coreboot[master]: google/kahlee: Move mainboard_ec_init to dev init phase
by build bot (Jenkins) (Code Review) 27 Jun '17

27 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20312 ) Change subject: google/kahlee: Move mainboard_ec_init to dev init phase ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56269/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11866/ : SUCCESS -- To view, visit https://review.coreboot.org/20312 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieabcecf70e4de0b42fc639d031755b6d0b66f08a Gerrit-Change-Number: 20312 Gerrit-PatchSet: 4 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Jun 2017 22:21:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Add trackpad SMBIOS information
by build bot (Jenkins) (Code Review) 27 Jun '17

27 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20311 ) Change subject: google/kahlee: Add trackpad SMBIOS information ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56268/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11865/ : SUCCESS -- To view, visit https://review.coreboot.org/20311 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5920f91eac06fa74056dab8bee789c1513c425fa Gerrit-Change-Number: 20311 Gerrit-PatchSet: 4 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Jun 2017 22:20:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add GNVS
by build bot (Jenkins) (Code Review) 27 Jun '17

27 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20275 ) Change subject: soc/amd/stoneyridge: Add GNVS ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56266/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11863/ : SUCCESS -- To view, visit https://review.coreboot.org/20275 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ecab92181bfe60e7b6c6e91ffb9fa843345352f Gerrit-Change-Number: 20275 Gerrit-PatchSet: 5 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Jun 2017 22:15:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Move ACPI MADT table to soc
by build bot (Jenkins) (Code Review) 27 Jun '17

27 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20277 ) Change subject: soc/amd/stoneyridge: Move ACPI MADT table to soc ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56265/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11862/ : SUCCESS -- To view, visit https://review.coreboot.org/20277 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49fb55b1315da8fe65421b43fc4312ed588d5ecb Gerrit-Change-Number: 20277 Gerrit-PatchSet: 5 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Jun 2017 22:14:37 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/crossgcc: Fix building gcc 6.3.0 with clang
by build bot (Jenkins) (Code Review) 27 Jun '17

27 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20366 ) Change subject: util/crossgcc: Fix building gcc 6.3.0 with clang ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56261/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11857/ : SUCCESS https://qa.coreboot.org/job/coreboot-toolchain/318/ : SUCCESS -- To view, visit https://review.coreboot.org/20366 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1930bb01dd62bd6abf0688b118236db2a9299e40 Gerrit-Change-Number: 20366 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Jun 2017 22:05:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP]arch/x86: Add function to play a sound through PC speaker
by Arthur Heymans (Code Review) 26 Jun '17

26 Jun '17

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/20379 ) Change subject: [WIP]arch/x86: Add function to play a sound through PC speaker ...................................................................... Abandoned making the function make_tone public in spkmodem.c would achieve the same... -- To view, visit https://review.coreboot.org/20379 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Iec31101892b109c52db279cc3a1c7f4c143a0f7b Gerrit-Change-Number: 20379 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP]arch/x86: Add function to play a sound through PC speaker
by build bot (Jenkins) (Code Review) 26 Jun '17

26 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20379 ) Change subject: [WIP]arch/x86: Add function to play a sound through PC speaker ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56259/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11856/ : SUCCESS -- To view, visit https://review.coreboot.org/20379 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec31101892b109c52db279cc3a1c7f4c143a0f7b Gerrit-Change-Number: 20379 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Jun 2017 20:34:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP]arch/x86: Add function to play a sound through PC speaker
by Arthur Heymans (Code Review) 26 Jun '17

26 Jun '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20379 to look at the new patch set (#2). Change subject: [WIP]arch/x86: Add function to play a sound through PC speaker ...................................................................... [WIP]arch/x86: Add function to play a sound through PC speaker inspired by http://wiki.osdev.org/PC_Speaker (todo archive the link) Change-Id: Iec31101892b109c52db279cc3a1c7f4c143a0f7b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/x86/Makefile.inc A src/arch/x86/include/arch/pit.h A src/arch/x86/pit.c 3 files changed, 62 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/20379/2 -- To view, visit https://review.coreboot.org/20379 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iec31101892b109c52db279cc3a1c7f4c143a0f7b Gerrit-Change-Number: 20379 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP]arch/x86: Add function to play a sound through PC speaker
by build bot (Jenkins) (Code Review) 26 Jun '17

26 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20379 ) Change subject: [WIP]arch/x86: Add function to play a sound through PC speaker ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56258/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/11855/ : SUCCESS -- To view, visit https://review.coreboot.org/20379 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec31101892b109c52db279cc3a1c7f4c143a0f7b Gerrit-Change-Number: 20379 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Jun 2017 20:26:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP]arch/x86: Add function to play a sound through PC speaker
by Arthur Heymans (Code Review) 26 Jun '17

26 Jun '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20379 Change subject: [WIP]arch/x86: Add function to play a sound through PC speaker ...................................................................... [WIP]arch/x86: Add function to play a sound through PC speaker inspired by http://wiki.osdev.org/PC_Speaker (todo archive the link) Change-Id: Iec31101892b109c52db279cc3a1c7f4c143a0f7b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/x86/Makefile.inc A src/arch/x86/include/arch/pit.h A src/arch/x86/pit.c 3 files changed, 62 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/20379/1 diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 5f184c5..ae7f5b6 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -215,6 +215,7 @@ romstage-$(CONFIG_X86_TOP4G_BOOTMEDIA_MAP) += mmap_boot.c romstage-y += postcar_loader.c romstage-$(CONFIG_COLLECT_TIMESTAMPS) += timestamp.c +romstage-y += pit.c ifneq ($(CONFIG_ROMCC),y) @@ -341,6 +342,7 @@ ramstage-$(CONFIG_COOP_MULTITASKING) += thread_switch.S ramstage-$(CONFIG_COLLECT_TIMESTAMPS) += timestamp.c ramstage-$(CONFIG_HAVE_ACPI_RESUME) += wakeup.S +ramstage-y += pit.c smm-y += memcpy.c smm-y += memmove.c diff --git a/src/arch/x86/include/arch/pit.h b/src/arch/x86/include/arch/pit.h new file mode 100644 index 0000000..6286bbf --- /dev/null +++ b/src/arch/x86/include/arch/pit.h @@ -0,0 +1,21 @@ +/* + * This file is part of the coreboot project. + * + * 2017 Arthur Heymans <arthur(a)aheymans.xyz> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __INCLUDE_ARCH_PIT__ +#define __INCLUDE_ARCH_PIT__ + +void play_sound(u32 frequency, u8 seconds); + +#endif /* __INCLUDE_ARCH_PIT__ */ diff --git a/src/arch/x86/pit.c b/src/arch/x86/pit.c new file mode 100644 index 0000000..b90767e --- /dev/null +++ b/src/arch/x86/pit.c @@ -0,0 +1,39 @@ +/* + * This file is part of the coreboot project. + * + * 2017 Arthur Heymans <arthur(a)aheymans.xyz> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <arch/io.h> +#include <delay.h> +#include <arch/pit.h> + + +void play_sound(u32 frequency, u8 seconds) +{ + u32 div; + u8 reg8; + + div = 1193180 / frequency; + outb(0xb6, 0x43); + outb((u8) (div), 0x42); + outb((u8) (div >> 8), 0x42); + + reg8 = inb(0x61); + if (reg8!= (reg8 | 3)) + outb(reg8 | 3, 0x61); + + udelay(1000 * seconds); + + reg8 = inb(0x61) & ~3; + outb(reg8, 0x61); +} -- To view, visit https://review.coreboot.org/20379 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iec31101892b109c52db279cc3a1c7f4c143a0f7b Gerrit-Change-Number: 20379 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2017