coreboot-gerrit June 2017

coreboot-gerrit@coreboot.org

1 participants
2269 discussions

Change in coreboot[master]: sb/intel/*: Use common SMBus functions
by build bot (Jenkins) (Code Review) 26 Jun '17

26 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19258 ) Change subject: sb/intel/*: Use common SMBus functions ...................................................................... Patch Set 20: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56253/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11851/ : SUCCESS -- To view, visit https://review.coreboot.org/19258 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93bb186e04e8c32dff04fc1abe4b5ecbc4c9c962 Gerrit-Change-Number: 19258 Gerrit-PatchSet: 20 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Jun 2017 20:04:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: libpayload/drivers/usb/ehci_private.h: Add brackets around m...
by build bot (Jenkins) (Code Review) 26 Jun '17

26 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20376 ) Change subject: libpayload/drivers/usb/ehci_private.h: Add brackets around macro ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56256/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11854/ : SUCCESS -- To view, visit https://review.coreboot.org/20376 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee8dc03d5a4ca7537c7da4fed2c67b169c9e2422 Gerrit-Change-Number: 20376 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Jun 2017 20:04:00 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: libpayload/drivers/usb/xhci_private.h: Add parentheses aroun...
by build bot (Jenkins) (Code Review) 26 Jun '17

26 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20371 ) Change subject: libpayload/drivers/usb/xhci_private.h: Add parentheses around macro ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56257/ : SUCCESS -- To view, visit https://review.coreboot.org/20371 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0347594e9480dedc4845b6863733a67fc5e47e1c Gerrit-Change-Number: 20371 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Jun 2017 19:57:29 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: libpayload/drivers/usb/xhci_private.h: Add parentheses aroun...
by HAOUAS Elyes (Code Review) 26 Jun '17

26 Jun '17

Hello Philippe Mathieu-Daudé, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20371 to look at the new patch set (#2). Change subject: libpayload/drivers/usb/xhci_private.h: Add parentheses around macro ...................................................................... libpayload/drivers/usb/xhci_private.h: Add parentheses around macro Change-Id: I0347594e9480dedc4845b6863733a67fc5e47e1c Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M payloads/libpayload/drivers/usb/xhci_private.h 1 file changed, 12 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/20371/2 -- To view, visit https://review.coreboot.org/20371 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0347594e9480dedc4845b6863733a67fc5e47e1c Gerrit-Change-Number: 20371 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: libpayload/drivers/usb/ehci_private.h: Add brackets around m...
by HAOUAS Elyes (Code Review) 26 Jun '17

26 Jun '17

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/20376 Change subject: libpayload/drivers/usb/ehci_private.h: Add brackets around macro ...................................................................... libpayload/drivers/usb/ehci_private.h: Add brackets around macro Change-Id: Iee8dc03d5a4ca7537c7da4fed2c67b169c9e2422 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M payloads/libpayload/drivers/usb/ehci_private.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/20376/1 diff --git a/payloads/libpayload/drivers/usb/ehci_private.h b/payloads/libpayload/drivers/usb/ehci_private.h index 8519c0f..79809f7 100644 --- a/payloads/libpayload/drivers/usb/ehci_private.h +++ b/payloads/libpayload/drivers/usb/ehci_private.h @@ -143,7 +143,7 @@ } ehci_t; #define PS_TERMINATE 1 -#define PS_TYPE_QH 1 << 1 +#define PS_TYPE_QH (1 << 1) #define PS_PTR_MASK ~0x1f #define EHCI_INST(controller) ((ehci_t*)((controller)->instance)) -- To view, visit https://review.coreboot.org/20376 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iee8dc03d5a4ca7537c7da4fed2c67b169c9e2422 Gerrit-Change-Number: 20376 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: libpayload/drivers/usb/ohci_private.h: Add brackets around m...
by build bot (Jenkins) (Code Review) 26 Jun '17

26 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20372 ) Change subject: libpayload/drivers/usb/ohci_private.h: Add brackets around macro ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56255/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11853/ : SUCCESS -- To view, visit https://review.coreboot.org/20372 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4892adba161cd08eecde71a011384b6c465b98f Gerrit-Change-Number: 20372 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Jun 2017 19:43:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: payloads/libpayload/drivers/usb/xhci_private.h: Add brackets...
by build bot (Jenkins) (Code Review) 26 Jun '17

26 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20371 ) Change subject: payloads/libpayload/drivers/usb/xhci_private.h: Add brackets around macro ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56254/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/11852/ : SUCCESS -- To view, visit https://review.coreboot.org/20371 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0347594e9480dedc4845b6863733a67fc5e47e1c Gerrit-Change-Number: 20371 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Jun 2017 19:38:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: libpayload/drivers/usb/ohci_private.h: Add brackets around m...
by HAOUAS Elyes (Code Review) 26 Jun '17

26 Jun '17

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/20372 Change subject: libpayload/drivers/usb/ohci_private.h: Add brackets around macro ...................................................................... libpayload/drivers/usb/ohci_private.h: Add brackets around macro Change-Id: Id4892adba161cd08eecde71a011384b6c465b98f Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M payloads/libpayload/drivers/usb/ohci_private.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/20372/1 diff --git a/payloads/libpayload/drivers/usb/ohci_private.h b/payloads/libpayload/drivers/usb/ohci_private.h index e912837..07bb20d 100644 --- a/payloads/libpayload/drivers/usb/ohci_private.h +++ b/payloads/libpayload/drivers/usb/ohci_private.h @@ -234,8 +234,8 @@ #define TD_DIRECTION_SHIFT 19 #define TD_DIRECTION_MASK MASK(TD_DIRECTION_SHIFT, 2) -#define TD_DIRECTION_SETUP OHCI_SETUP << TD_DIRECTION_SHIFT -#define TD_DIRECTION_IN OHCI_IN << TD_DIRECTION_SHIFT +#define TD_DIRECTION_SETUP (OHCI_SETUP << TD_DIRECTION_SHIFT) +#define TD_DIRECTION_IN (OHCI_IN << TD_DIRECTION_SHIFT) #define TD_DIRECTION_OUT OHCI_OUT << TD_DIRECTION_SHIFT #define TD_DELAY_INTERRUPT_SHIFT 21 #define TD_DELAY_INTERRUPT_MASK MASK(TD_DELAY_INTERRUPT_SHIFT, 3) -- To view, visit https://review.coreboot.org/20372 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id4892adba161cd08eecde71a011384b6c465b98f Gerrit-Change-Number: 20372 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: payloads/libpayload/drivers/usb/xhci_private.h: Add brackets...
by Philippe Mathieu-Daudé (Code Review) 26 Jun '17

26 Jun '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/20371 ) Change subject: payloads/libpayload/drivers/usb/xhci_private.h: Add brackets around macro ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/20371/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/20371/1//COMMIT_MSG@7 PS1, Line 7: brackets parentheses? or round brackets -- To view, visit https://review.coreboot.org/20371 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0347594e9480dedc4845b6863733a67fc5e47e1c Gerrit-Change-Number: 20371 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Comment-Date: Mon, 26 Jun 2017 19:37:16 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: payloads/libpayload/drivers/usb/xhci_private.h: Add brackets...
by HAOUAS Elyes (Code Review) 26 Jun '17

26 Jun '17

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/20371 Change subject: payloads/libpayload/drivers/usb/xhci_private.h: Add brackets around macro ...................................................................... payloads/libpayload/drivers/usb/xhci_private.h: Add brackets around macro Change-Id: I0347594e9480dedc4845b6863733a67fc5e47e1c Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M payloads/libpayload/drivers/usb/xhci_private.h 1 file changed, 12 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/20371/1 diff --git a/payloads/libpayload/drivers/usb/xhci_private.h b/payloads/libpayload/drivers/usb/xhci_private.h index 47a464f..3b4e7bb 100644 --- a/payloads/libpayload/drivers/usb/xhci_private.h +++ b/payloads/libpayload/drivers/usb/xhci_private.h @@ -387,25 +387,25 @@ making bitfields unusable for MMIO register blocks. Yay C :-( */ volatile struct opreg { u32 usbcmd; -#define USBCMD_RS 1<<0 -#define USBCMD_HCRST 1<<1 -#define USBCMD_INTE 1<<2 +#define USBCMD_RS (1 << 0) +#define USBCMD_HCRST (1 << 1) +#define USBCMD_INTE (1 << 2) u32 usbsts; -#define USBSTS_HCH 1<<0 -#define USBSTS_HSE 1<<2 -#define USBSTS_EINT 1<<3 -#define USBSTS_PCD 1<<4 -#define USBSTS_CNR 1<<11 +#define USBSTS_HCH (1 << 0) +#define USBSTS_HSE (1 << 2) +#define USBSTS_EINT (1 << 3) +#define USBSTS_PCD (1 << 4) +#define USBSTS_CNR (1 << 11) #define USBSTS_PRSRV_MASK ((1 << 1) | 0xffffe000) u32 pagesize; u8 res1[0x13-0x0c+1]; u32 dnctrl; u32 crcr_lo; u32 crcr_hi; -#define CRCR_RCS 1<<0 -#define CRCR_CS 1<<1 -#define CRCR_CA 1<<2 -#define CRCR_CRR 1<<3 +#define CRCR_RCS (1 << 0) +#define CRCR_CS (1 << 1) +#define CRCR_CA (1 << 2) +#define CRCR_CRR (1 << 3) u8 res2[0x2f-0x20+1]; u32 dcbaap_lo; u32 dcbaap_hi; -- To view, visit https://review.coreboot.org/20371 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0347594e9480dedc4845b6863733a67fc5e47e1c Gerrit-Change-Number: 20371 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2017