June 2017 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: WIP soc/amd/common: Convert to C_ENVIRONMENT_BOOTBLOCK
by Marc Jones (Code Review) June 1, 2017

June 1, 2017

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19755 ) Change subject: WIP soc/amd/common: Convert to C_ENVIRONMENT_BOOTBLOCK ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/19755/4/src/mainboard/amd/gardenia/bootbloc… File src/mainboard/amd/gardenia/bootblock/OemCustomize.c: Line 128: }; some of this doesn't belong in the bootblock. So maybe lets split this file. -- To view, visit https://review.coreboot.org/19755 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I811c7ef875b980874f3c4b1f234f969ae5618c44 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: google/kahlee: Start Kahlee mainboard
by Marc Jones (Code Review) June 1, 2017

June 1, 2017

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19830 ) Change subject: google/kahlee: Start Kahlee mainboard ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/19830/3/src/mainboard/google/kahlee/bootblo… File src/mainboard/google/kahlee/bootblock/OemCustomize.c: PS3, Line 102: static const UINT32 AzaliaCodecAlc286Table[] = : { : 0x00172051, 0x001721C7, 0x00172222, 0x00172310, : 0x0017FF00, 0x0017FF00, 0x0017FF00, 0x0017FF00, : 0x01271C50, 0x01271D01, 0x01271EA6, 0x01271FB7, : 0x01371C00, 0x01371D00, 0x01371E00, 0x01371F40, : 0x01471C10, 0x01471D01, 0x01471E17, 0x01471F90, : 0x01771CF0, 0x01771D11, 0x01771E11, 0x01771F41, : 0x01871C40, 0x01871D10, 0x01871EA1, 0x01871F04, : 0x01971CF0, 0x01971D11, 0x01971E11, 0x01971F41, : 0x01A71CF0, 0x01A71D11, 0x01A71E11, 0x01A71F41, : 0x01D71C2D, 0x01D71DA5, 0x01D71E67, 0x01D71F40, : 0x01E71C30, 0x01E71D11, 0x01E71E45, 0x01E71F04, : 0x02171C20, 0x02171D10, 0x02171E21, 0x02171F04, : 0x02050071, 0x02040014, 0x02050010, 0x02040C22, : 0x0205004F, 0x0204B029, 0x0205002B, 0x02040C50, : 0x0205002D, 0x02041020, 0x02050020, 0x02040000, : 0x02050019, 0x02040817, 0x02050035, 0x02041AA5, : 0x02050063, 0x02042906, 0x02050063, 0x02042906, : 0xffffffff : }; > Where else would it be? Ah, I understand your comment as about this file. This probably needs a better split. Lets put the comment in the gardenia patch earlier in the stack. -- To view, visit https://review.coreboot.org/19830 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia68b16969518f4d63d5d2dea7658a472b2daca05 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: google/kahlee: Start Kahlee mainboard
by Marc Jones (Code Review) June 1, 2017

June 1, 2017

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19830 ) Change subject: google/kahlee: Start Kahlee mainboard ...................................................................... Patch Set 3: (2 comments) Only copied from Gardenia, so comments are addressed in other patches. https://review.coreboot.org/#/c/19830/3/src/mainboard/google/kahlee/bootblo… File src/mainboard/google/kahlee/bootblock/OemCustomize.c: PS3, Line 102: static const UINT32 AzaliaCodecAlc286Table[] = : { : 0x00172051, 0x001721C7, 0x00172222, 0x00172310, : 0x0017FF00, 0x0017FF00, 0x0017FF00, 0x0017FF00, : 0x01271C50, 0x01271D01, 0x01271EA6, 0x01271FB7, : 0x01371C00, 0x01371D00, 0x01371E00, 0x01371F40, : 0x01471C10, 0x01471D01, 0x01471E17, 0x01471F90, : 0x01771CF0, 0x01771D11, 0x01771E11, 0x01771F41, : 0x01871C40, 0x01871D10, 0x01871EA1, 0x01871F04, : 0x01971CF0, 0x01971D11, 0x01971E11, 0x01971F41, : 0x01A71CF0, 0x01A71D11, 0x01A71E11, 0x01A71F41, : 0x01D71C2D, 0x01D71DA5, 0x01D71E67, 0x01D71F40, : 0x01E71C30, 0x01E71D11, 0x01E71E45, 0x01E71F04, : 0x02171C20, 0x02171D10, 0x02171E21, 0x02171F04, : 0x02050071, 0x02040014, 0x02050010, 0x02040C22, : 0x0205004F, 0x0204B029, 0x0205002B, 0x02040C50, : 0x0205002D, 0x02041020, 0x02050020, 0x02040000, : 0x02050019, 0x02040817, 0x02050035, 0x02041AA5, : 0x02050063, 0x02042906, 0x02050063, 0x02042906, : 0xffffffff : }; > Something tells me that the bootblock is not the right place for this code. Where else would it be? Note, that this is just a copy and not customized yet. Obviously Kahlee has an I2S codec. https://review.coreboot.org/#/c/19830/3/src/mainboard/google/kahlee/mptable… File src/mainboard/google/kahlee/mptable.c: PS3, Line 1: /* > do we really still want to support hard coded mp and pirq tables? I suggest Except for those strange embedded folks that still run dos and other strange OSs. Granted, this has just come along for the ride from Gardenia and could be removed later for Kahlee. -- To view, visit https://review.coreboot.org/19830 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia68b16969518f4d63d5d2dea7658a472b2daca05 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add northbridge support
by Marc Jones (Code Review) June 1, 2017

June 1, 2017

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19724 ) Change subject: soc/amd/stoneyridge: Add northbridge support ...................................................................... Patch Set 4: Issues opened or updated based on the this review: Kahlee: coreboot -stoneyridge - move dram top setup 62240756 Kahlee: coreboot - fix src/soc/amd/common/agesawrapper_call.h 62240989 Kahlee: coreboot - stoneyridge - use coreboot register write functions 62241048 Kahlee: coreboot - stonyridge - fix northbridge.c 62240927 Kahlee: coreboot - stoneyridge - fix checkpatch warnings and errors 62240746 Kahlee: coreboot -stoneyridge - include headers for filetypes used. 62239898 Kahlee: coreboot - stoneyridge - fix soc/amd/common include files 62240201 Kahlee: coreboot -stoneyridge - fix agesa header file include paths / namespace 62239980 -- To view, visit https://review.coreboot.org/19724 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie86b4d744900f23502068517ece5bcea6c128993 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add CPU files
by Marc Jones (Code Review) June 1, 2017

June 1, 2017

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19723 ) Change subject: soc/amd/stoneyridge: Add CPU files ...................................................................... Patch Set 4: Opened the following issues in addition to the one from the southbridge patch. Kahlee: coreboot - stoneyridge - fix #if throughout 62237963 Kahlee: coreboot - stoneyridge - fix headers ifdef leading underscore 62235990 Kahlee: coreboot - Fix soc/amd/common/Kconfig and Makefile 62235314 -- To view, visit https://review.coreboot.org/19723 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b6b1991372c2c6a02709777a73615a86e78ac26 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block/gpio: Port gpio code from Apollolake ...
by Hannah Williams (Code Review) June 1, 2017

June 1, 2017

Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19759 ) Change subject: soc/intel/common/block/gpio: Port gpio code from Apollolake to common ...................................................................... Patch Set 14: (1 comment) https://review.coreboot.org/#/c/19759/19/src/soc/intel/common/block/include… File src/soc/intel/common/block/include/intelblocks/gpio_defs.h: Line 29: #define PAD_CFG0_RX_STATE (1 << PAD_CFG0_RX_STATE_BIT) > This shouldn't be exposed to the user of this API. Also what about the TOL yes I was going to get APL and GLK working and then go to SKL - so as part of CNL using common GPIO we can address that -- To view, visit https://review.coreboot.org/19759 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic48401e92103ff0ec278fb69a3d304148a2d79aa Gerrit-PatchSet: 14 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Divya Chellappa <divya.chella(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/intel/apollolake: Bring in delta for GLK SOC
by build bot (Jenkins) (Code Review) June 1, 2017

June 1, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19603 ) Change subject: soc/intel/apollolake: Bring in delta for GLK SOC ...................................................................... Patch Set 60: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/54675/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/10380/ : SUCCESS -- To view, visit https://review.coreboot.org/19603 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3 Gerrit-PatchSet: 60 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com> Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Bring in delta for GLK SOC
by Hannah Williams (Code Review) June 1, 2017

June 1, 2017

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19603 to look at the new patch set (#60). Change subject: soc/intel/apollolake: Bring in delta for GLK SOC ...................................................................... soc/intel/apollolake: Bring in delta for GLK SOC Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3 Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- M src/soc/intel/apollolake/Kconfig M src/soc/intel/apollolake/Makefile.inc A src/soc/intel/apollolake/acpi/gpio_glk.asl M src/soc/intel/apollolake/acpi/lpss.asl M src/soc/intel/apollolake/acpi/southbridge.asl M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/apollolake/chip.c M src/soc/intel/apollolake/cpu.c A src/soc/intel/apollolake/gpio_glk.c D src/soc/intel/apollolake/include/FspUpd.h M src/soc/intel/apollolake/include/soc/cpu.h M src/soc/intel/apollolake/include/soc/gpio.h A src/soc/intel/apollolake/include/soc/gpio_glk.h D src/soc/intel/apollolake/include/soc/pci_ids.h M src/soc/intel/apollolake/include/soc/pcr_ids.h M src/soc/intel/apollolake/include/soc/pm.h M src/soc/intel/apollolake/lpc_lib.c M src/soc/intel/apollolake/pmutil.c M src/soc/intel/apollolake/romstage.c M src/soc/intel/apollolake/uart_early.c 20 files changed, 970 insertions(+), 138 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/19603/60 -- To view, visit https://review.coreboot.org/19603 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3 Gerrit-PatchSet: 60 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com> Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/apollolake: Bring in delta for GLK SOC
by Hannah Williams (Code Review) June 1, 2017

June 1, 2017

Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19603 ) Change subject: soc/intel/apollolake: Bring in delta for GLK SOC ...................................................................... Patch Set 59: (2 comments) https://review.coreboot.org/#/c/19603/59/src/soc/intel/apollolake/acpi/lpss… File src/soc/intel/apollolake/acpi/lpss.asl: Line 20: Method(LPD3, 0, Serialized) { > What is this for? Comments are required. putting LPSS in D3 https://review.coreboot.org/#/c/19603/59/src/soc/intel/apollolake/bootblock… File src/soc/intel/apollolake/bootblock/bootblock.c: Line 38: #if !IS_ENABLED(CONFIG_SOC_INTEL_GLK) > why? It is default enabled as Native Function on GLK -- To view, visit https://review.coreboot.org/19603 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3 Gerrit-PatchSet: 59 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com> Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0