Change in coreboot[master]: soc/intel/common/block/gpio: Port gpio code from Apollolake ...
Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19759 ) Change subject: soc/intel/common/block/gpio: Port gpio code from Apollolake to common ...................................................................... Patch Set 14: (1 comment) https://review.coreboot.org/#/c/19759/19/src/soc/intel/common/block/include/... File src/soc/intel/common/block/include/intelblocks/gpio_defs.h: Line 29: #define PAD_CFG0_RX_STATE (1 << PAD_CFG0_RX_STATE_BIT)
This shouldn't be exposed to the user of this API. Also what about the TOL yes I was going to get APL and GLK working and then go to SKL - so as part of CNL using common GPIO we can address that
-- To view, visit https://review.coreboot.org/19759 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic48401e92103ff0ec278fb69a3d304148a2d79aa Gerrit-PatchSet: 14 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams@intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar@intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com> Gerrit-Reviewer: Divya Chellappa <divya.chella@gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi@intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha@intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-HasComments: Yes
participants (1)
-
Hannah Williams (Code Review)