March 2017 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: arch/x86/acpigen: Allow writing buffers larger than 256 bytes
by build bot (Jenkins) (Code Review) March 31, 2017

March 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18966 ) Change subject: arch/x86/acpigen: Allow writing buffers larger than 256 bytes ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50990/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6958/ : SUCCESS -- To view, visit https://review.coreboot.org/18966 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifaf508ae1d5c0eb2629ca112224bfeae1c644e58 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/x86/acpigen: Allow writing buffers larger than 256 bytes
by V Sowmya (Code Review) March 31, 2017

March 31, 2017

V Sowmya has posted comments on this change. ( https://review.coreboot.org/18966 ) Change subject: arch/x86/acpigen: Allow writing buffers larger than 256 bytes ...................................................................... Patch Set 1: (1 comment) > (2 comments) https://review.coreboot.org/#/c/18966/1/src/arch/x86/include/arch/acpigen.h File src/arch/x86/include/arch/acpigen.h: PS1, Line 245: uint32_t > Just make these size_t. Done -- To view, visit https://review.coreboot.org/18966 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifaf508ae1d5c0eb2629ca112224bfeae1c644e58 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: arch/x86/acpigen: Allow writing buffers larger than 256 bytes
by V Sowmya (Code Review) March 31, 2017

March 31, 2017

Hello Rizwan Qureshi, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/18966 to look at the new patch set (#2). Change subject: arch/x86/acpigen: Allow writing buffers larger than 256 bytes ...................................................................... arch/x86/acpigen: Allow writing buffers larger than 256 bytes Currently only 256 bytes can be written at a time using the acpigen_write_return_byte_buffer or acpigen_write_byte_buffer API's and there can be cases where the buffer size can exceed this, hence increase the number of bytes that can be written. Change-Id: Ifaf508ae1d5c0eb2629ca112224bfeae1c644e58 Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Signed-off-by: Sowmya V <v.sowmya(a)intel.com> --- M src/arch/x86/acpigen.c M src/arch/x86/include/arch/acpigen.h 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/18966/2 -- To view, visit https://review.coreboot.org/18966 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifaf508ae1d5c0eb2629ca112224bfeae1c644e58 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by build bot (Jenkins) (Code Review) March 31, 2017

March 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19043 ) Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50989/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6957/ : SUCCESS -- To view, visit https://review.coreboot.org/19043 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by Mario Scheithauer (Code Review) March 31, 2017

March 31, 2017

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/19043 ) Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/#/c/19043/1/src/mainboard/siemens/mc_apl1/lcd_p… File src/mainboard/siemens/mc_apl1/lcd_panel.c: PS1, Line 38: > Verb is spelled with a space *Set up*. Done Line 38 > Right, then I mean below, that `0x%x\n", status` is not needed. lcd_panel.c no longer exists. The function call ptn3460_init is placed directly into mainboard.c because the mainboard doesn’t need a selection of the connected panel. I changed it there. -- To view, visit https://review.coreboot.org/19043 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by Mario Scheithauer (Code Review) March 31, 2017

March 31, 2017

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19043 to look at the new patch set (#5). Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ...................................................................... siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC This mainboard uses a LVDS connection for LCD panels. Apollo Lake SoC provides a display controller with three independent pipes (1x eDP and 2x DP/HDMI). PTN3460 is an embedded DisplayPort to LVDS bridge device that enables connectivity between an eDP source and LVDS display panel (http://www.nxp.com/documents/data_sheet/PTN3460.pdf) The bridge contains an On-chip Extended Display Identification Data (EDIT) emulation for EDIT data structures. This patch sets up PTN3460 to be used with the appropriate LCD panel. Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_apl1/Makefile.inc M src/mainboard/siemens/mc_apl1/mainboard.c A src/mainboard/siemens/mc_apl1/ptn3460.c A src/mainboard/siemens/mc_apl1/ptn3460.h 4 files changed, 289 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/19043/5 -- To view, visit https://review.coreboot.org/19043 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by build bot (Jenkins) (Code Review) March 31, 2017

March 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19043 ) Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50988/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6956/ : SUCCESS -- To view, visit https://review.coreboot.org/19043 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by Mario Scheithauer (Code Review) March 31, 2017

March 31, 2017

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/19043 ) Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ...................................................................... Patch Set 4: (6 comments) https://review.coreboot.org/#/c/19043/1/src/mainboard/siemens/mc_apl1/ptn34… File src/mainboard/siemens/mc_apl1/ptn3460.c: PS1, Line 106: (i = 0; > It seems like it would be easy to provide one. Have you tried that? Sure but we should think about an i2c_write_bytes function if we made a separate driver for the PTN. https://review.coreboot.org/#/c/19043/3/src/mainboard/siemens/mc_apl1/ptn34… File src/mainboard/siemens/mc_apl1/ptn3460.c: PS3, Line 35: PTN_ > There's not a constant defined for edid size anywhere? You seem to have def Changed it to PTN_EDID_LEN PS3, Line 50: s > sizeof(disp_con) Changed both sides of comparsion to sizeof(disp_con). PS3, Line 55: > sizeof(color_depth) Done PS3, Line 75: (cfg)) > i2c_read_bytes() doesn't return CB_* return codes explicitly. You probably I changed it back to the previous version because of the distinction of the different error messages. PS3, Line 126: > should be const u8 *. changed -- To view, visit https://review.coreboot.org/19043 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC
by Mario Scheithauer (Code Review) March 31, 2017

March 31, 2017

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19043 to look at the new patch set (#4). Change subject: siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC ...................................................................... siemens/mc_apl1: Activate PTN3460 eDP to LVDS bridge IC This mainboard uses a LVDS connection for LCD panels. Apollo Lake SoC provides a display controller with three independent pipes (1x eDP and 2x DP/HDMI). PTN3460 is an embedded DisplayPort to LVDS bridge device that enables connectivity between an eDP source and LVDS display panel (http://www.nxp.com/documents/data_sheet/PTN3460.pdf) The bridge contains an On-chip Extended Display Identification Data (EDIT) emulation for EDIT data structures. This patch sets up PTN3460 to be used with the appropriate LCD panel. Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_apl1/Makefile.inc M src/mainboard/siemens/mc_apl1/mainboard.c A src/mainboard/siemens/mc_apl1/ptn3460.c A src/mainboard/siemens/mc_apl1/ptn3460.h 4 files changed, 289 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/19043/4 -- To view, visit https://review.coreboot.org/19043 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib8fa79bb608f1842f26c1af3d7bf4bb0513fa94d Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: mainboard/lenovo/x60: Add TPM 1.2 mainboard support
by build bot (Jenkins) (Code Review) March 31, 2017

March 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/13410 ) Change subject: mainboard/lenovo/x60: Add TPM 1.2 mainboard support ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/50987/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/6955/ : SUCCESS -- To view, visit https://review.coreboot.org/13410 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e65b37507c111af1c0c56822327d5497f58f085 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Denis Carikli <GNUtoo(a)no-log.org> Gerrit-Reviewer: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0