March 2017 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: drivers/i2c/tpm: remove unused variable in tpm_transmit()
by Furquan Shaikh (Code Review) March 31, 2017

March 31, 2017

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19060 ) Change subject: drivers/i2c/tpm: remove unused variable in tpm_transmit() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19060 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I015a6633c0951980658b3c879e48bc84d604d62e Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/i2c/tpm: remove unused types from tpm.h
by Furquan Shaikh (Code Review) March 31, 2017

March 31, 2017

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19059 ) Change subject: drivers/i2c/tpm: remove unused types from tpm.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19059 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddc147640dcec70e80791846eb46298de1070672 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi/tpm: honor tis_sendrecv() API
by Furquan Shaikh (Code Review) March 31, 2017

March 31, 2017

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19058 ) Change subject: drivers/spi/tpm: honor tis_sendrecv() API ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19058 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bfb5a09198ae4c293330e770271773a185d5061 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi/tpm: make tpm_info object local to compilation unit
by Furquan Shaikh (Code Review) March 31, 2017

March 31, 2017

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19057 ) Change subject: drivers/spi/tpm: make tpm_info object local to compilation unit ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19057 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idded3dad8d0d1c3535bddfb359009210d3439703 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi/tpm: de-assert chip select on transaction error
by Furquan Shaikh (Code Review) March 31, 2017

March 31, 2017

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19056 ) Change subject: drivers/spi/tpm: de-assert chip select on transaction error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19056 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c5200085eb357259edab39c1a0fa7b1d81ba7b2 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi/tpm: de-assert chip select on transaction error
by build bot (Jenkins) (Code Review) March 31, 2017

March 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19056 ) Change subject: drivers/spi/tpm: de-assert chip select on transaction error ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/6965/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/50997/ : SUCCESS -- To view, visit https://review.coreboot.org/19056 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c5200085eb357259edab39c1a0fa7b1d81ba7b2 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Use intel/common/uart driver
by build bot (Jenkins) (Code Review) March 31, 2017

March 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19003 ) Change subject: soc/intel/skylake: Use intel/common/uart driver ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/50996/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/6964/ : SUCCESS -- To view, visit https://review.coreboot.org/19003 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id132df15ae5a6aef75d6434df18fc71d8d28c3ca Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Add Intel common UART code
by build bot (Jenkins) (Code Review) March 31, 2017

March 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18952 ) Change subject: soc/intel/common/block: Add Intel common UART code ...................................................................... Patch Set 8: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/50995/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/6963/ : SUCCESS -- To view, visit https://review.coreboot.org/18952 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3843fac88cfb7bbb405be50d69f555b274f0d72a Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Add LPSS function library
by build bot (Jenkins) (Code Review) March 31, 2017

March 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19001 ) Change subject: soc/intel/skylake: Add LPSS function library ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/50994/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/6962/ : SUCCESS -- To view, visit https://review.coreboot.org/19001 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I881da01be8191270d9505737f68a6d2d8cd8cc69 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Add LPSS function library
by Aamir Bohra (Code Review) March 31, 2017

March 31, 2017

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19001 to look at the new patch set (#5). Change subject: soc/intel/skylake: Add LPSS function library ...................................................................... soc/intel/skylake: Add LPSS function library Add LPSS function library and move common register programming under i2c and uart to lpss.c. Clean up serialio.h and move common register and bit definitions to intelblocks/lpss.h. Change-Id: I881da01be8191270d9505737f68a6d2d8cd8cc69 Signed-off-by: Aamir Bohra <aamir.bohra(a)intel.com> --- A src/soc/intel/common/block/include/intelblocks/lpss.h A src/soc/intel/common/block/lpss/Kconfig A src/soc/intel/common/block/lpss/Makefile.inc A src/soc/intel/common/block/lpss/lpss.c M src/soc/intel/skylake/Kconfig M src/soc/intel/skylake/bootblock/i2c.c M src/soc/intel/skylake/bootblock/uart.c M src/soc/intel/skylake/include/soc/serialio.h 8 files changed, 99 insertions(+), 30 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/19001/5 -- To view, visit https://review.coreboot.org/19001 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I881da01be8191270d9505737f68a6d2d8cd8cc69 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins)

1 0