Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19057 )
Change subject: drivers/spi/tpm: make tpm_info object local to compilation unit
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19057
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idded3dad8d0d1c3535bddfb359009210d3439703
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-HasComments: No
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19001
to look at the new patch set (#5).
Change subject: soc/intel/skylake: Add LPSS function library
......................................................................
soc/intel/skylake: Add LPSS function library
Add LPSS function library and move common register
programming under i2c and uart to lpss.c. Clean up
serialio.h and move common register and bit
definitions to intelblocks/lpss.h.
Change-Id: I881da01be8191270d9505737f68a6d2d8cd8cc69
Signed-off-by: Aamir Bohra <aamir.bohra(a)intel.com>
---
A src/soc/intel/common/block/include/intelblocks/lpss.h
A src/soc/intel/common/block/lpss/Kconfig
A src/soc/intel/common/block/lpss/Makefile.inc
A src/soc/intel/common/block/lpss/lpss.c
M src/soc/intel/skylake/Kconfig
M src/soc/intel/skylake/bootblock/i2c.c
M src/soc/intel/skylake/bootblock/uart.c
M src/soc/intel/skylake/include/soc/serialio.h
8 files changed, 99 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/19001/5
--
To view, visit https://review.coreboot.org/19001
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I881da01be8191270d9505737f68a6d2d8cd8cc69
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins)